Revision f419a08fb329e235df0cb8e329cff770e02d171a authored by Arnd Bergmann on 25 March 2016, 21:21:47 UTC, committed by Linus Torvalds on 25 March 2016, 23:37:42 UTC
The r592 driver relies on behavior of the DMA mapping API that is
normally observed but not guaranteed by the API.  Instead it uses a
runtime check to fail transfers if the API ever behaves

When CONFIG_NEED_SG_DMA_LENGTH is not set, one of the checks turns into a
comparison of a variable with itself, which gcc-6.0 now warns about:

drivers/memstick/host/r592.c: In function 'r592_transfer_fifo_dma':
drivers/memstick/host/r592.c:302:31: error: self-comparison always evaluates to false [-Werror=tautological-compare]
    (sg_dma_len(&dev->req->sg) < dev->req->sg.length)) {
                               ^

The check itself is not a problem, so this patch just rephrases the
condition in a way that gcc does not consider an indication of a mistake.
We already know that dev->req->sg.length was initially R592_LFIFO_SIZE, so
we can compare it to that constant again.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 102c259
History
File Mode Size
Kconfig -rw-r--r-- 476 bytes
Makefile -rw-r--r-- 343 bytes
ast.c -rw-r--r-- 8.0 KB
ast.h -rw-r--r-- 1.3 KB
config.c -rw-r--r-- 21.4 KB
config.h -rw-r--r-- 1.5 KB
debug_fs.c -rw-r--r-- 18.1 KB
dir.c -rw-r--r-- 7.4 KB
dir.h -rw-r--r-- 1.0 KB
dlm_internal.h -rw-r--r-- 20.0 KB
lock.c -rw-r--r-- 157.6 KB
lock.h -rw-r--r-- 3.1 KB
lockspace.c -rw-r--r-- 20.3 KB
lockspace.h -rw-r--r-- 1.0 KB
lowcomms.c -rw-r--r-- 41.8 KB
lowcomms.h -rw-r--r-- 1.1 KB
lvb_table.h -rw-r--r-- 687 bytes
main.c -rw-r--r-- 2.0 KB
member.c -rw-r--r-- 16.2 KB
member.h -rw-r--r-- 1.4 KB
memory.c -rw-r--r-- 2.1 KB
memory.h -rw-r--r-- 1.0 KB
midcomms.c -rw-r--r-- 3.7 KB
midcomms.h -rw-r--r-- 864 bytes
netlink.c -rw-r--r-- 2.8 KB
plock.c -rw-r--r-- 11.6 KB
rcom.c -rw-r--r-- 15.9 KB
rcom.h -rw-r--r-- 1.2 KB
recover.c -rw-r--r-- 22.8 KB
recover.h -rw-r--r-- 1.5 KB
recoverd.c -rw-r--r-- 7.9 KB
recoverd.h -rw-r--r-- 927 bytes
requestqueue.c -rw-r--r-- 4.8 KB
requestqueue.h -rw-r--r-- 882 bytes
user.c -rw-r--r-- 24.4 KB
user.h -rw-r--r-- 586 bytes
util.c -rw-r--r-- 4.5 KB
util.h -rw-r--r-- 805 bytes

back to top