Revision f419a08fb329e235df0cb8e329cff770e02d171a authored by Arnd Bergmann on 25 March 2016, 21:21:47 UTC, committed by Linus Torvalds on 25 March 2016, 23:37:42 UTC
The r592 driver relies on behavior of the DMA mapping API that is normally observed but not guaranteed by the API. Instead it uses a runtime check to fail transfers if the API ever behaves When CONFIG_NEED_SG_DMA_LENGTH is not set, one of the checks turns into a comparison of a variable with itself, which gcc-6.0 now warns about: drivers/memstick/host/r592.c: In function 'r592_transfer_fifo_dma': drivers/memstick/host/r592.c:302:31: error: self-comparison always evaluates to false [-Werror=tautological-compare] (sg_dma_len(&dev->req->sg) < dev->req->sg.length)) { ^ The check itself is not a problem, so this patch just rephrases the condition in a way that gcc does not consider an indication of a mistake. We already know that dev->req->sg.length was initially R592_LFIFO_SIZE, so we can compare it to that constant again. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Maxim Levitsky <maximlevitsky@gmail.com> Cc: Quentin Lambert <lambert.quentin@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 102c259
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 640 bytes |
Makefile | -rw-r--r-- | 207 bytes |
alloc.c | -rw-r--r-- | 14.3 KB |
anode.c | -rw-r--r-- | 15.4 KB |
buffer.c | -rw-r--r-- | 5.3 KB |
dentry.c | -rw-r--r-- | 1.4 KB |
dir.c | -rw-r--r-- | 8.5 KB |
dnode.c | -rw-r--r-- | 30.4 KB |
ea.c | -rw-r--r-- | 11.4 KB |
file.c | -rw-r--r-- | 5.5 KB |
hpfs.h | -rw-r--r-- | 17.9 KB |
hpfs_fn.h | -rw-r--r-- | 12.9 KB |
inode.c | -rw-r--r-- | 8.8 KB |
map.c | -rw-r--r-- | 9.7 KB |
name.c | -rw-r--r-- | 3.1 KB |
namei.c | -rw-r--r-- | 15.6 KB |
super.c | -rw-r--r-- | 19.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...