Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision f6c8e432cb0479255322c5d0335b9f1699a0270c authored by Sagi Grimberg on 21 November 2018, 23:17:37 UTC, committed by Christoph Hellwig on 30 November 2018, 16:23:23 UTC 
nvme: flush namespace scanning work just before removing namespaces
 
nvme_stop_ctrl can be called also for reset flow and there is no need to
flush the scan_work as namespaces are not being removed. This can cause
deadlock in rdma, fc and loop drivers since nvme_stop_ctrl barriers
before controller teardown (and specifically I/O cancellation of the
scan_work itself) takes place, but the scan_work will be blocked anyways
so there is no need to flush it.

Instead, move scan_work flush to nvme_remove_namespaces() where it really
needs to flush.

Reported-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed by: James Smart <jsmart2021@gmail.com>
Tested-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
1 parent 14a1336
History
Tip revision: f6c8e432cb0479255322c5d0335b9f1699a0270c authored by Sagi Grimberg on 21 November 2018, 23:17:37 UTC
nvme: flush namespace scanning work just before removing namespaces
Tip revision: f6c8e43
File Mode Size
acpi
asm-generic
clocksource
crypto
drm
dt-bindings
keys
kvm
linux
math-emu
media
memory
misc
net
pcmcia
ras
rdma
scsi
soc
sound
target
trace
uapi
video
xen
back to top