Revision faba3fb53defe4fa32f32202d459726ad49f4033 authored by Andrew Kryczka on 06 April 2018, 03:58:35 UTC, committed by Facebook Github Bot on 06 April 2018, 04:13:21 UTC
Summary: When `max_valid_backups_to_open` is set, the `BackupEngine` doesn't know about the files referenced by existing backups. This PR prevents us from deleting valid files when that option is set, in cases where we are unable to accurately determine refcount. There are warnings logged when we may miss deleting unreferenced files, and a recommendation in the header for users to periodically unset this option and run a full `GarbageCollect`. Closes https://github.com/facebook/rocksdb/pull/3518 Differential Revision: D7008331 Pulled By: ajkr fbshipit-source-id: 87907f964dc9716e229d08636a895d2fc7b72305
1 parent 6571770
| File | Mode | Size |
|---|---|---|
| alloc_tracker.cc | -rw-r--r-- | 1.9 KB |
| hash_cuckoo_rep.cc | -rw-r--r-- | 24.7 KB |
| hash_cuckoo_rep.h | -rw-r--r-- | 1.6 KB |
| hash_linklist_rep.cc | -rw-r--r-- | 29.2 KB |
| hash_linklist_rep.h | -rw-r--r-- | 1.8 KB |
| hash_skiplist_rep.cc | -rw-r--r-- | 11.1 KB |
| hash_skiplist_rep.h | -rw-r--r-- | 1.4 KB |
| inlineskiplist.h | -rw-r--r-- | 33.9 KB |
| inlineskiplist_test.cc | -rw-r--r-- | 17.1 KB |
| memtablerep_bench.cc | -rw-r--r-- | 24.1 KB |
| skiplist.h | -rw-r--r-- | 15.6 KB |
| skiplist_test.cc | -rw-r--r-- | 10.2 KB |
| skiplistrep.cc | -rw-r--r-- | 8.9 KB |
| stl_wrappers.h | -rw-r--r-- | 885 bytes |
| vectorrep.cc | -rw-r--r-- | 9.0 KB |
| write_buffer_manager.cc | -rw-r--r-- | 4.7 KB |
| write_buffer_manager_test.cc | -rw-r--r-- | 5.1 KB |
Computing file changes ...
