Revision fbb974ba693bbfb4e24a62181ef16d4e45febc37 authored by Hans de Goede on 04 September 2018, 14:51:29 UTC, committed by Alexandre Belloni on 07 November 2018, 16:13:55 UTC
When there is no IRQ configured for the RTC, the rtc-cmos code does not support alarms, all alarm rtc_ops fail with -EIO / -EINVAL. The rtc-core expects a rtc driver which does not support rtc alarms to not have alarm ops at all. Otherwise the wakealarm sysfs attr will read as empty rather then returning an error, making it impossible for userspace to find out beforehand if alarms are supported. A system without an IRQ for the RTC before this patch: [root@localhost ~]# cat /sys/class/rtc/rtc0/wakealarm [root@localhost ~]# After this patch: [root@localhost ~]# cat /sys/class/rtc/rtc0/wakealarm cat: /sys/class/rtc/rtc0/wakealarm: No such file or directory [root@localhost ~]# This fixes gnome-session + systemd trying to use suspend-then-hibernate, which causes systemd to abort the suspend when writing the RTC alarm fails. BugLink: https://github.com/systemd/systemd/issues/9988 Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 6510223
| File | Mode | Size |
|---|---|---|
| .gitignore | -rw-r--r-- | 44 bytes |
| Kconfig | -rw-r--r-- | 3.4 KB |
| Makefile | -rw-r--r-- | 4.1 KB |
| blacklist.c | -rw-r--r-- | 4.0 KB |
| blacklist.h | -rw-r--r-- | 84 bytes |
| blacklist_hashes.c | -rw-r--r-- | 166 bytes |
| blacklist_nohashes.c | -rw-r--r-- | 122 bytes |
| system_certificates.S | -rw-r--r-- | 828 bytes |
| system_keyring.c | -rw-r--r-- | 7.5 KB |
Computing file changes ...
