https://github.com/torvalds/linux
Revision fbedd9b9905c1643b9f7244d88999e39632bbd87 authored by John Keeping on 05 April 2016, 14:05:46 UTC, committed by Joerg Roedel on 07 April 2016, 12:50:18 UTC
Since commit cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi
slaves") rk_iommu_is_stall_active() always returns false because the
bitwise AND operates on the boolean flag promoted to an integer and a
value that is either zero or BIT(2).
Explicitly convert the right-hand value to a boolean so that both sides
are guaranteed to be either zero or one.
rk_iommu_is_paging_enabled() does not suffer from the same problem since
RK_MMU_STATUS_PAGING_ENABLED is BIT(0), but let's apply the same change
for consistency and to make it clear that it's correct without needing
to lookup the value.
Fixes: cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi slaves")
Signed-off-by: John Keeping <john@metanate.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent eebb803
Tip revision: fbedd9b9905c1643b9f7244d88999e39632bbd87 authored by John Keeping on 05 April 2016, 14:05:46 UTC
iommu/rockchip: Fix "is stall active" check
iommu/rockchip: Fix "is stall active" check
Tip revision: fbedd9b
| File | Mode | Size |
|---|---|---|
| partitions | ||
| Kconfig | -rw-r--r-- | 4.2 KB |
| Kconfig.iosched | -rw-r--r-- | 1.6 KB |
| Makefile | -rw-r--r-- | 922 bytes |
| badblocks.c | -rw-r--r-- | 14.1 KB |
| bio-integrity.c | -rw-r--r-- | 14.3 KB |
| bio.c | -rw-r--r-- | 48.6 KB |
| blk-cgroup.c | -rw-r--r-- | 35.8 KB |
| blk-core.c | -rw-r--r-- | 94.8 KB |
| blk-exec.c | -rw-r--r-- | 3.2 KB |
| blk-flush.c | -rw-r--r-- | 15.2 KB |
| blk-integrity.c | -rw-r--r-- | 12.3 KB |
| blk-ioc.c | -rw-r--r-- | 10.2 KB |
| blk-lib.c | -rw-r--r-- | 7.5 KB |
| blk-map.c | -rw-r--r-- | 6.3 KB |
| blk-merge.c | -rw-r--r-- | 18.6 KB |
| blk-mq-cpu.c | -rw-r--r-- | 1.6 KB |
| blk-mq-cpumap.c | -rw-r--r-- | 2.6 KB |
| blk-mq-sysfs.c | -rw-r--r-- | 11.3 KB |
| blk-mq-tag.c | -rw-r--r-- | 16.7 KB |
| blk-mq-tag.h | -rw-r--r-- | 2.6 KB |
| blk-mq.c | -rw-r--r-- | 56.6 KB |
| blk-mq.h | -rw-r--r-- | 3.3 KB |
| blk-settings.c | -rw-r--r-- | 26.9 KB |
| blk-softirq.c | -rw-r--r-- | 4.4 KB |
| blk-sysfs.c | -rw-r--r-- | 17.4 KB |
| blk-tag.c | -rw-r--r-- | 10.0 KB |
| blk-throttle.c | -rw-r--r-- | 42.6 KB |
| blk-timeout.c | -rw-r--r-- | 5.9 KB |
| blk.h | -rw-r--r-- | 9.1 KB |
| bounce.c | -rw-r--r-- | 5.8 KB |
| bsg-lib.c | -rw-r--r-- | 6.0 KB |
| bsg.c | -rw-r--r-- | 22.9 KB |
| cfq-iosched.c | -rw-r--r-- | 123.9 KB |
| cmdline-parser.c | -rw-r--r-- | 4.9 KB |
| compat_ioctl.c | -rw-r--r-- | 20.8 KB |
| deadline-iosched.c | -rw-r--r-- | 11.2 KB |
| elevator.c | -rw-r--r-- | 23.8 KB |
| genhd.c | -rw-r--r-- | 45.0 KB |
| ioctl.c | -rw-r--r-- | 15.3 KB |
| ioprio.c | -rw-r--r-- | 5.1 KB |
| noop-iosched.c | -rw-r--r-- | 2.6 KB |
| partition-generic.c | -rw-r--r-- | 14.7 KB |
| scsi_ioctl.c | -rw-r--r-- | 19.4 KB |
| t10-pi.c | -rw-r--r-- | 4.8 KB |
Computing file changes ...
