Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision fc4b514f2727f74a4587c31db87e0e93465518c3 authored by Tejun Heo on 04 December 2012, 15:40:39 UTC, committed by Tejun Heo on 04 December 2012, 15:58:47 UTC 
workqueue: convert BUG_ON()s in __queue_delayed_work() to WARN_ON_ONCE()s
 
8852aac25e ("workqueue: mod_delayed_work_on() shouldn't queue timer on
0 delay") unexpectedly uncovered a very nasty abuse of delayed_work in
megaraid - it allocated work_struct, casted it to delayed_work and
then pass that into queue_delayed_work().

Previously, this was okay because 0 @delay short-circuited to
queue_work() before doing anything with delayed_work.  8852aac25e
moved 0 @delay test into __queue_delayed_work() after sanity check on
delayed_work making megaraid trigger BUG_ON().

Although megaraid is already fixed by c1d390d8e6 ("megaraid: fix
BUG_ON() from incorrect use of delayed work"), this patch converts
BUG_ON()s in __queue_delayed_work() to WARN_ON_ONCE()s so that such
abusers, if there are more, trigger warning but don't crash the
machine.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Xiaotian Feng <xtfeng@gmail.com>
1 parent c1d390d
History
Tip revision: fc4b514f2727f74a4587c31db87e0e93465518c3 authored by Tejun Heo on 04 December 2012, 15:40:39 UTC
workqueue: convert BUG_ON()s in __queue_delayed_work() to WARN_ON_ONCE()s
Tip revision: fc4b514
File Mode Size
hidraw
hw_breakpoint
kdb
kfifo
kobject
kprobes
rpmsg
seccomp
trace_events
tracepoints
uhid
Kconfig -rw-r--r-- 2.0 KB
Makefile -rw-r--r-- 164 bytes
back to top