Skip to main content

Browse the archive

Revision fc7c0b7d097b3f584889127fd6ea350a1980cc7a authored by Emilio Cobos Álvarez on 09 April 2018, 07:01:25 UTC, committed by moz-wptsync-bot on 09 April 2018, 07:52:06 UTC 
Make LazyFC assertions actually hold.
 
The code was trying to assert that we had frames constructed for all the nodes
in the parent chain, but we don't bail out in the
!GetContentInsertionFrameFor(aContainer) in the case that it's a children
element, because they actually have no insertion frame, though their children
do.

Move the LazyFC check after the insertion point check. That makes the previous
check work on the insertion point of the child, which makes it sound.

This also fixes bug 1410020, and with it a Shadow DOM test-case that was failing
because we had two sibling assigned to two different <slot>s, and the second one
wasn't getting properly flagged, and thus the second sibling never got a frame.

The other two test failures in this test are an event dispatch failure, where
the position of the target is not what the test expects (we don't account for
margin and padding). Filed that as bug 1450027.

Also, added a test for which we have wrong layout without these patches, and
that crashes with "Called Servo_Element_IsDisplayNone" with the first patch of
this bug applied but not this one, due to the bogus check mentioned above.
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1303605
gecko-commit: 12a824f8d55a8fb0396fb2132974f8223c6a9606
gecko-integration-branch: central
gecko-reviewers: bz
1 parent a835486
History
File Mode Size
resources
FormData-append.html -rw-r--r-- 3.8 KB
OWNERS -rw-r--r-- 117 bytes
README.md -rw-r--r-- 176 bytes
XMLHttpRequest-withCredentials.any.js -rw-r--r-- 1.5 KB
abort-after-receive.htm -rw-r--r-- 1.3 KB
abort-after-send.htm -rw-r--r-- 2.7 KB
abort-after-stop.htm -rw-r--r-- 1011 bytes
abort-after-timeout.htm -rw-r--r-- 1.8 KB
abort-during-done.htm -rw-r--r-- 3.6 KB
abort-during-headers-received.htm -rw-r--r-- 2.0 KB
abort-during-loading.htm -rw-r--r-- 2.0 KB
abort-during-open.htm -rw-r--r-- 607 bytes
abort-during-open.js -rw-r--r-- 506 bytes
abort-during-open.worker.js -rw-r--r-- 91 bytes
abort-during-unsent.htm -rw-r--r-- 999 bytes
abort-during-upload.htm -rw-r--r-- 1.5 KB
abort-event-abort.htm -rw-r--r-- 1.5 KB
abort-event-listeners.htm -rw-r--r-- 836 bytes
abort-event-loadend.htm -rw-r--r-- 1.2 KB
abort-event-order.htm -rw-r--r-- 1.9 KB
abort-upload-event-abort.htm -rw-r--r-- 1.4 KB
abort-upload-event-loadend.htm -rw-r--r-- 1.4 KB
access-control-and-redirects-async-same-origin.htm -rw-r--r-- 3.1 KB
access-control-and-redirects-async.htm -rw-r--r-- 3.8 KB
access-control-and-redirects.htm -rw-r--r-- 2.5 KB
access-control-basic-allow-access-control-origin-header-data-url.htm -rw-r--r-- 1.3 KB
access-control-basic-allow-access-control-origin-header.htm -rw-r--r-- 703 bytes
access-control-basic-allow-async.htm -rw-r--r-- 908 bytes
access-control-basic-allow-non-cors-safelisted-method-async.htm -rw-r--r-- 938 bytes
access-control-basic-allow-non-cors-safelisted-method.htm -rw-r--r-- 798 bytes
access-control-basic-allow-preflight-cache-invalidation-by-header.htm -rw-r--r-- 1.8 KB
access-control-basic-allow-preflight-cache-invalidation-by-method.htm -rw-r--r-- 1.7 KB
access-control-basic-allow-preflight-cache-timeout.htm -rw-r--r-- 1.7 KB
access-control-basic-allow-preflight-cache.htm -rw-r--r-- 1.6 KB
access-control-basic-allow-star.htm -rw-r--r-- 668 bytes
access-control-basic-allow.htm -rw-r--r-- 656 bytes
access-control-basic-cors-safelisted-request-headers.htm -rw-r--r-- 1.1 KB
access-control-basic-cors-safelisted-response-headers.htm -rw-r--r-- 1.3 KB
access-control-basic-denied.htm -rw-r--r-- 994 bytes
access-control-basic-get-fail-non-simple.htm -rw-r--r-- 998 bytes
access-control-basic-non-cors-safelisted-content-type.htm -rw-r--r-- 1.3 KB
access-control-basic-post-success-no-content-type.htm -rw-r--r-- 876 bytes
access-control-basic-post-with-non-cors-safelisted-content-type.htm -rw-r--r-- 1.4 KB
access-control-basic-preflight-denied.htm -rw-r--r-- 1.1 KB
access-control-preflight-async-header-denied.htm -rw-r--r-- 1.3 KB
access-control-preflight-async-method-denied.htm -rw-r--r-- 1.2 KB
access-control-preflight-async-not-supported.htm -rw-r--r-- 1.0 KB
access-control-preflight-credential-async.htm -rw-r--r-- 924 bytes
access-control-preflight-credential-sync.htm -rw-r--r-- 772 bytes
access-control-preflight-headers-async.htm -rw-r--r-- 1.0 KB
access-control-preflight-headers-sync.htm -rw-r--r-- 1011 bytes
access-control-preflight-request-header-lowercase.htm -rw-r--r-- 895 bytes
access-control-preflight-request-header-sorted.htm -rw-r--r-- 918 bytes
access-control-preflight-request-headers-origin.htm -rw-r--r-- 882 bytes
access-control-preflight-request-invalid-status-301.htm -rw-r--r-- 911 bytes
access-control-preflight-request-invalid-status-400.htm -rw-r--r-- 911 bytes
access-control-preflight-request-invalid-status-501.htm -rw-r--r-- 911 bytes
access-control-preflight-request-must-not-contain-cookie.htm -rw-r--r-- 2.0 KB
access-control-preflight-sync-header-denied.htm -rw-r--r-- 1.1 KB
access-control-preflight-sync-method-denied.htm -rw-r--r-- 1.1 KB
access-control-preflight-sync-not-supported.htm -rw-r--r-- 1017 bytes
access-control-recursive-failed-request.htm -rw-r--r-- 983 bytes
access-control-response-with-body-sync.htm -rw-r--r-- 790 bytes
access-control-response-with-body.htm -rw-r--r-- 920 bytes
access-control-response-with-exposed-headers.htm -rw-r--r-- 1.2 KB
access-control-sandboxed-iframe-allow-origin-null.htm -rw-r--r-- 1.1 KB
access-control-sandboxed-iframe-allow.htm -rw-r--r-- 1.1 KB
access-control-sandboxed-iframe-denied-without-wildcard.htm -rw-r--r-- 1.7 KB
access-control-sandboxed-iframe-denied.htm -rw-r--r-- 1.4 KB
allow-lists-starting-with-comma.htm -rw-r--r-- 1.4 KB
anonymous-mode-unsupported.htm -rw-r--r-- 1.6 KB
data-uri.htm -rw-r--r-- 1.9 KB
event-abort.htm -rw-r--r-- 1.0 KB
event-error-order.sub.html -rw-r--r-- 1.2 KB
event-error.sub.html -rw-r--r-- 725 bytes
event-load.htm -rw-r--r-- 1.1 KB
event-loadend.htm -rw-r--r-- 1.1 KB
event-loadstart-upload.htm -rw-r--r-- 1.2 KB
event-loadstart.htm -rw-r--r-- 1.2 KB
event-progress.htm -rw-r--r-- 1.0 KB
event-readystate-sync-open.htm -rw-r--r-- 1.1 KB
event-readystatechange-loaded.htm -rw-r--r-- 1.1 KB
event-timeout-order.htm -rw-r--r-- 1.3 KB
event-timeout.htm -rw-r--r-- 1.5 KB
event-upload-progress-crossorigin.htm -rw-r--r-- 1.2 KB
event-upload-progress.htm -rw-r--r-- 1.1 KB
firing-events-http-content-length.html -rw-r--r-- 1.2 KB
firing-events-http-no-content-length.html -rw-r--r-- 1.2 KB
folder.txt -rw-r--r-- 4 bytes
formdata-blob.htm -rw-r--r-- 2.1 KB
formdata-delete.htm -rw-r--r-- 2.3 KB
formdata-foreach.html -rw-r--r-- 2.5 KB
formdata-get.htm -rw-r--r-- 2.5 KB
formdata-has.htm -rw-r--r-- 1.6 KB
formdata-set.htm -rw-r--r-- 3.6 KB
formdata.htm -rw-r--r-- 1.8 KB
getallresponseheaders-cookies.htm -rw-r--r-- 1.5 KB
getallresponseheaders-status.htm -rw-r--r-- 1.1 KB
getallresponseheaders.htm -rw-r--r-- 1.1 KB
getresponseheader-case-insensitive.htm -rw-r--r-- 1.3 KB
getresponseheader-chunked-trailer.htm -rw-r--r-- 1.3 KB
getresponseheader-cookies-and-more.htm -rw-r--r-- 1.4 KB
getresponseheader-error-state.htm -rw-r--r-- 1.3 KB
getresponseheader-server-date.htm -rw-r--r-- 1010 bytes
getresponseheader-special-characters.htm -rw-r--r-- 1.4 KB
getresponseheader-unsent-opened-state.htm -rw-r--r-- 1.2 KB
header-user-agent-async.htm -rw-r--r-- 816 bytes
header-user-agent-sync.htm -rw-r--r-- 700 bytes
headers-normalize-response.htm -rw-r--r-- 1.2 KB
historical.html -rw-r--r-- 473 bytes
interfaces.html -rw-r--r-- 1.3 KB
loadstart-and-state.html -rw-r--r-- 1.2 KB
no-utf16-json.htm -rw-r--r-- 784 bytes
open-after-abort.htm -rw-r--r-- 1.2 KB
open-after-setrequestheader.htm -rw-r--r-- 1.0 KB
open-during-abort-event.htm -rw-r--r-- 1.6 KB
open-during-abort-processing.htm -rw-r--r-- 1.9 KB
open-during-abort.htm -rw-r--r-- 1000 bytes
open-method-bogus.htm -rw-r--r-- 823 bytes
open-method-case-insensitive.htm -rw-r--r-- 918 bytes
open-method-case-sensitive.htm -rw-r--r-- 961 bytes
open-method-insecure.htm -rw-r--r-- 890 bytes
open-method-responsetype-set-sync.htm -rw-r--r-- 1.1 KB
open-open-send.htm -rw-r--r-- 1.1 KB
open-open-sync-send.htm -rw-r--r-- 1.1 KB
open-parameters-toString.htm -rw-r--r-- 1008 bytes
open-referer.htm -rw-r--r-- 642 bytes
open-send-during-abort.htm -rw-r--r-- 863 bytes
open-send-open.htm -rw-r--r-- 1.1 KB
open-sync-open-send.htm -rw-r--r-- 1.9 KB
open-url-about-blank-window.htm -rw-r--r-- 1000 bytes
open-url-base-inserted-after-open.htm -rw-r--r-- 1.0 KB
open-url-base-inserted.htm -rw-r--r-- 1.0 KB
open-url-base.htm -rw-r--r-- 857 bytes
open-url-encoding.htm -rw-r--r-- 1.0 KB
open-url-fragment.htm -rw-r--r-- 1.6 KB
open-url-javascript-window-2.htm -rw-r--r-- 882 bytes
open-url-javascript-window.htm -rw-r--r-- 974 bytes
open-url-multi-window-2.htm -rw-r--r-- 907 bytes
open-url-multi-window-3.htm -rw-r--r-- 762 bytes
open-url-multi-window-4.htm -rw-r--r-- 1.9 KB
open-url-multi-window-5.htm -rw-r--r-- 934 bytes
open-url-multi-window-6.htm -rw-r--r-- 1.4 KB
open-url-multi-window.htm -rw-r--r-- 1.0 KB
open-url-redirected-worker-origin.htm -rw-r--r-- 440 bytes
open-url-worker-origin.htm -rw-r--r-- 331 bytes
open-url-worker-simple.htm -rw-r--r-- 841 bytes
open-user-password-non-same-origin.htm -rw-r--r-- 963 bytes
overridemimetype-blob.html -rw-r--r-- 2.2 KB
overridemimetype-done-state.htm -rw-r--r-- 1.0 KB
overridemimetype-headers-received-state-force-shiftjis.htm -rw-r--r-- 1.4 KB
overridemimetype-invalid-mime-type.htm -rw-r--r-- 1.7 KB
overridemimetype-loading-state.htm -rw-r--r-- 1.1 KB
overridemimetype-open-state-force-utf-8.htm -rw-r--r-- 1.0 KB
overridemimetype-open-state-force-xml.htm -rw-r--r-- 1.6 KB
overridemimetype-unsent-state-force-shiftjis.htm -rw-r--r-- 1.0 KB
preserve-ua-header-on-redirect.htm -rw-r--r-- 1.4 KB
progress-events-response-data-gzip.htm -rw-r--r-- 3.6 KB
progressevent-constructor.html -rw-r--r-- 1.8 KB
progressevent-interface.html -rw-r--r-- 1.7 KB
response-data-arraybuffer.htm -rw-r--r-- 1.9 KB
response-data-blob.htm -rw-r--r-- 1.9 KB
response-data-deflate.htm -rw-r--r-- 1.4 KB
response-data-gzip.htm -rw-r--r-- 1.4 KB
response-data-progress.htm -rw-r--r-- 2.0 KB
response-invalid-responsetype.htm -rw-r--r-- 1.5 KB
response-json.htm -rw-r--r-- 2.9 KB
response-method.htm -rw-r--r-- 631 bytes
responseText-status.html -rw-r--r-- 883 bytes
responseType-document-in-worker.html -rw-r--r-- 310 bytes
responseXML-unavailable-in-worker.html -rw-r--r-- 312 bytes
responsedocument-decoding.htm -rw-r--r-- 1.7 KB
responsetext-decoding.htm -rw-r--r-- 4.6 KB
responsetype.html -rw-r--r-- 3.3 KB
responseurl.html -rw-r--r-- 1.2 KB
responsexml-basic.htm -rw-r--r-- 1.7 KB
responsexml-document-properties.htm -rw-r--r-- 4.0 KB
responsexml-get-twice.htm -rw-r--r-- 2.4 KB
responsexml-media-type.htm -rw-r--r-- 1.7 KB
responsexml-non-document-types.htm -rw-r--r-- 1.7 KB
responsexml-non-well-formed.htm -rw-r--r-- 1.2 KB
security-consideration.sub.html -rw-r--r-- 1.5 KB
send-accept-language.htm -rw-r--r-- 1.0 KB
send-accept.htm -rw-r--r-- 991 bytes
send-after-setting-document-domain.htm -rw-r--r-- 1.4 KB
send-authentication-basic-cors-not-enabled.htm -rw-r--r-- 1.4 KB
send-authentication-basic-cors.htm -rw-r--r-- 1.5 KB
send-authentication-basic-repeat-no-args.htm -rw-r--r-- 1.6 KB
send-authentication-basic-setrequestheader-and-arguments.htm -rw-r--r-- 1.7 KB
send-authentication-basic-setrequestheader-existing-session.htm -rw-r--r-- 3.2 KB
send-authentication-basic-setrequestheader.htm -rw-r--r-- 1.6 KB
send-authentication-basic.htm -rw-r--r-- 1.3 KB
send-authentication-competing-names-passwords.htm -rw-r--r-- 3.2 KB
send-authentication-cors-basic-setrequestheader.htm -rw-r--r-- 1.2 KB
send-authentication-cors-setrequestheader-no-cred.htm -rw-r--r-- 2.8 KB
send-authentication-existing-session-manual.htm -rw-r--r-- 1.5 KB
send-authentication-prompt-2-manual.htm -rw-r--r-- 1.0 KB
send-authentication-prompt-manual.htm -rw-r--r-- 1.0 KB
send-blob-with-no-mime-type.html -rw-r--r-- 2.6 KB
send-conditional-cors.htm -rw-r--r-- 1.4 KB
send-conditional.htm -rw-r--r-- 1.3 KB
send-content-type-charset.htm -rw-r--r-- 3.0 KB
send-content-type-string.htm -rw-r--r-- 1.1 KB
send-data-arraybuffer.htm -rw-r--r-- 1.5 KB
send-data-arraybufferview.htm -rw-r--r-- 1.4 KB
send-data-blob.htm -rw-r--r-- 2.1 KB
send-data-es-object.htm -rw-r--r-- 2.5 KB
send-data-formdata.htm -rw-r--r-- 1.6 KB
send-data-unexpected-tostring.htm -rw-r--r-- 1.9 KB
send-entity-body-basic.htm -rw-r--r-- 939 bytes
send-entity-body-document-bogus.htm -rw-r--r-- 950 bytes
send-entity-body-document.htm -rw-r--r-- 3.4 KB
send-entity-body-empty.htm -rw-r--r-- 1.2 KB
send-entity-body-get-head-async.htm -rw-r--r-- 1.4 KB
send-entity-body-get-head.htm -rw-r--r-- 1.3 KB
send-entity-body-none.htm -rw-r--r-- 2.0 KB
send-network-error-async-events.sub.htm -rw-r--r-- 2.4 KB
send-network-error-sync-events.sub.htm -rw-r--r-- 1.5 KB
send-no-response-event-loadend.htm -rw-r--r-- 1.6 KB
send-no-response-event-loadstart.htm -rw-r--r-- 1.7 KB
send-no-response-event-order.htm -rw-r--r-- 2.2 KB
send-non-same-origin.htm -rw-r--r-- 1.0 KB
send-receive-utf16.htm -rw-r--r-- 1.7 KB
send-redirect-bogus-sync.htm -rw-r--r-- 1.1 KB
send-redirect-bogus.htm -rw-r--r-- 1.4 KB
send-redirect-infinite-sync.htm -rw-r--r-- 1.0 KB
send-redirect-infinite.htm -rw-r--r-- 1.5 KB
send-redirect-no-location.htm -rw-r--r-- 1.5 KB
send-redirect-post-upload.htm -rw-r--r-- 6.1 KB
send-redirect-to-cors.htm -rw-r--r-- 4.6 KB
send-redirect-to-non-cors.htm -rw-r--r-- 1.5 KB
send-redirect.htm -rw-r--r-- 1.3 KB
send-response-event-order.htm -rw-r--r-- 2.6 KB
send-response-upload-event-loadend.htm -rw-r--r-- 1.5 KB
send-response-upload-event-loadstart.htm -rw-r--r-- 1.4 KB
send-response-upload-event-progress.htm -rw-r--r-- 1.5 KB
send-send.htm -rw-r--r-- 425 bytes
send-send.js -rw-r--r-- 215 bytes
send-send.worker.js -rw-r--r-- 83 bytes
send-sync-blocks-async.htm -rw-r--r-- 1.8 KB
send-sync-no-response-event-load.htm -rw-r--r-- 1.5 KB
send-sync-no-response-event-loadend.htm -rw-r--r-- 1.5 KB
send-sync-no-response-event-order.htm -rw-r--r-- 2.6 KB
send-sync-response-event-order.htm -rw-r--r-- 2.0 KB
send-sync-timeout.htm -rw-r--r-- 855 bytes
send-timeout-events.htm -rw-r--r-- 2.6 KB
send-usp.any.js -rw-r--r-- 1.3 KB
setrequestheader-after-send.htm -rw-r--r-- 905 bytes
setrequestheader-allow-empty-value.htm -rw-r--r-- 856 bytes
setrequestheader-allow-whitespace-in-value.htm -rw-r--r-- 896 bytes
setrequestheader-before-open.htm -rw-r--r-- 660 bytes
setrequestheader-bogus-name.htm -rw-r--r-- 2.5 KB
setrequestheader-bogus-value.htm -rw-r--r-- 1.3 KB
setrequestheader-case-insensitive.htm -rw-r--r-- 1.2 KB
setrequestheader-content-type.htm -rw-r--r-- 9.3 KB
setrequestheader-header-allowed.htm -rw-r--r-- 1.1 KB
setrequestheader-header-forbidden.htm -rw-r--r-- 1.7 KB
setrequestheader-open-setrequestheader.htm -rw-r--r-- 1.6 KB
status-async.htm -rw-r--r-- 2.9 KB
status-basic.htm -rw-r--r-- 2.4 KB
status-error.htm -rw-r--r-- 1.9 KB
template-element.html -rw-r--r-- 1.3 KB
timeout-cors-async.htm -rw-r--r-- 2.0 KB
timeout-multiple-fetches.html -rw-r--r-- 1.0 KB
timeout-sync.htm -rw-r--r-- 1.0 KB
xmlhttprequest-basic.htm -rw-r--r-- 1.8 KB
xmlhttprequest-closing-worker.html -rw-r--r-- 779 bytes
xmlhttprequest-eventtarget.htm -rw-r--r-- 1.6 KB
xmlhttprequest-network-error-sync.htm -rw-r--r-- 2.3 KB
xmlhttprequest-network-error.htm -rw-r--r-- 2.2 KB
xmlhttprequest-sync-block-defer-scripts-subframe.html -rw-r--r-- 524 bytes
xmlhttprequest-sync-block-defer-scripts.html -rw-r--r-- 553 bytes
xmlhttprequest-sync-block-scripts.html -rw-r--r-- 750 bytes
xmlhttprequest-sync-default-feature-policy.sub.html -rw-r--r-- 910 bytes
xmlhttprequest-sync-not-hang-scriptloader-subframe.html -rw-r--r-- 484 bytes
xmlhttprequest-sync-not-hang-scriptloader.html -rw-r--r-- 575 bytes
xmlhttprequest-timeout-aborted.html -rw-r--r-- 1.8 KB
xmlhttprequest-timeout-abortedonmain.html -rw-r--r-- 1.2 KB
xmlhttprequest-timeout-overrides.html -rw-r--r-- 1.1 KB
xmlhttprequest-timeout-overridesexpires.html -rw-r--r-- 1.5 KB
xmlhttprequest-timeout-reused.html -rw-r--r-- 1.8 KB
xmlhttprequest-timeout-simple.html -rw-r--r-- 1.5 KB
xmlhttprequest-timeout-synconmain.html -rw-r--r-- 970 bytes
xmlhttprequest-timeout-twice.html -rw-r--r-- 1.5 KB
xmlhttprequest-timeout-worker-aborted.html -rw-r--r-- 1.9 KB
xmlhttprequest-timeout-worker-overrides.html -rw-r--r-- 1.2 KB
xmlhttprequest-timeout-worker-overridesexpires.html -rw-r--r-- 1.5 KB
xmlhttprequest-timeout-worker-simple.html -rw-r--r-- 1.5 KB
xmlhttprequest-timeout-worker-synconworker.html -rw-r--r-- 1.5 KB
xmlhttprequest-timeout-worker-twice.html -rw-r--r-- 1.5 KB
xmlhttprequest-unsent.htm -rw-r--r-- 2.2 KB

README.md

back to top