| 4ab4049 | Adam Retter | 31 March 2017, 16:59:02 UTC | gflags has moved to GitHub Summary: Closes https://github.com/facebook/rocksdb/issues/2068 Closes https://github.com/facebook/rocksdb/pull/2072 Differential Revision: D4810855 Pulled By: ajkr fbshipit-source-id: 288ddb9 | 31 March 2017, 17:09:21 UTC |
| 4e00650 | Andrew Kryczka | 31 March 2017, 06:27:42 UTC | make all DB::Get overloads virtual Summary: some fbcode services override it, we need to keep it virtual. original change: #1756 Closes https://github.com/facebook/rocksdb/pull/2065 Differential Revision: D4808123 Pulled By: ajkr fbshipit-source-id: 5eaeea7 | 31 March 2017, 06:39:14 UTC |
| 6401a8b | Orgad Shaneh | 30 March 2017, 23:47:19 UTC | Fix build with MinGW Summary: There still are many warnings (most of them about invalid printf format for long long), but it builds if FAIL_ON_WARNINGS is disabled. Closes https://github.com/facebook/rocksdb/pull/2052 Differential Revision: D4807355 Pulled By: siying fbshipit-source-id: ef03786 | 30 March 2017, 23:54:52 UTC |
| 80fe5b3 | Andrew Kryczka | 30 March 2017, 23:45:39 UTC | disable test: DeleteSchedulerTest.DynamicRateLimiting1 Summary: temporarily disable since it isn't working on travis. Closes https://github.com/facebook/rocksdb/pull/2064 Differential Revision: D4807373 Pulled By: ajkr fbshipit-source-id: f2bb2b0 | 30 March 2017, 23:54:52 UTC |
| a9c86f5 | Andrew Kryczka | 30 March 2017, 21:44:56 UTC | backup garbage collect shared_checksum tmp files Summary: previously we only cleaned up .tmp files under "shared/" and "private/" directories in case the previous backup failed. we need to do the same for "shared_checksum/"; otherwise, the subsequent backup will fail if it tries to backup at least one of the same files. Closes https://github.com/facebook/rocksdb/pull/2062 Differential Revision: D4805599 Pulled By: ajkr fbshipit-source-id: eaa6088 | 30 March 2017, 21:54:12 UTC |
| da175f7 | Aaron Gao | 30 March 2017, 20:56:52 UTC | exit with code 2 when there is already a db_bench running in regression test Summary: Closes https://github.com/facebook/rocksdb/pull/2063 Differential Revision: D4805507 Pulled By: lightmark fbshipit-source-id: 59ccb18 | 30 March 2017, 21:09:11 UTC |
| 0ee7f04 | Adam Retter | 30 March 2017, 19:04:09 UTC | Added missing options to RocksJava Summary: This adds almost all missing options to RocksJava Closes https://github.com/facebook/rocksdb/pull/2039 Differential Revision: D4779991 Pulled By: siying fbshipit-source-id: 4a1bf28 | 30 March 2017, 19:09:21 UTC |
| c6d04f2 | Sagar Vemuri | 30 March 2017, 18:57:05 UTC | Option to fail a request as incomplete when skipping too many internal keys Summary: Operations like Seek/Next/Prev sometimes take too long to complete when there are many internal keys to be skipped. Adding an option, max_skippable_internal_keys -- which could be used to set a threshold for the maximum number of keys that can be skipped, will help to address these cases where it is much better to fail a request (as incomplete) than to wait for a considerable time for the request to complete. This feature -- to fail an iterator seek request as incomplete, is disabled by default when max_skippable_internal_keys = 0. It is enabled only when max_skippable_internal_keys > 0. This feature is based on the discussion mentioned in the PR https://github.com/facebook/rocksdb/pull/1084. Closes https://github.com/facebook/rocksdb/pull/2000 Differential Revision: D4753223 Pulled By: sagar0 fbshipit-source-id: 1c973f7 | 30 March 2017, 19:09:21 UTC |
| 58179ec | Herman Lee | 30 March 2017, 17:31:26 UTC | Cleanup of ThreadStatusUtil structures should use the DB's reference Summary: instead of thread_local The cleanup path for the rocksdb database might not have the thread_updater_local_cache_ pointer initialized because the thread executing the cleanup is likely not a rocksdb thread. This results in a memory leak detected by Valgrind. The cleanup code path should use the thread_status_updater pointer obtained from the DB object instead of a thread local one. Closes https://github.com/facebook/rocksdb/pull/2059 Differential Revision: D4801611 Pulled By: hermanlee fbshipit-source-id: 407d7de | 30 March 2017, 17:39:13 UTC |
| f360764 | Aaron Gao | 30 March 2017, 01:06:24 UTC | add ldb build to regression test Summary: add ldb to regression test in order to enable reuse db by creating checkpoint Closes https://github.com/facebook/rocksdb/pull/2030 Differential Revision: D4800549 Pulled By: lightmark fbshipit-source-id: d3a7325 | 30 March 2017, 01:24:11 UTC |
| 8a8c967 | Min Wei | 30 March 2017, 00:34:36 UTC | Enable Fast CRC32 for Win64 Summary: Currently the fast crc32 path is not enabled on Windows. I am trying to enable it here, hopefully, with the minimum impact to the existing code structure. Closes https://github.com/facebook/rocksdb/pull/2033 Differential Revision: D4770635 Pulled By: siying fbshipit-source-id: 676f8b8 | 30 March 2017, 00:39:19 UTC |
| f9813b8 | Mikhail Antonov | 30 March 2017, 00:13:43 UTC | Added SstFileWriter construtor without explicit comparator to JNI api Summary: Adding API missing after https://github.com/facebook/rocksdb/commit/1ffbdfd9a7637b6517053842386d71df2cd00d9b#diff-b94146418eed4a9c1bf324041b95b279. adamretter IslamAbdelRahman Tested locally. Closes https://github.com/facebook/rocksdb/pull/2028 Differential Revision: D4762817 Pulled By: IslamAbdelRahman fbshipit-source-id: 833f478 | 30 March 2017, 00:24:14 UTC |
| 8d3cb4f | Sharan Suryanarayanan | 29 March 2017, 23:58:45 UTC | Added naming of backup engine threads Summary: Changed the naming of backup engine threads from "ldb" to "backup_engine" Closes https://github.com/facebook/rocksdb/pull/2053 Differential Revision: D4799325 Pulled By: ajkr fbshipit-source-id: 046893f | 30 March 2017, 00:10:46 UTC |
| 67d7623 | Siying Dong | 29 March 2017, 18:42:56 UTC | Expose the stalling information through DB::GetProperty() Summary: Add two DB properties: rocksdb.actual_delayed_write_rate and rocksdb.is_write_stooped, for people to know whether current writes are being throttled. Closes https://github.com/facebook/rocksdb/pull/2043 Differential Revision: D4782975 Pulled By: siying fbshipit-source-id: 6b2f5cf | 29 March 2017, 18:54:20 UTC |
| 0fd5749 | Aaron Gao | 28 March 2017, 22:47:54 UTC | delete fallocate with punch_hole Summary: As discuss in this thread: https://www.facebook.com/groups/rocksdb.dev/permalink/1218043868294125/ We remove fallocate with FALLOC_FL_PUNCH_HOLE because the recent bug on xfs in kernel 4.x+ that align file size to page size even with FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE. Closes https://github.com/facebook/rocksdb/pull/2038 Differential Revision: D4779974 Pulled By: siying fbshipit-source-id: 5f54625 | 28 March 2017, 22:54:12 UTC |
| 41fe9ad | Yi Wu | 28 March 2017, 20:26:53 UTC | Hide usage of compaction_options_fifo from lite build Summary: ...to fix lite build error. Closes https://github.com/facebook/rocksdb/pull/2046 Differential Revision: D4785910 Pulled By: yiwu-arbug fbshipit-source-id: b591f27 | 28 March 2017, 20:39:13 UTC |
| e7731d1 | Maysam Yabandeh | 28 March 2017, 18:56:56 UTC | Configure index partition size Summary: Allow the users to specify the target index partition size. With this patch an index partition is cut before its estimated in-memory size goes above the configured value for metadata_block_size. The filter partitions are still cut right after an index partition is cut. Closes https://github.com/facebook/rocksdb/pull/2041 Differential Revision: D4780216 Pulled By: maysamyabandeh fbshipit-source-id: 95a0831 | 28 March 2017, 19:09:12 UTC |
| 69c8d52 | Ayappan | 27 March 2017, 20:57:07 UTC | Fix jni library name for PowerPC Architecture Summary: Right now, building rocksdbjava in PowerPC is broken due to JNI library name. I figured it out that "uname -m" and java's os.arch matches in PowerPC architecture. I made use of this advantage to fix the issue. More info can found from this issue --> https://github.com/facebook/rocksdb/issues/1317 Closes https://github.com/facebook/rocksdb/pull/2040 Differential Revision: D4779967 Pulled By: siying fbshipit-source-id: 259f939 | 27 March 2017, 21:09:11 UTC |
| 34a7085 | Maysam Yabandeh | 25 March 2017, 00:07:38 UTC | Fix segmentation fault caused by #1961 Summary: Fixes #1961 which causes a segfault when filter_policy is nullptr and both pin_l0_filter_and_index_blocks_in_cache/cache_index_and_filter_blocks are set. Closes https://github.com/facebook/rocksdb/pull/2029 Differential Revision: D4764862 Pulled By: maysamyabandeh fbshipit-source-id: 05bd695 | 25 March 2017, 00:24:11 UTC |
| 8dee8ca | Shu Zhang | 24 March 2017, 23:58:51 UTC | Enable fifo compaction benchmark to db_bench Summary: Added fifo benchmark to db_bench. One thing i am not sure is that i am using CompactRange() instead of CompactFiles(). (may cause performance skew because CompactionRange() is not happening in current thread?) For CompactFiles(), for some reason FIFO compaction doesn't work as expected. More insight is welcomed. I guess FIFO compaction doesn't work with file names? igorcanadi test cmd: ./db_bench --compaction_style=2 --benchmarks=fillseqdeterministic --disable_auto_compactions --num_levels=1 --fifo_compaction_max_table_files_size_mb=10 ---------------------- DB 0 LSM --------------------- Level[0]: /000014.sst(size: 4211014 bytes) fillseqdeterministic : 4.731 micros/op 211381 ops/sec; 23.4 MB/s Closes https://github.com/facebook/rocksdb/pull/1734 Differential Revision: D4774964 Pulled By: siying fbshipit-source-id: 9d08df6 | 25 March 2017, 00:09:15 UTC |
| a5c8b54 | Andrew Kryczka | 24 March 2017, 02:20:04 UTC | fix a header include Summary: need to consistently include "rocksdb/persistent_cache.h" to fix internal build Closes https://github.com/facebook/rocksdb/pull/2034 Differential Revision: D4768101 Pulled By: ajkr fbshipit-source-id: 2ecb07f | 24 March 2017, 02:24:22 UTC |
| 91b5feb | Siying Dong | 24 March 2017, 01:06:44 UTC | Fix Windows Build broken by a recent commit Summary: Closes https://github.com/facebook/rocksdb/pull/2032 Differential Revision: D4766260 Pulled By: siying fbshipit-source-id: 415daa4 | 24 March 2017, 01:09:57 UTC |
| 41ccae6 | Warren Falk | 23 March 2017, 22:50:51 UTC | Add C API functions (and tests) for WriteBatchWithIndex Summary: I've added functions to the C API to support WriteBatchWithIndex as requested in #1833. I've also added unit tests to c_test I've implemented the WriteBatchWithIndex variation of every function available for regular WriteBatch. And added additional functions unique to WriteBatchWithIndex. For now, the following is omitted: 1. The ability to create WriteBatchWithIndex's custom batch-only iterator as I'm not sure what its purpose is. It should be possible to add later if anyone wants it. 2. The ability to create the batch with a fallback comparator, since it appears to be unnecessary. I believe the column family comparator will be used for this, meaning those using a custom comparator can just use the column family variations. Closes https://github.com/facebook/rocksdb/pull/1985 Differential Revision: D4760039 Pulled By: siying fbshipit-source-id: 393227e | 23 March 2017, 22:54:13 UTC |
| 88bb6f6 | Siying Dong | 23 March 2017, 22:09:15 UTC | non_shm CI should run tests on /tmp Summary: Since non_shn CI was made to run in parallel, /dev/shm is automatically used. It defeated the purpose of the test to cover a non-ramfs file system. Closes https://github.com/facebook/rocksdb/pull/2031 Differential Revision: D4764804 Pulled By: siying fbshipit-source-id: 5666bda | 23 March 2017, 22:24:12 UTC |
| 8888de2 | Sagar Vemuri | 23 March 2017, 18:20:47 UTC | Update .gitignore file in examples Summary: options_file_example should be added in .gitignore so that it does not show up as an untracked file in `git status`. Closes https://github.com/facebook/rocksdb/pull/2026 Differential Revision: D4759402 Pulled By: sagar0 fbshipit-source-id: d7fe133 | 23 March 2017, 18:24:14 UTC |
| 203136e | Ayappan | 23 March 2017, 01:05:39 UTC | Fix Compilation errors when using IBM Java Summary: PR to fix this issue -> https://github.com/facebook/rocksdb/issues/1926 Closes https://github.com/facebook/rocksdb/pull/1965 Differential Revision: D4682411 Pulled By: siying fbshipit-source-id: a519be1 | 23 March 2017, 01:09:10 UTC |
| f4fce47 | Daniel Black | 23 March 2017, 01:03:58 UTC | Fix clang compile error - [-Werror,-Wunused-lambda-capture] Summary: Errors where: db/version_set.cc:1535:20: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] [this](const Fsize& f1, const Fsize& f2) -> bool { ^ db/version_set.cc:1541:20: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] [this](const Fsize& f1, const Fsize& f2) -> bool { ^ db/db_test.cc:2983:27: error: lambda capture 'kNumPutsBeforeWaitForFlush' is not required to be captured for this use [-Werror,-Wunused-lambda-capture] auto gen_l0_kb = [this, kNumPutsBeforeWaitForFlush](int size) { ^ Closes https://github.com/facebook/rocksdb/pull/1972 Differential Revision: D4685991 Pulled By: siying fbshipit-source-id: 9125379 | 23 March 2017, 01:09:10 UTC |
| a084b26 | Siying Dong | 23 March 2017, 00:45:15 UTC | Blog post for releasing 5.2.1 Summary: Closes https://github.com/facebook/rocksdb/pull/2025 Differential Revision: D4759957 Pulled By: siying fbshipit-source-id: 5b5b625 | 23 March 2017, 00:54:18 UTC |
| 15950fe | Siying Dong | 22 March 2017, 22:45:15 UTC | Remove ASSERT_EQ(boolean, ...) Summary: Closes https://github.com/facebook/rocksdb/pull/2024 Differential Revision: D4755420 Pulled By: siying fbshipit-source-id: 7332ab1 | 22 March 2017, 22:54:12 UTC |
| 3e56c7e | Aaron Gao | 22 March 2017, 18:50:25 UTC | make total_log_size_ atomic Summary: make total_log_size_ atomic to avoid overflow caused by data race. Closes https://github.com/facebook/rocksdb/pull/2019 Differential Revision: D4751391 Pulled By: siying fbshipit-source-id: fac01dd | 22 March 2017, 18:54:40 UTC |
| 909028e | Siying Dong | 22 March 2017, 18:13:55 UTC | HISTORY.md for log_size_for_flush in CreateCheckpoint() Summary: Closes https://github.com/facebook/rocksdb/pull/2021 Differential Revision: D4755324 Pulled By: siying fbshipit-source-id: c8d7955 | 22 March 2017, 18:24:12 UTC |
| be723a8 | Dmitri Smirnov | 22 March 2017, 18:07:52 UTC | Optionally construct Post Processing Info map in MemTableInserter Summary: MemTableInserter default constructs Post processing info std::map. However, on Windows with 2015 STL the default constructed map still dynamically allocates one node which shows up on a profiler and we loose ~40% throughput on fillrandom benchmark. Solution: declare a map as std::aligned storage and optionally construct. This addresses https://github.com/facebook/rocksdb/issues/1976 Before: ------------------------------------------------------------------- Initializing RocksDB Options from command-line flags DB path: [k:\data\BulkLoadRandom_10M_fillonly] fillrandom : 2.775 micros/op 360334 ops/sec; 280.4 MB/s Microseconds per write: Count: 10000000 Average: 2.7749 StdDev: 39.92 Min: 1 Median: 2.0826 Max: 26051 Percentiles: P50: 2.08 P75: 2.55 P99: 3.55 P99.9: 9.58 P99.99: 51.5**6 ------------------------------------------------------ After: Initializing RocksDB Options from command-line flags DB path: [k:\data\BulkLoadRandom_10M_fillon Closes https://github.com/facebook/rocksdb/pull/2011 Differential Revision: D4740823 Pulled By: siying fbshipit-source-id: 1daaa2c | 22 March 2017, 18:24:12 UTC |
| e474df9 | Siying Dong | 22 March 2017, 18:05:55 UTC | db_bench: not need to check mmap for PlainTable Summary: PlainTable now supports non-mmap mode. We don't need to check it anymore. Closes https://github.com/facebook/rocksdb/pull/1882 Differential Revision: D4751643 Pulled By: siying fbshipit-source-id: ab14540 | 22 March 2017, 18:09:13 UTC |
| 8b0097b | Maysam Yabandeh | 22 March 2017, 16:11:23 UTC | Readers for partition filter Summary: This is the last split of this pull request: https://github.com/facebook/rocksdb/pull/1891 which includes the reader part as well as the tests. Closes https://github.com/facebook/rocksdb/pull/1961 Differential Revision: D4672216 Pulled By: maysamyabandeh fbshipit-source-id: 6a2b829 | 22 March 2017, 16:24:15 UTC |
| 9ef3627 | Siying Dong | 22 March 2017, 00:53:21 UTC | Allow checkpointing without flushing Summary: Add a parameter to Checkpoint::CreateCheckpoint() so that flush can be skipped if total log file size is within a threshold. Closes https://github.com/facebook/rocksdb/pull/1993 Differential Revision: D4719842 Pulled By: siying fbshipit-source-id: 4f9d9e1 | 22 March 2017, 01:09:13 UTC |
| 17866ec | Siying Dong | 22 March 2017, 00:22:10 UTC | Allow Users to change customized ldb tools' header in help printing Summary: Closes https://github.com/facebook/rocksdb/pull/2018 Differential Revision: D4748448 Pulled By: siying fbshipit-source-id: a54c2f9 | 22 March 2017, 00:39:12 UTC |
| a2a8833 | Leonidas Galanis | 21 March 2017, 19:47:36 UTC | remove deleted option from benchmark.sh Summary: Removed max_grandparent_overlap_factor from benchmark.sh since it is not a valid option anymore. Closes https://github.com/facebook/rocksdb/pull/2015 Differential Revision: D4748229 Pulled By: lgalanis fbshipit-source-id: c3869ea | 21 March 2017, 19:54:13 UTC |
| 78cb195 | Aaron Gao | 21 March 2017, 18:49:08 UTC | add checkpoint to ldb Summary: Closes https://github.com/facebook/rocksdb/pull/2017 Differential Revision: D4747656 Pulled By: lightmark fbshipit-source-id: c52f160 | 21 March 2017, 18:54:11 UTC |
| 4b04add | Raza Hussain | 21 March 2017, 18:04:06 UTC | updated solution if "make format" command fails Summary: Closes https://github.com/facebook/rocksdb/pull/2016 Differential Revision: D4747003 Pulled By: yiwu-arbug fbshipit-source-id: c1e2c5a | 21 March 2017, 18:09:10 UTC |
| 8f5bf04 | Siying Dong | 21 March 2017, 17:59:57 UTC | Flush triggered by DB write buffer size picks the oldest unflushed CF Summary: Previously, when DB write buffer size triggers, we always pick the CF with most data in its memtable to flush. This approach can minimize total flush happens. Change the behavior to always pick the oldest unflushed CF, which makes it the same behavior when max_total_wal_size hits. This approach will minimize size used by max_total_wal_size. Closes https://github.com/facebook/rocksdb/pull/1987 Differential Revision: D4703214 Pulled By: siying fbshipit-source-id: 9ff8b09 | 21 March 2017, 18:09:10 UTC |
| 6908e24 | Raza Hussain | 21 March 2017, 05:50:56 UTC | dynamic setting of stats_dump_period_sec through SetDBOption() Summary: Resolved the following issue: https://github.com/facebook/rocksdb/issues/1930 Closes https://github.com/facebook/rocksdb/pull/2004 Differential Revision: D4736764 Pulled By: yiwu-arbug fbshipit-source-id: 64fe0b7 | 21 March 2017, 05:54:13 UTC |
| 93c68b6 | Aaron Gao | 21 March 2017, 00:24:20 UTC | change regression bash file with debug mode Summary: add debug mode for better debugging refactor some regex change micros/op to ops/sec Closes https://github.com/facebook/rocksdb/pull/1999 Differential Revision: D4742806 Pulled By: lightmark fbshipit-source-id: 0fe3ae6 | 21 March 2017, 00:39:17 UTC |
| 21d8c31 | Maysam Yabandeh | 20 March 2017, 19:52:20 UTC | remove LIKELY from public headers Summary: Fixes #2008 Closes https://github.com/facebook/rocksdb/pull/2009 Differential Revision: D4739885 Pulled By: maysamyabandeh fbshipit-source-id: 36fba5d | 20 March 2017, 19:54:14 UTC |
| 36ad757 | Tamir Duberstein | 17 March 2017, 18:39:00 UTC | INSTALL: document USE_SSE Summary: Fixes #1790. adamretter siying Closes https://github.com/facebook/rocksdb/pull/1996 Differential Revision: D4730449 Pulled By: IslamAbdelRahman fbshipit-source-id: 19944fa | 17 March 2017, 18:54:11 UTC |
| 9272e12 | Aaron Gao | 17 March 2017, 18:25:01 UTC | avoid ftruncate twice in buffered io Summary: in buffered io, the filesize_ is the real size. Closes https://github.com/facebook/rocksdb/pull/1991 Differential Revision: D4711433 Pulled By: lightmark fbshipit-source-id: ad604b9 | 17 March 2017, 18:39:13 UTC |
| d52f334 | Islam AbdelRahman | 17 March 2017, 01:10:37 UTC | Break stalls when no bg work is happening Summary: Current stall will keep sleeping even if there is no Flush/Compactions to wait for, I changed the logic to break the stall if we are not flushing or compacting db_bench command used ``` # fillrandom # memtable size = 10MB # value size = 1 MB # num = 1000 # use /dev/shm ./db_bench --benchmarks="fillrandom,stats" --value_size=1048576 --write_buffer_size=10485760 --num=1000 --delayed_write_rate=XXXXX --db="/dev/shm/new_stall" | grep "Cumulative stall" ``` ``` Current results # delayed_write_rate = 1000 Kb/sec Cumulative stall: 00:00:9.031 H:M:S # delayed_write_rate = 200 Kb/sec Cumulative stall: 00:00:22.314 H:M:S # delayed_write_rate = 100 Kb/sec Cumulative stall: 00:00:42.784 H:M:S # delayed_write_rate = 50 Kb/sec Cumulative stall: 00:01:23.785 H:M:S # delayed_write_rate = 25 Kb/sec Cumulative stall: 00:02:45.702 H:M:S ``` ``` New results # delayed_write_rate = 1000 Kb/sec Cumulative stall: 00:00:9.017 H:M:S # delayed_write_rate = 200 Kb/sec Cumulative stall: 00 Closes https://github.com/facebook/rocksdb/pull/1884 Differential Revision: D4585439 Pulled By: IslamAbdelRahman fbshipit-source-id: aed2198 | 17 March 2017, 01:24:17 UTC |
| e66221a | Andrew Kryczka | 17 March 2017, 00:45:28 UTC | fix db_bench rate limiter callsites Summary: pass nullptr as stats object for db_bench-specific rate limiters since its stats are intended to capture background write activity only. Closes https://github.com/facebook/rocksdb/pull/1997 Differential Revision: D4726806 Pulled By: ajkr fbshipit-source-id: 8e4b225 | 17 March 2017, 00:54:12 UTC |
| dbae438 | Siying Dong | 16 March 2017, 20:42:13 UTC | Replace "DEPRECATED" comment to "not supported" Summary: "DEPRECATED" is ambiguous. Make it clear that those options not supported won't take effect. Closes https://github.com/facebook/rocksdb/pull/1995 Differential Revision: D4724241 Pulled By: siying fbshipit-source-id: 1e812b8 | 16 March 2017, 20:54:11 UTC |
| 995618a | Islam AbdelRahman | 16 March 2017, 19:06:04 UTC | Support SstFileManager::SetDeleteRateBytesPerSecond() Summary: Update DeleteScheduler component to support changing delete rate in runtime by introducing SstFileManager::SetDeleteRateBytesPerSecond() Closes https://github.com/facebook/rocksdb/pull/1994 Differential Revision: D4719906 Pulled By: IslamAbdelRahman fbshipit-source-id: e6b8d9e | 16 March 2017, 19:09:15 UTC |
| e191636 | Islam AbdelRahman | 16 March 2017, 02:22:52 UTC | Add macros to include file name and line number during Logging Summary: current logging ``` 2017/03/14-14:20:30.393432 7fedde9f5700 (Original Log Time 2017/03/14-14:20:30.393414) [default] Level summary: base level 1 max bytes base 268435456 files[1 0 0 0 0 0 0] max score 0.25 2017/03/14-14:20:30.393438 7fedde9f5700 [JOB 2] Try to delete WAL files size 61417909, prev total WAL file size 73820858, number of live WAL files 2. 2017/03/14-14:20:30.393464 7fedde9f5700 [DEBUG] [JOB 2] Delete /dev/shm/old_logging//MANIFEST-000001 type=3 #1 -- OK 2017/03/14-14:20:30.393472 7fedde9f5700 [DEBUG] [JOB 2] Delete /dev/shm/old_logging//000003.log type=0 #3 -- OK 2017/03/14-14:20:31.427103 7fedd49f1700 [default] New memtable created with log file: #9. Immutable memtables: 0. 2017/03/14-14:20:31.427179 7fedde9f5700 [JOB 3] Syncing log #6 2017/03/14-14:20:31.427190 7fedde9f5700 (Original Log Time 2017/03/14-14:20:31.427170) Calling FlushMemTableToOutputFile with column family [default], flush slots available 1, compaction slots allowed 1, compaction slots scheduled 1 2017/03/14-14:20:31. Closes https://github.com/facebook/rocksdb/pull/1990 Differential Revision: D4708695 Pulled By: IslamAbdelRahman fbshipit-source-id: cb8968f | 16 March 2017, 02:39:12 UTC |
| d525718 | Aaron Gao | 15 March 2017, 05:23:21 UTC | cleanup direct io flag in WritableFileWriter Summary: remove unnecessary field `direct_io_`, use `use_direct_io()` instead. Closes https://github.com/facebook/rocksdb/pull/1992 Differential Revision: D4712195 Pulled By: lightmark fbshipit-source-id: 57d34f9 | 15 March 2017, 05:39:09 UTC |
| 5fa927a | slyrz | 14 March 2017, 19:00:38 UTC | Add Xpress and ZSTD CompressionType values to C header Summary: This PR copies the missing CompressionType values ```cpp enum CompressionType : unsigned char { ... kXpressCompression = 0x6, kZSTD = 0x7, ... }; ``` into the C header. Closes https://github.com/facebook/rocksdb/pull/1989 Differential Revision: D4706265 Pulled By: siying fbshipit-source-id: e65e62a | 14 March 2017, 19:09:21 UTC |
| 1152625 | Maysam Yabandeh | 13 March 2017, 18:44:50 UTC | Pinnableslice (2nd attempt) Summary: PinnableSlice Summary: Currently the point lookup values are copied to a string provided by the user. This incures an extra memcpy cost. This patch allows doing point lookup via a PinnableSlice which pins the source memory location (instead of copying their content) and releases them after the content is consumed by the user. The old API of Get(string) is translated to the new API underneath. Here is the summary for improvements: value 100 byte: 1.8% regular, 1.2% merge values value 1k byte: 11.5% regular, 7.5% merge values value 10k byte: 26% regular, 29.9% merge values The improvement for merge could be more if we extend this approach to pin the merge output and delay the full merge operation until the user actually needs it. We have put that for future work. PS: Sometimes we observe a small decrease in performance when switching from t5452014 to this patch but with the old Get(string) API. The d Closes https://github.com/facebook/rocksdb/pull/1756 Differential Revision: D4391738 Pulled By: maysamyabandeh fbshipit-source-id: 6f3edd3 | 13 March 2017, 18:54:10 UTC |
| e5bd8de | Aaron Gao | 13 March 2017, 18:35:50 UTC | update history.md for fixing the bug that skips keys Summary: Closes https://github.com/facebook/rocksdb/pull/1986 Differential Revision: D4699152 Pulled By: siying fbshipit-source-id: b18c32c | 13 March 2017, 18:39:13 UTC |
| 1ffbdfd | Sagar Vemuri | 13 March 2017, 18:17:19 UTC | Add a new SstFileWriter constructor without explicit comparator Summary: The comparator param in SstFileWriter constructor is redundant as it already exists as a field in options. So the current SstFileWriter constructor should be deprecated in favor of a new one which does not take a comparator. Note that the jni/java apis have not been touched yet. Closes https://github.com/facebook/rocksdb/pull/1978 Differential Revision: D4685629 Pulled By: sagar0 fbshipit-source-id: 372ce96 | 13 March 2017, 18:39:13 UTC |
| ebd5639 | Reid Horuff | 13 March 2017, 17:24:52 UTC | Add ability to search for key prefix in sst_dump tool Summary: Add the flag --prefix to the sst_dump tool This flag is similar to, and exclusive from, the --from flag. --prefix=0x00FF will return all rows prefixed with 0x00FF. The --to flag may also be specified and will work as expected. These changes were used to help in debugging the power cycle corruption issue and theses changes were tested by scanning through a udb. Closes https://github.com/facebook/rocksdb/pull/1984 Differential Revision: D4691814 Pulled By: reidHoruff fbshipit-source-id: 027f261 | 13 March 2017, 17:39:12 UTC |
| e6725e8 | Maysam Yabandeh | 13 March 2017, 16:41:30 UTC | Fix some bugs in MockEnv Summary: Fixing some bugs in MockEnv so it be actually used. Closes https://github.com/facebook/rocksdb/pull/1914 Differential Revision: D4609923 Pulled By: maysamyabandeh fbshipit-source-id: ca25735 | 13 March 2017, 16:54:11 UTC |
| 900c62b | Min Wei | 10 March 2017, 19:07:33 UTC | fix compile for VS2015 Summary: Without the cast, the build will break on Windows. Closes https://github.com/facebook/rocksdb/pull/1982 Differential Revision: D4690462 Pulled By: ajkr fbshipit-source-id: c493b6c | 10 March 2017, 19:24:09 UTC |
| fe18356 | Andrew Kryczka | 09 March 2017, 20:33:48 UTC | release 5.3 Summary: Closes https://github.com/facebook/rocksdb/pull/1971 Differential Revision: D4683851 Pulled By: ajkr fbshipit-source-id: 967116e | 09 March 2017, 20:39:10 UTC |
| 5dae019 | Maysam Yabandeh | 09 March 2017, 18:59:06 UTC | Revert "Report cpu usage using time command" Summary: This reverts commit d43adf21bb26c2dd89d2942895c376dd4775455c. The patch has caused problems in regression tests. Will revert it for now until we figure how to debug the problems regression tests. Closes https://github.com/facebook/rocksdb/pull/1975 Differential Revision: D4682880 Pulled By: maysamyabandeh fbshipit-source-id: 84df83a | 09 March 2017, 19:09:13 UTC |
| f2817fb | Andrew Kryczka | 09 March 2017, 06:16:45 UTC | avoid ASSERT_EQ(false, ...); Summary: lately it fails on travis due to a compiler bug (see https://github.com/google/googletest/issues/322#issuecomment-125645145). interestingly it seems to affect occurrences of `ASSERT_EQ(false, ...);` but not `ASSERT_EQ(true, ...);`. Closes https://github.com/facebook/rocksdb/pull/1958 Differential Revision: D4680742 Pulled By: ajkr fbshipit-source-id: 291fe41 | 09 March 2017, 06:24:16 UTC |
| 5b11124 | Andrew Kryczka | 09 March 2017, 06:13:15 UTC | add max to histogram stats Summary: Domas enlightened me about p100 (i.e., max) stats. Let's add them to our histograms. Closes https://github.com/facebook/rocksdb/pull/1968 Differential Revision: D4678716 Pulled By: ajkr fbshipit-source-id: 65e7118 | 09 March 2017, 06:24:15 UTC |
| d43adf2 | Maysam Yabandeh | 09 March 2017, 01:50:19 UTC | Report cpu usage using time command Summary: It augments the regression benchmarks with a time command, parses the output, and print them to the SUMMARY.csv file. I tested a variation of the script locally. Any idea how to do run a test that also involves writing to scuba tables? Closes https://github.com/facebook/rocksdb/pull/1967 Differential Revision: D4679470 Pulled By: maysamyabandeh fbshipit-source-id: 44dac30 | 09 March 2017, 01:54:11 UTC |
| 18fc1bc | Andrew Kryczka | 09 March 2017, 01:43:11 UTC | minor changes for rate limiter test flakiness Summary: the 50%+ drained constraint wasn't working consistently in some of our test environments, maybe their resources are too low. relax the constraints a bit. Closes https://github.com/facebook/rocksdb/pull/1970 Differential Revision: D4679419 Pulled By: ajkr fbshipit-source-id: 3789cd8 | 09 March 2017, 01:54:11 UTC |
| 12ba00e | Aaron Gao | 09 March 2017, 01:12:04 UTC | Reset DBIter::saved_key_ with proper user key anywhere before pass to DBIter::FindNextUserEntry Summary: fix db_iter bug introduced by [facebook#1413](https://github.com/facebook/rocksdb/pull/1413) Closes https://github.com/facebook/rocksdb/pull/1962 Differential Revision: D4672369 Pulled By: lightmark fbshipit-source-id: 6a22953 | 09 March 2017, 01:24:11 UTC |
| c9df05d | Dmitri Smirnov | 09 March 2017, 01:00:04 UTC | Fix random access alignment Summary: This fixes an issue when the most recent readers assume that alignment is always set even if direct io is off. Also adjust slightly appveyor script to run db_basic_test cases concurrently. Closes https://github.com/facebook/rocksdb/pull/1959 Differential Revision: D4671972 Pulled By: IslamAbdelRahman fbshipit-source-id: 1886620 | 09 March 2017, 01:09:11 UTC |
| f649915 | Islam AbdelRahman | 08 March 2017, 02:19:02 UTC | Add Bulkoading IngestExternalFile blog post Summary: new blog post for bulkoading Closes https://github.com/facebook/rocksdb/pull/1883 Differential Revision: D4671984 Pulled By: IslamAbdelRahman fbshipit-source-id: 3450860 | 08 March 2017, 02:24:10 UTC |
| 54b4341 | Maysam Yabandeh | 07 March 2017, 21:48:02 UTC | Builders for partition filter Summary: This is the second split of this pull request: https://github.com/facebook/rocksdb/pull/1891 which includes only the builder part. The testing will be included in the third split, where the reader is also included. Closes https://github.com/facebook/rocksdb/pull/1952 Differential Revision: D4660272 Pulled By: maysamyabandeh fbshipit-source-id: 36b3cf0 | 07 March 2017, 21:54:12 UTC |
| 97edc72 | Sagar Vemuri | 07 March 2017, 19:50:02 UTC | Add a memtable-only iterator Summary: This PR is to support a way to iterate over all the keys that are just in memtables. Closes https://github.com/facebook/rocksdb/pull/1953 Differential Revision: D4663500 Pulled By: sagar0 fbshipit-source-id: 144e177 | 07 March 2017, 19:54:10 UTC |
| 7220296 | Leonidas Galanis | 07 March 2017, 19:06:53 UTC | fix db_sst_test flakiness Summary: db_sst_test had been flaky occasionally in the following way: reached_max_space_on_compaction can in very rare cases be 0. This happens when the limit on maximum allowable space set using SetMaxAllowedSpaceUsage is hit during flush for all test db sizes (1,2,4,8 and 10MB).The fix clears the error returned when the the space limit is reached during flush. This ensures that the compaction call back will always be called. The runtime is increased slightly because the 1MB loop writes more data and hits the limit during multiple flushes until compaction is scheduled. Closes https://github.com/facebook/rocksdb/pull/1861 Differential Revision: D4557396 Pulled By: lgalanis fbshipit-source-id: ff778d1 | 07 March 2017, 19:24:13 UTC |
| 5f65dc8 | Matteo Merli | 07 March 2017, 06:13:53 UTC | Expose DB::DeleteRange and WriteBath::DeleteRange in Java Summary: Added JNI wrapper from `DeleteRange` methods Closes https://github.com/facebook/rocksdb/pull/1951 Differential Revision: D4657746 Pulled By: yiwu-arbug fbshipit-source-id: 3fc7ab8 | 07 March 2017, 06:24:26 UTC |
| 58b12df | Reid Horuff | 06 March 2017, 23:04:36 UTC | Set logs as getting flushed before releasing lock, race condition fix Summary: Relating to #1903: In MaybeFlushColumnFamilies() we want to modify the 'getting_flushed' flag before releasing the db mutex when SwitchMemtable() is called. The following 2 actions need to be atomic in MaybeFlushColumnFamilies() - getting_flushed is false on oldest log - we determine that all CFs can be flushed to successfully release oldest log - we set getting_flushed = true on the oldest log. ------- - getting_flushed is false on oldest log - we determine that all CFs can NOT be flushed to successfully release oldest log - we set unable_to_flush_oldest_log_ = true on the oldest log. #### In the 2pc case: T1 enters function but is unable to flush all CFs to release log T1 sets unable_to_flush_oldest_log_ = true T1 begins flushing all CFs possible T2 enters function but is unable to flush all CFs to release log T2 sees unable_to_flush_oldes_log_ has been set so exits T3 enters function and will be able to flush all CFs to release oldest log T3 sets getting_flushed = true on oldes Closes https://github.com/facebook/rocksdb/pull/1909 Differential Revision: D4646235 Pulled By: reidHoruff fbshipit-source-id: c8d0447 | 06 March 2017, 23:09:11 UTC |
| f8a4ea0 | Siying Dong | 06 March 2017, 17:25:58 UTC | Move db_test and external_sst_file_test out of Travis's MAC OS run Summary: After we have db_basic_test and external_sst_file_basic_test, we don't need to run db_test and external_sst_file_test in Travis's MAC OS run anymore. Move it out. Closes https://github.com/facebook/rocksdb/pull/1940 Differential Revision: D4659361 Pulled By: siying fbshipit-source-id: e64e291 | 06 March 2017, 17:39:15 UTC |
| 534581a | Maysam Yabandeh | 06 March 2017, 02:01:28 UTC | Fix a bug in tests in options operator= Summary: Note: Using the default operator= is an unsafe approach for Options since it destructs shared_ptr in the same order of their creation, in contrast to destructors which destructs them in the opposite order of creation. One particular problme is that the cache destructor might invoke callback functions that use Option members such as statistics. To work around this problem, we manually call destructor of table_facotry which eventually clears the block cache. Closes https://github.com/facebook/rocksdb/pull/1950 Differential Revision: D4655473 Pulled By: maysamyabandeh fbshipit-source-id: 6c4bbff | 06 March 2017, 02:09:09 UTC |
| a2f7a51 | Maysam Yabandeh | 04 March 2017, 02:09:43 UTC | Refactoring Summary: This is the first split of https://github.com/facebook/rocksdb/pull/1891 and will be needed for the upcoming partitioned filter patch. Closes https://github.com/facebook/rocksdb/pull/1949 Differential Revision: D4652152 Pulled By: maysamyabandeh fbshipit-source-id: 9801778 | 04 March 2017, 02:24:12 UTC |
| 2a5daa0 | Andrew Kryczka | 03 March 2017, 21:17:39 UTC | Add stderr log level for ldb backup commands Summary: Also extracted the common logic into a base class, BackupableCommand. Closes https://github.com/facebook/rocksdb/pull/1939 Differential Revision: D4630121 Pulled By: ajkr fbshipit-source-id: 04bb067 | 03 March 2017, 21:24:15 UTC |
| 4561275 | Andrew Kryczka | 03 March 2017, 19:00:46 UTC | fix rate limiter test flakiness Summary: fix when elapsed time spans non-integral number of intervals since the rate limiter may still be drained during a partial interval. Closes https://github.com/facebook/rocksdb/pull/1948 Differential Revision: D4651304 Pulled By: ajkr fbshipit-source-id: b1f9e70 | 03 March 2017, 19:09:11 UTC |
| 7c80a6d | Andrew Kryczka | 03 March 2017, 01:40:24 UTC | Statistic for how often rate limiter is drained Summary: This is the metric I plan to use for adaptive rate limiting. The statistics are updated only if the rate limiter is drained by flush or compaction. I believe (but am not certain) that this is the normal case. The Statistics object is passed in RateLimiter::Request() to avoid requiring changes to client code, which would've been necessary if we passed it in the RateLimiter constructor. Closes https://github.com/facebook/rocksdb/pull/1946 Differential Revision: D4646489 Pulled By: ajkr fbshipit-source-id: d8e0161 | 03 March 2017, 01:54:15 UTC |
| 0ad5af4 | Andrew Kryczka | 03 March 2017, 01:17:06 UTC | Clarify VerifyBackup behavior Summary: It's non-obvious to users that using the same backup engine for creating/verifying provides better results than using separate backup engines, so add a comment in header. Closes https://github.com/facebook/rocksdb/pull/1942 Differential Revision: D4637865 Pulled By: ajkr fbshipit-source-id: e6efe24 | 03 March 2017, 01:24:11 UTC |
| 6fb9013 | Aaron Gao | 03 March 2017, 01:11:18 UTC | sanitize readahead when direct read enabled Summary: no readahead: readseq : 8.438 micros/op 118510 ops/sec; 13.1 MB/s sanitize to 10MB: readseq : 6.051 micros/op 165248 ops/sec; 18.3 MB/s Closes https://github.com/facebook/rocksdb/pull/1945 Differential Revision: D4645811 Pulled By: lightmark fbshipit-source-id: 5d63770 | 03 March 2017, 01:24:11 UTC |
| f89b389 | Islam AbdelRahman | 03 March 2017, 00:45:07 UTC | Remove skip_table_builder_flush and default it to true Summary: This option is needed to be enabled for Direct IO and I cannot think of a reason where we need to disable it remove it and default it to true Closes https://github.com/facebook/rocksdb/pull/1944 Differential Revision: D4641088 Pulled By: IslamAbdelRahman fbshipit-source-id: d7085b9 | 03 March 2017, 00:54:10 UTC |
| cc25398 | Andrew Kryczka | 02 March 2017, 18:45:04 UTC | Use more default options in db_bench Summary: The default behavior was too weird because, previously, we got the L0 file size limit (64MB) from Options default and L1+ file size limit (2MB) from the hardcoded value. We should get both from Options default. Closes https://github.com/facebook/rocksdb/pull/1943 Differential Revision: D4640301 Pulled By: ajkr fbshipit-source-id: fd8c0fd | 02 March 2017, 18:54:11 UTC |
| 8432bcf | Siying Dong | 02 March 2017, 18:08:49 UTC | Make compaction_pri settable through option string Summary: Closes https://github.com/facebook/rocksdb/pull/1941 Differential Revision: D4637253 Pulled By: siying fbshipit-source-id: a59dcdb | 02 March 2017, 18:24:12 UTC |
| d5b607a | Siying Dong | 01 March 2017, 01:32:58 UTC | Make db_wal_test slightly faster Summary: Avoid to run db_wal_test in all the DB test options, and some small changes. Closes https://github.com/facebook/rocksdb/pull/1921 Differential Revision: D4622054 Pulled By: siying fbshipit-source-id: 890fd64 | 01 March 2017, 01:39:10 UTC |
| ba4c77b | Siying Dong | 28 February 2017, 22:11:01 UTC | Divide external_sst_file_test Summary: Separate the platform dependent tests from external_sst_file_test. Only those tests need to run on platforms like OSX Closes https://github.com/facebook/rocksdb/pull/1923 Differential Revision: D4622461 Pulled By: siying fbshipit-source-id: d2d6f04 | 28 February 2017, 22:24:11 UTC |
| e877afa | Aaron Gao | 28 February 2017, 19:05:08 UTC | Remove bulk loading and auto_roll_logger in rocksdb_lite Summary: shrink lite size Closes https://github.com/facebook/rocksdb/pull/1929 Differential Revision: D4622059 Pulled By: siying fbshipit-source-id: 050b796 | 28 February 2017, 19:09:11 UTC |
| 90d8355 | xiusir | 28 February 2017, 18:29:44 UTC | Fix the wrong address for PREFETCH in DynamicBloom::Prefetch Summary: - Change data_[b] to data_[b / 8] in DynamicBloom::Prefetch, as b means the b-th bit in data_ and data_[b / 8] is the proper byte in data_. Closes https://github.com/facebook/rocksdb/pull/1935 Differential Revision: D4628696 Pulled By: siying fbshipit-source-id: bc5a0c6 | 28 February 2017, 18:39:11 UTC |
| 08864df | Islam AbdelRahman | 28 February 2017, 01:36:06 UTC | Move advanced column family options to advanced_options.h Summary: For the sake of making our options simpler, we should keep options.h as simple as possible and move more advanced/less common options to advaned_options.h I started with ColumnFamilyOptions and also did some re-ordering I have moved all ColumnFamilyOptions to advanced_options.h and only left these options in options.h ``` const Comparator* comparator = BytewiseComparator(); std::shared_ptr<MergeOperator> merge_operator = nullptr; const CompactionFilter* compaction_filter = nullptr; std::shared_ptr<CompactionFilterFactory> compaction_filter_factory = nullptr; size_t write_buffer_size = 64 << 20; CompressionType compression; int level0_file_num_compaction_trigger = 4; bool disable_auto_compactions = false; ``` Please feel free to comment on specific options if you think they should be advanced or should not be Closes https://github.com/facebook/rocksdb/pull/1847 Differential Revision: D4519996 Pulled By: IslamAbdelRahman fbshipit-source-id: abebd9a | 28 February 2017, 01:54:14 UTC |
| 2ca2059 | Peter (Stig) Edwards | 28 February 2017, 01:22:50 UTC | Get unique_ptr to use delete[] for char[] in DumpMallocStats Summary: Avoid mismatched free() / delete / delete [] in DumpMallocStats Closes https://github.com/facebook/rocksdb/pull/1927 Differential Revision: D4622045 Pulled By: siying fbshipit-source-id: 1131b30 | 28 February 2017, 01:39:12 UTC |
| 253799c | Tamir Duberstein | 28 February 2017, 01:19:09 UTC | Add missing include for `abort()` Summary: Fixes #1233 (again). Closes https://github.com/facebook/rocksdb/pull/1931 Differential Revision: D4625289 Pulled By: ajkr fbshipit-source-id: 70e774e | 28 February 2017, 01:24:13 UTC |
| c6d464a | Adam Retter | 28 February 2017, 00:26:12 UTC | Fixed various memory leaks and Java 8 JNI Compatibility Summary: I have manually audited the entire RocksJava code base. Sorry for the large pull-request, I have broken it down into many small atomic commits though. My initial intention was to fix the warnings that appear when running RocksJava on Java 8 with `-Xcheck:jni`, for example when running `make jtest` you would see many errors similar to: ``` WARNING in native method: JNI call made without checking exceptions when required to from CallObjectMethod WARNING in native method: JNI call made without checking exceptions when required to from CallVoidMethod WARNING in native method: JNI call made without checking exceptions when required to from CallStaticVoidMethod ... ``` A few of those warnings still remain, however they seem to come directly from the JVM and are not directly related to RocksJava; I am in contact with the OpenJDK hostpot-dev mailing list about these - http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025981.html. As a result of fixing these, I realised we were not r Closes https://github.com/facebook/rocksdb/pull/1890 Differential Revision: D4591758 Pulled By: siying fbshipit-source-id: 7f7fdf4 | 28 February 2017, 00:39:12 UTC |
| be3e556 | Islam AbdelRahman | 27 February 2017, 20:59:34 UTC | Fix unaligned reads in read cache Summary: - Fix unaligned reads in read cache by using RandomAccessFileReader - Allow read cache flags in db_bench Closes https://github.com/facebook/rocksdb/pull/1916 Differential Revision: D4610885 Pulled By: IslamAbdelRahman fbshipit-source-id: 2aa1dc8 | 27 February 2017, 21:09:12 UTC |
| 8ad0fcd | Siying Dong | 27 February 2017, 20:19:23 UTC | Separate small subset tests in DBTest Summary: Separate a smal subset of tests in DBTest to DBBasicTest. Tests in DBTest don't have to run in CI tests on platforms like OSX, as long as they are covered by Linux. Closes https://github.com/facebook/rocksdb/pull/1924 Differential Revision: D4616702 Pulled By: siying fbshipit-source-id: 13e6549 | 27 February 2017, 20:24:11 UTC |
| 6c951c4 | Siying Dong | 27 February 2017, 19:04:27 UTC | Run fewer tests in OSX Summary: Travis is short of OSX resource. Try to move platform independent test suites out of OSX Closes https://github.com/facebook/rocksdb/pull/1922 Differential Revision: D4616070 Pulled By: siying fbshipit-source-id: 786342c | 27 February 2017, 19:09:20 UTC |
| f7997f1 | Aaron Gao | 24 February 2017, 05:59:26 UTC | add direct I/O to version notes 5.2.0 Summary: let users know this feature is ready Closes https://github.com/facebook/rocksdb/pull/1915 Differential Revision: D4610842 Pulled By: lightmark fbshipit-source-id: d102772 | 24 February 2017, 06:09:12 UTC |
| 3b8ba70 | Siying Dong | 24 February 2017, 02:36:20 UTC | Fix flaky DBTestUniversalCompaction.UniversalCompactionTrivialMoveTest2 Summary: A previous fix to DBTestUniversalCompaction.UniversalCompactionTrivialMoveTest2 didn't address the right problem. The problem is L0->L0 compaction is not trivial move in the scenario, not parallel compactions. Fix this. Closes https://github.com/facebook/rocksdb/pull/1911 Differential Revision: D4608955 Pulled By: siying fbshipit-source-id: 7a712cb | 24 February 2017, 02:39:13 UTC |
| 96c7e15 | Siying Dong | 24 February 2017, 02:35:54 UTC | Fix Java build Summary: The PATH update should put the Java path in the beginning, rather than the end. Otherwise, it will be overwritten. Also upgrade the Java version. Closes https://github.com/facebook/rocksdb/pull/1912 Differential Revision: D4609854 Pulled By: siying fbshipit-source-id: 3dc04f2 | 24 February 2017, 02:39:13 UTC |
| e0b87af | Siying Dong | 23 February 2017, 23:54:47 UTC | Black list some slow valgrind tests Summary: valgrind tests always timeout with parallel run. Black list some slowest ones. It is better to run fewer tests than always have the tests timeout. Closes https://github.com/facebook/rocksdb/pull/1908 Differential Revision: D4607875 Pulled By: siying fbshipit-source-id: 7062664 | 24 February 2017, 00:09:11 UTC |
| e67232c | Andrew Kryczka | 23 February 2017, 23:29:41 UTC | Handle failed Finish() in SST file writer Summary: The assertion in Abandon() fails when called after Finish() fails. Finish() already closes the builder so there's no need to call Abandon(). Closes https://github.com/facebook/rocksdb/pull/1901 Differential Revision: D4601373 Pulled By: ajkr fbshipit-source-id: e5678be | 23 February 2017, 23:39:16 UTC |
| 8efb5ff | Siying Dong | 23 February 2017, 22:53:03 UTC | [rocksdb][PR] Remove option min_partial_merge_operands and verify_checksums_in_comp… Summary: …action The two options, min_partial_merge_operands and verify_checksums_in_compaction, are not seldom used. Remove them to reduce the total number of options. Also remove them from Java and C interface. Closes https://github.com/facebook/rocksdb/pull/1902 Differential Revision: D4601219 Pulled By: siying fbshipit-source-id: aad4cb2 | 23 February 2017, 23:09:12 UTC |
