| c1b1e58 | Marc Mutz | 19 August 2016, 08:09:50 UTC | QGuiVariant: use new QColor::setNamedColor(QLatin1String) Change-Id: If36f9f3c60ee5cea3082a973a4b8ea9d2de1b62f Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> | 23 September 2016, 16:36:44 UTC |
| 0be620a | Maurice Kalinowski | 22 September 2016, 13:01:55 UTC | Fix test for targets without process support There is no need to switch to the current directory, when there is no process support. This also fixes running the test on sandboxed target platforms. Change-Id: I25fabb8b22d3510062a012884eb1eaab682901d3 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io> | 23 September 2016, 07:32:44 UTC |
| 31b3986 | Eskil Abrahamsen Blomfeldt | 20 September 2016, 14:29:58 UTC | Fix DirectWrite engine when loading from data through QRawFont The stretch, once it is passed to the font engine, is assumed to be the horizontal scale needed to match the requested stretch for the given font. When loading from data in QRawFont, there is no way to specify this stretch; the scale should always be 1. The effect of this was that when DirectWrite was backing a font loaded through QRawFont directly from data, then the glyph images would be scaled to 0xHEIGHT before they were returned, thus they would be empty. This was a regression caused by ec7fee968f5f1a842b7d2fe670de1d517ecca308. Task-number: QTBUG-56091 Change-Id: I38e76e0e8f6809262474922946752b2ad0d6209b Reviewed-by: Konstantin Ritt <ritt.ks@gmail.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> | 23 September 2016, 07:29:14 UTC |
| 9888a2c | Maurice Kalinowski | 23 September 2016, 05:42:48 UTC | Fix test for WinRT Only on win32 we can omit creating a new window. Change-Id: Ie49ef45ccb745aaa43f58096e7810c71671124ba Reviewed-by: Oliver Wolff <oliver.wolff@qt.io> | 23 September 2016, 07:20:53 UTC |
| 0889e9d | Marc Mutz | 19 August 2016, 07:48:14 UTC | QColor: provide QLatin1String overloads of functions taking QString The inefficiency of QColor(const char*) came to light by a recent refactoring which showed that the existing char* overload of qt_get_hex_rgb() was never called. So, provide a QLatin1String interface for named colors that allows user code to reach that internal function without converting to QString first. Change-Id: I74df7b570ef28c00e35ca4adf46c4b7c7e9994b3 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 23 September 2016, 04:39:41 UTC |
| ceb3c2e | Marc Mutz | 16 August 2016, 13:33:18 UTC | QXmlAttributes: re-enable suppressed move special member functions ... at least for compilers that support defaulting functions. The class is polymorphic, but shouldn't, so add a note to remove the vtable in Qt 6. Change-Id: I93e4402004b7c52ba506946220e214dd6990f1f7 Reviewed-by: Lars Knoll <lars.knoll@qt.io> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 23 September 2016, 04:37:33 UTC |
| a41393d | Marc Mutz | 19 August 2016, 07:00:37 UTC | QColor: clean up qcolor_p.h Only qt_get_hex_rgb(const char*, QRgb*) is used outside qcolor.cpp (in qxpmhandler.cpp), so remove all other function declarations from qcolor_p.h, and make the functions file-static in qcolor.cpp, removing their qt_ prefix to avoid confusion. Exception: it turned out that qt_get_named_rgb(const char *, QRgb*) wasn't actually used anywhere, but a follow-up commit will fix this. Adjust interface to that of the QChar overload (add explicit int len). Simplify conditional compilation of QT_NO_COLORNAMES: move the ifdef inside get_colornames, to avoid duplicating the declaration, and remove the empty implementation of get_named_rgb, since their use is already conditional on QT_NO_COLORNAMES not being defined. Change-Id: Iaf685dfbea0b9d3bd010448dac0e95be7b097ce5 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> | 22 September 2016, 21:20:05 UTC |
| ced4d16 | Mark Brand | 05 September 2016, 16:05:43 UTC | fix -system-sqlite configure option Although configuration seemed to work and the configure summary indicated that the system sqlite library was being used, qtsql was actually still built from bundled sqlite sources. The problem was that system-sqlite was not reaching the context of sqlite.pro. Change-Id: I24676a19f0fc895111844cd0fe6c7e80f33574de Reviewed-by: Lars Knoll <lars.knoll@qt.io> | 22 September 2016, 21:06:31 UTC |
| 690587e | Morten Johan Sørvig | 17 August 2016, 11:12:28 UTC | QPaintDeviceWindow: Don’t request update on hide This is not the time to update and the window is repainted on expose anyway. Change-Id: I07680a2c351d337e2f35a18b804a03631d5cedc5 Reviewed-by: Jake Petroules <jake.petroules@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 22 September 2016, 16:45:25 UTC |
| 3bd5876 | Morten Johan Sørvig | 16 August 2016, 12:52:14 UTC | Cocoa: Add drawBackingStoreUsingCoreGraphics drawRect is a general “repaint now” function, which we should handle also for OpenGL content. Make that clearer by moving the implementation details of drawing the raster backing store using CoreGraphics to a separate function. Behavior change: Call invalidateWindowShadowIfNeeded also for the OpenGL case. Change-Id: I158ebef548e063f826db2dc708c14ab1d784b095 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 22 September 2016, 16:45:20 UTC |
| 0deb079 | Tor Arne Vestbø | 14 September 2016, 13:01:13 UTC | Modernize rasterwindow/openglwindow examples to use requestUpdate() Change-Id: Ib8d0c42db7343247d0431ea008eb17da9ee98f4d Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> | 22 September 2016, 16:45:15 UTC |
| 524b59b | Tor Arne Vestbø | 21 September 2016, 13:15:22 UTC | Rename QPA ExposeEvent's window-pointer from 'exposed' to 'window' The former is easy to mistake for the isExposed state of the event. Change-Id: Ic769ac332901ac97449ebc8dcca5959b6b42df68 Reviewed-by: Paul Olav Tvete <paul.tvete@qt.io> | 22 September 2016, 16:45:01 UTC |
| e0254fd | Oleksandr Tymoshenko | 08 September 2016, 00:26:01 UTC | Fixed double delete in bsdfb plugin on app exit Fixed double delete of QBsdFbScreen in destructor, first it was deleted in destroyScreen, then as a smart pointer. Take ownership of pointer before passing it to destroyScreen to avoid second delete. Change-Id: I252fcd1f31a32b463ecefce5b7139c4b3c857d33 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> | 22 September 2016, 15:24:20 UTC |
| 7c71370 | Laszlo Agocs | 20 September 2016, 11:39:56 UTC | eglfs: make qeglfsglobal.h private To avoid build system warnings about including _p headers. There is no real reason to have this as a .h header anymore, now that it is in the device integration private module. Change-Id: I16526419356284e66861f95d1d0553abf0711218 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Giulio Camuffo <giulio.camuffo@kdab.com> Reviewed-by: Andy Nichols <andy.nichols@qt.io> | 22 September 2016, 10:30:24 UTC |
| 2586a62 | Laszlo Agocs | 20 September 2016, 11:15:25 UTC | eglfs: Move remaining sources to under api Move platform integration, context and offscreensurface to under 'api'. This allows accessing these from out-of-tree eglfs backends as well. For instance, the upcoming eglfs_emu backend for the Qt Simulator may need access to QEglFSIntegration. Clean up the project files and remove out-of-date comments (the private module QtEglFSDeviceIntegration is not really header-less since 5.7). Change-Id: If96dd5780a6bd33a1cf29164364df9bf921c4d01 Reviewed-by: Andy Nichols <andy.nichols@qt.io> | 22 September 2016, 10:30:18 UTC |
| b638a7d | Laszlo Agocs | 14 September 2016, 12:05:05 UTC | eglfs: Add missing virtual layout setting for DRM/KMS Just setting virtualDesktopLayout and virtualIndex are not always enough. To create more complex shapes (e.g. a T-shaped cluster) the top-left position has to be specified explicitly. Enable this via an optional virtualPos property. This also involves improving evdevtouch's mapping functionality. Instead of fragile indices, rely on the screen name instead. Change-Id: I138840779032ad9da674bfef7763adfdfc74ccd4 Reviewed-by: Andy Nichols <andy.nichols@qt.io> | 22 September 2016, 10:30:13 UTC |
| 036639c | Eskil Abrahamsen Blomfeldt | 21 September 2016, 12:55:00 UTC | Windows/freetype: Fix loading non-regular fonts When resolving the filenames of fonts, we would first match against the font face name, meaning that an italic font, for instance would always be matched to the file of the regular font in the same face. To fix this, we look up the full name in the file name cache first, before the face name. Also, since the font names in the registry are the English names, but the names we get when enumerating the fonts on the system can be localized on non-English locales, we need to translate the full name of the font before we give up on matching it against the registry. Since this can be a heavy operation, we add a cut-off which skips resolving the English name when the style is one of the most common "Italic" or "Bold" since we know these to be English. [ChangeLog][QtGui][Windows] Fix selecting non-regular fonts when using the Freetype engine. Task-number: QTBUG-47485 Change-Id: If897abb93dc93263902b1c62bc3f66c4d06721c2 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> Reviewed-by: Lars Knoll <lars.knoll@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> | 22 September 2016, 10:29:49 UTC |
| 27d2593 | Eskil Abrahamsen Blomfeldt | 20 September 2016, 14:38:48 UTC | Return color bitmap from QRawFont for color fonts When the font in question is a color font, we should call the appropriate function bitmapForGlyph() and return the color bitmap from the font, rather than the alpha map in QRawFont::alphaMapForGlyph(). Change-Id: I2c3cd66db5a93ddf0cc463f4d136dd6771b9734c Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> Reviewed-by: Konstantin Ritt <ritt.ks@gmail.com> | 22 September 2016, 10:29:37 UTC |
| b3aa173 | Maurice Kalinowski | 21 September 2016, 08:31:53 UTC | Fix out of source builds Change-Id: I13db11320598a884ed817b4ce6f7ffefae91452e Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> | 22 September 2016, 09:36:30 UTC |
| 2ce8590 | Maurice Kalinowski | 22 September 2016, 07:00:15 UTC | win32: Fix Visual Studio project generation With the removal of Windows CE support(52623d6d) the logic of these checks have changed, as it was always true for non Windows CE builds before. This did not affect WinRT, as those mkspecs define VCPROJ_ARCH explicitly in their qmake.conf. Task-number: QTBUG-55753 Change-Id: Ie2eddf197c17fcbf7343b444cfe8940a332a545c Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> | 22 September 2016, 09:36:18 UTC |
| 50908f0 | Liang Qi | 22 September 2016, 05:28:34 UTC | Merge remote-tracking branch 'origin/5.7' into 5.8 Conflicts: src/plugins/platforms/ios/qiosviewcontroller.mm Change-Id: I2dda31867cbc79ea7fe965f52afb518aefa4ad20 | 22 September 2016, 05:28:34 UTC |
| 7555a92 | Liang Qi | 21 September 2016, 08:23:29 UTC | Merge remote-tracking branch 'origin/5.7' into 5.8 5971b88e is not needed in new configure. This merge also reverts "fix QMAKE_DEFAULT_*DIRS resolution with apple SDK", 2c9d15d7, because it breaks iOS build with new configure system. Conflicts: mkspecs/features/default_pre.prf mkspecs/features/mac/toolchain.prf mkspecs/features/toolchain.prf src/dbus/qdbusconnection.cpp src/plugins/sqldrivers/mysql/qsql_mysql.cpp src/sql/drivers/mysql/qsql_mysql.cpp src/widgets/widgets/qmenubar.cpp src/widgets/widgets/qmenubar_p.h tools/configure/configureapp.cpp tools/configure/environment.cpp tools/configure/environment.h Change-Id: I995533dd334211ebd25912db05b639d6f908aaec | 21 September 2016, 09:57:52 UTC |
| d10e4c1 | Liang Qi | 21 September 2016, 05:14:33 UTC | Merge remote-tracking branch 'origin/5.6' into 5.7 Change-Id: I9cfefaf22b010fca937be77979f5fb50574bb71e | 21 September 2016, 05:14:40 UTC |
| 25e9bde | Takumi ASAKI | 14 July 2016, 05:47:05 UTC | Bearer/ConnMan: Fix getTechnologies() is not called Change-Id: I4e39c971198583af815f5bcecaad4a9c52e5d2dd Reviewed-by: Lorn Potter <lorn.potter@canonical.com> | 21 September 2016, 00:46:10 UTC |
| 31c2517 | Allan Sandfeld Jensen | 20 March 2016, 14:35:23 UTC | Save memcpy when converting to 32bit formats If the destination format is 32bit, we can convert directly in the destination instead of in a buffer. Change-Id: I2b4407da77b863deec7869c341e1a8d464b46600 Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com> | 20 September 2016, 23:21:11 UTC |
| 23e76a1 | Samuel Gaist | 28 August 2016, 15:33:35 UTC | Doc: add macOS example of QAbstractNativeEventFilter implementation This patch adds a sample native event filter that can be easily integrated in a project. Task-number: QTBUG-53209 Change-Id: Iedf6df33a3de5b01dc7871cca5e7897a5b485733 Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com> | 20 September 2016, 21:23:32 UTC |
| 9f2c260 | Samuel Gaist | 26 September 2015, 23:26:28 UTC | Add missing test for QReguarExpression for QTextDocument::findMultiple Change-Id: Ia9b3eb21a178da4ae2844dba37b7e1cc669d6b50 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> | 20 September 2016, 21:23:08 UTC |
| b69ac5a | Nico Vertriest | 20 September 2016, 10:58:04 UTC | Doc: corrected mistaken refernce to macro \macos Change-Id: I734943820400384a2f9ac7e148dc42d3428b0732 Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com> Reviewed-by: Jake Petroules <jake.petroules@qt.io> | 20 September 2016, 19:46:17 UTC |
| b598541 | Allan Sandfeld Jensen | 19 September 2016, 09:36:59 UTC | Simplify source fetch qdrawhelper tables Collapse the tables that are mostly identical, to much shorter tables and a simple functions to make it easier to read and maintain. Change-Id: I44fdaebe9927b49a94385057756d9d87ad3c33f5 Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com> | 20 September 2016, 14:26:16 UTC |
| e395e79 | Alex Blasche | 20 September 2016, 10:53:39 UTC | Fix QtNative.checkSelfPermission() Only return activity object when available and *not* when unavailable. Task-number: QTBUG-55035 Task-number: QTBUG-50759 Change-Id: I60b1be528b2e4a3d630f4085b7642d74e18482bd Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> Reviewed-by: BogDan Vatra <bogdan@kdab.com> | 20 September 2016, 11:13:42 UTC |
| 04cb6e2 | Jake Petroules | 19 September 2016, 01:40:13 UTC | Fix namespaced build on iOS Change-Id: I682fabe8891e0325e6545b4499a59af4ad584c41 Reviewed-by: Mike Krus <mike.krus@kdab.com> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 20 September 2016, 05:46:56 UTC |
| 8347b54 | Richard Moe Gustavsen | 21 June 2016, 11:19:02 UTC | iOS: open menu on popup regardless of visibility It should be possible to show a menu by calling showPopup, even if visible is set to false. After all, it's only logical that visibility is false before showing it. And whether or not the menu is enabled should not matter as well. Change-Id: I9a2b453c8c6e88c47812c652d99e4b4a9c7524a7 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 19 September 2016, 11:20:58 UTC |
| e32ecdb | Richard Moe Gustavsen | 06 September 2016, 09:00:21 UTC | iOS: explicit synthesize properties as readwrite The synthesized properties were defined as (read only) methods in the UIViewController API in iOS9, and we extended them into readwrite properties in our own sub class to enable some local bookkeeping in addition to normal overriding. But in iOS10, Apple has changed the methods into being readonly properties instead. The difference then is that automatic property synthesizing will ignore our local readwrite declarations, and use the declarations in the super class instead. And this will lead to a runtime crash on iOS10 since no setter methods are generated. This patch will instead explicit synthesize the affected properties to ensure that both getters and setters will be generated. Change-Id: Iac330e991b8a0fe335e383e1f7d9ff30c0ce1559 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 19 September 2016, 11:20:50 UTC |
| d3389a6 | Richard Moe Gustavsen | 06 September 2016, 12:36:20 UTC | iOS: let quiview conform to API signature changes in iOS 10 In the iOS 10 SDK, method signatures has been annotated with NS_ASSUME_NONNULL macros and 'nullable' keywords. This means that certain methods should not be called with argumens that can be null, or in this case, set to 0 explicitly. The result will be compiler warnings. This patch will rewrite the explicit call we do to touchesCancelled so that we send an empty set instead of 0. Change-Id: I50aa80b91312397d17e0e380815adff87cee852b Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 19 September 2016, 11:20:44 UTC |
| e30d0e4 | Frederik Schwarzer | 17 August 2016, 11:27:03 UTC | QAbstractProxyModel: fix sentence structure in apidoc Change-Id: Ib3371549ecb80da326260b1df431f20e7a04f07e Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> | 19 September 2016, 11:17:58 UTC |
| fecee98 | Tor Arne Vestbø | 25 August 2016, 13:04:54 UTC | multiwindow: Base vsync debug output on actual surface format Allows us to detect cases where the requested vsync combination was not possible to fulfill. Change-Id: Ie8f3665129f7a1ab7fcefb94b2298d54520b753a Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> | 19 September 2016, 00:42:53 UTC |
| efdecff | Tor Arne Vestbø | 31 August 2016, 16:15:52 UTC | multiwindow: Replace per window fps timers with unified approach The FPS is now calculated and output on the command line in a single place. The animated fps counter has been replaced with a vertical line which should make it easier to observe tearing issues when vsync is disabled. Change-Id: Id356fc1958c048d85aba48edfed59124454038d4 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> | 19 September 2016, 00:42:33 UTC |
| 880beb1 | Tor Arne Vestbø | 31 August 2016, 16:21:18 UTC | multiwindow: Call update() after swap Change-Id: Ic2c26339bce9fe92b2ccc730c72f53ce94397b78 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> | 19 September 2016, 00:42:28 UTC |
| 44fec65 | Tor Arne Vestbø | 31 August 2016, 17:42:31 UTC | Update swap interval of QCocoaGLContext after creation QSurfaceFormat is recreated from scratch, and by not reading back the swap interval the QCocoaGLContext seemed to be vsynced even if it actually was not. Change-Id: I72ddaae9a4c695fe4c74d7b4b70ca9db84bcc084 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> | 19 September 2016, 00:42:23 UTC |
| 6ce96fd | Tor Arne Vestbø | 25 August 2016, 11:09:27 UTC | multiwindow: React to mouse press to allow debugging UI responsiveness The animated FPS counter should be enough to observe smooth animations, so we use the color of the window to visualize frame latency. Change-Id: I1171a1c4bdc261ca8655771290c6735357821781 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> | 19 September 2016, 00:42:20 UTC |
| bcbc812 | Tor Arne Vestbø | 25 August 2016, 11:02:47 UTC | multiwindow: Use showNormal() instead of show() to ensure normal geometry Change-Id: Ice607f536a620da5a70f2ba066f4983bb78c6288 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> | 19 September 2016, 00:42:04 UTC |
| 8b2f91e | Allan Sandfeld Jensen | 06 September 2016, 09:12:30 UTC | Add AVX2 versions of the fast blending functions This patch adds AVX2 versions of the fast blending functions that we already have SSE2 versions of. Change-Id: Ifd1a22f7891b6208cb74929ad26095d12c5a1efb Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 18 September 2016, 19:36:30 UTC |
| 8082c0d | Marc Mutz | 18 September 2016, 14:44:19 UTC | QBrush: Fix UB (non-virtual dtor) in QBrush::detach() As the d-pointer, QBrush uses a QScopedPointer with a custom deleter that checks for QBrushData::style and casts the QBrushData pointer down to corresponding subclasses before calling delete on them. In QBrush::detach(), however, any of the three brush data classes were held in a QScopedPointer _without_ the custom deleter, invoking UB when that scoped pointer would ever get to be the one that deleted the payload instead of handing it over to the objects d-pointer. Found by making dtors protected following a Coverity report wrongly marked as 'dismissed' (these static checks are not included in this patch, since they are binary-incompatible), to find out where Coverity could possibly see a problem. Also replace the d.reset(x.take()) that allowed this mismatch to compile with d.swap(x), which nicely ensures that x and d are of the same type. Coverity-Id: 11772 Change-Id: I85e2c205df9291bd7508b6c90f7b03fbe8c3bcd2 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 18 September 2016, 17:59:24 UTC |
| 2d2d907 | Tor Arne Vestbø | 08 September 2016, 21:08:29 UTC | macOS: Implement QCocoaBackingStore in terms of QRasterBackingStore The previous detection of device pixel ratio changes in paintDevice() is not needed, as QBackingStore::beginPaint() already does this check and calls resize(). Change-Id: I9ee8410fa3a5404c5ec19d2cba4543a9e3359fe9 Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> | 18 September 2016, 14:33:04 UTC |
| 41ab34d | Morten Johan Sørvig | 14 September 2016, 12:29:26 UTC | Blacklist modalWindowModallity on macOS aka “osx” Passes locally, unstable on CI. Change-Id: I251ad9603d14fd6195f721135ac606a1fd6b5060 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 18 September 2016, 14:32:42 UTC |
| dc3af6a | Tor Arne Vestbø | 16 December 2015, 14:27:21 UTC | iOS: Implement support for QScreen::grabWindow() Only windows that are part of the application can be grabbed. This excludes the system statusbar and other system overlays, as well as windows of other applications. This is a limitation due to the security model of iOS. There exists APIs to grab a snapshot of the complete screen, but these APIs return a view that can be used as a placeholder e.g. during view transformations, and doesn't match our API that require reading of pixels. Task-number: QTBUG-49944 Change-Id: I8fd5b4c2777be1486f0ff22762d5e9b64c927e70 Reviewed-by: Jake Petroules <jake.petroules@qt.io> | 18 September 2016, 11:38:59 UTC |
| 5ad8b3a | Tor Arne Vestbø | 13 September 2016, 10:15:49 UTC | macOS: Move QColor/QBrush conversion functions to QtGui Change-Id: I971d1d69b491532fd0dc0bab72b274dec6591e6b Reviewed-by: Jake Petroules <jake.petroules@qt.io> | 18 September 2016, 11:38:54 UTC |
| 49b3510 | Tor Arne Vestbø | 13 September 2016, 12:08:27 UTC | macOS: Move image conversion functions to QtGui Change-Id: I911f2648e506f27519e98be1bffe2c5ab0f388f1 Reviewed-by: Jake Petroules <jake.petroules@qt.io> | 18 September 2016, 11:38:47 UTC |
| e419403 | Tor Arne Vestbø | 13 September 2016, 09:44:34 UTC | macOS: Remove unused function qt_mac_QRegionToHIMutableShape Code using it was removed in a198ce8d. Change-Id: I841f55768da080fbc87e0f2d9394cdc0a22e500e Reviewed-by: Jake Petroules <jake.petroules@qt.io> | 18 September 2016, 11:38:41 UTC |
| 29d64bc | Marc Mutz | 15 September 2016, 15:31:25 UTC | QEvdevKeyboardHandler: use RAII in create()/ctor Coverity somewhat rightfully complained that the FD may be leaked in certain cases, e.g. when the new-expression throws. Yes, the plugin is compiled with exceptions disabled, but the code is still a bug waiting to happen, because it's too easy to just add an early return to the function and leak the FD that way. Fix by writing a small RAII class for FDs (can't use QSharedPointer, since it's not a pointer we're dealing with). It's quite generically named, in anticipation that it might come in handy elsewhere, too. Coverity-Id: 89046 Change-Id: I83d1ed3f11219065d2248c129ed191a651f617c7 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 18 September 2016, 10:55:27 UTC |
| 8d64d1e | Albert Astals Cid | 30 May 2016, 23:13:03 UTC | xcb: Do not eat events with different keyboard state Change-Id: Iac8dc7b369eb7c2fbe0cf27baa34a40278088219 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io> | 18 September 2016, 10:34:53 UTC |
| 76adb6c | Albert Astals Cid | 20 April 2016, 23:39:27 UTC | xcb: Use the state of the key event to process it Instead of the global state Task-number: QTBUG-48795 Change-Id: Ic2c545718adb68df41730e5a3bf25adb374ffce3 Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Gatis Paeglis <gatis.paeglis@qt.io> | 18 September 2016, 09:56:41 UTC |
| d58d7a5 | Marc Mutz | 28 August 2016, 17:23:45 UTC | Add QStringList::join(QLatin1String) overload Costs only ~300B in text size in QtCore, which is roughly compensated by savings in other QtBase libraries, even without specifically porting users to QL1S. Of course, the raison d'être for this overload is avoiding the expensive QLatin1String -> QString conversion which, for small lists, can take up to 50% of the total runtime (assuming memory allocations dominate over scanning and copying the list). [ChangeLog][QtCore][QStringList] Added join(QLatin1String) overload. Change-Id: I91d7e1d4e2c76d6dc79f2b750cf8e256dd4e0ab6 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 18 September 2016, 07:28:56 UTC |
| c52bb03 | Tor Arne Vestbø | 12 September 2016, 15:05:39 UTC | macOS: Move QMacCGContext helper into QtGui The implementation was duplicated and spread out between QMacStyle, QMacPaintEngine, and the Cocoa platform plugin. Moving it into QtGui allows using it on other Apple platform. Change-Id: Iadcbd71998204887e116271c575037789b6e2163 Reviewed-by: Jake Petroules <jake.petroules@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 17 September 2016, 18:00:47 UTC |
| 734da26 | BogDan Vatra | 08 September 2016, 09:45:20 UTC | Android: Don't hang when resuming the application If the main thread is blocked updateApplicationState will hang. It happens when we're using functions like runOnAndroidThreadSync or requestPermissionsSync. Change-Id: Ic1135c5630b48cf1076ef5cbc133933fce439bfb Reviewed-by: Alex Blasche <alexander.blasche@qt.io> | 17 September 2016, 07:38:15 UTC |
| 542ba86 | Marc Mutz | 22 August 2016, 19:00:40 UTC | tests/auto/corelib/mimetypes: use local QThreadPool Isolates the test from anything that might be going on on the globalInstance(). Enabled by the explicit thread-pool feature on QtConcurrent::run(). Add explicit timed wait (unit tests should contain as little indefinite waits as possible). Also avoids the use of QFutureSynchronizer, which makes my static QList checker go nuts, with no way of fixing it until Qt 6. Change-Id: I0829992642b2a49bb6a10ddd4b31eb3f88e3adeb Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 17 September 2016, 06:47:05 UTC |
| 1b98ce1 | Marc Mutz | 20 February 2016, 18:36:45 UTC | QSqlRelation: mark shared-come-qt6 ... and plaster API with nothrow (well, one function). Change-Id: I36fd64c6fda5390954c82bba307c720d3b3215df Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 17 September 2016, 06:47:01 UTC |
| bd4d847 | Liang Qi | 16 September 2016, 21:33:56 UTC | Merge "Merge remote-tracking branch 'origin/5.6' into 5.7" into refs/staging/5.7 | 17 September 2016, 03:11:41 UTC |
| 18ed6f2 | Thiago Macieira | 15 September 2016, 16:44:24 UTC | Change some #elif to #endif / #if in qcompilerdetection.h The conditions aren't exclusive, but complementary. This change removes one check for defined(Q_CC_INTEL) because it was disabled before and requires testing before we confirm it to be correct. Change-Id: I33dc971f005a4848bb8ffffd14748cde4dd23333 Reviewed-by: Marc Mutz <marc.mutz@kdab.com> | 16 September 2016, 21:25:47 UTC |
| d148019 | Liang Qi | 16 September 2016, 21:16:25 UTC | Merge remote-tracking branch 'origin/5.6' into 5.7 Conflicts: src/plugins/platforms/qnx/qqnxscreeneventhandler.cpp Change-Id: I0af32ee55936d523cbd259b6fe82eb9c409f9074 | 16 September 2016, 21:16:25 UTC |
| 597d625 | Thiago Macieira | 15 September 2016, 16:11:19 UTC | Disable forcing of -fomit-frame-pointer with ICC qlogging.cpp(1226): error #3175: unrecognized gcc optimization level __attribute__((optimize("omit-frame-pointer"))) ^ Change-Id: I33dc971f005a4848bb8ffffd14748b100dcefa95 Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com> | 16 September 2016, 20:50:05 UTC |
| 6b9c57f | Liang Qi | 16 September 2016, 18:18:29 UTC | Merge "Merge remote-tracking branch 'origin/5.6.2' into 5.6" into refs/staging/5.6 | 16 September 2016, 18:18:29 UTC |
| a6bc015 | Thiago Macieira | 13 September 2016, 21:20:37 UTC | Correct the C++ standard references in QMutex functions Section 30.4.1.3 [thread.timedmutex.requirements] has 16 paragraphs and 2 subsections. Change-Id: I9093948278414644a416fffd1473fec7fdd2716c Reviewed-by: Marc Mutz <marc.mutz@kdab.com> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> | 16 September 2016, 15:33:46 UTC |
| 8a2401b | James McDonnell | 26 July 2016, 20:33:47 UTC | Switch to 7.0 screen property names The names of some screen properties have changed in 7.0. For 6.6, map the 7.0 names to 6.6 names. Change-Id: Iaf9d297fdd6a0329a84150f2b9a27665d89cc1ec Reviewed-by: Dan Cape <dcape@qnx.com> Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com> | 16 September 2016, 13:21:18 UTC |
| 71e195f | James McDonnell | 25 August 2016, 14:55:35 UTC | Reverse the flush-screen-context test It was backwards so the screen context was being flushed on every screen interaction when the parameter was _not_ specified. During mouse/touch movement, the number of flushes can be so great that it negatively impacts performance. Change-Id: I4dfe9c33c8ce31237db1d78db1cb8e04c00c4dd3 Reviewed-by: Dan Cape <dcape@qnx.com> Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com> | 16 September 2016, 13:21:07 UTC |
| 8d6f2e7 | Lars Knoll | 31 August 2016, 13:39:30 UTC | Add a QT_REQUIRE_CONFIG(feature) macro This macro expands into a static_assert and can be used to trigger a compile error if a certain feature is not available when trying to compile some code. This is especially useful to protect against accidental inclusion of headers that implement functionality related to a feature. Change-Id: I456c55b989ce5f35f3af0e13c1886a85c23dfe29 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Lars Knoll <lars.knoll@qt.io> | 16 September 2016, 12:27:59 UTC |
| 31a63b6 | BogDan Vatra | 07 September 2016, 13:55:51 UTC | Say hello to Android 6+ permissions model This API was introduced by Android v23 and is used in connection with the new permission request system. From Android v23 onwards, some permissions such as Location permissions cannot only be granted via Android's Manifest files. An additional runtime check/request system was introduced which forces applications to prompt the user the first time a privileged function is called. Such user prompt responses are returned to the current application via the Activity.onRequestPermissionsResult(..) callback. This change add Qt API to nicely check & request permissions. For now this is private API which can be used to fix permission problems in other Qt compontents. Later Qt versions will introduce a public API to QtAndroidExtras. [ChangeLog][QtCore][Android] Introduced a mechanism to forward permission related callbacks on Activity objects to interested parties. Task-number: QTBUG-55035 Task-number: QTBUG-50759 Change-Id: I64ee748d741b39e35c4713ed9fdd15dd1d96dc56 Reviewed-by: Christian Stromme <christian.stromme@qt.io> Reviewed-by: Alex Blasche <alexander.blasche@qt.io> | 16 September 2016, 12:13:29 UTC |
| a95d81e | Edward Welbourne | 08 September 2016, 16:57:46 UTC | Q(Date|Time)+::(to|from)String(): mention relevant QLocale methods The const QString &format variants of these methods lack adequate control over the locale used; the Qt::DateFormat variants give only limited control over the format string. So reference the QLocale methods that provide the general case, in the docs of each. Also made the \sa cross-referencing among these methods a little more coherent. Task-number: QTBUG-55632 Change-Id: Icd0c8548045e74879e941ba089c3bdea78f14e34 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 16 September 2016, 12:07:05 UTC |
| 2c48695 | Frederik Gladhorn | 15 September 2016, 21:21:15 UTC | XCB Drop from external app: fix keyboard modifier state Fix inspired by Qt 4 sources. When we get drop events that are not coming from the same application, it's unlikely that the keyboard modifiers are in a sensible state (the usual XCB events are not sent during drag and drop), so set the keyboard modifier state explicitly. Task-number: QTBUG-49645 Change-Id: I9360f2b7ffeaa5243a4dfe7ccf96df134c5d2156 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> | 16 September 2016, 11:49:12 UTC |
| 59b275b | Liang Qi | 16 September 2016, 06:56:12 UTC | Merge remote-tracking branch 'origin/5.6.2' into 5.6 Change-Id: I84acde3251893f2a7a776962b2ff970b90884b63 | 16 September 2016, 06:56:12 UTC |
| f242b91 | Jake Petroules | 14 September 2016, 18:36:45 UTC | Fix code signing for qmake-generated Xcode projects in Xcode 8 Task-number: QTBUG-55915 Change-Id: I7cbddd7ed8a6e0fa220b423e11e4d550e09297f9 Reviewed-by: Louai Al-Khanji <louai.al-khanji@qt.io> | 16 September 2016, 05:49:42 UTC |
| 47d064e | Marc Mutz | 15 September 2016, 15:58:59 UTC | libjpeg config test: init variable Yes, yes, this is just a configure test, but why do something stupid in the code and then have to shut up Coverity manually? Fix by making it a global, which means it will be zero-initialized (I didn't want to do the obvious = 0, as that could protentially create a "0 used as nullptr" warning at some point in the future. Coverity-Id: 59485 Change-Id: I49ecd28be983a0e42b420d20da0db34a872c6f44 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 16 September 2016, 04:12:03 UTC |
| f1e87dc | Marc Mutz | 15 September 2016, 13:25:01 UTC | QTableGenerator: Fix uninit'ed values It's probably benign, but it causes Corverity to complain, so always init all fields of QComposeCacheFileHeader. Format the code so it can easily be ported to uniform init later on. Coverity-Id: 93043 Change-Id: Ifa1ccc3fa58dc813306917f216772fd24d4930c9 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 16 September 2016, 04:12:00 UTC |
| 2ccf6c6 | Loïc Molinari | 01 September 2016, 17:13:32 UTC | Fix the GCC version supporting -Wsuggest-override Q_CC_GNU is (__GNUC__ * 100 + __GNUC_MINOR__), so 510 is 5.10 not 5.1.0. The first GCC 5 release has support for -Wsuggest-override, so it should really be 501. Change-Id: I7b264af087cd4562ce8720c99b70116d7654ea5f Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 16 September 2016, 04:11:57 UTC |
| ebf0b12 | Thiago Macieira | 06 September 2016, 18:41:00 UTC | Make QDBusConnectionPrivate::relaySignal be called in the right thread This function sends D-Bus messages directly (in huntAndEmit), so it should only be called from the QDBusConnectionManager thread. Somehow, I missed this in the Qt 5.6 refactoring of QtDBus. Being called in the wrong thread means that there's a visible behavior change compared to Qt 5.5: if the user code sent a method call or method return/error and then emitted a signal, we'd have two threads racing to send the D-Bus messages. This was observed in Telepathy-Qt code: certain signals arrived before a method return, even though they were clearly emitted by a queued QMetaObject::invokeMethod. In addition to that, we have has an internal problem (though not observed): the libdbus-1 timer and socket callbacks would be called in the wrong thread and we no longer have protection against that. Unit testing not possible since this is a race condition. Change-Id: I9e96ecd4f6aa4ff0ae08fffd1471d002142613d6 Reviewed-by: Gustavo Pichorim Boiko <gustavo.boiko@canonical.com> Reviewed-by: Alex Blasche <alexander.blasche@qt.io> | 16 September 2016, 04:11:54 UTC |
| 8ceab12 | Thiago Macieira | 08 September 2016, 20:56:16 UTC | Fake exporting of the QDBusUtil namespace It's a namespace containing only private things, but some of those get used in some QtDBus tools. By adding a macro that expands to nothing, findclasslist.pl will notice the namespace and add it to the ELF version script. Task-number: QTBUG-55897 Change-Id: I371f5b01e24a4d56b304fffd1472748cde56f0c3 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 15 September 2016, 23:12:42 UTC |
| 2c9d15d | Oswald Buddenhagen | 19 August 2016, 13:07:57 UTC | fix QMAKE_DEFAULT_*DIRS resolution with apple SDK the code got factored out to an own toolchain.prf file, which is load()ed from default_pre.prf, so no change at first. however, on mac, we shadow toolchain.prf, and make it load() sdk.prf first. a side effect of this is that project files may not override QMAKE_MAC_SDK any more, which seems to be no big loss. it is still possible to override the sdk on the configure command line (but note that this only ever worked for the target sdk). it has also become harder to disable the use of an sdk altogether: putting CONFIG-=sdk into a project file or the qmake command line has no effect now. instead, it's possible to put it into .qmake.{conf,cache}. to make it simpler again, it's conceivable to finally add qmake -pre, which would allow setting variables before default_pre.prf is executed. Change-Id: I149e0540c00745fe8119fffd146283bb214f22ec Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 15 September 2016, 20:01:33 UTC |
| 469d68b | Sune Vuorela | 04 September 2016, 12:59:37 UTC | Fix handling of bad compose table The ASAN talk at QtCon was pointing out a out of bound read in a vector. Let's try to do something about it. If the lazy initialization of compose table fails, the first character handling still tries to actually access it. Later characters are properly handled in the caller. Reported-by: Hanno Böck Change-Id: Ieac3e95361abd0fcd06c555bcd00ca1c4d8f1931 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 15 September 2016, 17:31:09 UTC |
| c59c759 | Thiago Macieira | 15 September 2016, 16:07:53 UTC | Suppress ICC warning #111 about unreachable code in toWCharArray qstring.h(961): warning #111: statement is unreachable Change-Id: I33dc971f005a4848bb8ffffd14748ae03dadefc9 Reviewed-by: Marc Mutz <marc.mutz@kdab.com> | 15 September 2016, 16:54:56 UTC |
| 43d935a | Shawn Rutledge | 14 September 2016, 11:36:06 UTC | QMenuBar: improve documentation of the D-Bus unified menu bar Since 5.7.0 this is not just a macOS feature. It's also not necessarily limited to Ubuntu Unity, since the specification is open, and there's work in progress to implement it on KDE. Also fixed a couple of typos. Task-number: QTBUG-54793 Change-Id: Idbc68ddafff4dea30649e634ca29f10703f60d3b Reviewed-by: Jake Petroules <jake.petroules@qt.io> | 15 September 2016, 14:52:26 UTC |
| 1f925d4 | Morten Johan Sørvig | 14 September 2016, 12:29:26 UTC | Blacklist modalWindowModallity on macOS aka “osx” Passes locally, unstable on CI. Change-Id: I132268ad0f6ad8b969701c9571fdb609d8225d07 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 15 September 2016, 14:52:10 UTC |
| 9ff7e7d | Maurice Kalinowski | 09 September 2016, 11:53:23 UTC | winrt: Fix touch on Hololens The pressure indicator is not handled for touch on the Hololens causing touch heuristic to fail and not identify the press event. Change-Id: I2aba95fde8aa9abfa3838cad6b3466ff8bc41811 Reviewed-by: Oliver Wolff <oliver.wolff@qt.io> | 15 September 2016, 14:25:56 UTC |
| c3084f1 | Richard Moe Gustavsen | 13 September 2016, 12:37:19 UTC | iOS: accept window modal message dialogs Although we cannot really show anything but application modal dialogs on iOS, falling back to using non-native dialogs for window modal seems unnecessary strict; In practice you will never have a work flow on iOS where you have several windows visible, and at the same time, need to show a dialog that blocks only one of them. This patch will lift the restriction, and handle window modal as application modal on iOS. Task-number: QTBUG-55909 Change-Id: I581c1a47724ee2bfc2e041672c82c25ed34b2b2d Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@theqtcompany.com> | 15 September 2016, 14:25:27 UTC |
| 0dedb60 | Victor Kropp | 04 August 2016, 14:42:46 UTC | Save temp icon in higher resolution on HiDPI screens In case temporary system tray icon is saved to /tmp, scale it according to current devicePixelRatio() instead of using hardcoded 22x22. Change-Id: I2adf2151da3241f4600f8645e323346daabcec4b Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> | 15 September 2016, 14:18:34 UTC |
| 5ca9631 | Dmitry Shachnev | 07 September 2016, 14:19:19 UTC | dbusmenu: Don’t leave dangling pointers when menus are destroyed Delete references from menu to its containing item, and vice versa. Fixes https://launchpad.net/bugs/1620937 Task-number: QTBUG-55966 Change-Id: I58f0f0a90184bee4b0466c28d91c670a34fa65a5 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> | 15 September 2016, 14:17:14 UTC |
| 63656db | Dmitry Shachnev | 09 September 2016, 08:39:10 UTC | dbustray: Delete m_notifier in QDBusTrayIcon::cleanup() This fixes a bug where notificationClosed() and actionInvoked() slots were called more than once, from previous alive notifier instances. Change-Id: I4cb4dfc27ee129bc5282fbd8e0961959d0765112 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> | 15 September 2016, 14:16:54 UTC |
| 835d7cf | Dmitry Shachnev | 07 September 2016, 14:37:50 UTC | QMenuBar: Get rid of QMenuBarPrivate::nativeMenuBar Instead of trying to keep that variable in sync with platformMenuBar state, just check whether platformMenuBar exists instead. Now QMenuBar::isNativeMenuBar() is more reliable, and will not return true if the QPA plugin provides no platform menu bar. Also, remove useless restrictions for code using isNativeMenuBar(). That method is available on all platforms for a long time, not only on macOS or WinCE. This makes sure local menus do not appear if global menus are available, and setVisible(true) is called. Change-Id: I7a5944c64376b4714a38ad981089df8a151c3403 Task-number: QTBUG-54793 Reviewed-by: J-P Nurmi <jpnurmi@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> | 15 September 2016, 14:15:21 UTC |
| f4eefce | Frederik Gladhorn | 22 February 2016, 08:16:26 UTC | Fix typos in highdpi docs Change-Id: I15fd6859ff777388a229e3cb10de45886fe543fb Reviewed-by: Nico Vertriest <nico.vertriest@theqtcompany.com> Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io> | 15 September 2016, 14:12:50 UTC |
| 46913db | Vikas Pachdha | 24 August 2016, 15:35:59 UTC | Fixes issue with iOS when project path has a whitespace Task-number: QTBUG-55505 Change-Id: Ic853ecd46a3cb098fff2904119e9002f3add3b8e Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 15 September 2016, 10:17:54 UTC |
| 25c9a6c | Błażej Szczygieł | 03 May 2016, 22:23:16 UTC | QtWidgets: Fix enter/leave events on popup menus If the sloppy menu popups - send the leave event to the last active menu (except Cocoa), because only currect active menu gets enter/leave events (currently Cocoa is an exception). Check that the menu really has a mouse before hiding the sloppy menu - don't rely on enter events. This patch removes some unnecessary synthetic mouse enter/leave events from QMenu which causes event duplications with different mouse cursor position. Refactor sloppy menu timer handling - start or restart timers on mouse move events. Enter/leave events are not reliable. Fixes: - better enter/leave events handling for native widget actions, - reduce duplicated enter/leave events for menu actions, - better handle torn off sloppy menus. Partially reverts: 0ed68f3f58c63bd1496cb268bd83881da180051f Amends: 57ecd5aeeb1f609206933be66b92fcdf703703d7 Task-number: QTBUG-53068 Change-Id: I7ad56ac1619db124915d373fab82d0512d44c90e Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> | 15 September 2016, 10:16:44 UTC |
| 2cf3dee | Błażej Szczygieł | 12 September 2016, 13:22:20 UTC | xcb: Don't send "Qt::WindowNoState" event when hiding minimized window This prevents getting "QWidget::showEvent()" when hiding minimized widget on some WMs like Marco or Xfwm4. If QWindow is minimized and it gets the new "XCB_WM_STATE_WITHDRAWN" event from XCB, then don't change the QWindow state. Task-number: QTBUG-55942 Change-Id: I90cfc2bf55e507864ad8f26c8f569ea562c27314 Reviewed-by: Uli Schlachter <psychon@znc.in> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> | 15 September 2016, 10:16:42 UTC |
| 258e4d0 | Marc Mutz | 14 September 2016, 22:36:54 UTC | QDBusError: don't bother dealing with unusable 'unused' field The move constructor as well as member-swap were dealing with the 'unused' field as if it would be usable. But as the comment in the default ctor suggests, the field can never be used in Qt 5, due to the inline dtor. So, don't bother with the field. Doing so only triggers checkers such as Coverity. Also mark the field for removal in Qt 6. Coverity-Id: 154503 Coverity-Id: 154510 Change-Id: If42c5ed66d1133e651de7477f3313b3989b64bc9 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> | 15 September 2016, 10:10:34 UTC |
| a54d442 | Marc Mutz | 14 September 2016, 14:14:16 UTC | QLatin1String: Fix UB (nullptr passed) in relational operators Found by UBSan: qstring.h:1160:44: runtime error: null pointer passed as argument 1, which is declared to never be null qstring.h:1160:44: runtime error: null pointer passed as argument 2, which is declared to never be null Fix by avoiding the memcmp() calls if there's a chance that they might be called with nullptr. While at it, also implement !=, >, <=, >= in terms of ==, <, and add a test, because this particular UB was not fingered by any of the QtCore test cases, but by a Qt3D one. Change-Id: I413792dcc8431ef14f0c79f26e89a3e9fab69465 Reviewed-by: Thiago Macieira <thiago.macieira@intel.com> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> | 15 September 2016, 10:10:28 UTC |
| 1f01423 | Thiago Macieira | 14 September 2016, 20:34:56 UTC | Move the ATSPI Linux A11y change to the Linux block I actually doubt it's Linux-specific (more like all Unix), but the changes are in files called "linuxaccessibility". Change-Id: I9093948278414644a416fffd14744ae826b83303 Reviewed-by: Marc Mutz <marc.mutz@kdab.com> | 15 September 2016, 10:09:22 UTC |
| ce9147f | Jani Heikkinen | 07 September 2016, 15:28:04 UTC | Add changes file for 5.6.2 Change-Id: Ie1d6d7f3adf61b482b8e797849dbb2b3053fe720 Reviewed-by: Kai Koehne <kai.koehne@qt.io> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io> | 15 September 2016, 10:09:11 UTC |
| 7529c39 | Dyami Caliri | 07 September 2016, 18:05:51 UTC | QStyleOption: return Q_NULLPTR from qstyleoption_cast instead of 0 qstyleoption_cast should use Q_NULLPTR to represent a null pointer. Task-number: QTBUG-45291 Change-Id: I85078ceb435b310daf63db2ed771be2f36cf3e4f Reviewed-by: Marc Mutz <marc.mutz@kdab.com> | 13 September 2016, 04:00:52 UTC |
| 7a593c8 | Tony Sarajärvi | 18 August 2016, 12:46:16 UTC | Blacklist selftest runSubTest This one selftest is currently blocking OS X 10.11 from entering the CI. It can't be reproduced when run manually. Task-number: QTBUG-55155 Change-Id: I4553ef2d7813b29f5dc8577976c4482686346504 Reviewed-by: Timur Pocheptsov <timur.pocheptsov@theqtcompany.com> | 12 September 2016, 12:59:48 UTC |
| 3370ab9 | Milian Wolff | 22 August 2016, 12:32:05 UTC | Never return char variants when reading prepared MySQL statements This has undesired effects when converting a QSqlRecord to JSON. A char(0) e.g. has special semantics that are undesired when reading a Tinyint column. I don't think that returning bool for the special case of a Tinyint(1) is required. This also did not happen before, and is also not happening when not using a prepared statement. Instead, a plain int/uint QVariant is returned. This patch extends tst_QSqlQuery::integralTypesMysql to also cover reading and writing booleans from/to a MySQL table column of type Tinyint(1). Additionally, the reading is now also done with a prepared statement and we also check the raw variant value. The broken behavior fixed by this patch was introduced by me in commit 194403a3483b7317cc9511bc8b2ab307775643c5. Change-Id: I028a3abd83fdd2b42d98d478950d205e5b6bbeb5 Task-number: QTBUG-53397 Reviewed-by: Andy Shaw <andy.shaw@qt.io> | 12 September 2016, 12:47:08 UTC |
| 3b8df0e | Błażej Szczygieł | 24 March 2016, 22:50:24 UTC | QtWidgets: Send show/hide event to children on restore/minimize Child widgets should get the show/hide event when the TLW changes its state, because child widgets are also visible or invisible. This restores the Qt4 behavior (fixes the Qt4->Qt5 regression). Restoring/minimizing the TLW now sends the spontaneous show/hide event. Show events are now handled also in the expose event handler in the QWidgetWindow class, because the show event must occur before the expose event to avoid possible flicker e.g. the OpenGL content. This can happen e.g. on XCB platform. If the "WindowStateChange" event occur before the expose event (e.g. Windows platform) then the code in expose event handler will be ignored to prevent event duplications. Added autotest. Task-number: QTBUG-50589 Change-Id: Ie9a9329b1f29bff876de28d5948d0d5fb6bc1f05 Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> | 12 September 2016, 08:38:06 UTC |
| 66fcd0c | Thorbjørn Lindeijer | 06 September 2016, 09:38:18 UTC | Fixed glitch when dragging a movable QTabBar tab When you would start to drag a tab, and then drag it in the other direction along the point where you started the drag, the tab would fail to follow the mouse for a distance twice the "startDragDistance", before jumping to the mouse again. Fixed this by only taking into account the "startDragDistance" when checking whether a drag is started, and to rely on the "dragInProgress" variable otherwise. Change-Id: I5dd4ebd8340fef7e870f087be68c5097b49728cb Reviewed-by: Marc Mutz <marc.mutz@kdab.com> | 12 September 2016, 08:03:30 UTC |
