| 92c1e71 | Junio C Hamano | 29 September 2010, 16:42:53 UTC | Git 1.7.3.1 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 29 September 2010, 17:39:53 UTC |
| 57693d0 | Jon Seymour | 28 September 2010, 13:19:52 UTC | stash: fix git stash branch regression when branch creation fails "git stash branch <branch> <stash>" started discarding the stash when the branch creation fails. It should have kept the stash intact when aborting. Signed-off-by: Jon Seymour <jon.seymour@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 29 September 2010, 17:07:09 UTC |
| 835d6a1 | Tomas Carnecky | 28 September 2010, 13:19:51 UTC | stash drops the stash even if creating the branch fails because it already exists This bug was disovered by someone on IRC when he tried to $ git stash branch <branch> <stash> while <branch> already existed. In that case the stash is dropped even though it isn't applied on any branch, so the stash is effectively lost. Signed-off-by: Tomas Carnecky <tom@dbservice.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 29 September 2010, 16:59:42 UTC |
| 442cb08 | Linus Torvalds | 27 September 2010, 19:14:57 UTC | Fix missing 'does' in man-page for 'git checkout' Reported-by: Rainer Standke <rainer.standke@krankikom.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 22:08:06 UTC |
| 9d14017 | Pat Notz | 16 September 2010, 20:53:22 UTC | dir.c: squelch false uninitialized memory warning GCC 4.4.4 on MacOS incorrectly warns about potential use of uninitialized memory. Signed-off-by: Pat Notz <patnotz@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 18:43:12 UTC |
| 61ef5e9 | Brandon Casey | 27 September 2010, 03:18:01 UTC | git-send-email.perl: ensure $domain is defined before using it valid_fqdn() may attempt to operate on an undefined value if Net::Domain::domainname fails to determine the domain name. This causes perl to emit unpleasant warnings. So, add a check for whether $domain has been defined before using it. Signed-off-by: Brandon Casey <drafnel@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 18:41:45 UTC |
| b822423 | Brandon Casey | 27 September 2010, 02:49:13 UTC | wt-status.c: don't leak directory entries when processing untracked,ignored When iterating through the list of directory entries, searching for untracked entries, only the entries added to the string_list were free'd. The rest (tracked or not matching the pathspec) were leaked. Ditto for the "ignored" loop. Rearrange the loops so that all entries are free'd. Signed-off-by: Brandon Casey <drafnel@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 18:41:25 UTC |
| d212cef | Christian Couder | 26 September 2010, 05:20:18 UTC | t6050 (replace): fix bogus "fetch branch with replacement" test The test was missing some "&&" at the end of some lines and it was wrong because, as the replacement refs were not fetched, the commits from the parallel branch should not show up. This was found by Elijah Newren. This is fixed by checking that after the branch from HASH6 is fetched, the commits from the parallel branch don't show up, and then by fetching the replacement refs and checking that they do show up afterwards. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 18:40:45 UTC |
| 831a8b8 | Wesley J. Landaker | 13 September 2010, 14:59:54 UTC | Documentation: Refer to git-commit-tree in git-filter-branch help Currently, the help for git filter-branch refers users of --env-filter to git-commit for information about environment variables affecting commits. However, this information is not contained in the git-commit help, but is very explicitly detailed in git-commit-tree. Signed-off-by: Wesley J. Landaker <wjl@icecavern.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 18:39:44 UTC |
| 95ad6d2 | Matthieu Moy | 24 September 2010, 16:43:59 UTC | update comment and documentation for :/foo syntax The documentation in revisions.txt did not match the implementation, and the comment in sha1_name.c was incomplete. Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 17:54:52 UTC |
| 3695dc0 | Daniel Knittl-Frank | 24 September 2010, 16:21:59 UTC | Improvements to `git checkout -h` be a little more verbose about what each option does Signed-off-by: Daniel Knittl-Frank <knittl89+git@googlemail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 17:54:17 UTC |
| 861514d | Michael J Gruber | 23 September 2010, 12:33:51 UTC | contrib/completion: --no-index option to git diff Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 17:52:49 UTC |
| afa0876 | Jeff King | 22 September 2010, 00:35:59 UTC | prefer test -h over test -L in shell scripts Even though "-L" is POSIX, the former is more portable, and we tend to prefer it already. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 17:48:23 UTC |
| 055467d | Junio C Hamano | 22 September 2010, 19:15:37 UTC | CodingGuidelines: spell Arithmetic Expansion with $(($var)) POSIX wants shells to support both "N" and "$N" and requires them to yield the same answer to $((N)) and $(($N)), but we should aim for portability in a case like this, especially when the price we pay to do so is so small, i.e. a few extra dollars. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 17:45:29 UTC |
| 4098f67 | Ramsay Jones | 21 September 2010, 17:45:09 UTC | t1503: Fix arithmetic expansion syntax error when using dash On systems which have dash as /bin/sh, such as Ubuntu, the final test (master@{n} for various n) fails with a syntax error while processing an arithmetic expansion. The syntax error is caused by using a bare name ('N') as a variable reference in the expression. In order to avoid the syntax error, we spell the variable reference as '$N' rather than simply 'N'. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 17:43:49 UTC |
| 4af3fab | Pat Notz | 16 September 2010, 20:53:23 UTC | strbuf.h: fix comment typo Signed-off-by: Pat Notz <patnotz@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 17:42:11 UTC |
| 9027fa9 | Brian Gernhardt | 24 September 2010, 22:15:34 UTC | git-stash: fix flag parsing Currently git-stash uses `git rev-parse --no-revs -- "$@"` to set its FLAGS variable. This is the same as `FLAGS="-- $@"`. It should use `git rev-parse --no-revs --flags "$@"`, but that eats any "-q" or "--quiet" argument. So move the check for quiet before rev-parse. Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 04:27:37 UTC |
| 3fcb887 | Brandon Casey | 24 September 2010, 20:40:38 UTC | t/t3903-stash: improve testing of git-stash show Recently, the 'stash show' functionality was broken for the case when a stash-like argument was supplied. Since, commit 9bf09e, 'stash show' when supplied a stash-like argument prints nothing and still exists with a zero status. Unfortunately, the flaw slipped through the test suite cracks since the output of 'stash show' was not verified to be correct. Improve and expand on the existing tests so that this flaws is detected. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 September 2010, 04:25:40 UTC |
| 87b5054 | Junio C Hamano | 18 September 2010, 21:55:08 UTC | Git 1.7.3 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 18 September 2010, 21:55:08 UTC |
| 1125297 | Junio C Hamano | 18 September 2010, 21:46:44 UTC | Merge branch 'js/ls-files-x-doc' * js/ls-files-x-doc: ls-files documentation: reword for consistency git-ls-files.txt: clarify -x/--exclude option Conflicts: Documentation/git-ls-files.txt | 18 September 2010, 21:46:44 UTC |
| 14d8729 | Chris Johnsen | 17 September 2010, 21:42:51 UTC | git-rebase--interactive.sh: replace cut with ${v%% *} Some versions of cut do not cope well with lines that do not end in an LF. In this case, we can completely avoid cut by using the ${var%% *} parameter expansion (suggested by Brandon Casey). I found this problem when t3404's "avoid unnecessary reset" failed due to the "rebase -i" not avoiding updating the tested timestamp. On a Mac OS X 10.4.11 system: % printf '%s' 'foo bar' | /usr/bin/cut -d ' ' -f 1 cut: stdin: Illegal byte sequence Signed-off-by: Chris Johnsen <chris_johnsen@pobox.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 17 September 2010, 21:58:08 UTC |
| 84d6940 | Brandon Casey | 15 September 2010, 20:58:22 UTC | t/t7300: workaround ancient touch by rearranging arguments The ancient touch on Solaris 7 thinks that a decimal number supplied as the first argument specifies a date_time to give to the files specified by the remaining arguments. In this case, it fails to parse '1' as a proper date_time and exits with a failure status. Workaround this flaw by rearranging the arguments supplied to touch so that a non-digit appears first and touch will not be confused. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 17 September 2010, 21:42:13 UTC |
| 02567e8 | Junio C Hamano | 16 September 2010, 14:43:41 UTC | Merge branch 'bg/fix-t7003' * bg/fix-t7003: t7003: Use test_commit instead of custom function | 16 September 2010, 14:43:41 UTC |
| 4c60852 | Junio C Hamano | 16 September 2010, 00:34:20 UTC | ls-files documentation: reword for consistency Similar to descriptions of other options, state what -x does in imperative mood. Start sentences for -X and --exclude-per-directory options in capital letters. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 16 September 2010, 00:38:50 UTC |
| 75609a0 | Jay Soffian | 15 September 2010, 23:56:48 UTC | git-ls-files.txt: clarify -x/--exclude option Since b5227d8, -x/--exclude does not apply to cached files. This is easy to miss unless you read the discussion in the EXCLUDE PATTERNS section. Clarify that the option applies to untracked files and direct the reader to EXCLUDE PATTERNS. Signed-off-by: Jay Soffian <jaysoffian@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 16 September 2010, 00:30:36 UTC |
| 7e100ef | Junio C Hamano | 15 September 2010, 19:47:37 UTC | Git 1.7.3 rc2 | 15 September 2010, 19:47:37 UTC |
| 2e1e961 | Junio C Hamano | 15 September 2010, 19:41:13 UTC | Merge branch 'dr/maint-ls-tree-prefix-recursion-fix' * dr/maint-ls-tree-prefix-recursion-fix: ls-tree $di $dir: do not mistakenly recurse into directories | 15 September 2010, 19:41:13 UTC |
| 0c61c6d | Junio C Hamano | 15 September 2010, 19:40:33 UTC | Merge branch 'os/fix-rebase-diff-no-prefix' * os/fix-rebase-diff-no-prefix: Add --src/dst-prefix to git-formt-patch in git-rebase.sh | 15 September 2010, 19:40:33 UTC |
| e3f213c | Junio C Hamano | 15 September 2010, 19:40:12 UTC | Merge branch 'jl/fix-test' * jl/fix-test: t1020: Get rid of 'cd "$HERE"' at the start of each test t2016 (checkout -p): add missing && t1302 (core.repositoryversion): style tweaks t2105 (gitfile): add missing && t1450 (fsck): remove dangling objects tests: subshell indentation stylefix Several tests: cd inside subshell instead of around | 15 September 2010, 19:40:12 UTC |
| 43d268e | Junio C Hamano | 15 September 2010, 19:39:32 UTC | Merge branch 'ch/filter-branch-deprecate-remap-to-ancestor' * ch/filter-branch-deprecate-remap-to-ancestor: filter-branch: retire --remap-to-ancestor | 15 September 2010, 19:39:32 UTC |
| d42cb58 | Junio C Hamano | 15 September 2010, 19:39:22 UTC | Merge branch 'ch/maint-cannot-create-bundle-error' * ch/maint-cannot-create-bundle-error: bundle: detect if bundle file cannot be created | 15 September 2010, 19:39:22 UTC |
| 9f0ccb5 | Junio C Hamano | 15 September 2010, 19:39:12 UTC | Merge branch 'ks/recursive-rename-add-identical' * ks/recursive-rename-add-identical: RE: [PATCH] Avoid rename/add conflict when contents are identical | 15 September 2010, 19:39:12 UTC |
| 12644fa | Junio C Hamano | 15 September 2010, 19:34:37 UTC | Merge git://repo.or.cz/git-gui * 'master' of git://repo.or.cz/git-gui: git-gui 0.13 git-gui: avoid mis-encoding the copyright message on Windows. git-gui: Update Swedish translation (521t). git-gui: ensure correct application termination in git-gui--askpass git-gui: handle textconv filter on Windows and in development git-gui: use shell to launch textconv filter in "blame" git-gui: display error launching blame as a message box. git-gui: Make usage statement visible on Windows. | 15 September 2010, 19:34:48 UTC |
| 00e9de7 | Pat Thoyts | 14 September 2010, 21:42:37 UTC | git-gui 0.13 Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net> | 14 September 2010, 21:42:37 UTC |
| 2473543 | Pat Thoyts | 13 September 2010, 19:41:42 UTC | git-gui: avoid mis-encoding the copyright message on Windows. On Windows the tcl script file will use the system encoding and attempting to convert the copyright mis-encodes the string. Instead, keep the message as ASCII and substitute in the correct unicode character when running. Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net> | 13 September 2010, 19:41:42 UTC |
| 421a31e | Peter Krefting | 12 September 2010, 20:13:29 UTC | git-gui: Update Swedish translation (521t). Signed-off-by: Peter Krefting <peter@softwolves.pp.se> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net> | 13 September 2010, 18:25:55 UTC |
| 77f2e4f | Brian Gernhardt | 10 September 2010, 22:06:36 UTC | t7003: Use test_commit instead of custom function t7003-filter-branch.sh had a make_commit() function that was identical to test_commit() in test-lib.sh except that it used tr to create a lowercase file name from the uppercase branch name instead of appending ".t". Not only is this unneeded code duplication, it also was something simply waiting to fail on case-insensitive file systems. So replace all uses of make_commit with test_commit. While we're editing the setup, chain it together with && so that failures early in the sequence don't get lost and add a commit graph. Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 13 September 2010, 17:59:06 UTC |
| 5879b6b | Junio C Hamano | 12 September 2010, 20:53:03 UTC | Merge branch 'maint' * maint: t3101: modernise style compat/nedmalloc: don't force NDEBUG on the rest of git Conflicts: Makefile | 12 September 2010, 20:53:03 UTC |
| b294ed6 | Junio C Hamano | 11 September 2010, 18:47:09 UTC | ls-tree $di $dir: do not mistakenly recurse into directories When applying two pathspecs, one of which is named as a prefix to the other, we mistakenly recursed into the shorter one. Noticed and fixed by David Reis. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 September 2010, 20:52:03 UTC |
| e22148f | Junio C Hamano | 11 September 2010, 17:53:29 UTC | t3101: modernise style Also add a few " &&" cascade that were missing. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 September 2010, 20:46:58 UTC |
| 5418d96 | Ramsay Jones | 09 September 2010, 17:24:06 UTC | vcs-svn: Fix some printf format compiler warnings In particular, on systems that define uint32_t as an unsigned long, gcc complains as follows: CC vcs-svn/fast_export.o vcs-svn/fast_export.c: In function `fast_export_modify': vcs-svn/fast_export.c:28: warning: unsigned int format, uint32_t arg (arg 2) vcs-svn/fast_export.c:28: warning: int format, uint32_t arg (arg 3) vcs-svn/fast_export.c: In function `fast_export_commit': vcs-svn/fast_export.c:42: warning: int format, uint32_t arg (arg 5) vcs-svn/fast_export.c:62: warning: int format, uint32_t arg (arg 2) vcs-svn/fast_export.c: In function `fast_export_blob': vcs-svn/fast_export.c:72: warning: int format, uint32_t arg (arg 2) vcs-svn/fast_export.c:72: warning: int format, uint32_t arg (arg 3) CC vcs-svn/svndump.o vcs-svn/svndump.c: In function `svndump_read': vcs-svn/svndump.c:260: warning: int format, uint32_t arg (arg 3) In order to suppress the warnings we use the C99 format specifier macros PRIo32 and PRIu32 from <inttypes.h>. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Acked-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 September 2010, 17:24:55 UTC |
| d555ff5 | René Scharfe | 11 September 2010, 09:59:18 UTC | compat/nedmalloc: don't force NDEBUG on the rest of git Define the nedmalloc feature configuration macros for nedmalloc.o, only. This keeps assert(3) working for the rest of the git source; it was turned off for nedmalloc users before by defining NDEBUG globally. Also remove -DUSE_NED_ALLOCATOR as this macro isn't used anywhere. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 11 September 2010, 17:23:03 UTC |
| 3b3a8ed | Junio C Hamano | 10 September 2010, 18:55:55 UTC | Git 1.7.3 rc1 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 18:55:55 UTC |
| 5b45c55 | Junio C Hamano | 10 September 2010, 18:54:58 UTC | Merge branch 'np/relnotes-in-subdir' * np/relnotes-in-subdir: install-webdoc: keep installed RelNotes-*.txt Documentation: move RelNotes into a directory of their own | 10 September 2010, 18:54:58 UTC |
| 6070bac | Junio C Hamano | 10 September 2010, 18:54:34 UTC | Prepare for 1.7.3 rc1 | 10 September 2010, 18:54:34 UTC |
| 9ab5a33 | Junio C Hamano | 10 September 2010, 16:39:08 UTC | Merge branch 'maint' * maint: config.txt: fix placement of diff.noprefix | 10 September 2010, 16:39:08 UTC |
| 9904fad | Mark Lodato | 10 September 2010, 01:39:37 UTC | config.txt: fix placement of diff.noprefix In git-config(1), diff.noprefix was placed in between diff.mnemonicprefix and the list of mnemonic prefixes, which is obviously incorrect and very confusing to readers. Now, it is located after the end of the explanation of mnemonicprefix, which makes much more sense. Signed-off-by: Mark Lodato <lodatom@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 16:31:13 UTC |
| 99f55eb | Brandon Casey | 10 September 2010, 16:13:38 UTC | t/t4018: avoid two unnecessary sub-shell invocations Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 16:30:14 UTC |
| 8ac8cf5 | Junio C Hamano | 10 September 2010, 00:29:40 UTC | Merge branch 'maint' * maint: xdiff-interface.c: always trim trailing space from xfuncname matches diff.c: call regfree to free memory allocated by regcomp when necessary | 10 September 2010, 00:29:40 UTC |
| bff4206 | Brandon Casey | 09 September 2010, 19:02:47 UTC | t/t4018: test whether the word_regex patterns compile Previously (e3bf5e43), a test was added to test whether the builtin xfuncname regular expressions could be compiled without error by regcomp. Let's do the same for the word_regex patterns. This should help catch any cross-platform incompatibilities that exist between the pattern creator's system and the various platforms that the test suite is commonly run on. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 00:19:18 UTC |
| 1b6ecba | Brandon Casey | 09 September 2010, 19:02:46 UTC | xdiff-interface.c: always trim trailing space from xfuncname matches Generally, trailing space is removed from the string matched by the xfuncname patterns. The exception is when the matched string exceeds the length of the fixed-size buffer that it will be copied in to. But, a string that exceeds the buffer can still contain trailing space in the portion of the string that will be copied into the buffer. So, simplify this code slightly, and just perform the trailing space removal always. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 00:18:29 UTC |
| ef5644e | Brandon Casey | 09 September 2010, 19:02:45 UTC | diff.c: call regfree to free memory allocated by regcomp when necessary Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 00:18:04 UTC |
| 042cca3 | Brandon Casey | 09 September 2010, 18:56:37 UTC | t/t5510-fetch.sh: improve testing with explicit URL and merge spec Commit 6106ce46 introduced a test to demonstrate fetch's failure to retrieve any objects or update FETCH_HEAD when it was supplied a repository URL and the current branch had a configured merge spec. This commit expands the original test based on comments from Junio Hamano. In addition to actually verifying that the fetch updates FETCH_HEAD correctly, and does not update the current branch, two more tests are added to ensure that the merge configuration is ignored even when the supplied URL matches the URL of the remote configured for the branch. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 00:16:08 UTC |
| f31dbdc | Brandon Casey | 09 September 2010, 18:56:36 UTC | builtin/fetch.c: comment that branch->remote_name is usable when has_merge Save future readers the trouble of tracing code to determine that the two uses of branch->remote_name are safe when has_merge is set, by adding a comment explaining that it is so. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 00:15:58 UTC |
| a1d558d | Brandon Casey | 09 September 2010, 19:15:58 UTC | Makefile: use compat regex on IRIX 6.5 The IRIX 6.5 regex.h header file defines REG_STARTEND, but the feature does not appear to work. Since REG_STARTEND is required for proper functioning of git-grep, set NO_REGEX and use the alternative regex libraries in compat/ Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 00:11:06 UTC |
| f985487 | Brandon Casey | 09 September 2010, 19:15:57 UTC | t/t7008: workaround broken handling of \000 by printf on IRIX On IRIX 6.5, the printf utility in /usr/bin does not appear to handle the \ddd notation according to POSIX. This printf appears to halt processing of the string argument and ignore any additional characters in the string. Work around this flaw by replacing the \000's with 'Q' and using the q_to_nul helper function provided by test-lib.sh This problem with printf is not apparent when using the Bash shell since Bash implements a POSIX compatible printf function internally. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 00:11:06 UTC |
| 5b220a6 | Oded Shimon | 09 September 2010, 18:49:51 UTC | Add --src/dst-prefix to git-formt-patch in git-rebase.sh For the case of "diff.noprefix" in git-config, git-format-patch should still output diff with standard prefixes for git-am Signed-off-by: Oded Shimon <ods15@ods15.dyndns.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 September 2010, 00:09:44 UTC |
| 3a4e6c7 | Junio C Hamano | 09 September 2010, 23:17:59 UTC | install-webdoc: keep installed RelNotes-*.txt Otherwise URLs in the wild that point at older release notes will become dangling. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 09 September 2010, 23:17:59 UTC |
| fd3c32c | Jens Lehmann | 07 September 2010, 10:29:20 UTC | t1020: Get rid of 'cd "$HERE"' at the start of each test To achieve that, all cd commands which weren't inside a subshell had to be put into a new one. Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 09 September 2010, 23:03:11 UTC |
| a814615 | Jonathan Nieder | 07 September 2010, 08:22:53 UTC | t2016 (checkout -p): add missing && Although the set_state command is not likely to fail, it is best to stay in the habit of checking for failures. Cc: Thomas Rast <trast@student.ethz.ch> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 09 September 2010, 23:02:47 UTC |
| 8fe5aed | Jonathan Nieder | 07 September 2010, 01:52:27 UTC | t1302 (core.repositoryversion): style tweaks This test is from 2007, which is late enough for the style to be recognizably modern but still a while ago. Freshen it up to follow new best practices: - guard setup commands with test_expect_setup, so errors at that stage can be caught; - use <<\EOF in preference to <<EOF, to save reviewers the trouble of looking for variable interpolations; - use test_cmp instead of test "$foo" = "$bar", for better output with -v on failure; - indent commands in subshells and let them span multiple lines; - combine the two "gitdir required mode" tests that do not make as much sense alone. Cc: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 09 September 2010, 23:01:10 UTC |
| 76bbcd4 | Jonathan Nieder | 07 September 2010, 01:49:10 UTC | t2105 (gitfile): add missing && Make sure early failures are not masked by later successes. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Acked-by: Brad King <brad.king@kitware.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 09 September 2010, 22:58:45 UTC |
| dbedf8b | Jonathan Nieder | 07 September 2010, 01:47:07 UTC | t1450 (fsck): remove dangling objects The fsck test is generally careful to remove the corrupt objects it inserts, but dangling objects are left behind due to some typos and omissions. It is better to clean up more completely, to simplify the addition of later tests. So: - guard setup and cleanup with test_expect_success to catch typos and errors; - check both stdout and stderr when checking for empty fsck output; - use test_cmp empty file in place of test $(wc -l <file) = 0, for better debugging output when running tests with -v; - add a remove_object () helper and use it to replace broken object removal code that forgot about the fanout in .git/objects; - disable gc.auto, to avoid tripping up object removal if the number of objects ever reaches that threshold. - use test_when_finished to ensure cleanup tasks are run and succeed when tests fail; - add a new final test that no breakage or dangling objects was left behind. While at it, add a brief description to test_description of the history that is expected to persist between tests. Part of a campaign to clean up subshell usage in tests. Cc: Thomas Rast <trast@student.ethz.ch> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 09 September 2010, 22:58:32 UTC |
| 18a8269 | Jonathan Nieder | 07 September 2010, 01:42:54 UTC | tests: subshell indentation stylefix Format the subshells introduced by the previous patch (Several tests: cd inside subshell instead of around, 2010-09-06) like so: ( cd subdir && ... ) && This is generally easier to read and has the nice side-effect that this patch will show what commands are used in the subshell, making it easier to check for lost environment variables and similar behavior changes. Cc: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 09 September 2010, 22:56:20 UTC |
| 154adcf | Junio C Hamano | 08 September 2010, 16:17:01 UTC | Merge branch 'tf/cleanup-builtin-help-headers' * tf/cleanup-builtin-help-headers: builtin.h: Move two functions definitions to help.h. | 08 September 2010, 16:17:01 UTC |
| 1080be2 | Junio C Hamano | 08 September 2010, 16:17:01 UTC | Merge branch 'jk/test-must-fail-missing' * jk/test-must-fail-missing: tests: make test_might_fail fail on missing commands tests: make test_might_fail more verbose tests: make test_must_fail fail on missing commands tests: make test_must_fail more verbose | 08 September 2010, 16:17:01 UTC |
| 1d86cb8 | Junio C Hamano | 08 September 2010, 16:17:01 UTC | Merge branch 'jh/error-removing-missing-note' * jh/error-removing-missing-note: notes: Don't create (empty) commit when removing non-existing notes | 08 September 2010, 16:17:01 UTC |
| b815a72 | Junio C Hamano | 08 September 2010, 16:17:01 UTC | Merge branch 'kf/askpass-config' * kf/askpass-config: Extend documentation of core.askpass and GIT_ASKPASS. Allow core.askpass to override SSH_ASKPASS. Add a new option 'core.askpass'. | 08 September 2010, 16:17:01 UTC |
| e250c59 | Junio C Hamano | 08 September 2010, 16:17:00 UTC | Merge branch 'bc/maint-fetch-url-only' * bc/maint-fetch-url-only: builtin/fetch.c: ignore merge config when not fetching from branch's remote t/t5510: demonstrate failure to fetch when current branch has merge ref | 08 September 2010, 16:17:00 UTC |
| 6b948a7 | Junio C Hamano | 08 September 2010, 16:17:00 UTC | Merge branch 'jk/maint-pass-c-config-in-env' * jk/maint-pass-c-config-in-env: do not pass "git -c foo=bar" params to transport helpers pass "git -c foo=bar" params through environment | 08 September 2010, 16:17:00 UTC |
| 9f44723 | Junio C Hamano | 08 September 2010, 15:54:01 UTC | Merge branch 'en/d-f-conflict-fix' * en/d-f-conflict-fix: fast-export: ensure that a renamed file is printed after all references | 08 September 2010, 15:54:01 UTC |
| 4ce6fb8 | Johannes Sixt | 07 September 2010, 19:33:02 UTC | fast-export: ensure that a renamed file is printed after all references t9350 sets up a commit where a file is both copied and renamed. The output of fast-export for this commit should look like this: author ... committer ... from :19 C "file2" "file4" R "file2" "file5" The order of the two modification lines is derived from the result that the diff machinery produces. 060df62 (fast-export: Fix output order of D/F changes) inserted a qsort call that modifies the order of the diff result. Unfortunately, qsort need not be stable. Therefore, it is possible that the 'R' line appears before the 'C' line and the resulting fast-import stream is incorrect. Fix it by forcing that the rename entry is printed after all other modification lines with the same file name. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 08 September 2010, 15:53:54 UTC |
| 761e742 | Nicolas Pitre | 07 September 2010, 00:29:57 UTC | Documentation: move RelNotes into a directory of their own There are 108 of them already. That's a bit more than one third of all the files in the Documentation directory already, and still growing. Signed-off-by: Nicolas Pitre <nico@fluxnic.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 September 2010, 00:41:18 UTC |
| 7505ae2 | Junio C Hamano | 07 September 2010, 00:40:18 UTC | Merge branch 'maint' * maint: revert: Fix trivial comment style issue cache_tree_free: Fix small memory leak Conflicts: builtin/revert.c | 07 September 2010, 00:40:18 UTC |
| 04df568 | Elijah Newren | 06 September 2010, 21:53:24 UTC | revert: Fix trivial comment style issue Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 September 2010, 00:33:59 UTC |
| e92fa51 | Elijah Newren | 06 September 2010, 21:40:16 UTC | cache_tree_free: Fix small memory leak Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 September 2010, 00:32:28 UTC |
| 79d532c | Junio C Hamano | 06 September 2010, 23:57:05 UTC | Merge branch 'jh/clean-exclude' * jh/clean-exclude: builtin/clean.c: Use STRING_LIST_INIT_NODUP. | 06 September 2010, 23:57:05 UTC |
| bdab6a5 | Thiago Farina | 06 September 2010, 23:32:55 UTC | builtin/clean.c: Use STRING_LIST_INIT_NODUP. Signed-off-by: Thiago Farina <tfransosi@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 September 2010, 23:56:51 UTC |
| 347c47e | Junio C Hamano | 06 September 2010, 23:46:36 UTC | Merge branch 'jl/maint-fix-test' * jl/maint-fix-test: Several tests: cd inside subshell instead of around Conflicts: t/t9600-cvsimport.sh | 06 September 2010, 23:46:36 UTC |
| fd4ec4f | Jens Lehmann | 06 September 2010, 18:39:54 UTC | Several tests: cd inside subshell instead of around Fixed all places where it was a straightforward change from cd'ing into a directory and back via "cd .." to a cd inside a subshell. Found these places with "git grep -w "cd \.\.". Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 September 2010, 21:30:53 UTC |
| c2e0940 | Jens Lehmann | 06 September 2010, 18:41:06 UTC | t3404 & t7508: cd inside subshell instead of around Fixed all places where it was a straightforward change from cd'ing into a directory and back via "cd .." to a cd inside a subshell. Found these places with "git grep -w "cd \.\.". Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 September 2010, 21:27:35 UTC |
| 4682693 | Junio C Hamano | 06 September 2010, 07:12:04 UTC | Merge branch 'maint' * maint: tag.c: whitespace breakages fix Fix whitespace issue in object.c t5505: add missing && | 06 September 2010, 07:12:04 UTC |
| af24059 | Junio C Hamano | 06 September 2010, 07:11:59 UTC | Merge branch 'xx/trivial' into maint * xx/trivial: tag.c: whitespace breakages fix Fix whitespace issue in object.c t5505: add missing && | 06 September 2010, 07:11:59 UTC |
| d2c030d | Junio C Hamano | 06 September 2010, 05:32:05 UTC | tag.c: whitespace breakages fix Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 September 2010, 05:32:05 UTC |
| 55b4e9e | Jared Hance | 05 September 2010, 19:36:33 UTC | Fix whitespace issue in object.c Change some expanded tabs (spaces) to tabs in object.c. Signed-off-by: Jared Hance <jaredhance@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 September 2010, 05:12:29 UTC |
| 65b26eb | Jens Lehmann | 05 September 2010, 12:56:11 UTC | t5505: add missing && Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 September 2010, 05:10:22 UTC |
| 02377cf | Junio C Hamano | 04 September 2010, 15:17:09 UTC | Merge branch 'jl/submodule-ignore-diff' * jl/submodule-ignore-diff: checkout: Use submodule.*.ignore settings from .git/config and .gitmodules checkout: Add test for diff.ignoreSubmodules checkout: respect diff.ignoreSubmodules setting Conflicts: builtin/checkout.c | 04 September 2010, 15:17:09 UTC |
| a2c6726 | Junio C Hamano | 04 September 2010, 15:15:36 UTC | Merge branch 'ab/test-2' * ab/test-2: (51 commits) tests: factor HOME=$(pwd) in test-lib.sh test-lib: use subshell instead of cd $new && .. && cd $old tests: simplify "missing PREREQ" message t/t0000-basic.sh: Run the passing TODO test inside its own test-lib test-lib: Allow overriding of TEST_DIRECTORY test-lib: Use "$GIT_BUILD_DIR" instead of "$TEST_DIRECTORY"/../ test-lib: Use $TEST_DIRECTORY or $GIT_BUILD_DIR instead of $(pwd) and ../ test: Introduce $GIT_BUILD_DIR cvs tests: do not touch test CVS repositories shipped with source t/t9602-cvsimport-branches-tags.sh: Add a PERL prerequisite t/t9601-cvsimport-vendor-branch.sh: Add a PERL prerequisite t/t7105-reset-patch.sh: Add a PERL prerequisite t/t9001-send-email.sh: convert setup code to tests t/t9001-send-email.sh: change from skip_all=* to prereq skip t/t9001-send-email.sh: Remove needless PROG=* assignment t/t9600-cvsimport.sh: change from skip_all=* to prereq skip lib-patch-mode tests: change from skip_all=* to prereq skip t/t3701-add-interactive.sh: change from skip_all=* to prereq skip tests: Move FILEMODE prerequisite to lib-prereq-FILEMODE.sh t/Makefile: Create test-results dir for smoke target ... Conflicts: t/t6035-merge-dir-to-symlink.sh | 04 September 2010, 15:15:36 UTC |
| b480d38 | Junio C Hamano | 04 September 2010, 05:45:58 UTC | Merge branch 'js/detached-stash' * js/detached-stash: t3903: fix broken test_must_fail calls detached-stash: update Documentation detached-stash: tests of git stash with stash-like arguments detached-stash: simplify git stash show detached-stash: simplify git stash branch detached-stash: refactor git stash pop implementation detached-stash: simplify stash_drop detached-stash: simplify stash_apply detached-stash: work around git rev-parse failure to detect bad log refs detached-stash: introduce parse_flags_and_revs function | 04 September 2010, 05:45:58 UTC |
| 306d7e5 | Junio C Hamano | 04 September 2010, 05:24:29 UTC | Merge branch 'js/maint-reflog-beyond-horizon' * js/maint-reflog-beyond-horizon: t1503: fix broken test_must_fail calls rev-parse: tests git rev-parse --verify master@{n}, for various n sha1_name.c: use warning in preference to fprintf(stderr rev-parse: exit with non-zero status if ref@{n} is not valid. | 04 September 2010, 05:24:29 UTC |
| c208e05 | Junio C Hamano | 04 September 2010, 05:23:49 UTC | Merge branch 'dg/local-mod-error-messages' * dg/local-mod-error-messages: t7609-merge-co-error-msgs: test non-fast forward case too. Move "show_all_errors = 1" to setup_unpack_trees_porcelain() setup_unpack_trees_porcelain: take the whole options struct as parameter Move set_porcelain_error_msgs to unpack-trees.c and rename it Conflicts: merge-recursive.c | 04 September 2010, 05:23:49 UTC |
| f92d62e | Junio C Hamano | 04 September 2010, 05:23:13 UTC | Merge branch 'nd/maint-fix-replace' * nd/maint-fix-replace: parse_object: pass on the original sha1, not the replaced one | 04 September 2010, 05:23:13 UTC |
| 2e3400c | Nguyễn Thái Ngọc Duy | 03 September 2010, 20:51:53 UTC | parse_object: pass on the original sha1, not the replaced one Commit 0e87c36 (object: call "check_sha1_signature" with the replacement sha1) changed the first argument passed to parse_object_buffer() from "sha1" to "repl". With that change, the returned obj pointer has the replacement SHA1 in obj->sha1, not the original one. But when using lookup_commit() and then parse_commit() on a commit, we get an object pointer with the original sha1, but the commit content comes from the replacement commit. So the result we get from using parse_object() is different from the we get from using lookup_commit() followed by parse_commit(). It looks much simpler and safer to fix this inconsistency by passing "sha1" to parse_object_bufer() instead of "repl". The commit comment should be used to tell the the replacement commit is replacing another commit and why. So it should be easy to see that we have a replacement commit instead of an original one. And it is not a problem if the content of the commit is not consistent with the sha1 as cat-file piped to hash-object can be used to see the difference. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 04 September 2010, 05:13:08 UTC |
| d5af510 | Schalk, Ken | 01 September 2010, 20:15:32 UTC | RE: [PATCH] Avoid rename/add conflict when contents are identical >Due to this this (and maybe all the tests) need to depend on the >SYMLINKS prereq. Here's a third attempt with no use of symlinks in the test: Skip the entire rename/add conflict case if the file added on the other branch has the same contents as the file being renamed. This avoids giving the user an extra copy of the same file and presenting a conflict that is confusing and pointless. A simple test of this case has been added in t/t3030-merge-recursive.sh. Signed-off-by: Ken Schalk <ken.schalk@intel.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 03 September 2010, 18:26:49 UTC |
| cd1547d | Junio C Hamano | 03 September 2010, 16:43:45 UTC | Merge branch 'ab/compat-regex' * ab/compat-regex: Fix compat/regex ANSIfication on MinGW autoconf: regex library detection typofix autoconf: don't use platform regex if it lacks REG_STARTEND t/t7008-grep-binary.sh: un-TODO a test that needs REG_STARTEND compat/regex: get rid of old-style definition compat/regex: define out variables only used under RE_ENABLE_I18N Change regerror() declaration from K&R style to ANSI C (C89) compat/regex: get the gawk regex engine to compile within git compat/regex: use the regex engine from gawk for compat Conflicts: compat/regex/regex.c | 03 September 2010, 16:43:45 UTC |
| c6babe5 | Junio C Hamano | 03 September 2010, 16:43:45 UTC | Merge branch 'nd/clone-depth-zero' * nd/clone-depth-zero: clone: warn users --depth is ignored in local clones | 03 September 2010, 16:43:45 UTC |
| f9c8e7c | Junio C Hamano | 03 September 2010, 16:43:44 UTC | Merge branch 'jn/maint-doc-user-manual-html-doctype' * jn/maint-doc-user-manual-html-doctype: docs: fix Makefile dependency for user manual Documentation: set a !DOCTYPE for user manual | 03 September 2010, 16:43:44 UTC |
| 1998f4c | Junio C Hamano | 03 September 2010, 16:43:44 UTC | Merge branch 'cb/maint-mergetool-no-tty' * cb/maint-mergetool-no-tty: mergetool: Remove explicit references to /dev/tty Conflicts: git-mergetool.sh | 03 September 2010, 16:43:44 UTC |
| 9502751 | Junio C Hamano | 03 September 2010, 16:43:44 UTC | Merge branch 'jn/apply-filename-with-sp' * jn/apply-filename-with-sp: apply: handle traditional patches with space in filename tests: exercise "git apply" with weird filenames apply: split quoted filename handling into new function | 03 September 2010, 16:43:44 UTC |
| 460645a | Junio C Hamano | 03 September 2010, 16:43:43 UTC | Merge branch 'jn/merge-custom-no-trivial' * jn/merge-custom-no-trivial: t7606: Avoid using head as a file name merge: let custom strategies intervene in trivial merges t7606 (merge-theirs): modernize style | 03 September 2010, 16:43:43 UTC |
