swh:1:snp:8a1bf80ec89c62a71cdcaaf0c2f9145695a5340a

sort by:
Revision Author Date Message Commit Date
2cf9e51 version: 3.3.11 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 11 January 2019, 19:12:25 UTC
1590373 auth: fix cherry-pick Signed-off-by: Sam Batschelet <sbatsche@redhat.com> 09 January 2019, 18:10:32 UTC
c7f744d auth: disable CommonName auth for gRPC-gateway Signed-off-by: Sam Batschelet <sbatsche@redhat.com> 08 January 2019, 21:01:25 UTC
e6b2f00 Merge pull request #10335 from gyuho/release-3.3-patch [Cherry pick 3.3] grpcproxy: fix memory leak 18 December 2018, 04:37:04 UTC
59cc0f9 grpcproxy: fix memory leak use set instead of slice as interval value fixes #10326 18 December 2018, 03:00:57 UTC
3a7b8b3 travis: use Go 1.10.7 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 18 December 2018, 03:00:22 UTC
6f250f9 version: 3.3.10+git Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 20:30:14 UTC
27fc7e2 version: 3.3.10 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 17:17:54 UTC
eb932c2 travis.yml: use Go 1.10.4 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 17:17:36 UTC
957700f etcdserver: add "etcd_server_read_indexes_failed_total" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 01:22:02 UTC
b45f530 rafthttp: probe all raft transports This PR adds another probing routine to monitor the connection for Raft message transports. Previously, we only monitored snapshot transports. In our production cluster, we found one TCP connection had >8-sec latencies to a remote peer, but "etcd_network_peer_round_trip_time_seconds" metrics shows <1-sec latency distribution, which means etcd server was not sampling enough while such latency spikes happen outside of snapshot pipeline connection. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 01:18:27 UTC
8491137 etcdserver: add "etcd_server_health_success/failures" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 10 October 2018, 00:54:30 UTC
ebe950f Merge pull request #10161 from jingyih/automated-cherry-pick-of-#10153-origin-release-3.3 clientv3: automated cherry pick of #10153 to release-3.3 09 October 2018, 01:37:52 UTC
20d83e4 clientv3: concurrency.Mutex.Lock() - preserve invariant Convenient invariant: - if werr == nil then lock is supposed to be locked at the moment. While we could not be confident in stronger invariant ('is exactly locked'), it were inconvenient that previous code could return `werr == nil` after Mutex.Unlock. It could happen when ctx is canceled/timeouted exactly after waitDeletes successfully returned werr == nil and before `<-ctx.Done()` checked. While such situation is very rare, it is still possible. fixes #10111 08 October 2018, 23:42:26 UTC
cb57901 Merge pull request #10041 from wenjiaswe/automated-cherry-pick-of-#9997-upstream-release-3.3 Automated cherry pick of #9997 03 October 2018, 20:52:02 UTC
d838e24 etcdserver/api/rafthttp: add v3 snapshot send/receive metrics Distribution would be: 0.1 second or more ... 25.6 seconds or more 51.2 seconds or more etcd_network_snapshot_send_success etcd_network_snapshot_send_failures etcd_network_snapshot_send_total_duration_seconds etcd_network_snapshot_receive_success etcd_network_snapshot_receive_failures etcd_network_snapshot_receive_total_duration_seconds Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 03 October 2018, 18:12:42 UTC
7ec9ff6 etcdserver/api/snap: add v3 snapshot fsync metrics etcd_snap_db_fsync_duration_seconds_count etcd_snap_db_save_total_duration_seconds_bucket Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 03 October 2018, 18:12:41 UTC
dc02dc2 tests/Dockerfile: update, fix GOPATH Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 October 2018, 08:30:23 UTC
40ed18a Merge pull request #10122 from jingyih/cherry-pick-of-#10109-origin-release-3.3 etcdctl: cherry pick of #10109 to release-3.3 26 September 2018, 00:30:01 UTC
60d546e etcdctl: cherry pick of #10109 to release-3.3 Add snapshot file integrity verification in snapshot status. 25 September 2018, 23:50:47 UTC
e774f73 Merge pull request #10093 from jingyih/remove_duplicated_import etcdserver: remove duplicated imports 14 September 2018, 03:57:09 UTC
9eee0b0 etcdserver: remove duplicated imports Removed duplicated imports of package 'context' in server.go 14 September 2018, 03:44:03 UTC
d1acb5a etcdserver: add "etcd_server_id" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:50:17 UTC
73c1100 etcdserver: clarify read index wait timeout warnings Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:38:59 UTC
c577335 rafthttp: clarify "became inactive" warning Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 August 2018, 21:34:15 UTC
f69413e Merge pull request #10027 from hexfusion/cherry-pick-a205cfe etcdserver: cherry-pick #9861 to release-3.3 20 August 2018, 19:54:43 UTC
0dc4632 Merge pull request #9861 from gyuho/race etcdserver/api/v3rpc: remove duplicate gRPC logger set 18 August 2018, 02:32:10 UTC
f8fc923 Merge pull request #10004 from jingyih/automated-cherry-pick-of-#9990-origin-release-3.3 Automated cherry pick of #9990 15 August 2018, 13:37:33 UTC
264bb51 etcdserver: code clean up Code clean up in interceptor.go 15 August 2018, 00:08:45 UTC
c6c0d03 vendor: add go-grpc-middleware Rebased to master PR #9994. Fixed a Go format issue in v3rpc/interceptor.go. Updated vendor to include go-grpc-middleware. 15 August 2018, 00:08:45 UTC
94f8136 etcdserver: add grpc interceptor to log info on incoming requests to etcd server To improve debuggability of etcd v3. Added a grpc interceptor to log info on incoming requests to etcd server. The log output includes remote client info, request content (with value field redacted), request handling latency, response size, etc. Uses zap logger if available, otherwise uses capnslog. Also did some clean up on the chaining of grpc interceptors on server side. 14 August 2018, 23:20:13 UTC
051587f version: bump up to 3.3.9+git 24 July 2018, 17:17:06 UTC
fca8add version: 3.3.9 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 24 July 2018, 16:48:32 UTC
ea40e9f etcdserver: add "etcd_server_go_version" metric Currently, one has to look at server logs manually, to see what Go version was used to build etcd server. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 July 2018, 23:39:24 UTC
fbc0510 clientv3: fix keepalive send interval when response queue is full client should update next keepalive send time even when lease keepalive response queue becomes full. Otherwise, client sends keepalive request every 500ms regardless of TTL when the send is only expected to happen with the interval of TTL / 3 at minimum. Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 July 2018, 15:51:18 UTC
267a621 Merge pull request #9940 from wenjiaswe/automated-cherry-pick-of-#9761-upstream-release-3.3 Automated cherry pick of #9761 20 July 2018, 01:27:15 UTC
143fc4c added "now := time.Now()" 20 July 2018, 00:27:40 UTC
7f421ef remove "github.com/gogo/protobuf/plugin/stringer" 20 July 2018, 00:15:32 UTC
d509620 etcdserver: rename to "heartbeat_send_failures_total" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 23:58:14 UTC
d5654ba mvcc: add "etcd_mvcc_hash_(rev)_duration_seconds" etcd_mvcc_hash_duration_seconds etcd_mvcc_hash_rev_duration_seconds Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 23:57:04 UTC
da304d7 mvcc/backend: fix defrag duration scale Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 23:54:26 UTC
978727a mvcc/backend: add "etcd_disk_backend_defrag_duration_seconds" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 23:54:26 UTC
4ad3504 mvcc/backend: document metrics ExponentialBuckets Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 23:53:31 UTC
f7367d9 mvcc/backend: clean up mutex, logging Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 23:53:31 UTC
e43224c etcdserver: add "etcd_server_slow_apply_total" {"level":"warn","ts":1527101858.6985068,"caller":"etcdserver/util.go:115","msg":"apply request took too long","took":0.114101529,"expected-duration":0.1,"prefix":"","request":"header:<ID:1029181977902852337> put:<key:\"\\000\\000... Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 23:52:37 UTC
4c7bf51 etcdserver: add "etcd_server_heartbeat_failures_total" {"level":"warn","ts":1527101858.4149103,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.025771662} {"level":"warn","ts":1527101858.4149644,"caller":"etcdserver/raft.go:370","msg":"failed to send out heartbeat; took too long, server is overloaded likely from slow disk","heartbeat-interval":0.1,"expected-duration":0.2,"exceeded-duration":0.034015766} Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 23:51:08 UTC
ffe52f7 e2e: log errors TestV3CurlCipherSuitesMismatch for now Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 17:11:10 UTC
1da638c Makefile: use Go 1.10.3 by default Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 17:01:27 UTC
82ce873 *: use Go 1.10.3 for testing Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 19 July 2018, 16:56:59 UTC
adfd0d3 mvcc: avoid unnecessary metrics update https://github.com/coreos/etcd/pull/9300 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:51:08 UTC
a410463 mvcc: add "etcd_mvcc_db_total_size_in_use_in_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:36:18 UTC
1da3603 mvcc: add "etcd_mvcc_db_total_size_in_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 21:35:48 UTC
72c51d3 etcdserver: add "etcd_server_quota_backend_bytes" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 20:26:49 UTC
4481238 etcdserver: add "etcd_server_slow_read_indexes_total" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 20:00:08 UTC
82e6707 etcdserver: clarify read index warnings Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 03 July 2018, 19:53:21 UTC
09addbd tests: update test scripts Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 18 June 2018, 21:08:36 UTC
4ea2271 version: 3.3.8+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 15 June 2018, 17:21:06 UTC
33245c6 version: 3.3.8 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 15 June 2018, 16:41:56 UTC
4c18c56 travis: use Go 1.9.7 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 15 June 2018, 16:41:41 UTC
cb46e9e gitignore: ignore "docs" and "vendor" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 15 June 2018, 16:34:20 UTC
1fea97b clientv3: backoff on reestablishing watches when Unavailable errors are encountered 14 June 2018, 17:47:46 UTC
5227545 tests/semaphore.test.bash: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 June 2018, 21:39:38 UTC
1ba7c71 Makefile: update Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 13 June 2018, 21:39:02 UTC
b7c1923 etcdserver: Fix txn request 'took too long' warnings to use loggable request stringer 12 June 2018, 16:33:33 UTC
07f833a etcdserver: Add response byte size and range response count to took too long warning 11 June 2018, 18:26:26 UTC
ef15409 etcdserver: Replace value contents with value_size in request took too long warning 08 June 2018, 16:49:43 UTC
21f186a version: bump up to 3.3.7+git 06 June 2018, 17:08:16 UTC
56536de version: 3.3.7 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 01:50:19 UTC
a0ebf8c e2e: test client-side cipher suites with curl Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 01:50:19 UTC
1371572 etcdmain: add "--cipher-suites" flag Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 01:50:15 UTC
22d65d8 embed: support custom cipher suites Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 01:18:16 UTC
6c2add4 integration: test client-side TLS cipher suites Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 01:11:16 UTC
6a38427 pkg/transport: add "TLSInfo.CipherSuites" field Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 01:10:35 UTC
641bddc pkg/tlsutil: add "GetCipherSuite" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 06 June 2018, 01:10:16 UTC
21a1162 tests/e2e: test move-leader command with TLS Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 05 June 2018, 20:56:31 UTC
e2cb9cb ctlv3: support TLS endpoints for move-leader command Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 05 June 2018, 20:56:05 UTC
243074c scripts/release: Fix docker push for 3.1 releases, remove inaccurate warning at the end of release script 31 May 2018, 21:44:29 UTC
26a73f2 version: bump up to 3.3.6+git 31 May 2018, 18:57:20 UTC
932c3c0 version: 3.3.6 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 31 May 2018, 18:41:42 UTC
41888dd mvcc: fix panic by allowing future revision watcher from restore operation This also happens without gRPC proxy. Fix panic when gRPC proxy leader watcher is restored: ``` go test -v -tags cluster_proxy -cpu 4 -race -run TestV3WatchRestoreSnapshotUnsync === RUN TestV3WatchRestoreSnapshotUnsync panic: watcher minimum revision 9223372036854775805 should not exceed current revision 16 goroutine 156 [running]: github.com/coreos/etcd/mvcc.(*watcherGroup).chooseAll(0xc4202b8720, 0x10, 0xffffffffffffffff, 0x1) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:242 +0x3b5 github.com/coreos/etcd/mvcc.(*watcherGroup).choose(0xc4202b8720, 0x200, 0x10, 0xffffffffffffffff, 0xc420253378, 0xc420253378) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watcher_group.go:225 +0x289 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchers(0xc4202b86e0, 0x0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:340 +0x237 github.com/coreos/etcd/mvcc.(*watchableStore).syncWatchersLoop(0xc4202b86e0) /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:214 +0x280 created by github.com/coreos/etcd/mvcc.newWatchableStore /home/gyuho/go/src/github.com/coreos/etcd/mvcc/watchable_store.go:90 +0x477 exit status 2 FAIL github.com/coreos/etcd/integration 2.551s ``` gRPC proxy spawns a watcher with a key "proxy-namespace__lostleader" and watch revision "int64(math.MaxInt64 - 2)" to detect leader loss. But, when the partitioned node restores, this watcher triggers panic with "watcher minimum revision ... should not exceed current ...". This check was added a long time ago, by my PR, when there was no gRPC proxy: https://github.com/coreos/etcd/pull/4043#discussion_r48457145 > we can remove this checking actually. it is impossible for a unsynced watching to have a future rev. or we should just panic here. However, now it's possible that a unsynced watcher has a future revision, when it was moved from a synced watcher group through restore operation. This PR adds "restore" flag to indicate that a watcher was moved from the synced watcher group with restore operation. Otherwise, the watcher with future revision in an unsynced watcher group would still panic. Example logs with future revision watcher from restore operation: ``` {"level":"info","ts":1527196358.9057755,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} {"level":"info","ts":1527196358.910349,"caller":"mvcc/watcher_group.go:261","msg":"choosing future revision watcher from restore operation","watch-key":"proxy-namespace__lostleader","watch-revision":9223372036854775805,"current-revision":16} ``` Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 31 May 2018, 18:41:34 UTC
7292963 auth: fix panic using WithRoot and improve JWT coverage Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 24 May 2018, 06:45:24 UTC
37767bc auth: a new auth token provider nop This commit adds a new auth token provider named nop. The nop provider refuses every Authenticate() request so CN based authentication can only be allowed. If the tokenOpts parameter of auth.NewTokenProvider() is empty, the provider will be used. 23 May 2018, 22:48:39 UTC
d659771 scripts: Fix remote tag check, gcloud login and umask in release script 09 May 2018, 18:08:23 UTC
39d01e7 version: 3.3.5+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 09 May 2018, 18:07:52 UTC
70c8726 version: 3.3.5 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 09 May 2018, 16:23:59 UTC
aaca01a tests/e2e: separate coverage tests for exec commands Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 04 May 2018, 01:48:16 UTC
bc2d400 etcdctl/ctlv3: fix watch with exec commands Following command was failing because the parser incorrectly picks up the second "watch" string in exec command, thus passing wrong exec commands. ``` ETCDCTL_API=3 ./bin/etcdctl watch aaa -- echo watch event received panic: runtime error: slice bounds out of range goroutine 1 [running]: github.com/coreos/etcd/etcdctl/ctlv3/command.parseWatchArgs(0xc42002e080, 0x8, 0x8, 0xc420206a20, 0x5, 0x6, 0x0, 0x0, 0x0, 0x0, ...) /home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/command/watch_command.go:303 +0xbed github.com/coreos/etcd/etcdctl/ctlv3/command.watchCommandFunc(0xc4202a7180, 0xc420206a20, 0x5, 0x6) /home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/command/watch_command.go:73 +0x11d github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).execute(0xc4202a7180, 0xc420206960, 0x6, 0x6, 0xc4202a7180, 0xc420206960) /home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:766 +0x2c1 github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x1363de0, 0xc420128638, 0xc420185e01, 0xc420185ee8) /home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:852 +0x30a github.com/coreos/etcd/vendor/github.com/spf13/cobra.(*Command).Execute(0x1363de0, 0x0, 0x0) /home/gyuho/go/src/github.com/coreos/etcd/vendor/github.com/spf13/cobra/command.go:800 +0x2b github.com/coreos/etcd/etcdctl/ctlv3.Start() /home/gyuho/go/src/github.com/coreos/etcd/etcdctl/ctlv3/ctl_nocov.go:25 +0x8e main.main() /home/gyuho/go/src/github.com/coreos/etcd/etcdctl/main.go:40 +0x17b ``` Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 04 May 2018, 01:48:08 UTC
913a985 tests: use Go 1.9.6 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 01 May 2018, 17:22:04 UTC
3f888b8 functional/tester: handle retries in "caseUntilSnapshot" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 30 April 2018, 21:37:20 UTC
c15c8c6 functional.yaml: use lower ports Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 30 April 2018, 20:36:36 UTC
f535bb6 scripts: Fix a few etcd release script bugs and make it reenterant. 25 April 2018, 17:04:43 UTC
f01d690 etcdmain: document peer-cert-allowed-cn flag 24 April 2018, 20:57:51 UTC
d09fa9c version: 3.3.4+git Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 24 April 2018, 20:56:13 UTC
fdde870 version: 3.3.4 Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 24 April 2018, 19:05:29 UTC
600b2d1 scripts: Add scripts/release that performs 'etcd-release-runbook' (https://goo.gl/Gxwysq) style release workflow 24 April 2018, 19:05:18 UTC
870138a etcdserver: log skipping initial election tick Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:59:01 UTC
758203b etcdmain: add "--initial-election-tick-advance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:58:57 UTC
8886a63 embed: add "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:26:48 UTC
ea82961 integration: set InitialElectionTickAdvance to true by default Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:22:16 UTC
b923c74 etcdserver: add "InitialElectionTickAdvance" Signed-off-by: Gyuho Lee <gyuhox@gmail.com> 23 April 2018, 17:21:51 UTC
back to top