swh:1:snp:c7c108084bc0bf3d81436bf980b46e98bd338453

sort by:
Revision Author Date Message Commit Date
d435fde [l10n] Update German translation 26 July 2015, 11:47:47 UTC
3b0b3d6 rawspeed: finetune samsung nx500 whitelevels 20 July 2015, 16:58:29 UTC
c588e03 rawspeed: olympus tg-4 keep image centered 20 July 2015, 16:47:45 UTC
ae2d36c rawspeed: olympus tg-4 crop finetune 20 July 2015, 16:19:39 UTC
66f6567 rawspeed: olympus tg-4 remove pointless blacklevel 20 July 2015, 16:15:51 UTC
3f2a352 [l10n] Update Spanish translation 16 July 2015, 21:09:49 UTC
9a13e12 rawspeed: olympus tg4 finetuning 14 July 2015, 17:33:51 UTC
6885126 wb_presets: olympus tg-4 14 July 2015, 17:23:39 UTC
97510c0 rawspeed: olympus tg-4 14 July 2015, 17:21:54 UTC
95b2443 adobe_coeff: olympus tg-4 14 July 2015, 17:21:10 UTC
fc5fa0f facebook: request publish_actions permission rather than publish_stream publish_stream was a superset of publish_actions permissions. and provided permission we don't require. This permission doesn't seems to exists anymore Fixes #10446 (cherry picked from commit 1b82e6e16ead15fb7f51e2b3a80f0a2f138d0588) 14 July 2015, 17:18:38 UTC
0fba13d tonecurve: nikon d5100 (cherry picked from commit 541a7f9a229e044b0e9865aa6d50fe3e81d91da1) 14 July 2015, 17:18:04 UTC
74b0024 basecurve: nikon d5100 (cherry picked from commit 4d73c5b53ab7f349279c4f132e3816a785f28133) 14 July 2015, 17:17:58 UTC
ac99ab8 Disk store: access(): check for W_OK | X_OK. Fixes #10440, Debian Bug#792209 E.g. if you: 1. $ mkdir /tmp/tst 2. $ chmod 0755 /tmp/tst 3. try to export to /tmp/del/$(FILE_NAME) => it works 4. $ chmod 0655 /tmp/tst 5. try to export to /tmp/del/$(FILE_NAME) => export fails with "[imageio_storage_disk] could not export to file" after processing image though pipe. Also 6. $ echo "tst" > /tmp/tst/file results in "Permission denied" (cherry picked from commit 6e8d7f3fcfd70b283c376c3c550435fd35ac4358) 13 July 2015, 22:18:04 UTC
5066a3b [noiseprofile] Add Canon EOS 5DS R Thanks Jack/FF. 08 July 2015, 20:56:01 UTC
6f0c9d1 OSX packaging: small update to building instructions (cherry picked from commit 726200fa3df710b41d6ddc4bf1f30a9c0a652725) 08 July 2015, 12:31:27 UTC
869778b OSX HiDPI: fix bug #10575 (cherry picked from commit b13c7e24a4f8e940da20d789e9f8298c3d62f1fb) 08 July 2015, 12:31:12 UTC
11e0e0d dt_exif_read_blob(): and drop DNGBackwardVersion. Refs #10564 (cherry picked from commit d960457bfd797f0e115c736e1a1d7a5f031001cb) 06 July 2015, 16:25:37 UTC
3e85d05 dt_exif_read_blob(): drop Exif.Image.DNGVersion Fixes #10564 (cherry picked from commit 3b7fd79ec7fbad32582e1b374fb862140822b396) 06 July 2015, 15:57:47 UTC
e37d7fc Add wb presets for Panasonic G7/G70 01 July 2015, 20:40:04 UTC
7859285 Support for all the modes of the Panasonic G7/G70 30 June 2015, 20:08:49 UTC
584ea2f get_matrix_from_profile(): if there is a LUT, give up. Fixes #10552 If profile contains only a LUT, we would fall-back to LCMS codepath. If profile contains a matrix + LUT, we would just use matrix in our fast matrix codepath. But, if profile contains a LUT, it might contain a swapped matrix, so some apps (like us right now) would use matrix, and get an image with swapped colors, and some would use LUT and get image with right colors. The matrix in a XYZLUT profile is intended for older outdated CMS implementations and should not be used. Falling back to matrix used to kinda-sorta make sense when our fastpath was an order of magnitude faster than our LCMS2 path, which is no longer true. (pr #495 + pr #509) (cherry picked from commit 199e7316f9dacbf9a9c23fbe8facf6dd6e660400) 30 June 2015, 18:30:34 UTC
c536276 dt_exif_xmp_read(): read & use version of current mask, not first. Fixes #10535 (cherry picked from commit b2219b57bd2bbb56c28db390f3eec9eb2b4dad1e) 28 June 2015, 20:40:18 UTC
4015fdb pentax k3-ii support (cherrypicked from #930 by tomtor) 24 June 2015, 15:54:10 UTC
5ab68b1 rawspeed: Likely fix for 5ds crashes (cherry picked from commit 5c17e1c5f42f2d2c6d40a370e39fd075968be4e9) 24 June 2015, 15:46:19 UTC
3ba1a45 Allows to copy disabled items in partial copy. Fixes #10536 (cherry picked from commit bc88e9f271059752f51b0af335e5f2496a556b22) 23 June 2015, 15:56:23 UTC
c65801a Replace strings with constants for i18n (cherry picked from commit 92b802521ee26457f064364de2adf39f6eb9c6f5) 23 June 2015, 15:55:58 UTC
2c16300 Add full set of 60D white balance presets with fine tuning. (cherry picked from commit 303141d1dae5e01b73255812d759c8b1640bd1b1) 23 June 2015, 15:55:45 UTC
e6c2539 [l10] Swedish update Enhanced the strings for the view accelerator keys 21 June 2015, 08:33:27 UTC
39dacae wb_presets: Panasonic TZ71 20 June 2015, 16:25:04 UTC
8d223a2 Basic support for Panasonic TZ71 20 June 2015, 13:56:46 UTC
9e6fd12 Remove leftover global variable This functionality got removed a LONG time ago in a2fdac3ebcb7fabf503b73a7dd5d15a5c2e68884. (cherry picked from commit 02a50b9b3cc70b013e1e7e1664804de1830f0fdd) 19 June 2015, 15:45:24 UTC
f63aa63 exif: fix clang-3.7 build: std::auto_ptr is deprecated, use std::unique_ptr Same as with imageio_rawspeed: AFAIK apple does not support it, so use #ifdef (cherry picked from commit 470c992aec855d441a0d0d7321e477aa9e2b1232) + fixed dt_exif_thumbnail(), which is different in master 19 June 2015, 12:00:39 UTC
c60fa56 basecurve: replace natural curve with neutral curve 17 June 2015, 18:31:20 UTC
7cb2f18 rawspeed: canon eos m3 crop and black areas 17 June 2015, 17:44:52 UTC
b697346 rawspeed: panasonic dmc-g7 crop 17 June 2015, 17:36:59 UTC
aded559 rawspeed: enable canon eos 5ds (r) 17 June 2015, 17:31:20 UTC
7c26ade rawspeed: ricoh pentax k-s2 17 June 2015, 17:28:33 UTC
ff3d61c adobe_coeff: ricoh pentax k-s2 17 June 2015, 17:16:04 UTC
311d2d0 rawspeed: fujifilm x-t10 17 June 2015, 17:14:54 UTC
dbf4b2b adobe_coeff: fujifilm x-t10 17 June 2015, 17:13:42 UTC
8c5a94e rawspeed: panasonic dmc-g7 (4:3 aspect only) 17 June 2015, 17:08:40 UTC
e4d84ce adobe_coeff: panasonic dmc-g7 17 June 2015, 17:06:31 UTC
1ac2b63 rawspeed: nikon 1 j5 17 June 2015, 17:05:30 UTC
5744dae adobe_coeff: nikon 1 j5 17 June 2015, 17:03:41 UTC
a944ed3 rawspeed: canon eos 5ds 17 June 2015, 17:02:42 UTC
02befd2 adobe_coeff: canon eos 5ds 17 June 2015, 16:59:07 UTC
3953847 rawspeed: canon eos m3 17 June 2015, 16:57:47 UTC
8bf2139 adobe_coeff: canon eos m3 17 June 2015, 16:56:23 UTC
8968883 wb_presets: samsung nx500 (thanks to josef wells) 17 June 2015, 16:51:49 UTC
d04bc96 dt_init(): always g_free() lang setlocale() does not own it afterwards (cherry picked from commit 27b663b206c2bbe8c56dd73155ef821981c75ef3) 17 June 2015, 16:27:02 UTC
92899c2 cltest: do not forget to dt_cleanup() (cherry picked from commit bddaa48d19069a2016bc8c13989cf072ab0db390) 17 June 2015, 16:26:55 UTC
6dc166d LCMS: do not leak curve after cmsWriteTag(h, cmsSigRedTRCTag, curve); cmsWriteTag() duplicates tags data so we can(and should) free our copy. (cherry picked from commit 27aa042c270f05dd00a4348baf21921aba01ef38) 15 June 2015, 15:25:12 UTC
6f78d44 ICC curves: do not write same curves several times, use cmsLinkTag() dt_colorspaces_create_srgb_profile() was using cmsLinkTag() for some time now, and i do not see why others shouldn't. This will result in smaller filesize of generated ICC's. (cherry picked from commit c1a0f33c518cac2da235f8a11da19a5356bee3dc) 15 June 2015, 15:25:06 UTC
4497549 Exif: ignore Exif.CanonCs.LensType if it contains "(0)". Fixes #10528 Try to look for other fields containing lens name. Canon stores lens name in several fields: $ exiv2 -pt 5D.CR2 | grep -ai lens Exif.CanonCs.LensType Short 1 (0) Exif.CanonCs.Lens Short 3 180.0 mm Exif.CanonCf.LensAFStopButton Short 1 2049 Exif.Canon.LensModel Ascii 64 EF180mm f/3.5L Macro USM $ exiv2 -pt 5DMk3.CR2 | grep -ai lens Exif.CanonCs.LensType Short 1 Canon EF 70-200mm f/2.8L IS II USM Exif.CanonCs.Lens Short 3 70.0 - 200.0 mm Exif.Canon.LensModel Ascii 74 EF70-200mm f/2.8L IS II USM Exif.Photo.LensSpecification Rational 4 70/1 200/1 0/1 0/1 Exif.Photo.LensModel Ascii 28 EF70-200mm f/2.8L IS II USM Exif.Photo.LensSerialNumber Ascii 11 0000c26687 In most cases, Exif.CanonCs.LensType will contain needed info, but if it does not, we need to look at other fields. Maybe we should also look at Exif.Photo.LensModel, but without a sample that would cause an issue i do not want to change anything. I have checked, and LensFun seems to be fine with the lens name from Exif.Canon.LensModel (cherry picked from commit 29cae8db2f4b41ef53ed527153abc5561f14de2e) 13 June 2015, 16:14:16 UTC
3fbcb64 rawspeed: better fix for CRW heap-buffer-overflow Seems like klaus did an incorrect change from calloc to malloc Replaces f000d59c8fd741364465ecbb08fb7036c9c7ca58 (cherry picked from commit 9a2c213f299084a7c587f57fb4dc86195448a963) 13 June 2015, 16:13:59 UTC
e2b49f6 CrwDecoder: makeDecoder(): fix heap-buffer-overflow Someone who knows that code, please verify that this is actually the right fix. ================================================================= ==25340==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6190006fc680 at pc 0x7f2f1616a2d8 bp 0x7f2efb9f25f0 sp 0x7f2efb9f25e8 WRITE of size 2 at 0x6190006fc680 thread T6 0 0x7f2f1616a2d7 in RawSpeed::CrwDecoder::makeDecoder(int, unsigned char const*) /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:231 1 0x7f2f1616a349 in RawSpeed::CrwDecoder::initHuffTables(unsigned int) /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:293 2 0x7f2f1616b83d in RawSpeed::CrwDecoder::decodeRaw(bool, unsigned int, unsigned int, unsigned int) /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:311 3 0x7f2f1616c397 in RawSpeed::CrwDecoder::decodeRawInternal() /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:70 4 0x7f2f16143041 in RawSpeed::RawDecoder::decodeRaw() /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/RawDecoder.cpp:648 5 0x7f2f15ee6045 in dt_imageio_open_rawspeed /home/lebedevri/darktable/src/common/imageio_rawspeed.cc:149 6 0x7f2f15ed934d in dt_imageio_open /home/lebedevri/darktable/src/common/imageio.c:916 7 0x7f2f15efac4a in dt_mipmap_cache_get_with_caller /home/lebedevri/darktable/src/common/mipmap_cache.c:621 8 0x7f2f15ed6c31 in dt_imageio_export_with_flags /home/lebedevri/darktable/src/common/imageio.c:536 9 0x7f2f15ef6d38 in _init_8 /home/lebedevri/darktable/src/common/mipmap_cache.c:986 10 0x7f2f15efae20 in dt_mipmap_cache_get_with_caller /home/lebedevri/darktable/src/common/mipmap_cache.c:651 11 0x7f2f15f516c5 in dt_image_load_job_run /home/lebedevri/darktable/src/control/jobs/image_jobs.c:36 12 0x7f2f15f45dff in dt_control_run_job /home/lebedevri/darktable/src/control/jobs.c:274 13 0x7f2f15f4601c in dt_control_work /home/lebedevri/darktable/src/control/jobs.c:472 14 0x7f2f120800a3 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x80a3) 15 0x7f2f0e9a604c in clone (/lib/x86_64-linux-gnu/libc.so.6+0xe604c) 0x6190006fc681 is located 0 bytes to the right of 1025-byte region [0x6190006fc280,0x6190006fc681) allocated by thread T6 here: 0 0x7f2f1635ccab in __interceptor_posix_memalign (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54cab) 1 0x7f2f16123200 in _aligned_malloc(unsigned long, unsigned long) /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/Common.cpp:54 2 0x7f2f1616a191 in RawSpeed::CrwDecoder::makeDecoder(int, unsigned char const*) /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:221 3 0x7f2f1616a349 in RawSpeed::CrwDecoder::initHuffTables(unsigned int) /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:293 4 0x7f2f1616b83d in RawSpeed::CrwDecoder::decodeRaw(bool, unsigned int, unsigned int, unsigned int) /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:311 5 0x7f2f1616c397 in RawSpeed::CrwDecoder::decodeRawInternal() /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:70 6 0x7f2f16143041 in RawSpeed::RawDecoder::decodeRaw() /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/RawDecoder.cpp:648 7 0x7f2f15ee6045 in dt_imageio_open_rawspeed /home/lebedevri/darktable/src/common/imageio_rawspeed.cc:149 8 0x7f2f15ed934d in dt_imageio_open /home/lebedevri/darktable/src/common/imageio.c:916 9 0x7f2f15efac4a in dt_mipmap_cache_get_with_caller /home/lebedevri/darktable/src/common/mipmap_cache.c:621 10 0x7f2f15ed6c31 in dt_imageio_export_with_flags /home/lebedevri/darktable/src/common/imageio.c:536 11 0x7f2f15ef6d38 in _init_8 /home/lebedevri/darktable/src/common/mipmap_cache.c:986 12 0x7f2f15efae20 in dt_mipmap_cache_get_with_caller /home/lebedevri/darktable/src/common/mipmap_cache.c:651 13 0x7f2f15f516c5 in dt_image_load_job_run /home/lebedevri/darktable/src/control/jobs/image_jobs.c:36 14 0x7f2f15f45dff in dt_control_run_job /home/lebedevri/darktable/src/control/jobs.c:274 15 0x7f2f15f4601c in dt_control_work /home/lebedevri/darktable/src/control/jobs.c:472 16 0x7f2f120800a3 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x80a3) Thread T6 created by T0 here: 0 0x7f2f1632bbca in pthread_create (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x23bca) 1 0x7f2f15f46f77 in dt_control_jobs_init /home/lebedevri/darktable/src/control/jobs.c:498 2 0x7f2f15f3866f in dt_control_init /home/lebedevri/darktable/src/control/control.c:327 3 0x7f2f15e84900 in dt_init /home/lebedevri/darktable/src/common/darktable.c:808 4 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24 5 0x7f2f0e8e1b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44) SUMMARY: AddressSanitizer: heap-buffer-overflow /home/lebedevri/darktable/src/external/rawspeed/RawSpeed/CrwDecoder.cpp:231 RawSpeed::CrwDecoder::makeDecoder(int, unsigned char const*) Shadow bytes around the buggy address: 0x0c32800d78c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 =>0x0c32800d78d0:[01]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa ==25340==ABORTING (cherry picked from commit f000d59c8fd741364465ecbb08fb7036c9c7ca58) 13 June 2015, 16:13:50 UTC
6261f86 LensModel read from Xmp.exifEX.LensModel This fixes #10525. (cherry picked from commit e78a04832641fa017da6c10dd1fff750bec94941) 13 June 2015, 16:13:39 UTC
3905cfe Only set Pixel[XY]Dimension for compressed images (cherry picked from commit eb750e6ae1b54390062816c98423941d37bf400b) 11 June 2015, 11:30:53 UTC
70adac6 Fix crash in finalization in non GUI mode. When calling darktable-cli there is no gui. The bauhaus is not initialized in dt_init() but cleanup was called in dt_cleanup(). (cherry picked from commit e18b9cf74066e55610e39267a0c02680b7ecbfe1) 11 June 2015, 11:00:30 UTC
d78da9e [noiseprofiles] Sony ILCE-5100 & Fujifilm HS50EXR Both profiles provided by Mat 10 June 2015, 09:10:00 UTC
46f7e10 rawspeed: add leica vlux1 4:3 aspect ratio mode 09 June 2015, 17:52:29 UTC
44acced clip&rotate: fix bug in flip function, fix for #10511 Due to rounding issues the old flipping code would lead to an undefined (1px black) line at one or two of the image borders - the image is shifted by one pixel relative to its buffer. With this fix images are now correctly positioned in the buffer, however, this leads to a -1px offset versus the old code. I would call it a bug fix without the need to deal with legacy history stacks. and/or bottom border (cherry picked from commit afc5e397d97c75968a6ca3c622314e30d29c0147) 09 June 2015, 17:13:50 UTC
f9e4105 Clipping IOP: custom aspect ratio: fix insane(?) sanity check I can not see anything wrong with negative dividers in aspect ratio... FIXME: why was it <= ? (cherry picked from commit d8180bc9233658b22d630e42db39e6921cce48d8) Conflicts: src/iop/clipping.c 09 June 2015, 17:13:16 UTC
8de931b Basic support for the Fuji F600EXR based on 094e251f3dc87001bb888242668b97507f63439e by pedrocr 07 June 2015, 09:40:16 UTC
e21d830 rawspeed: add nikon d7200 12bit compressed mode 06 June 2015, 09:42:40 UTC
4f2072e [l10n] Update Spanish translation 05 June 2015, 17:15:55 UTC
a3a10fb wb_presets: nikon coolpix p340 (thanks to davide alberelli) 04 June 2015, 15:55:18 UTC
6135327 OSX: disable display profile detection for OS X 10.10 (cherry picked from commit 02a3e6d99a619535f5f64e16ad7aefb1648cb6d9) 02 June 2015, 18:33:00 UTC
f1016e6 rawspeed: experimental nikon coolpix p340 support 02 June 2015, 16:37:37 UTC
eb3fafa adobe_coeff: nikon coolpix p340 02 June 2015, 16:31:54 UTC
534486c basecurve: update D90 curve with a smoother and more natural version (cherry picked from commit 986d8ea51b6e25dd8a758123bb4a9eeedaba4fc8) 02 June 2015, 16:26:26 UTC
6d2b55e tonecurve: add D90 curve to presets (cherry picked from commit 28818b1fa9f997f687752b680d8f8aab82225705) 02 June 2015, 16:26:19 UTC
c892fa4 gradient masks: fix for #10505 (cherry picked from commit 5ecff57ff048da759d4e8da350f8fd57d9cc8056) 02 June 2015, 16:25:37 UTC
70d72ae wb_presets: olympus e-m10 update (stolen from ufraw) 30 May 2015, 14:06:41 UTC
5653956 Revert "fix global toolbox being populated each time darkroom was entered" This reverts commit f62dc2d59dd6f09f5a4cda38fb874619aa447ade. 30 May 2015, 13:59:22 UTC
3104923 [noiseprofiles] Add Nikon D7200 Profiles provided by Ralf Brown 27 May 2015, 19:14:41 UTC
478b5ad fix caps in basecurve/tonecurve 27 May 2015, 18:23:10 UTC
3d62afb tonecurve: nikon d7200 27 May 2015, 18:21:19 UTC
a3d71cf basecurve: nikon d7200 27 May 2015, 18:17:28 UTC
3d751da tonecurve: filter out non matching model curves (cherry picked from commit d2b212c10c89c501cd6350136cac865249f0c4a0) 27 May 2015, 18:11:39 UTC
62566c5 tonecurve: add NIKON D750 entry (cherry picked from commit ce2c5cbb829bbbbcd078aeda28793916fa1884f7) 27 May 2015, 18:11:31 UTC
3bde4a0 tonecurve: add NIKON D7000 entry (cherry picked from commit 54409f4d08b0575fcdcc041b602d17347b16c317) 27 May 2015, 18:11:22 UTC
cae764b tonecurve: filter presets with maker/model/iso metadata (cherry picked from commit 0729aec7277a7b10fc588ff9dfe79cebc6fee8a1) 27 May 2015, 18:11:14 UTC
7581926 tonecurve: rename preset array and prevent clang-format from formatting the presets (cherry picked from commit 5556ff4c6b19271c2e763256216aed56ea0e6a05) 27 May 2015, 18:11:04 UTC
09737d4 basecurve: add NIKON D750 entry (cherry picked from commit f35db8436ee23d350f52ec0b550f9f647bf2c2a3) 27 May 2015, 18:10:03 UTC
7a0454e basecurve: add NIKON D7000 entry (cherry picked from commit 44d3b62dcbf4434cf97a44da5b0b0ce98221a9f1) 27 May 2015, 18:09:51 UTC
02b7705 rawspeed: panasonic dmc-g5 remaining aspect ratios 27 May 2015, 18:05:44 UTC
8f98247 [Bug #9017] Fix output of embedded preview in Pentax (k-x) DNG (cherry picked from commit 453f2a51bb9066360440d1da42eed1e93ec631c4) 27 May 2015, 17:07:47 UTC
3648f9a There's no "username" in new Facebook APIs The "username" got removed somewhere in the 2.x Graph API version history. Given that we don't actually need it for anything but showing the current account to the user, let's just replace it with the human-readable name of the current account. (cherry picked from commit 075bfdcad84beba534edef04bf989470be542a7a) 27 May 2015, 17:07:40 UTC
caa823c dt_opencl_init(): results of dt_conf_get_string() should be g_free()'d Direct leak of 11 byte(s) in 1 object(s) allocated from: #0 0x7f5b4e4f474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f) #1 0x7f5b4ba8f799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799) #2 0x7f5b4baa812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e) #3 0x7f5b4e0c4841 in dt_conf_get_string /home/lebedevri/darktable/src/control/conf.h:195 #4 0x7f5b4e0c4841 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:524 #5 0x7f5b4e01c6c5 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839 #6 0x400dd3 in main /home/lebedevri/darktable/src/cltest/main.c:27 #7 0x7f5b46871b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44) #8 0x400c68 (/usr/local/bin/darktable-cltest+0x400c68) (cherry picked from commit ed88970f789d2986dd7dfa1f1ad9121b730f7b11) 27 May 2015, 17:07:31 UTC
8d6faca Result of dt_loc_get_home_dir() should be g_free()'d at the end. Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x7f95987e474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f) #1 0x7f9595d7f799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799) #2 0x7f9595d9812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e) #3 0x7f95983365df in dt_loc_get_home_dir /home/lebedevri/darktable/src/common/file_location.c:41 #4 0x7f95983988f7 in dt_util_fix_path /home/lebedevri/darktable/src/common/utility.c:198 #5 0x7f95983364d1 in dt_loc_init_generic /home/lebedevri/darktable/src/common/file_location.c:84 #6 0x7f9598336894 in dt_loc_init_user_cache_dir /home/lebedevri/darktable/src/common/file_location.c:161 #7 0x7f959830a9da in dt_init /home/lebedevri/darktable/src/common/darktable.c:701 #8 0x400dd3 in main /home/lebedevri/darktable/src/cltest/main.c:27 #9 0x7f9590b61b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44) #190 0x400c68 in _start ??:? (cherry picked from commit 5b5477cfe09c93d7c46d2413c6f53793965f16ac) 27 May 2015, 17:07:23 UTC
a6ca448 IOP headers: issue redraw once iop is toggled. Else, after user has toggled iop, correct status (on/off) would show up only after user moves the mouse. Similar to cc98a6e6b84649722bbfc8e19a9ccec677801228 (cherry picked from commit d728b2d142b1978dccdcda95c78941b3cf7b2320) 27 May 2015, 17:07:14 UTC
800c0ac Modules: ignore double and triple-clicks. Else module would collapse if you double-click on e.g. reset or toggle (cherry picked from commit 63209fdcf08ffc7bbd6b61eee9b0e9f0191f01a8) 27 May 2015, 17:07:00 UTC
9389323 dt_opencl_cleanup(): free device name and cname Direct leak of 7 byte(s) in 1 object(s) allocated from: #0 0x7f51f2483327 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x33327) #1 0x7f51f2072da1 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:317 #2 0x7f51f1fcc605 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839 #3 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24 #4 0x7f51ea821b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44) Direct leak of 7 byte(s) in 1 object(s) allocated from: #0 0x7f51f24a474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f) #1 0x7f51f2060618 in _ascii_str_canonical /home/lebedevri/darktable/src/common/opencl.c:858 #2 0x7f51f2072e00 in dt_opencl_init /home/lebedevri/darktable/src/common/opencl.c:318 #3 0x7f51f1fcc605 in dt_init /home/lebedevri/darktable/src/common/darktable.c:839 #4 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24 #5 0x7f51ea821b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44) (cherry picked from commit 654b352e9bab83c219a2211fbb3831733bb6c857) 27 May 2015, 17:06:36 UTC
b886564 Bauhaus: fix some leaks related to autocompleteon lists Fixes a LOT of LeakSanitizer-detected leaks like: Direct leak of 1298 byte(s) in 39 object(s) allocated from: #0 0x7f293d4d474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f) #1 0x7f293aabf799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799) #2 0x7f293aad812e in g_strdup (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x6812e) #3 0x7f293d00f49a in dt_bauhaus_widget_set_label /home/lebedevri/darktable/src/bauhaus/bauhaus.c:849 #4 0x7f293d15931b in dt_iop_gui_init_blending /home/lebedevri/darktable/src/develop/blend_gui.c:1797 #5 0x7f293d10be91 in dt_iop_gui_get_expander /home/lebedevri/darktable/src/develop/imageop.c:1847 ... (cherry picked from commit a7fc7697b9539f3bac2889614fe3b2f1768775fb) 27 May 2015, 17:06:21 UTC
9f72fd5 Do not forget to call cairo_pattern_destroy() after cairo_pattern_create_linear() Fixes LeakSanitizer-detected leaks like: Direct leak of 2640 byte(s) in 10 object(s) allocated from: #0 0x7f4541e9474f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f) #1 0x7f45408610f6 in cairo_pattern_create_linear (/usr/lib/x86_64-linux-gnu/libcairo.so.2+0x510f6) #2 0x7f4541ba56e0 in dtgtk_cairo_paint_modulegroup_color /home/lebedevri/darktable/src/dtgtk/paint.c:1353 #3 0x7f4541ba7cf9 in _togglebutton_draw /home/lebedevri/darktable/src/dtgtk/togglebutton.c:138 (cherry picked from commit 4d7416408dc85bb8b5a104ffa49d82b17f559e28) 27 May 2015, 17:06:13 UTC
9bf3f99 Accels: properly handle accels in dt_accel_deregister_{iop,lib}() Fixes following issue: (refs #10455, comment 3) 1. Open image in DT 2. change exposure 3. create preset Each accel in accel_closures_local, accel_closures and accelerator_list points to the same memory, so we must free it only once, when no other list contains it and when no longer needed - when deleting from accelerator_list AddressSanitizer: heap-use-after-free on address 0x61800054ec80 at pc 0x7fc58932f178 bp 0x7ffd083407a0 sp 0x7ffd08340768 READ of size 1 at 0x61800054ec80 thread T0 #0 0x7fc58932f177 in strncmp (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x37177) #1 0x7fc589065042 in dt_accel_deregister_iop /home/lebedevri/darktable/src/gui/accelerators.c:730 #2 0x7fc589065db3 in dt_accel_rename_preset_iop /home/lebedevri/darktable/src/gui/accelerators.c:848 #3 0x7fc5890a8f56 in edit_preset_response /home/lebedevri/darktable/src/gui/presets.c:295 ... 0x61800054ec80 is located 0 bytes inside of 784-byte region [0x61800054ec80,0x61800054ef90) freed by thread T0 here: #0 0x7fc58934c537 in __interceptor_free (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54537) #1 0x7fc589064fb1 in dt_accel_deregister_iop /home/lebedevri/darktable/src/gui/accelerators.c:719 #2 0x7fc589065db3 in dt_accel_rename_preset_iop /home/lebedevri/darktable/src/gui/accelerators.c:848 #3 0x7fc5890a8f56 in edit_preset_response /home/lebedevri/darktable/src/gui/presets.c:295 #4 0x7fc586c0a567 in g_cclosure_marshal_VOID__INTv (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x12567) previously allocated by thread T0 here: #0 0x7fc58934c74f in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x5474f) #1 0x7fc586937799 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4f799) #2 0x7fc5890a7cb5 in menuitem_new_preset /home/lebedevri/darktable/src/gui/presets.c:663 #3 0x7fc586c082d4 in g_closure_invoke (/usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0+0x102d4) (cherry picked from commit d24d1310331a5b53f9a478809d7d4eed6c472f01) 27 May 2015, 17:06:04 UTC
791d382 dt_control_cleanup(): implement and call dt_control_jobs_cleanup() TODO(?): move some cleanup code into this new function? Might help with current hang on quit if main window is not in focus. Fixes following LeakSanitizer-detected leak: Direct leak of 64 byte(s) in 1 object(s) allocated from: #0 0x7f2cccb04895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895) #1 0x7f2ccc712314 in dt_control_jobs_init /home/lebedevri/darktable/src/control/jobs.c:488 #2 0x7f2ccc703b45 in dt_control_init /home/lebedevri/darktable/src/control/control.c:319 #3 0x7f2ccc66e107 in dt_init /home/lebedevri/darktable/src/common/darktable.c:808 #4 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24 #5 0x7f2cc4ed9b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44) (cherry picked from commit 8291a1e7cde3e326392ed7d94e5dd3f1cc640883) 27 May 2015, 17:05:56 UTC
44bdd5e picasa_api_destroy(): do call curl_easy_cleanup() I see no segfault, not in picasa.c nor in facebook.c, so it must have been fixed already. Fixes following LeakSanitizer-detected leak: Direct leak of 36032 byte(s) in 1 object(s) allocated from: #0 0x7fe413b94895 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.1+0x54895) #1 0x7fe40f1b5319 (/usr/lib/x86_64-linux-gnu/libcurl-gnutls.so.4+0x1d319) #2 0x7fe40f1c4a03 in curl_easy_init (/usr/lib/x86_64-linux-gnu/libcurl-gnutls.so.4+0x2ca03) #3 0x7fe3ee78850b #4 0x7fe3ee78c10e #5 0x7fe4137589d3 in dt_imageio_load_modules_storage /home/lebedevri/darktable/src/common/imageio_module.c:306 #6 0x7fe413758b05 in dt_imageio_init /home/lebedevri/darktable/src/common/imageio_module.c:321 #7 0x7fe4136fe91f in dt_init /home/lebedevri/darktable/src/common/darktable.c:875 #8 0x400cb8 in main /home/lebedevri/darktable/src/main.c:24 #9 0x7fe40bf69b44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44) #10 0x400bd8 (/usr/local/bin/darktable+0x400bd8) (cherry picked from commit dd033299bde21eacd949443df5541109f4207ed8) 27 May 2015, 17:05:46 UTC
back to top