swh:1:snp:c7c108084bc0bf3d81436bf980b46e98bd338453

sort by:
Revision Author Date Message Commit Date
c59e18c Fix handling of integer preference parameters Before this commit, the code did: int max = G_MAXINT; /* INT_MAX, 2147483647 */ float factor = 1.0f; max *= factor; Dimitry Andric helped me understand the problem; here is the explanation: Here, "max * factor" is 2147483648.0, not 2147483647.0: the value is rounded up because the float type has a mantissa of 23 bits only. However, converting 2147483648.0 to an integer is an undefined behaviour. The resulting value depends on the compiler and the level of optimization: GCC (all versions) with -O0: max = -2147483648 GCC (all versions) with -O2: max = 2147483647 Clang up-to 3.5 with -O0: max = -2147483648 Clang up-to 3.5 with -O2: max = 2147483647 (ie. same behaviour as GCC) Clang 3.6+ with -O0: max = -2147483648 Clang 3.6+ with -O2: max = 0 In the context of the preferences dialog, this means that all integers must be between min=0 and max=0. The fix, suggested by Dimitry, is to use a double as an intermediate variable: it is wide enough to store "max * factor" without rounding up the value. Then, 2147483647.0 can be converted to 2147483647. (cherry picked from commit 9d77a28e54f8bc19592a170b1e4b9cf083f7b5a3) 18 April 2015, 15:44:20 UTC
6bc644e Make --g-fatal-warnings work again The clean solution would be to rely on the glib argv parser to remove its arguments, but that would require a bigger refactoring of our init system with potential bugs. So this is the not-so-nice-but-safe solution. (cherry picked from commit 53711cc540bbeb7b1f36bfecf2131c5cce7fb53b) 15 April 2015, 15:43:39 UTC
1ddc1b2 rawspeed: fix two more clang warnings (cherry picked from commit 1c7fea09db4e56bee69688948792b1053418e1ef) 15 April 2015, 15:43:30 UTC
56570a3 rawspeed: cleanup convuluted ARW "decrypt" code (cherry picked from commit fae7b46d6aa91bea268cfc3ae778a3e43f8f2455) 13 April 2015, 15:52:31 UTC
d26a8d3 Sync new cameras from klaus New cameras are the Canon M2, Canon 5DS R, Nikon 7200, Panasonic CM1 (3:2 mode only) and Sigma dp2 quattro (disabled for now) (cherry picked from commit ec7a6dc8e74008378e8dd6c7ed1f7e819a99be53) 12 April 2015, 21:46:00 UTC
1dac463 rawspeed: fix typo in function prototype (cherry picked from commit f602fb6563d665a07920f458bdf49e28d5eccd35) 12 April 2015, 18:35:52 UTC
1470482 rawspeed: Hints for ORF uncompressed cameras (cherry picked from commit 2a1f3876e755a5501daf17571a739ee3913ac7ee) 12 April 2015, 18:20:45 UTC
991c3c1 rawspeed: cleanup the ORF decompressed code path (cherry picked from commit 6a88a12b3375310dcd033a268e8bcaa5853c4191) 12 April 2015, 18:20:38 UTC
2f80dac rawspeed: merge in changes from klaus Small fixes and decoding support for the Sigma dp2 quattro and the Canon 5DS R (neither currently enabled) (cherry picked from commit 960e9205ea7fc8a02aa3c467ac6bb03011ee9a4f) 12 April 2015, 18:20:30 UTC
a30e1f1 rawspeed: fix the Olympus E330 decoding (cherry picked from commit dcba6657df861a8847d0b8b203d52055b0c1a3ca) 11 April 2015, 10:49:39 UTC
8ad973a Unlink after removing image otherwise we can't remove local copies. If a local copy existed it was not possible to delete it as the file was deleted first, and so the resync was not done as the original file was not found (thinking the original was not accessible). (cherry picked from commit 8f4b6b66a53066dff7a1727ca5e5c720a4339fbb) 10 April 2015, 16:29:59 UTC
475f6d9 masks: minor code cleanup (cherry picked from commit 9750ea7e4e246a264ccea303296ebf16b3b0225a) 08 April 2015, 21:28:14 UTC
6846042 masks: prevent access to uninitialized dynamic buffer in path shape TODO: add checks for brush shape (cherry picked from commit 6c6863fb0c649e67b063c20fd1e92ec886dd0523) 08 April 2015, 21:28:11 UTC
dfb27d2 wb_presets: RICOH GR (thanks to Dan Tableau) 08 April 2015, 17:00:01 UTC
fb9b365 masks: little refactoring (cherry picked from commit 1c609354615924cedd45851358fa99a84de8122a) 08 April 2015, 16:46:31 UTC
4aed941 Import lib: fix regression from last commit filename could be NULL when selecting a bookmark in a file selector Reported by <andabata> (cherry picked from commit fe4b6c234330d07db69992758ac082216ec8c19c) 08 April 2015, 12:48:33 UTC
ec82d63 gdk_pixbuf_new_from_inline() is deprecated since version 2.32. Fixes #10412 (cherry picked from commit 30ffbc2e15f136a42e55b018246823bce25c6403) Conflicts: src/libs/import.c Difference from original commit: gdk_pixbuf_get_from_surface() is only awaliable in GTK+-3, and darktable-1.6.x is GTK+-2, so the solution to solve this with minimal effort that i choose was to copy the needed functions... 08 April 2015, 12:42:54 UTC
28b8c18 rawspeed: bandaid for ORF uncompressed cases This needs a cleanup, ORF has several slightly different uncompressed cases and the code for them is a mess right now (cherry picked from commit b82d2c08afac4cf98df151cec89e82056049238b) 07 April 2015, 09:47:22 UTC
8323092 masks: use dynamic buffering in path shape (cherry picked from commit bb69826c51b8e4b69f6764a2acc4031dee5452c7) 06 April 2015, 17:02:24 UTC
2f5fd27 denoise profiled: eliminate useless calculation of mean_y from OpenCL codepath (cherry picked from commit 072b4296411aeacfe33231d9b90e8023caf5ee78) 06 April 2015, 17:00:47 UTC
99e1002 Fix WB for Canon Powershot SX50 HS (cherry picked from commit 51ed0099a5418125c8ccca5cbc7ea31e37e62561) 06 April 2015, 17:00:38 UTC
1bb8567 Lens iop: enhance "corrections done" message. Refs #9736 (cherry picked from commit f8ec4fc23e2c01789e36fbda85eb785f5bec421e) 06 April 2015, 17:00:29 UTC
0f55b8c Fix clang build 03 April 2015, 13:59:08 UTC
dda16ae fix last fix of a fix 03 April 2015, 12:55:53 UTC
9f036bd fix last fix (cherry picked from commit 8c86ba4d4e48403337579bd1454ce570340bd215) 03 April 2015, 12:52:51 UTC
247424e fix bug #10404, error handling in dt_opencl_init is a mess (cherry picked from commit 469dd5922d356dc7b27bf5fb2821e41382d2f837) 03 April 2015, 12:30:33 UTC
fe44f37 rawspeed: more olympus e-m5 finetuning 02 April 2015, 18:57:18 UTC
77f7953 rawspeed: e-m5 finetuning 02 April 2015, 18:26:04 UTC
4a45535 masks, dynamic buffer: avoid double-buffering and prevent potential mem leak (cherry picked from commit 557094851fdedbae44346ad4d985fe0658c8e6c7) 02 April 2015, 18:13:06 UTC
290aedc Add easter calculation (cherry picked from commit 1bf55371a5b94aca0a2ea2884165c764e7a18cda) 01 April 2015, 18:32:03 UTC
8710f07 wb_presets: Fujifilm X-E2 (thanks to Paul Herbert) 01 April 2015, 16:08:17 UTC
d64a2f2 wb_presets: Olympus E-M5 Mark II (thanks to Brandon Zehm) 01 April 2015, 16:04:39 UTC
ab197ad masks: make sure that assert.h is included in masks.h (cherry picked from commit 898b72057d665a3aeefc155d0c17a53efaef6047) Conflicts: src/develop/masks.h 01 April 2015, 15:53:10 UTC
a8ca965 update of dutch translations 01 April 2015, 09:41:34 UTC
cccb809 Spots iop: process(): do not leak mask mem if Found by Coverity (cherry picked from commit 6d044e81e7f12afbc73509caafbc46d692eb1e1a) 31 March 2015, 16:07:32 UTC
94d2a5e Address review comments (cherry picked from commit e0145afcc70af1f71d0dc2b2f8e3e8de72112832) 31 March 2015, 16:07:25 UTC
1e47efc Spots IOP: finally fix "black/white stripe" when source is [partially] outside of image. (cherry picked from commit 6f3f5452210427a851c463f4009086596438edd4) 31 March 2015, 16:07:18 UTC
a01b10d Spots IOP: refactor some code into masks_form_is_in_roi() FIXME: fix "black/white stripe" when source is [partially] outside of image. (cherry picked from commit 1b0e02f1c813e5c0260201c75debd23abe2c6c36) 31 March 2015, 16:07:10 UTC
cd2b074 Spots IOP: refactor process(), use dt_dev_distort_transform_plus() This is absolutely required due to "raw cropping" (cherry picked from commit 94dbc0851f9382ba9d459c83dc193ef4e52e39fc) 31 March 2015, 16:07:03 UTC
a11d5bd dt_masks_dynbuf_add(): prevent null pointer dereferencing Found by Coverity (cherry picked from commit 66c37e151499ed83359d50c5242f8708e5d83297) 31 March 2015, 16:05:44 UTC
0aad92e masks: use dynamically growing buffers in brush shape; hopefully fixes #10349 (cherry picked from commit 4761c6c33e9f457dfe27f73df654e20cef8075b2) 29 March 2015, 17:21:29 UTC
f924199 Zonesystem iop: issue redraw once number of zones has changed Else, after user has scrolled, correct number of zones would show up only after user moves the mouse. (cherry picked from commit cc98a6e6b84649722bbfc8e19a9ccec677801228) 29 March 2015, 17:21:22 UTC
aad2fea Merge pull request #882 from pryds/darktable-1.6.x Updated Danish translation 28 March 2015, 17:15:48 UTC
3b4e5ad Merge pull request #884 from josepvm/darktable-1.6.x Updated Catalan translation for 1.6.x branch 28 March 2015, 16:27:43 UTC
bb5f009 [l10n] Update of Japanese translation 28 March 2015, 16:25:25 UTC
04694c7 Updated Catalan translation for 1.6.x branch 28 March 2015, 11:18:27 UTC
56abbc1 Updated Danish translation 28 March 2015, 08:18:53 UTC
c18a838 Update Russian translation 28 March 2015, 02:18:17 UTC
cdf593a Update French translation. 27 March 2015, 23:28:49 UTC
ed25f6e [l10n] Update German translation 27 March 2015, 20:37:47 UTC
c79b9d4 Free some more memory (using the correct free) (cherry picked from commit 32236006147bce7ed2d8b512ba44c8277addd2f2) 27 March 2015, 19:14:22 UTC
008aa5f Fix some minor memleaks (cherry picked from commit d680f73f2f58cec51025a2a1706d0c91e3d460b6) 27 March 2015, 19:13:19 UTC
6102c3f Disconnect from signals when leaving (export lib) (cherry picked from commit 9214b54542cefe39f29b572c66a87f94d746d99a) Conflicts: src/libs/export.c 27 March 2015, 19:12:19 UTC
3083039 Update export style list when styles got changed This fixes #10387. (cherry picked from commit 5ac21627e5b3be9b467e24df7a170919a8093b42) Conflicts: src/libs/export.c 27 March 2015, 19:06:21 UTC
bc5a078 Fix small memleak (cherry picked from commit 345706a10d475ec76ea176e6e7c7cbcef51dcbb2) Conflicts: src/libs/print_settings.c 27 March 2015, 18:50:31 UTC
7994c26 adobe_coeff: proper nikon d800e match 27 March 2015, 17:40:50 UTC
7c7c286 Disconnect from more signals (cherry picked from commit a38203ca639791cdd0d79bcebf077e4b7db714de) 27 March 2015, 17:07:54 UTC
7018eab Ellipsize lib/iop titles + full title in tooltip (cherry picked from commit 4a16497c522631d17f4753349ea606892e16a052) 27 March 2015, 17:07:06 UTC
9a20b50 Noise profiles for Canon EOS 7D Mark II Manually picked from 71ff469fd9291ef41ba3b07e32055b8f6a516014 26 March 2015, 20:05:06 UTC
e083bfa http server: drop unneeded check for SOUP_MAJOR_VERSION It was only there to guard SOUP_CHECK_VERSION (and someone reported it to work) (cherry picked from commit 11e676684c6c25e64cf562d6e2f2af35adf76470) 26 March 2015, 18:41:39 UTC
867e9ed Merge branch 'darktable-1.6.x' of https://github.com/darktable-org/darktable into darktable-1.6.x 26 March 2015, 18:39:21 UTC
55f1b3e http server: SOUP_CHECK_VERSION was introduced in 2.42 Fixes build on some ancient systems (e.g. ubuntu 12.04) With previous versions, compilation fails with the following message: darktable/src/common/http_server.c:27:56: error: missing binary operator before token "(" #if !defined(SOUP_MAJOR_VERSION) || !SOUP_CHECK_VERSION(2, 48, 0) 26 March 2015, 18:26:38 UTC
9dbab2b Interpolate mask border width for new nodes This fixes #10377. (cherry picked from commit 9c489d78af6ef6118d8d5dadbad9bdc961e4315e) 26 March 2015, 17:16:53 UTC
997dede Fix #10383: Initialize tag list for current image (cherry picked from commit fa2201546b9571adadb8d70fe7ad5ad980b90d52) 26 March 2015, 17:16:41 UTC
68bf1e6 Fix a small memleak in tethering (cherry picked from commit 159794d99fa9e0af1a28e8cab30a7403ff4a6862) 26 March 2015, 17:16:32 UTC
04a4fb2 wb_presets: NIKON D7200 (thanks to Ralf Brown) 25 March 2015, 17:22:55 UTC
5d4e838 rawspeed: OLYMPUS E-M5 Mark II support 25 March 2015, 17:15:40 UTC
9e53fee rawspeed: NIKON D5500 support 25 March 2015, 17:12:50 UTC
cc86637 adobe_coeff: OLYMPUS E-M5 Mark II support 25 March 2015, 17:02:36 UTC
74a5fff adobe_coeff: NIKON D5500 support 25 March 2015, 17:01:20 UTC
b6aa744 Lens IOP: process() do not even try to compute if coords are NAN/INF. Refs #10344 LensFun can return NAN coords, so we need to handle them carefully. (cherry picked from commit 7e162aa20e47efdae43e4a1fc7423fd604ee6e9f) 25 March 2015, 16:51:07 UTC
9f0a437 Lens IOP: modify_roi_in(): do not request too much. Refs #10344 LensFun can return NAN coords, so we need to handle them carefully. (cherry picked from commit e20f6f1389ff28445255249ee8f051527cd99f1a) 25 March 2015, 16:50:56 UTC
da86219 Bilateral: dt_bilateral_slice(): do not clamp L. Refs #10320 Syncs native and OpenCL codepaths. (slice kernel was not clamping) (cherry picked from commit 414b7a2c868cada039d14c9d251006d5bcb2626f) 24 March 2015, 16:55:02 UTC
8c8915a export: drastically increase max export dimensions @tatica requested export to 12k, so i figure 2^16-1 should be enough for everyone. (also, nice trick to test/check tiling!) based on 00548a9d77fef6e394877989684f35479831be12 by LebedevRI 22 March 2015, 11:31:05 UTC
fcc9ac8 Enhance ui_last/gui_language If the locale specified in that variable does not exist in LANGUAGE env variable, nothing happens. So we need to make sure that it does exist there... (cherry picked from commit c62951c15ffcfbf8dd4f94f2a43cd41e87c00870) 21 March 2015, 17:56:36 UTC
9e4f109 [l10n] Swedish update 21 March 2015, 14:15:02 UTC
ddfe9df adobe_coeff: experimental samsung nx500 support 20 March 2015, 17:14:38 UTC
875e9d2 rawspeed: experimental samsung nx500 support 20 March 2015, 17:14:16 UTC
1c8216d opencl: shorter slow gpu message 19 March 2015, 17:25:19 UTC
22a34b6 opencl: fix potential mem leak in last commit (cherry picked from commit 1355562cf536486bd4e195bbdbd1ee88864386a3) 19 March 2015, 17:20:24 UTC
2cd1e90 clipping: ensure that all values are computed in distort fct (cherry picked from commit 3bf3b3a48420389c8180bacf647b5d0bff71723c) 18 March 2015, 18:52:13 UTC
7538d5b lock history_mutex before processing distort fct (cherry picked from commit a62043b8112f249f24de9a77946056518e850e01) 18 March 2015, 18:52:05 UTC
88a4943 opencl: de-activate opencl in case GPU is slower than CPU when darktable sees an new config file or if the OpenCL setup (GPUs) has changed we do a simple benchmarking test. If the fastest GPU is not clearly ahead of the CPU we de-activate OpenCL. user can always activate it again in the preferences dialog. rationale: avoid that a slow GPU negatively affects experience of users who are unaware of that fact. (cherry picked from commit ffe96c68aab08ebb90fb2106e330b2cd9e1abafb) 18 March 2015, 17:01:26 UTC
44f2b8d Fix support for Olympus Stylus1 in all fw versions (cherry picked from commit e3ef46cda67b54dd67e5466e6279d12ef9a70c70) 17 March 2015, 17:23:35 UTC
586d2cc lua : update internal copy to latest release 5.2.4 (cherry picked from commit 64af314d583e474c846ec7902b4f643adacd6fb5) 16 March 2015, 16:51:02 UTC
fb2708e update visible copyright info 15 March 2015, 15:59:14 UTC
7ff2001 Fix build with old libsoup versions (cherry picked from commit 13c11fb53b2e42ec65221c86b574c36520116d5a) 15 March 2015, 15:45:17 UTC
ff2d380 Use a tiny HTTP server for facebook logins The story is long and boring, bottom line being that facebook is smarter than everyone else and excel at creating software that is easy to interface to. (cherry picked from commit 5771b212ead6957a60dcf1722becbb973d28cad7) Conflicts: src/imageio/storage/facebook.c 15 March 2015, 15:45:09 UTC
2819f6d facebook: make the module redirect to localhost Redirecting to the default Facebook URL is no longer working unless we get the browser to be able to capture the URL. Redirecting to localhost will show a 404 message in the user's browser, but will have the URL with the auth token in it. (cherry picked from commit 6803c8fb7ecdacdb50f7c1b64ef7fceb5c563bf2) 15 March 2015, 15:41:16 UTC
4dc79d9 Update the exporter guis in the gui thread (cherry picked from commit 2a5604820a3bcd8f1deb141b94785f90f8d068c9) 15 March 2015, 15:40:04 UTC
c8c7718 Canon PowerShot G7 X: fix white balance reading (cherry picked from commit 4231f0ae3e64269e37c064bf440eb0fa259861b5) 13 March 2015, 20:33:15 UTC
41f5842 Remove pre_applied_wb as rawspeed reverses it now (cherry picked from commit 9384f413eb6b7850d6f131acf4be3ccb6d4408cd) Conflicts: src/common/image.h 09 March 2015, 16:56:36 UTC
62f5bdc dt_mipmap_cache_release(): do not assert that enum with minimal value of 0 is >= 0 Fixes gcc-4.6/4.7 build in debug mode. (cherry picked from commit 77ccd2c84224c541379d9fcc7e21a1daa53f6ce1) 09 March 2015, 16:50:12 UTC
14c1875 CMakeLists: no -Og for gcc <= 4.8 (cherry picked from commit 9cb53acd1a5885837b5af696322dd2dbe31e9e54) 09 March 2015, 16:50:05 UTC
4869f0b CMakeLists: disable Debug build type if source package build (cherry picked from commit e612a5c728c206d438e31ce442b988a8d59d4e80) 09 March 2015, 16:49:54 UTC
cf12b04 Use standard names for A77II wb presets (cherry picked from commit 375e71f21769df07007f90c0783d51e664fac310) 08 March 2015, 18:18:22 UTC
4f3bbc3 Add WB presets for the Sony A77II (cherry picked from commit 5321bb05402002ba5fb71224bfcb244068eea5e8) 08 March 2015, 18:18:13 UTC
1351312 rawspeed: backport imageio_rawspeed.cc changes 07 March 2015, 19:54:02 UTC
7c93303 rawspeed: update to the latest version from master 07 March 2015, 19:43:45 UTC
ff711c9 global tonemap: fix for #10325 Tonemap operator Drago needs the absolute maximum L value of the image (lwmax). In pixelpipe FULL we can not reliably get this value as the pixelpipe might only see part of the image (region of interest). Therefore we let the PREVIEW pixelpipe store it for use in pixelpipe FULL. (cherry picked from commit 787be707cf3d0d15a43313fbc667c6f7fdcae958) Conflicts: src/iop/globaltonemap.c 07 March 2015, 16:56:35 UTC
back to top