swh:1:snp:d2871480d5f4e06baf16689eecc7e047c1f18981

sort by:
Revision Author Date Message Commit Date
84ed0f7 version: 3.4.0-rc.0 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 12 August 2019, 17:06:34 UTC
52d3429 scripts: remove ".aci" commands Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 12 August 2019, 17:06:24 UTC
9c1d2ea scripts/release: fix version check commands Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 12 August 2019, 16:59:24 UTC
547631a scripts: fix build docker commands, add more logging Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 12 August 2019, 16:50:21 UTC
802e01a *: remove "acbuild" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 12 August 2019, 16:50:21 UTC
1dff1c8 scripts/release: fix "yq" command Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 12 August 2019, 16:50:18 UTC
ac6b604 raft/rafttest: introduce datadriven testing It has often been tedious to test the interactions between multi-member Raft groups, especially when many steps were required to reach a certain scenario. Often, this boilerplate was as boring as it is hard to write and hard to maintain, making it attractive to resort to shortcuts whenever possible, which in turn tended to undercut how meaningful and maintainable the tests ended up being - that is, if the tests were even written, which sometimes they weren't. This change introduces a datadriven framework specifically for testing deterministically the interaction between multiple members of a raft group with the goal of reducing the friction for writing these tests to near zero. In the near term, this will be used to add thorough testing for joint consensus (which is already available today, but wildly undertested), but just converting an existing test into this framework has shown that the concise representation and built-in inspection of log messages highlights unexpected behavior much more readily than the previous unit tests did (the test in question is `snapshot_succeed_via_app_resp`; the reader is invited to compare the old and new version of it). The main building block is `InteractionEnv`, which holds on to the state of the whole system and exposes various relevant methods for manipulating it, including but not limited to adding nodes, delivering and dropping messages, and proposing configuration changes. All of this is extensible so that in the future I hope to use it to explore the phenomena discussed in https://github.com/etcd-io/etcd/issues/7625#issuecomment-488798263 which requires injecting appropriate "crash points" in the Ready handling loop. Discussions of the "what if X happened in state Y" can quickly be made concrete by "scripting up an interaction test". Additionally, this framework is intentionally not kept internal to the raft package.. Though this is in its infancy, a goal is that it should be possible for a suite of interaction tests to allow applications to validate that their Storage implementation behaves accordingly, simply by running a raft-provided interaction suite against their Storage. 12 August 2019, 15:10:29 UTC
69c97cd vendor: bump datadriven Picks up some fixes for papercuts. 12 August 2019, 15:10:19 UTC
faa71d8 cleanup: correct summary message in put.go 12 August 2019, 15:07:33 UTC
64c1677 tests/e2e: pass "rc.0" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 12 August 2019, 08:46:58 UTC
8ff71c5 test: fix metric name typo 09 August 2019, 20:24:27 UTC
dbe5198 raft: fix restoring joint configurations While writing interaction tests for joint configuration changes, I realized that this wasn't working yet - restoring had no notion of the joint configuration and was simply dropping it on the floor. This commit introduces a helper `confchange.Restore` which takes a `ConfState` and initializes a `Tracker` from it. This is then used both in `(*raft).restore` as well as in `newRaft`. 09 August 2019, 18:18:40 UTC
39d0f4e confchange: clean up unnecessary block 09 August 2019, 18:18:30 UTC
a8b4213 raft : `newRaft()` does check for validity of `Config` 09 August 2019, 18:18:06 UTC
a945379 raft/tracker: visit Progress in stable order This is helpful for upcoming testing work which allows datadriven testing of the interaction of multiple nodes. This testing requires determinism to work correctly. 09 August 2019, 15:39:52 UTC
7a50cd7 raft/auorum: remove unused type 09 August 2019, 15:39:44 UTC
f786b6b etcdserver: add "etcd_server_snapshot_apply_in_progress_total" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 08 August 2019, 21:02:13 UTC
1c8ab76 integration: test snapshot inflights metrics Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 08 August 2019, 21:01:54 UTC
abdb7ca etcdserver/api: add "etcd_network_snapshot_send_inflights_total", "etcd_network_snapshot_receive_inflights_total" Useful for deciding when to terminate the unhealthy follower. If the follower is receiving a leader snapshot, operator may wait. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 08 August 2019, 21:01:45 UTC
629cb7a agent: fix a data race and deadlock add 1-size buffer for `errc` to avoid deadlock of child goroutine add a local variable to a void data race in `err` when `case <-stream.Context().Done():` is taken 08 August 2019, 19:23:08 UTC
89e1023 Documentation/op-guide: update runtime configuration Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 08 August 2019, 16:25:29 UTC
9018b3d raft: let learners vote It turns out that that learners must be allowed to cast votes. This seems counter- intuitive but is necessary in the situation in which a learner has been promoted (i.e. is now a voter) but has not learned about this yet. For example, consider a group in which id=1 is a learner and id=2 and id=3 are voters. A configuration change promoting 1 can be committed on the quorum `{2,3}` without the config change being appended to the learner's log. If the leader (say 2) fails, there are de facto two voters remaining. Only 3 can win an election (due to its log containing all committed entries), but to do so it will need 1 to vote. But 1 considers itself a learner and will continue to do so until 3 has stepped up as leader, replicates the conf change to 1, and 1 applies it. Ultimately, by receiving a request to vote, the learner realizes that the candidate believes it to be a voter, and that it should act accordingly. The candidate's config may be stale, too; but in that case it won't win the election, at least in the absence of the bug discussed in: https://github.com/etcd-io/etcd/issues/7625#issuecomment-488798263. 08 August 2019, 16:10:21 UTC
b9bea9d functional/agent: copy file, instead of renaming To retain failure logs in CI testing. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 08 August 2019, 16:09:39 UTC
d2675c1 functional/rpcpb: make client log less verbose Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 08 August 2019, 16:09:34 UTC
8230536 functional.yaml: try lower snapshot count for flaky tests, error threshold Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 08 August 2019, 16:09:29 UTC
524278c pkg/types: Avoid potential double lock of tsafeSet. (tsafeSet).Sub and (tsafeSet).Equals can cause double lock bug if ts and other is pointing the same variable gofmt the code and add some comments 07 August 2019, 23:02:24 UTC
29cdc9a test: output etcd server logs when functional tests fail Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 07 August 2019, 17:16:44 UTC
a6a9a71 integration: fix a data race about `err` don't share `err` between goroutines 06 August 2019, 23:15:27 UTC
8c8f6f4 mvcc: fix typo in test Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 06 August 2019, 22:09:55 UTC
b6cfaf8 v3rpc: fix a typo `err` don't read return value in child goroutine which causes data race. 06 August 2019, 22:09:47 UTC
b522281 stream: Prevent panic when newAttemptLocked fails to get a transport for the new attempt Testing https://github.com/grpc/grpc-go/pull/2958 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 06 August 2019, 22:09:42 UTC
a78793e vendor: update gRPC to latest Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 06 August 2019, 22:09:37 UTC
e09528a Merge pull request #10988 from wenjiaswe/automated-cherry-pick-of-#10987-upstream-release-3.4 Automated cherry pick of #10987 06 August 2019, 06:31:33 UTC
cb4507d functional:update go.etcd.io/etcd link and go image registry for functional test 06 August 2019, 06:28:45 UTC
4cead3c Merge pull request #10986 from wenjiaswe/automated-cherry-pick-of-#10985-upstream-release-3.4 Automated cherry pick of #10985 06 August 2019, 05:45:31 UTC
3ac4164 functional test: Update functional README.md 06 August 2019, 05:12:50 UTC
0564743 CHANGELOG: remove from release branch Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 21:39:18 UTC
9d927af Documentation/upgrades: highlight "grpc.ErrClientConnClosing" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 21:38:51 UTC
5d19b96 proxy/grpcproxy: deprecate "grpc.ErrClientConnClosing" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 21:38:44 UTC
faa1d9d functional: deprecate "grpc.ErrClientConnClosing" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 21:38:35 UTC
ab1db0d clientv3: deprecate "grpc.ErrClientConnClosing" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 21:38:27 UTC
1c312ce functional: use Go 1.12.7 as default Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 19:40:50 UTC
b4fcaad pkg/adt: remove TODO Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 07:25:02 UTC
3468505 clientv3: document "WithBlock" dial option Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 06:53:02 UTC
a2d68dd travis: do not allow CPU 4 test failures Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 06:34:31 UTC
c6e9699 travis: do not run coverage, tip tests in v3.4 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 06:33:13 UTC
b05dfeb scripts/release: remove acbuild commands Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 06:21:51 UTC
bb7df24 pkg/adt: fix interval tree black-height property based on rbtree Author: xkey <xk33430@ly.com> ref. https://github.com/etcd-io/etcd/pull/10978 Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 05 August 2019, 06:15:09 UTC
9ff86fe tests/e2e: skip release tests until release candidate Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 03 August 2019, 07:09:10 UTC
bc9a54b tests/e2e: fix upgrade, metrics tests Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 02 August 2019, 22:58:25 UTC
df1d3f7 functional: remove "embed" support in tests Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 02 August 2019, 22:58:21 UTC
14053ba etcdserver/api: enable 3.4 capability Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 02 August 2019, 22:24:40 UTC
040f2c5 version: 3.4.0-pre Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 23:05:22 UTC
f1c7fd3 functional: add "LogLevel" flags Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 22:58:01 UTC
22a3ec3 CHANGELOG-3.4: highlight version string change Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 22:30:04 UTC
4244ea4 CHANGELOG: update with latest changes, make language consistent Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 22:26:31 UTC
d239b21 Documentation/upgrades: update 3.4 guides Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 22:26:16 UTC
b679c12 Merge pull request #10968 from gyuho/mmm mvcc: add "etcd_mvcc_range_total", "etcd_mvcc_txn_total" 01 August 2019, 21:46:49 UTC
328fdc2 mvcc: add TODOs Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 21:45:21 UTC
f82e23a mvcc: add "etcd_mvcc_range_total", "etcd_mvcc_txn_total" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 21:44:55 UTC
dde3c5f mvcc: clean up metrics names, add missing register calls Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 21:44:55 UTC
05b2f96 Merge pull request #10969 from gyuho/maintainers MAINTAINERS: add @spzala 01 August 2019, 21:44:12 UTC
8d88fea MAINTAINERS: add @spzala Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 21:24:24 UTC
c9bd8db CHANGELOG: fix typos Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 21:11:50 UTC
6804bd8 CHANGELOG: add latest metrics change Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 20:53:12 UTC
d5bd600 CHANGELOG: update "pkg/adt" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 20:37:28 UTC
3b631e1 pkg/adt: document textbook implementation with pseudo-code Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 19:58:47 UTC
456c91b Merge pull request #10959 from gyuho/adt pkg/adt: refactor + add more test cases 01 August 2019, 19:22:15 UTC
5ef8f27 Merge pull request #10962 from hexfusion/promote_mvcc metrics: promote etcd_debugging_mvcc put_total and delete_total 01 August 2019, 05:24:40 UTC
6a0811a *: use new adt.IntervalTree interface Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 05:23:13 UTC
3cc3aff pkg/adt: mask test failure, add TODO Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 01 August 2019, 05:20:59 UTC
f46ee91 metrics: promote etcd_debugging_mvcc put_total and delete_total Signed-off-by: Sam Batschelet <sbatsche@redhat.com> 01 August 2019, 01:28:07 UTC
46f04b3 pkg/adt: add "IntervalTree.Delete" failure case Described in https://github.com/etcd-io/etcd/issues/10877. "black-height" property: Every path from a node to any descendant leaf node must have the same number of black nodes. Expected After deleting 11 (requires rebalancing): [510,511] / \ ---------- -------------------------- / \ [383,384] [830,831] / \ / \ / \ / \ [261,262](red) [410,411] [647,648] [899,900](red) / \ \ / \ / \ \ / \ [82,83] [292,293] [815,816](red) [888,889] [972,973] \ / \ / [238,239](red) [953,954](red) Got After deleting 11 (requires rebalancing): [510,511] / \ ---------- -------------------------- / \ [82,83] [830,831] \ / \ \ / \ [383,384] [647,648] [899,900] / \ \ / \ / \ \ / \ [261,262] [410,411] [815,816] [888,889] [972,973] / \ / / \ / [238,239] [292,293] [953,954] This violates "black-height" property. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 31 July 2019, 17:05:32 UTC
f2742d6 pkg/adt: test node "11" deletion Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 31 July 2019, 17:05:32 UTC
1d638ba pkg/adt: README "IntervalTree.Delete" test case images Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 31 July 2019, 17:05:32 UTC
19d69d2 pkg/adt: README initial commit Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 31 July 2019, 17:05:27 UTC
6917c49 pkg/adt: add "visitLevel", make "IntervalTree" interface, more tests Make "IntervalTree" an interface to abstract range tree interface Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 30 July 2019, 22:59:59 UTC
149e5dc etcdserver: mark flag as experimental, add to changelog and configuration 30 July 2019, 20:57:57 UTC
03fd396 pkg/transport: Improved description of flag peer-skip-client-san-verification 30 July 2019, 20:57:57 UTC
2f476f2 pkg/transport: Added test for SkipClientVerify flag. 30 July 2019, 20:57:57 UTC
1b048c9 etcdserver: Added configuration flag --peer-skip-client-verify=true 30 July 2019, 20:57:57 UTC
a2a8887 Merge pull request #10953 from gyuho/grpc-gateway vendor: update grpc-ecosystem 30 July 2019, 20:31:44 UTC
465592a Documentation/etcd-mixin: Add an alert for down etcd members An etcd member being down is an important failure state - while normal admin operations may cause transient outages to rotate, when any member is down the cluster is operating in a degraded fashion. Add an alert that records when any members are down so that administrators know whether the next failure is fatal. The rule is more complicated than `up{...} == 0` because not all failure modes for etcd may have an `up{...}` entry for each member. For instance, a Kubernetes service in front of an etcd cluster might only have 2 endpoints recorded in `up` because the third pod is evicted by the kubelet - the cluster is degraded but `count(up{...})` would not return the full quorum size. Instead, use network peer send failures as a failure detector and attempt to return the max of down services or failing peers. We may undercount the number of total failures, but we will at least alert that a member is down. 30 July 2019, 18:39:50 UTC
12c049e Merge pull request #10835 from spzala/securityprocess Security: Create etcd security process 30 July 2019, 18:14:46 UTC
bc95b1f bill-of-materials: update Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 30 July 2019, 04:41:47 UTC
80efba3 tests/e2e: fix curl proclaim error message Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 30 July 2019, 04:28:15 UTC
f3bca1d vendor: update grpc-ecosystem Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 23:13:54 UTC
800e723 CHANGELOG: add recent changes in logger Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 23:09:06 UTC
6e766ac Merge pull request #10947 from gyuho/log-level *: make log level configurable 29 July 2019, 23:06:51 UTC
4e43a08 raft: use mutex in "SetLogger" to avoid race conditions in tests Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 22:43:19 UTC
c6e3401 etcdserver: make raft log configured by top level logger To make it consistent Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 22:43:19 UTC
abba542 Documentation/op-guide: add "--log-level" flag Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 22:43:19 UTC
a37f344 etcdmain: add "--log-level" flag Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 22:43:19 UTC
b9de4bd embed: add "LogLevel", deprecate "Debug" in v3.5 Make log level configurable, and deprecate "debug" flag in v3.5. And adds more warnings on flags that's being deprecated in v3.5. Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 22:43:19 UTC
e911f90 pkg/logutil: add log level utilities Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 22:43:19 UTC
348b0d4 embed: do not expose "zapLoggerBuilder" Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 22:43:19 UTC
324952c Merge pull request #10935 from gyuho/v2 *: disable v2 API by default 29 July 2019, 22:42:56 UTC
936c506 Merge pull request #10945 from tbg/add-todo raft: leave TODO about leaving StateSnapshot 29 July 2019, 20:51:38 UTC
4ca04ba Merge pull request #10949 from gyuho/docs Documentation: move design docs to "Documentation", remove "docs" 29 July 2019, 20:48:38 UTC
87e203a Documentation/learning: rewrite balancer design doc images Signed-off-by: Gyuho Lee <leegyuho@amazon.com> 29 July 2019, 20:47:25 UTC
back to top