e584fca | Antoine R. Dumont (@ardumont) | 21 November 2018, 07:55:13 UTC | Updated debian stretch backport directory for version 0.0.111 | 21 November 2018, 07:55:13 UTC |
4a68c7b | Antoine R. Dumont (@ardumont) | 21 November 2018, 07:55:13 UTC | Merge branch 'debian/unstable-swh' into debian/stretch-swh # Conflicts: # debian/changelog | 21 November 2018, 07:55:13 UTC |
335bfdf | Antoine R. Dumont (@ardumont) | 21 November 2018, 07:55:13 UTC | Updated debian directory for version 0.0.111 | 21 November 2018, 07:55:13 UTC |
600e091 | Antoine R. Dumont (@ardumont) | 21 November 2018, 07:55:13 UTC | Update upstream source from tag 'debian/upstream/0.0.111' Update to upstream version '0.0.111' with Debian dir 2cee739dcdcfcc5847621d8d02d6c87290b45806 | 21 November 2018, 07:55:13 UTC |
04c8faa | Antoine R. Dumont (@ardumont) | 21 November 2018, 07:55:13 UTC | New upstream version 0.0.111 | 21 November 2018, 07:55:13 UTC |
8ea06fa | Antoine R. Dumont (@ardumont) | 19 November 2018, 09:26:58 UTC | tests: Move generation tests fixture in a dedicated module So that tests that requires tests fixture without hypothesis does not break. Related T1354 | 19 November 2018, 09:28:26 UTC |
b61cf3d | Valentin Lorentz | 16 November 2018, 15:02:22 UTC | Add in-memory storage. Test Plan: Land the two parent diffs, then rebase this one on top of them. Reviewers: #reviewers, douardda Reviewed By: #reviewers, douardda Subscribers: olasd, douardda, swh-public-ci Differential Revision: https://forge.softwareheritage.org/D645 | 19 November 2018, 09:03:52 UTC |
12bd423 | Antoine R. Dumont (@ardumont) | 16 November 2018, 10:53:14 UTC | Updated debian stretch backport directory for version 0.0.110 | 16 November 2018, 10:53:14 UTC |
750117c | Antoine R. Dumont (@ardumont) | 16 November 2018, 10:53:14 UTC | Updated debian directory for version 0.0.110 | 16 November 2018, 10:53:14 UTC |
724a960 | Antoine R. Dumont (@ardumont) | 16 November 2018, 10:53:14 UTC | Update upstream source from tag 'debian/upstream/0.0.110' Update to upstream version '0.0.110' with Debian dir d0c14a6ea74f7891699b8c00d5ae2f6671645836 | 16 November 2018, 10:53:14 UTC |
b4dedfa | Antoine R. Dumont (@ardumont) | 16 November 2018, 10:53:14 UTC | Merge branch 'debian/unstable-swh' into debian/stretch-swh # Conflicts: # debian/changelog | 16 November 2018, 10:53:14 UTC |
f09707c | Antoine R. Dumont (@ardumont) | 16 November 2018, 10:53:14 UTC | New upstream version 0.0.110 | 16 November 2018, 10:53:14 UTC |
fc3b9dc | Valentin Lorentz | 12 November 2018, 10:35:45 UTC | Document metadata providers. Reviewers: #reviewers, douardda, moranegg Reviewed By: #reviewers, douardda, moranegg Subscribers: douardda, moranegg, swh-public-ci Differential Revision: https://forge.softwareheritage.org/D637 | 15 November 2018, 09:02:57 UTC |
12edfac | Antoine R. Dumont (@ardumont) | 14 November 2018, 14:22:14 UTC | tox: Define a py3-slow environment Use: tox -e py3-slow | 14 November 2018, 15:07:33 UTC |
880aa9c | Antoine R. Dumont (@ardumont) | 13 November 2018, 09:59:41 UTC | tests: Use fast/slow profile names | 14 November 2018, 15:07:33 UTC |
3f05ada | Antoine R. Dumont (@ardumont) | 12 November 2018, 13:51:31 UTC | Makefile: Adapt makefile to use the dev profile | 14 November 2018, 15:07:33 UTC |
076a392 | Antoine R. Dumont (@ardumont) | 12 November 2018, 13:11:03 UTC | tests: Use hypothesis profile mechanism to configure samples size | 14 November 2018, 15:07:33 UTC |
04323a6 | Antoine R. Dumont (@ardumont) | 12 November 2018, 12:42:05 UTC | tests: Decrease generation sample to make tests faster Currently investigating hypothesis settings [1] [1] https://hypothesis.readthedocs.io/en/latest/settings.html#settings-profiles | 14 November 2018, 15:07:33 UTC |
8aa990f | Antoine R. Dumont (@ardumont) | 12 November 2018, 10:38:12 UTC | tests: Add docstring to test to detail what's tested | 14 November 2018, 15:07:33 UTC |
e1a460c | Antoine R. Dumont (@ardumont) | 09 November 2018, 17:40:49 UTC | tests: Move property_based marker to toplevel test class | 14 November 2018, 15:07:33 UTC |
3829885 | Antoine R. Dumont (@ardumont) | 14 November 2018, 14:08:35 UTC | tests: Use sorted | 14 November 2018, 15:07:33 UTC |
c876d86 | Antoine R. Dumont (@ardumont) | 09 November 2018, 15:27:19 UTC | storage: Open content_get_range endpoint Related T991 | 14 November 2018, 15:07:33 UTC |
a429574 | Antoine R. Dumont (@ardumont) | 14 November 2018, 13:58:33 UTC | tests: Use sorted on list directly | 14 November 2018, 15:07:33 UTC |
c7a3266 | Antoine R. Dumont (@ardumont) | 14 November 2018, 13:58:17 UTC | tests: Build content generated in less steps | 14 November 2018, 15:07:33 UTC |
f87808c | Antoine R. Dumont (@ardumont) | 14 November 2018, 13:58:05 UTC | tests: Clarify gen_content docstring | 14 November 2018, 15:07:33 UTC |
0c51e4d | Antoine R. Dumont (@ardumont) | 09 November 2018, 13:53:11 UTC | tests: Add test content generation util function and use it Test back `content_get` and `content_get_metadata` as a first step. Plan to use those for the new and upcoming `content_get_range` function. | 14 November 2018, 15:07:32 UTC |
823465f | Valentin Lorentz | 14 November 2018, 14:55:56 UTC | Remove SQLisms from the tests and API. Reviewers: #reviewers, olasd Reviewed By: #reviewers, olasd Subscribers: olasd, swh-public-ci Differential Revision: https://forge.softwareheritage.org/D642 | 14 November 2018, 14:58:30 UTC |
64e67aa | David Douard | 12 November 2018, 13:05:25 UTC | make-doc: add an 'assets' make target for the doc used by the swh-docs to generate images and schemas when building the whole documentation. | 12 November 2018, 15:19:22 UTC |
3792831 | Antoine Lambert | 12 November 2018, 13:11:09 UTC | New upstream version 0.0.109 | 12 November 2018, 13:11:09 UTC |
d46a98b | Antoine Lambert | 12 November 2018, 13:11:09 UTC | Updated debian directory for version 0.0.109 | 12 November 2018, 13:11:09 UTC |
8bcac9c | Antoine Lambert | 12 November 2018, 13:11:09 UTC | Update upstream source from tag 'debian/upstream/0.0.109' Update to upstream version '0.0.109' with Debian dir 6afadf4568de45bf8226d89541fd0e202a7d7c19 | 12 November 2018, 13:11:09 UTC |
faca02c | Antoine Lambert | 12 November 2018, 13:11:09 UTC | Updated debian stretch backport directory for version 0.0.109 | 12 November 2018, 13:11:09 UTC |
2dcc7ac | Antoine Lambert | 12 November 2018, 13:11:09 UTC | Merge branch 'debian/unstable-swh' into debian/stretch-swh # Conflicts: # debian/changelog | 12 November 2018, 13:11:09 UTC |
1031dc5 | Antoine Lambert | 12 November 2018, 12:56:28 UTC | debian: Remove nose and migrate to pytest | 12 November 2018, 13:10:07 UTC |
1a1d214 | Antoine Lambert | 12 November 2018, 10:12:36 UTC | algos.revisions_walker: Fix get_revisions_walker doc | 12 November 2018, 10:12:36 UTC |
14e17d1 | Valentin Lorentz | 09 November 2018, 11:08:01 UTC | Fix storage doc. Reviewers: #reviewers, olasd Reviewed By: #reviewers, olasd Subscribers: olasd, swh-public-ci Differential Revision: https://forge.softwareheritage.org/D643 | 09 November 2018, 17:38:49 UTC |
b944f00 | Valentin Lorentz | 09 November 2018, 11:10:35 UTC | Restructure tests to prepare for tests with no DB. Reviewers: #reviewers, olasd Reviewed By: #reviewers, olasd Subscribers: swh-public-ci Differential Revision: https://forge.softwareheritage.org/D644 | 09 November 2018, 17:38:38 UTC |
7934ded | David Douard | 09 November 2018, 12:23:30 UTC | Fix rst syntax in docstrings | 09 November 2018, 14:15:17 UTC |
81b8c9b | David Douard | 09 November 2018, 12:21:24 UTC | Add :orphan: metadata to archive-copies and sql-storage doc files to prevent sphinx from complaining about these not being included. | 09 November 2018, 14:15:17 UTC |
88c33cc | Antoine Lambert | 06 November 2018, 21:19:01 UTC | algos: Add iterators to walk across revisions history This commit adds iterators to walk across the history of revisions heading to a given one. The following types of iteration are offered: - committer_date: revisions are returned in reverse chronological order of their commit date (same as git log) - dfs: revisions are returned in the same order they are visited when performing a depth-first search in pre order on the revisions DAG - dfs_post: revisions are returned in the same order they are visited when performing a depth-first search in post order on the revisions DAG - bfs: revisions are returned in the same order they are visited when performing a breadth-first search on the revisions DAG Another iterator of type path, returning only revisions that modify a specific path in reverse chronological order of their commit date, is also introduced. Nevertheless, due to client-side implementation, its performances are far from optimal when walking across a really large history. Related T1026 Related T1284 | 09 November 2018, 13:04:04 UTC |
19d4019 | Valentin Lorentz | 08 November 2018, 13:32:28 UTC | Rename the 'ts' argument of 'origin_visit_add' to 'date'. Summary: To be consistent with the name used in the DB and the dict key returned by 'origin_visit_get'. Note that this makes the client incompatible with older versions of the server. Reviewers: #reviewers, olasd Reviewed By: #reviewers, olasd Subscribers: olasd, swh-public-ci Differential Revision: https://forge.softwareheritage.org/D636 | 09 November 2018, 10:45:41 UTC |
884d9e7 | Antoine Lambert | 08 November 2018, 13:42:42 UTC | sql/Makefile: Fix pifpaf test as it was always considered used | 08 November 2018, 13:43:03 UTC |
465192e | Antoine R. Dumont (@ardumont) | 18 October 2018, 14:23:59 UTC | storage.listener: Subscribe listener to snapshot insertion Related T1275 | 26 October 2018, 10:21:52 UTC |
1ad38af | Antoine R. Dumont (@ardumont) | 18 October 2018, 13:24:09 UTC | sql: Add snapshot trigger event on insertion Related T1275 | 26 October 2018, 10:21:52 UTC |
fba230d | Stefano Zacchiroli | 26 October 2018, 07:57:04 UTC | DB schema: manual fix for some arrow source/dest to avoid degenerate angles in rendering | 26 October 2018, 07:57:04 UTC |
a579a1a | Stefano Zacchiroli | 26 October 2018, 07:51:57 UTC | DB schema: add light foreign key arrows from snapshot to * | 26 October 2018, 07:51:57 UTC |
b032d2a | Stefano Zacchiroli | 26 October 2018, 07:51:25 UTC | DB schema: remove left-over occurrence stuff from snapshot cluster | 26 October 2018, 07:51:25 UTC |
1c74f6d | Antoine R. Dumont (@ardumont) | 24 October 2018, 13:42:12 UTC | tox.ini: Align configuration file with other Also, without this, this failed because somehow, something is not finding requirements-test.txt. ``` Could not open requirements file: [Errno 2] No such file or directory: ' requirements-test.txt' ``` | 24 October 2018, 13:42:12 UTC |
7628710 | Stefano Zacchiroli | 24 October 2018, 12:35:02 UTC | SQL schema: update to reflect recent changes recent changes include most notably the removal of occurrence-related tables, but also the addition of table columns accumulated over time Closes T1283 | 24 October 2018, 12:35:02 UTC |
a6742b7 | Stefano Zacchiroli | 24 October 2018, 12:34:52 UTC | DB schema doc: error out if SQL schema cannot be found | 24 October 2018, 12:34:52 UTC |
582d72d | Stefano Zacchiroli | 24 October 2018, 12:22:42 UTC | docs Makefile: only echo SQL queries on error | 24 October 2018, 12:22:48 UTC |
5fe9221 | Stefano Zacchiroli | 24 October 2018, 12:20:01 UTC | docs Makefile: forward "distclean" to sql dir | 24 October 2018, 12:20:01 UTC |
b91482a | Stefano Zacchiroli | 24 October 2018, 12:00:01 UTC | gitignore and remove generate archive copies diagram Closes T1269 | 24 October 2018, 12:00:01 UTC |
242f985 | Nicolas Dandrimont | 23 October 2018, 14:48:15 UTC | Don't run pytest in the docs directory | 23 October 2018, 14:48:15 UTC |
e77d809 | David Douard | 22 October 2018, 16:06:59 UTC | tests: increase deadline for CI seems to run slower on there. | 22 October 2018, 16:06:59 UTC |
076144e | David Douard | 18 October 2018, 15:17:09 UTC | tests: assertEquals -> assertEqual | 22 October 2018, 14:46:34 UTC |
32ef182 | David Douard | 18 October 2018, 15:11:35 UTC | tests: use pytest and add a simple tox file related to T1261 | 22 October 2018, 14:45:08 UTC |
5b38656 | David Douard | 18 October 2018, 15:07:19 UTC | flake8 | 22 October 2018, 14:32:18 UTC |
a8fbce5 | Valentin Lorentz | 22 October 2018, 07:27:41 UTC | Warn when using db_transaction/db_transaction_generator where you shouldn't. Summary: I did it, it caused closed cursors that hang the process, that's hard to debug. Reviewers: #reviewers, ardumont Reviewed By: #reviewers, ardumont Subscribers: ardumont Differential Revision: https://forge.softwareheritage.org/D556 | 22 October 2018, 09:03:36 UTC |
2debb74 | Nicolas Dandrimont | 18 October 2018, 16:32:10 UTC | Updated debian directory for version 0.0.108 | 18 October 2018, 16:32:10 UTC |
7ffa64e | Nicolas Dandrimont | 18 October 2018, 16:32:10 UTC | Update upstream source from tag 'debian/upstream/0.0.108' Update to upstream version '0.0.108' with Debian dir 71af9b7cededed745d092c0bf974d378648c63ef | 18 October 2018, 16:32:10 UTC |
ba47d8d | Nicolas Dandrimont | 18 October 2018, 16:32:10 UTC | New upstream version 0.0.108 | 18 October 2018, 16:32:10 UTC |
c789a7a | Nicolas Dandrimont | 18 October 2018, 16:32:10 UTC | Updated debian stretch backport directory for version 0.0.108 | 18 October 2018, 16:32:10 UTC |
5e587ae | Nicolas Dandrimont | 18 October 2018, 16:32:10 UTC | Merge branch 'debian/unstable-swh' into debian/stretch-swh # Conflicts: # debian/changelog | 18 October 2018, 16:32:10 UTC |
d211615 | Nicolas Dandrimont | 18 October 2018, 16:30:44 UTC | Mark snapshot tests as needing the database | 18 October 2018, 16:30:44 UTC |
b2d4921 | Nicolas Dandrimont | 18 October 2018, 16:27:56 UTC | Mark minimum hypothesis version for datetimes | 18 October 2018, 16:27:56 UTC |
ec7a119 | Nicolas Dandrimont | 18 October 2018, 16:25:07 UTC | Add hypothesis to debian build-dependencies | 18 October 2018, 16:25:07 UTC |
ad92248 | Nicolas Dandrimont | 17 October 2018, 19:25:42 UTC | Add a function to retrieve a full snapshot Summary: This function wraps the paginating branch listing API to do its work. It's in swh.storage.algos because it should be done client-side rather than server-side. The tests are fairly simple, and mostly add a bunch of tooling around hypothesis to generate data that conforms to the swh data schema. Those things could probably be adequately moved to a new submodule of swh.model. Test Plan: new tests added Reviewers: anlambert Differential Revision: https://forge.softwareheritage.org/D551 | 18 October 2018, 14:57:55 UTC |
7cd7597 | Nicolas Dandrimont | 17 October 2018, 14:54:14 UTC | Rewrite snapshot_get in terms of snapshot_get_branches Summary: This increases uniformity and reduces code duplication between the two functions. The addition of the 'next_branch' return value in snapshot_get_branches allows callers to get branches incrementally in a loop which is friendlier. Depends on D545 Test Plan: tests have been updated to add the new next_branch field Reviewers: anlambert Differential Revision: https://forge.softwareheritage.org/D546 | 17 October 2018, 14:56:42 UTC |
0d52bf4 | Nicolas Dandrimont | 17 October 2018, 14:51:59 UTC | Rewrite snapshot pagination tests declaratively Summary: This looks less confusing than removing a bunch of values from the test data. Test Plan: make test still passes Reviewers: anlambert Differential Revision: https://forge.softwareheritage.org/D545 | 17 October 2018, 14:56:07 UTC |
80cd420 | David Douard | 17 October 2018, 13:56:52 UTC | packaging: bump swh-core dependency to 0.0.44 | 17 October 2018, 13:56:52 UTC |
9ce5f78 | David Douard | 17 October 2018, 13:56:13 UTC | README: swh-storage-testdata is not required any more | 17 October 2018, 13:56:13 UTC |
a9c32d2 | David Douard | 16 October 2018, 08:59:14 UTC | sql: adapt Makefile for sql file renames and make it pifpaf compliant ie. delete stamps when executed via pifpaf for the db setup. | 17 October 2018, 13:46:36 UTC |
ee27736 | David Douard | 16 October 2018, 08:58:09 UTC | kill sql/db-init in favor of swh-core's new swh-db-init tool | 17 October 2018, 13:46:36 UTC |
c4cdb64 | David Douard | 12 October 2018, 11:27:47 UTC | tests: refactor the StorageTestFixture class and move sql files in the package so we can build the db setup sql file on the fly: - make it inherit from SingleDbTestFixture, so we can - move sql files in swh/storage/sql/ - get rid og the setUpClass static method to reuse the one from SingleDbTestFixture, - apply the required modifications to tests based on this StorageTestFixture. Warnings: - this requires D538, - this will break tests in swh-vault. Also add README.md to the MANIFEST.in file so it does not require a too recent setuptool. | 17 October 2018, 13:46:36 UTC |
8f9af9b | Nicolas Dandrimont | 17 October 2018, 13:16:31 UTC | Remove some leftover compatibility code | 17 October 2018, 13:16:31 UTC |
2683ec4 | Nicolas Dandrimont | 17 October 2018, 13:06:07 UTC | Updated debian stretch backport directory for version 0.0.107 | 17 October 2018, 13:06:07 UTC |
773631d | Nicolas Dandrimont | 17 October 2018, 13:06:07 UTC | Merge branch 'debian/unstable-swh' into debian/stretch-swh # Conflicts: # debian/changelog | 17 October 2018, 13:06:07 UTC |
a985ba9 | Nicolas Dandrimont | 17 October 2018, 13:06:07 UTC | New upstream version 0.0.107 | 17 October 2018, 13:06:07 UTC |
bea72f8 | Nicolas Dandrimont | 17 October 2018, 13:06:07 UTC | Updated debian directory for version 0.0.107 | 17 October 2018, 13:06:07 UTC |
fcb62ce | Nicolas Dandrimont | 17 October 2018, 13:06:07 UTC | Update upstream source from tag 'debian/upstream/0.0.107' Update to upstream version '0.0.107' with Debian dir 69035d517dda22d8063a7cf29e4f076d3319eecb | 17 October 2018, 13:06:07 UTC |
2d5efac | Nicolas Dandrimont | 17 October 2018, 12:44:42 UTC | Reorder upgrade statements so that they actually pass | 17 October 2018, 12:44:42 UTC |
4f05900 | Nicolas Dandrimont | 17 October 2018, 12:22:08 UTC | Remove redundant removals from the 122->123 upgrade | 17 October 2018, 12:22:08 UTC |
435ebcd | Nicolas Dandrimont | 15 October 2018, 08:09:29 UTC | Drop table occurrence_history Summary: The migration to snapshots has been completed, and all users have been migrated. Depends on D534. Close T830. Test Plan: make test after a testdata rebuild is ok Reviewers: zack Maniphest Tasks: T830 Differential Revision: https://forge.softwareheritage.org/D535 | 15 October 2018, 14:22:17 UTC |
b486063 | Nicolas Dandrimont | 15 October 2018, 13:49:18 UTC | Drop confusing functions revision_get_by/revision_log_by Summary: The combination of timestamp search for an occurrence with branch name filtering never got ported to the snapshot model. As this function only has a single user, which is a single endpoint deep in the public-facing API, let's just drop it. revision_log_by uses the same filter but gives a log of parent revisions, and has never been used by any client. This will break this API endpoint, which is tracked in T1221, but iff we want to keep it, I think it can be easily reimplemented by composing origin_visit_get_by and the new snapshot_get_branches function. Test Plan: It's dead, Jim. Reviewers: zack Differential Revision: https://forge.softwareheritage.org/D534 | 15 October 2018, 13:58:52 UTC |
3a59229 | Nicolas Dandrimont | 12 October 2018, 09:54:00 UTC | Rename test methods to test_* to allow py.test collection Summary: Part of T1261 Test Plan: Make test runs the same number of tests before and after Reviewers: #reviewers! Differential Revision: https://forge.softwareheritage.org/D522 | 12 October 2018, 09:57:14 UTC |
65e6b69 | Nicolas Dandrimont | 10 October 2018, 14:23:33 UTC | Drop unused entity tables Summary: Close T838 Test Plan: Remove all the tests! Reviewers: #reviewers! Maniphest Tasks: T838 Differential Revision: https://forge.softwareheritage.org/D509 | 10 October 2018, 14:25:54 UTC |
ee40117 | Nicolas Dandrimont | 10 October 2018, 13:55:36 UTC | Merge remote-tracking branch 'origin/master' | 10 October 2018, 13:55:36 UTC |
e9e5e73 | Antoine Lambert | 03 October 2018, 09:33:32 UTC | storage: Enable to paginate, filter and count snapshot content Related T1207 | 09 October 2018, 13:28:34 UTC |
30b60b8 | Nicolas Dandrimont | 08 October 2018, 15:03:54 UTC | Updated debian stretch backport directory for version 0.0.106 | 08 October 2018, 15:03:54 UTC |
9c789eb | Nicolas Dandrimont | 08 October 2018, 15:03:54 UTC | Merge branch 'debian/unstable-swh' into debian/stretch-swh # Conflicts: # debian/changelog | 08 October 2018, 15:03:54 UTC |
a4bd5d4 | Nicolas Dandrimont | 08 October 2018, 15:03:54 UTC | New upstream version 0.0.106 | 08 October 2018, 15:03:54 UTC |
baa6be4 | Nicolas Dandrimont | 08 October 2018, 15:03:54 UTC | Updated debian directory for version 0.0.106 | 08 October 2018, 15:03:54 UTC |
a9a496e | Nicolas Dandrimont | 08 October 2018, 15:03:54 UTC | Update upstream source from tag 'debian/upstream/0.0.106' Update to upstream version '0.0.106' with Debian dir ae40342c9f5554caa854e2fac147ec13bdfff7f5 | 08 October 2018, 15:03:54 UTC |
80b4644 | Nicolas Dandrimont | 08 October 2018, 15:03:46 UTC | Update version requirements for swh.model | 08 October 2018, 15:03:46 UTC |
7ae19db | David Douard | 04 October 2018, 15:16:56 UTC | add build/ to gitignore | 08 October 2018, 10:22:39 UTC |
63c924d | David Douard | 04 October 2018, 15:15:31 UTC | setup: prepare for pypi upload related to T1242 | 08 October 2018, 10:22:32 UTC |
b1eaa9a | David Douard | 04 October 2018, 15:14:20 UTC | docs: merge both README files in a single README.md also documement the usage of pifpaf to run pg tests | 05 October 2018, 14:38:22 UTC |
fb794bf | Antoine Pietri | 05 October 2018, 10:56:14 UTC | Add requirements-test.txt | 05 October 2018, 10:56:16 UTC |
3d1b95e | Nicolas Dandrimont | 03 October 2018, 16:46:17 UTC | Remove the occurrence table Summary: This table is obsolete, and was never really used in the first place. This solves the first half of T839. Depends on D471. Test Plan: rebuild-testdata and make test Reviewers: #reviewers! Differential Revision: https://forge.softwareheritage.org/D472 | 03 October 2018, 16:55:46 UTC |