swh:1:snp:5115096b921df712aeb2a08114fede57fb3331fb
Revision 3b5fa6bd9bc2cdef7535901c73c759fa18092522 authored by Igor Canadi on 02 May 2014, 14:13:51 UTC, committed by Igor Canadi on 02 May 2014, 14:13:51 UTC
Summary:
Our valgrind tests are failing because ttl_test is kind of flakey. This diff should fix valgrind issue and make ttl_test less flakey and much faster.

Instead of relying on Env::Default() for getting current time, I expose `Env*` to all TTL functions that are interested in time. That way, I can insert a custom test Env which is then used to provide exactly the times we need. That way, we don't need to sleep anymore -- we control the time.

Test Plan: ttl_test in normal and valgrind run

Reviewers: dhruba, haobo, sdong, yhchiang

Reviewed By: haobo

CC: leveldb

Differential Revision: https://reviews.facebook.net/D18399
1 parent 82042f4
History
Tip revision: 19076c95aa2bcee55c26fcf0960cc844ad86ee9c authored by Levi Tamasi on 21 January 2021, 22:18:25 UTC
Update HISTORY.md for PR 7888 (#7890)
Tip revision: 19076c9
File Mode Size
build_tools
coverage
db
doc
hdfs
helpers
include
java
linters
port
table
tools
util
utilities
.arcconfig -rw-r--r-- 246 bytes
.clang-format -rw-r--r-- 138 bytes
.gitignore -rw-r--r-- 317 bytes
CONTRIBUTING.md -rw-r--r-- 759 bytes
HISTORY.md -rw-r--r-- 5.3 KB
INSTALL.md -rw-r--r-- 3.3 KB
LICENSE -rw-r--r-- 1.6 KB
Makefile -rw-r--r-- 20.3 KB
PATENTS -rw-r--r-- 1.4 KB
README -rw-r--r-- 2.9 KB
ROCKSDB_LITE.md -rw-r--r-- 1020 bytes

README

back to top