Revision 45f38e4c17379c83be5533ff60697ac888d8eea7 authored by Frank Liberato on 21 September 2018, 18:34:39 UTC, committed by Blink WPT Bot on 21 September 2018, 18:44:44 UTC
This reverts commit 254369a5f6df06c2c6be067d14c2cb2a036ba173.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> bindings: Implement timers with V8Function
>
> This fixes bug 866610 by using the IDL infrastructure to properly enter
> the v8::Context before calling the registered callback.
>
> Also ensure eager finalization of ScheduledAction in DOMTimer to
> prevent a memory leak. Added two more effective DCHECKs to confirm.
>
> Bug: 866610
> Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1
> Reviewed-on: https://chromium-review.googlesource.com/1220486
> Reviewed-by: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Timothy Gu <timothygu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593108}

TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org

Change-Id: Ifaccc3374466b851fc28b10c63ed1397bdae635e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866610
Reviewed-on: https://chromium-review.googlesource.com/1239216
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593260}
1 parent 2719d8f
History
File Mode Size
.well-known
2dcontext
BackgroundSync
FileAPI
IndexedDB
WebCryptoAPI
WebIDL
accelerometer
accname
acid
ambient-light
animation-worklet
annotation-model
annotation-protocol
annotation-vocab
apng
appmanifest
async-local-storage
audio-output
background-fetch
battery-status
beacon
bluetooth
clear-site-data
client-hints
clipboard-apis
common
compat
conformance-checkers
console
content-security-policy
cookie-store
cookies
core-aam
cors
credential-management
css
custom-elements
device-memory
docs
dom
domparsing
domxpath
dpub-aam
dpub-aria
editing
encoding
encrypted-media
entries-api
eventsource
feature-policy
fetch
fonts
fullscreen
gamepad
generic-sensor
geolocation-API
geolocation-sensor
graphics-aam
gyroscope
hr-time
html
html-longdesc
html-media-capture
imagebitmap-renderingcontext
images
inert
infrastructure
input-device-capabilities
input-events
interfaces
intersection-observer
js
keyboard-lock
keyboard-map
lifecycle
longtask-timing
magnetometer
mathml
media
media-capabilities
media-source
mediacapture-depth
mediacapture-fromelement
mediacapture-image
mediacapture-record
mediacapture-streams
mediasession
mimesniff
mixed-content
mst-content-hint
navigation-timing
netinfo
network-error-logging
notifications
offscreen-canvas
old-tests
orientation-event
orientation-sensor
origin-policy
page-visibility
paint-timing
payment-handler
payment-method-basic-card
payment-method-id
payment-request
performance-timeline
permissions
picture-in-picture
pointerevents
pointerlock
preload
presentation-api
priority-hints
proximity
push-api
quirks
referrer-policy
remote-playback
reporting
requestidlecallback
resize-observer
resource-timing
resources
screen-capture
screen-orientation
scroll-animations
secure-contexts
selection
server-timing
service-workers
shadow-dom
shape-detection
speech-api
storage
streams
subresource-integrity
svg
svg-aam
tools
touch-events
trusted-types
uievents
upgrade-insecure-requests
url
user-timing
vibration
visual-viewport
wai-aria
wake-lock
wasm
web-animations
web-locks
web-nfc
web-share
webaudio
webauthn
webdriver
webgl
webmessaging
webmidi
webrtc
webrtc-stats
websockets
webstorage
webusb
webvr
webvtt
webxr
workers
worklets
x-frame-options
xhr
.codecov.yml -rw-r--r-- 66 bytes
.gitignore -rw-r--r-- 340 bytes
.gitmodules -rw-r--r-- 138 bytes
.pyup.yml -rw-r--r-- 1.0 KB
.taskcluster.yml -rw-r--r-- 6.3 KB
.travis.yml -rw-r--r-- 2.8 KB
CODEOWNERS -rw-r--r-- 98 bytes
CONTRIBUTING.md -rw-r--r-- 1.6 KB
LICENSE.md -rw-r--r-- 5.1 KB
README.md -rw-r--r-- 17.2 KB
check_stability.ini -rw-r--r-- 463 bytes
lint.whitelist -rw-r--r-- 45.6 KB
serve.py -rw-r--r-- 263 bytes
server-side.md -rw-r--r-- 8.1 KB
testharness_runner.html -rw-r--r-- 95 bytes
update-built-tests.sh -rwxr-xr-x 208 bytes
wpt -rwxr-xr-x 95 bytes
wpt.py -rw-r--r-- 15 bytes

README.md

back to top