Revision 8e13c351acb8087f5a101d70bd7f9f9aebbdc1bc authored by JoostK on 21 September 2021, 21:39:11 UTC, committed by Jessica Janiuk on 26 October 2021, 18:22:33 UTC
The `ErrorCode` enum in the `error_code.ts` file is governed by public api guards but the other top-level exports from that file are exempt from public api documentation and are therefore marked as `@internal`. However, TypeScript is configured with the `stripInternal` compiler option such that declarations with `@internal` markers are not emitted into the `.d.ts` files, but this means that the reexports in the barrel file end up referring to missing declarations. The `stripInternal` option is considered internal and its documentation states to use at your own risk (as per https://github.com/microsoft/TypeScript/issues/45307). Having the option enabled is desirable for us as it works well for hiding class fields that are marked `@internal`, which is an effective way to hide members from the .d.ts file. As a workaround for the issue with top-level symbols, the declarations with `@internal` markers are moved to dedicated files for which no public api guard is setup, therefore allowing their `@internal` markers to be dropped. Fixes #43097 PR Close #43527
1 parent 59e56e7
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .devcontainer | ||
| .github | ||
| .husky | ||
| .ng-dev | ||
| .vscode | ||
| .yarn | ||
| aio | ||
| docs | ||
| goldens | ||
| integration | ||
| modules | ||
| packages | ||
| scripts | ||
| third_party | ||
| tools | ||
| .bazelignore | -rw-r--r-- | 4.2 KB |
| .bazelrc | -rw-r--r-- | 6.4 KB |
| .bazelversion | -rw-r--r-- | 6 bytes |
| .clang-format | -rw-r--r-- | 73 bytes |
| .editorconfig | -rw-r--r-- | 245 bytes |
| .gitattributes | -rw-r--r-- | 240 bytes |
| .gitignore | -rw-r--r-- | 797 bytes |
| .gitmessage | -rw-r--r-- | 7.2 KB |
| .mailmap | -rw-r--r-- | 51 bytes |
| .npmrc | -rw-r--r-- | 21 bytes |
| .nvmrc | -rw-r--r-- | 8 bytes |
| .prettierrc | -rw-r--r-- | 157 bytes |
| .pullapprove.yml | -rw-r--r-- | 46.9 KB |
| .yarnrc | -rw-r--r-- | 130 bytes |
| BUILD.bazel | -rw-r--r-- | 2.0 KB |
| CHANGELOG.md | -rw-r--r-- | 967.6 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 1.1 KB |
| CONTRIBUTING.md | -rw-r--r-- | 15.8 KB |
| LICENSE | -rw-r--r-- | 1.1 KB |
| README.md | -rw-r--r-- | 4.7 KB |
| WORKSPACE | -rw-r--r-- | 2.6 KB |
| browser-providers.conf.js | -rw-r--r-- | 6.9 KB |
| gulpfile.js | -rw-r--r-- | 631 bytes |
| karma-js.conf.js | -rw-r--r-- | 7.3 KB |
| package.json | -rw-r--r-- | 8.6 KB |
| renovate.json | -rw-r--r-- | 2.3 KB |
| test-events.js | -rw-r--r-- | 259 bytes |
| test-main.js | -rw-r--r-- | 9.4 KB |
| tsconfig-tslint.json | -rw-r--r-- | 149 bytes |
| tslint.json | -rw-r--r-- | 4.9 KB |
| yarn.lock | -rw-r--r-- | 641.3 KB |
| yarn.lock.readme.md | -rw-r--r-- | 1.3 KB |
Computing file changes ...
