Revision 9334d97a1fd4c4efb842d014dc71ac65b4a57363 authored by Tim Horner on 04 June 2024, 14:14:29 UTC, committed by Dylan Reimerink on 12 June 2024, 08:17:06 UTC
As-is, when l2 neighbor discovery is enabled, the node-neighbor-link-updater controller fails with "invalid node spec found in queue". This is due to a bug in the controller's DoFunc, where an empty list is treated the same as an invalid queue entry. When this controller fails, `cilium status` reports errors for all nodes in the cluster similar to the following: ``` cilium cilium-mgstt controller node-neighbor-link-updater is failing since 21s (49x): invalid node spec found in queue: (*manager.nodeQueueEntry)(nil) ``` To differentiate between an empty queue and a nil item, the queue's `pop` method now also returns a bool to indicate whether an element was successfully retrieved from the queue. Fixes: #8d525fe Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
1 parent 22b3e82
| File | Mode | Size |
|---|---|---|
| .devcontainer | ||
| .github | ||
| .nvim | ||
| .vscode | ||
| Documentation | ||
| api | ||
| bpf | ||
| bugtool | ||
| cilium-dbg | ||
| cilium-health | ||
| clustermesh-apiserver | ||
| contrib | ||
| daemon | ||
| examples | ||
| hack | ||
| hubble | ||
| hubble-relay | ||
| images | ||
| install | ||
| operator | ||
| pkg | ||
| plugins | ||
| test | ||
| tools | ||
| vendor | ||
| .authors.aux | -rw-r--r-- | 416 bytes |
| .clang-format | -rw-r--r-- | 7.6 KB |
| .clomonitor.yml | -rw-r--r-- | 984 bytes |
| .gitattributes | -rw-r--r-- | 887 bytes |
| .gitignore | -rw-r--r-- | 1.8 KB |
| .golangci.yaml | -rw-r--r-- | 4.4 KB |
| .mailmap | -rw-r--r-- | 6.9 KB |
| AUTHORS | -rw-r--r-- | 51.5 KB |
| CODEOWNERS | -rw-r--r-- | 28.2 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 2.2 KB |
| CONTRIBUTING.md | -rw-r--r-- | 691 bytes |
| FURTHER_READINGS.rst | -rw-r--r-- | 6.4 KB |
| LICENSE | -rw-r--r-- | 11.1 KB |
| MAINTAINERS.md | -rw-r--r-- | 4.6 KB |
| Makefile | -rw-r--r-- | 25.3 KB |
| Makefile.defs | -rw-r--r-- | 7.5 KB |
| Makefile.docker | -rw-r--r-- | 7.1 KB |
| Makefile.kind | -rw-r--r-- | 16.8 KB |
| Makefile.quiet | -rw-r--r-- | 818 bytes |
| README.rst | -rw-r--r-- | 19.6 KB |
| SECURITY-INSIGHTS.yml | -rw-r--r-- | 2.1 KB |
| SECURITY.md | -rw-r--r-- | 1.0 KB |
| USERS.md | -rw-r--r-- | 35.0 KB |
| VERSION | -rw-r--r-- | 11 bytes |
| Vagrantfile | -rw-r--r-- | 14.9 KB |
| go.mod | -rw-r--r-- | 13.7 KB |
| go.sum | -rw-r--r-- | 97.3 KB |
| netlify.toml | -rw-r--r-- | 92 bytes |
| stable.txt | -rw-r--r-- | 8 bytes |
| vagrant_box_defaults.rb | -rw-r--r-- | 334 bytes |
Computing file changes ...
