Revision d6e199016cf36ce3c790202db79e55b561789e24 authored by Maysam Yabandeh on 12 December 2019, 21:48:50 UTC, committed by myabandeh on 12 December 2019, 21:54:29 UTC
Summary: This change fixes a source issue that caused compile time error which breaks build for many fbcode services in that setup. The size() member function of channel is a const member, so member variables accessed within it are implicitly const as well. This caused error when clang fails to resolve to a constructor that takes std::mutex because the suitable constructor got rejected due to loss of constness for its argument. The fix is to add mutable modifier to the lock_ member of channel. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6161 Differential Revision: D18967685 Pulled By: maysamyabandeh fbshipit-source-id: 698b6a5153c3c92eeacb842c467aa28cc350d432
1 parent 92453f2
| File | Mode | Size |
|---|---|---|
| buckifier | ||
| build_tools | ||
| cache | ||
| cmake | ||
| coverage | ||
| db | ||
| docs | ||
| env | ||
| examples | ||
| file | ||
| hdfs | ||
| include | ||
| java | ||
| logging | ||
| memory | ||
| memtable | ||
| monitoring | ||
| options | ||
| port | ||
| table | ||
| test_util | ||
| third-party | ||
| tools | ||
| trace_replay | ||
| util | ||
| utilities | ||
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 875 bytes |
| .lgtm.yml | -rw-r--r-- | 67 bytes |
| .travis.yml | -rw-r--r-- | 3.5 KB |
| .watchmanconfig | -rw-r--r-- | 130 bytes |
| AUTHORS | -rw-r--r-- | 322 bytes |
| CMakeLists.txt | -rw-r--r-- | 38.7 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 3.3 KB |
| CONTRIBUTING.md | -rw-r--r-- | 706 bytes |
| COPYING | -rw-r--r-- | 17.7 KB |
| DEFAULT_OPTIONS_HISTORY.md | -rw-r--r-- | 1.5 KB |
| DUMP_FORMAT.md | -rw-r--r-- | 763 bytes |
| HISTORY.md | -rw-r--r-- | 98.6 KB |
| INSTALL.md | -rw-r--r-- | 7.5 KB |
| LANGUAGE-BINDINGS.md | -rw-r--r-- | 1.1 KB |
| LICENSE.Apache | -rw-r--r-- | 11.1 KB |
| LICENSE.leveldb | -rw-r--r-- | 1.5 KB |
| Makefile | -rw-r--r-- | 72.9 KB |
| README.md | -rw-r--r-- | 1.8 KB |
| ROCKSDB_LITE.md | -rw-r--r-- | 1.0 KB |
| TARGETS | -rw-r--r-- | 34.4 KB |
| USERS.md | -rw-r--r-- | 6.5 KB |
| Vagrantfile | -rw-r--r-- | 1017 bytes |
| WINDOWS_PORT.md | -rw-r--r-- | 12.5 KB |
| appveyor.yml | -rw-r--r-- | 2.7 KB |
| defs.bzl | -rw-r--r-- | 1.4 KB |
| issue_template.md | -rw-r--r-- | 243 bytes |
| src.mk | -rw-r--r-- | 32.8 KB |
| thirdparty.inc | -rw-r--r-- | 7.8 KB |
Computing file changes ...
