| 8051a03 | Junio C Hamano | 07 February 2010, 23:52:28 UTC | Merge git://repo.or.cz/git-gui * git://repo.or.cz/git-gui: git-gui: update french translation git-gui: update Japanese translation git-gui: fix shortcut for menu "Commit/Revert Changes" git-gui: Quote git path when starting another gui in a submodule git-gui: update Italian translation git-gui: Update Swedish translation (520t0f0u) git-gui: use themed tk widgets with Tk 8.5 git-gui: Update German translation (12 new or changed strings). git-gui: Update translation template git-gui: Remove unused icon file_parttick git-gui: use different icon for new and modified files in the index git-gui: set GIT_DIR and GIT_WORK_TREE after setup git-gui: update shortcut tools to use _gitworktree git-gui: handle bare repos correctly git-gui: handle non-standard worktree locations git-gui: Support applying a range of changes at once git-gui: Add a special diff popup menu for submodules git-gui: Use git diff --submodule when available | 07 February 2010, 23:52:28 UTC |
| e7ec9de | Junio C Hamano | 07 February 2010, 23:52:12 UTC | Merge branch 'maint' * maint: archive: simplify archive format guessing | 07 February 2010, 23:52:12 UTC |
| fe12d8e | René Scharfe | 07 February 2010, 23:30:20 UTC | archive: simplify archive format guessing The code to guess an output archive's format consumed any --format options and built a new one. Jonathan noticed that it does so in an unsafe way, risking to overflow the static buffer fmt_opt. Change the code to keep the existing --format options intact and to only add a new one if a format could be guessed based on the output file name. The new option is added as the first one, allowing the existing ones to overrule it, i.e. explicit --format options given on the command line win over format guesses, as before. To simplify the code further, format_from_name() is changed to return the full --format option, thus no potentially dangerous sprintf() calls are needed any more. Reported-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 February 2010, 23:40:27 UTC |
| 8424981 | Jeff King | 01 February 2010, 13:39:03 UTC | Fix invalid read in quote_c_style_counted This function did not work on strings that were not NUL-terminated. It reads through a length-bounded string, searching for characters in need of quoting. After we find one, we output the quoted character, then advance our pointer to find the next one. However, we never decremented the length, meaning we ended up looking at whatever random junk was stored after the string. This bug was not found by the existing tests because most code paths feed a NUL-terminated string. The notable exception is a directory name being fed by ls-tree. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 February 2010, 18:55:03 UTC |
| d2d66f1 | Jeff King | 01 February 2010, 12:43:45 UTC | docs: fix filter-branch example for quoted paths If there is a quoted path, update-index will correctly unquote it. However, we must take care to put our new prefix inside the double-quote. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 February 2010, 18:52:14 UTC |
| ab35469 | Brian Gernhardt | 06 February 2010, 14:50:03 UTC | t9501: Re-fix max load test Revert the previous attempt to skip this test on platforms where we currently cannot determine the system load. We want to make sure that the max-load-limit codepath produces results cleanly, when gitweb is updated and becomes capable of reading the load average by some other method. The code to check for load returns 0 if it doesn't know how to find load. It also checks to see if the current load is higher than the max load. So to force the script to quit early by setting the maxload variable negative which should work for systems where we can detect load (which should be a positive number) and systems where we can't (where detected load is 0) Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 February 2010, 18:33:07 UTC |
| 6d0d465 | Björn Gustavsson | 06 February 2010, 08:37:53 UTC | bash: support the --autosquash option for rebase Signed-off-by: Björn Gustavsson <bgustavsson@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 February 2010, 17:51:43 UTC |
| 04bf448 | Junio C Hamano | 06 February 2010, 05:22:59 UTC | Merge git://git.kernel.org/pub/scm/gitk/gitk * git://git.kernel.org/pub/scm/gitk/gitk: gitk: Fix copyright symbol in About box message | 06 February 2010, 05:22:59 UTC |
| 6448e0c | Brian Gernhardt | 06 February 2010, 05:00:40 UTC | t9501: Skip testing load if we can't detect it Currently gitweb only knows how to check for load using /proc/loadavg, which isn't available on all systems. We shouldn't fail the test just because we don't know how to check the system load. Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 February 2010, 05:12:06 UTC |
| 71f1a21 | Junio C Hamano | 06 February 2010, 00:36:56 UTC | Update draft release notes to 1.7.0 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 06 February 2010, 00:36:56 UTC |
| 3bd8de5 | Junio C Hamano | 06 February 2010, 00:34:00 UTC | Merge branch 'maint' * maint: Update git fsck --full short description to mention packs | 06 February 2010, 00:34:00 UTC |
| 2b26e0e | Wesley J. Landaker | 05 February 2010, 19:58:50 UTC | Update git fsck --full short description to mention packs The '--full' option to git fsck does two things: 1) Check objects in packs 2) Check alternate objects This is documented in the git fsck manual; this patch reflects that in the short git fsck option help message as well. Signed-off-by: Wesley J. Landaker <wjl@icecavern.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 05 February 2010, 21:01:45 UTC |
| b401a12 | Junio C Hamano | 05 February 2010, 18:59:05 UTC | Merge branch 'jc/maint-limit-note-output' into maint * jc/maint-limit-note-output: Fix "log --oneline" not to show notes Fix "log" family not to be too agressive about showing notes | 05 February 2010, 18:59:05 UTC |
| 3c8f6c8 | Junio C Hamano | 05 February 2010, 17:20:01 UTC | Revert 30816237 and 7e62265 It seems that we have bad interaction with the code related to GIT_WORK_TREE and "grep --no-index", and broke running grep inside the .git directory. For now, just revert it and resurrect it after 1.7.0 ships. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 05 February 2010, 17:27:25 UTC |
| 8bff7c5 | Andrew Myrick | 30 January 2010, 03:14:22 UTC | git-svn: persistent memoization Make memoization of the svn:mergeinfo processing functions persistent with Memoize::Storable so that the memoization tables don't need to be regenerated every time the user runs git-svn fetch. The Memoize::Storable hashes are stored in ENV{GIT_DIR}/svn/.caches. [ew: changed caches path to avoid conflicts with old repos] [ew: File::Path::{make_path => mkpath} for compatibility] [ew: line-wrapped at 80 chars] Acked-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Andrew Myrick <amyrick@apple.com> | 05 February 2010, 07:33:25 UTC |
| 4d0cc22 | Junio C Hamano | 04 February 2010, 19:10:44 UTC | fast-import: count --max-pack-size in bytes Similar in spirit to 07cf0f2 (make --max-pack-size argument to 'git pack-object' count in bytes, 2010-02-03) which made the option by the same name to pack-objects, this counts the pack size limit in bytes. In order not to cause havoc with people used to the previous megabyte scale an integer smaller than 8192 is interpreted in megabytes but the user gets a warning. Also a minimum size of 1 MiB is enforced to avoid an explosion of pack files. Signed-off-by: Junio C Hamano <gitster@pobox.com> Acked-by: Shawn O. Pearce <spearce@spearce.org> Acked-by: Nicolas Pitre <nico@fluxnic.net> | 04 February 2010, 23:12:17 UTC |
| 9f17688 | Nicolas Pitre | 04 February 2010, 21:19:35 UTC | update git-repack documentation wrt repack.UseDeltaBaseOffset This default for repack.UseDeltaBaseOffset has been "true" since Git v1.6.0. Signed-off-by: Nicolas Pitre <nico@fluxnic.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 04 February 2010, 23:12:16 UTC |
| 89c3850 | Michael J Gruber | 04 February 2010, 16:01:16 UTC | git-clean: fix the description of the default behavior Currently, when called without -n and -f, git clean issues fatal: clean.requireForce not set and -n or -f not given; refusing to clean which leaves the user wondering why force is required when requireForce is not set. Looking up in git-clean(1) does not help because its description is wrong. Change it so that git clean issues fatal: clean.requireForce defaults to true and -n or -f not given; refusing to clean in this situation (and "...set to true..." when it is set) which makes it clearer that an unset config means true here, and adjust the documentation. Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 04 February 2010, 23:12:13 UTC |
| 76ea93c | Junio C Hamano | 04 February 2010, 02:27:08 UTC | fast-import.c: Fix big-file-threshold parsing bug Manual merge made at 844ad3d (Merge branch 'sp/maint-fast-import-large-blob' into sp/fast-import-large-blob, 2010-02-01) did not correctly reflect the change of unit in which this variable's value is counted from its previous version. Now it counts in bytes, not in megabytes. Signed-off-by: Junio C Hamano <gitster@pobox.com> Acked-by: Shawn O. Pearce <spearce@spearce.org> | 04 February 2010, 17:09:50 UTC |
| 07cf0f2 | Nicolas Pitre | 04 February 2010, 03:48:28 UTC | make --max-pack-size argument to 'git pack-object' count in bytes The value passed to --max-pack-size used to count in MiB which was inconsistent with the corresponding configuration variable as well as other command arguments which are defined to count in bytes with an optional unit suffix. This brings --max-pack-size in line with the rest of Git. Also, in order not to cause havoc with people used to the previous megabyte scale, and because this is a sane thing to do anyway, a minimum size of 1 MiB is enforced to avoid an explosion of pack files. Adjust and extend test suite accordingly. Signed-off-by: Nicolas Pitre <nico@fluxnic.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 04 February 2010, 04:39:56 UTC |
| a2430dd | Nicolas Pitre | 04 February 2010, 03:48:27 UTC | pack-objects: fix pack generation when using pack_size_limit Current handling of pack_size_limit is quite suboptimal. Let's consider a list of objects to pack which contain alternatively big and small objects (which pretty matches reality when big blobs are interlaced with tree objects). Currently, the code simply close the pack and opens a new one when the next object in line breaks the size limit. The current code may degenerate into: - small tree object => store into pack #1 - big blob object busting the pack size limit => store into pack #2 - small blob but pack #2 is over the limit already => pack #3 - big blob busting the size limit => pack #4 - small tree but pack #4 is over the limit => pack #5 - big blob => pack #6 - small tree => pack #7 - ... and so on. The reality is that the content of packs 1, 3, 5 and 7 could well be stored more efficiently (and delta compressed) together in pack #1 if the big blobs were not forcing an immediate transition to a new pack. Incidentally this can be fixed pretty easily by simply skipping over those objects that are too big to fit in the current pack while trying the whole list of unwritten objects, and then that list considered from the beginning again when a new pack is opened. This creates much fewer smallish pack files and help making more predictable test cases for the test suite. This change made one of the self sanity checks useless so it is removed as well. That check was rather redundant already anyway. Signed-off-by: Nicolas Pitre <nico@fluxnic.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 04 February 2010, 04:39:24 UTC |
| 2fca19f | Nicolas Pitre | 04 February 2010, 03:48:26 UTC | fix multiple issues with t5300 First of all, trying to run 'git verify-pack' on packs produced by the tests using pack.packSizeLimit always failed. After lots of digging and head scratching, it turns out that the preceeding test simulating a SHA1 collision did leave the repository quite confused, impacting subsequent tests. So let's move that destructive test last, and add tests to run verify-pack on the output from those packSizeLimit tests to catch such goofage. Finally, group those packSizeLimit tests together. Signed-off-by: Nicolas Pitre <nico@fluxnic.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 04 February 2010, 04:38:47 UTC |
| 57017b3 | John 'Warthog9' Hawley | 03 February 2010, 11:28:28 UTC | gitweb: Simplify (and fix) chop_str The chop_str subroutine is meant to be used on strings (such as commit description / title) *before* HTML escaping, which means before applying esc_html or equivalent. Therefore get rid of the failed attempt to always remove full HTML entities (like e.g. & or ). It is not necessary (HTML entities gets added later), and it can cause chop_str to chop a string incorrectly. Specifically: API & protocol: support option to force written data immediately to disk from http://git.kernel.org/?p=daemon/distsrv/chunkd.git;a=commit;h=3b02f749df2cb1288f345a689d85e7061f507e54 The short version of the title gets chopped to API ... where it should be API & protocol: support option to force written data... Noticed-by: John 'Warthog9' Hawley <warthog9@kernel.org> Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 04 February 2010, 01:14:00 UTC |
| 7963791 | Paul Mackerras | 03 February 2010, 21:49:00 UTC | gitk: Fix copyright symbol in About box message Somehow it got corrupted in commit d93f1713 ("gitk: Use themed tk widgets"). Signed-off-by: Paul Mackerras <paulus@samba.org> | 03 February 2010, 21:49:00 UTC |
| 7928610 | René Scharfe | 03 February 2010, 18:16:30 UTC | grep: simplify assignment of ->fixed After 885d211e, the value of the ->fixed pattern option only depends on the grep option of the same name. Regex flags don't matter any more, because fixed mode and regex mode are strictly separated. Thus we can simply copy the value from struct grep_opt to struct grep_pat, as we do already for ->word_regexp and ->ignore_case. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 03 February 2010, 20:03:40 UTC |
| 4b7acc1 | Junio C Hamano | 03 February 2010, 05:48:34 UTC | Merge branch 'ms/filter-branch-submodule' * ms/filter-branch-submodule: filter-branch: Add tests for submodules in tree-filter filter-branch: Fix to allow replacing submodules with another content | 03 February 2010, 05:48:34 UTC |
| 484e669 | Junio C Hamano | 03 February 2010, 05:48:22 UTC | Merge branch 'jh/gitweb-caching' (early part) * 'jh/gitweb-caching' (early part): gitweb: Add optional extra parameter to die_error, for extended explanation gitweb: add a "string" variant of print_sort_th gitweb: add a "string" variant of print_local_time gitweb: Check that $site_header etc. are defined before using them gitweb: Makefile improvements gitweb: Load checking gitweb: Make running t9501 test with '--debug' reliable and usable | 03 February 2010, 05:48:22 UTC |
| 347d04d | Junio C Hamano | 03 February 2010, 05:48:13 UTC | Merge branch 'bw/no-python-autoconf' * bw/no-python-autoconf: configure: Allow --without-python configure: Allow GIT_ARG_SET_PATH to handle --without-PROGRAM | 03 February 2010, 05:48:13 UTC |
| d3b91fa | Junio C Hamano | 03 February 2010, 05:47:51 UTC | Merge branch 'sp/fast-import-large-blob' * sp/fast-import-large-blob: fast-import: Stream very large blobs directly to pack | 03 February 2010, 05:47:51 UTC |
| b659b49 | Shawn O. Pearce | 02 February 2010, 15:33:28 UTC | Correct spelling of 'REUC' extension The new dircache extension CACHE_EXT_RESOLVE_UNDO, whose value is 0x52455543, is actually the ASCII sequence 'REUC', not the ASCII sequence 'REUN'. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 02 February 2010, 17:54:34 UTC |
| 89d6159 | Emmanuel Trillaud | 02 February 2010, 11:59:34 UTC | git-gui: update french translation Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 02 February 2010, 15:34:04 UTC |
| 5bf4684 | Nanako Shiraishi | 02 February 2010, 10:20:21 UTC | git-gui: update Japanese translation Update ja.po to match 2010-01-26 version of pot file. Signed-off-by: しらいし ななこ <nanako3@lavabit.com> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 02 February 2010, 14:59:06 UTC |
| b8bba41 | Junio C Hamano | 02 February 2010, 06:04:03 UTC | build: make code "-Wpointer-arith" clean Recently introduced resolve_undo_read() expected arithmetic to (void *) to work on byte-addresses. Correct this. Noticed by Brandon Casey. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 02 February 2010, 06:04:03 UTC |
| dc78250 | Ben Walton | 01 February 2010, 02:15:05 UTC | configure: Allow --without-python This patch allows someone to use configure to build git while at the same time disabling the python remote helper code. It leverages the ability of GIT_ARG_SET_PATH to accept an optional second argument indicating that --without-$PROGRAM is acceptable. Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 01 February 2010, 21:03:55 UTC |
| f22cd7f | Ben Walton | 01 February 2010, 02:15:04 UTC | configure: Allow GIT_ARG_SET_PATH to handle --without-PROGRAM Add an optional second argument to both GIT_ARG_SET_PATH and GIT_CONF_APPEND_PATH such that any value of the second argument will enable configure to set NO_$PROGRAM in addition to an empty $PROGRAM_PATH. This is initially useful for allowing configure to disable the use of python, as the remote helper code has nothing leveraging it yet. The Makefile already recognizes NO_PYTHON, but configure provided no way to set it appropriately. Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 01 February 2010, 21:03:54 UTC |
| 844ad3d | Junio C Hamano | 01 February 2010, 20:41:31 UTC | Merge branch 'sp/maint-fast-import-large-blob' into sp/fast-import-large-blob * sp/maint-fast-import-large-blob: fast-import: Stream very large blobs directly to pack bash: don't offer remote transport helpers as subcommands Conflicts: fast-import.c | 01 February 2010, 20:42:00 UTC |
| 5eef828 | Shawn O. Pearce | 01 February 2010, 17:27:35 UTC | fast-import: Stream very large blobs directly to pack If a blob is larger than the configured big-file-threshold, instead of reading it into a single buffer obtained from malloc, stream it onto the end of the current pack file. Streaming the larger objects into the pack avoids the 4+ GiB memory footprint that occurs when fast-import is processing 2+ GiB blobs. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 01 February 2010, 20:09:47 UTC |
| 562d53f | Pal-Kristian Engstad | 22 January 2010, 02:33:00 UTC | git-p4: Fix sync errors due to new server version Fix sync errors due to new Perforce servers. The P4D/NTX64/2009.2/228098 (2009/12/16) server reports 'move/delete' instead of 'delete'. This causes the Perforce depot and the git repo to get out of sync. Fixed by adding the new status string. Signed-off-by: Pal-Kristian Engstad <pal_engstad@naughtydog.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 01 February 2010, 20:08:14 UTC |
| 8d9e7d5 | Jens Lehmann | 01 February 2010, 18:09:39 UTC | Updates for dirty submodules in release notes and user manual In the release notes "git status" was not mentioned, also shortly explain the "-dirty" output generated by diff. Added a paragraph to the "Pitfalls with submodules" section in user-manual.txt describing new and old behavior of "git status" and "git diff" for dirty submodules. Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 01 February 2010, 20:08:12 UTC |
| c0da5db | Junio C Hamano | 31 January 2010, 20:20:30 UTC | Update draft release notes to 1.7.0 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 January 2010, 20:20:30 UTC |
| 2ee8c5b | Junio C Hamano | 31 January 2010, 20:09:35 UTC | Merge branch 'dm/make-threaded-simplify' * dm/make-threaded-simplify: Make NO_PTHREADS the sole thread configuration variable | 31 January 2010, 20:09:35 UTC |
| 7eb151d | Dan McGee | 30 January 2010, 01:22:19 UTC | Make NO_PTHREADS the sole thread configuration variable When the first piece of threaded code was introduced in commit 8ecce684, it came with its own THREADED_DELTA_SEARCH Makefile option. Since this time, more threaded code has come into the codebase and a NO_PTHREADS option has also been added. Get rid of the original option as the newer, more generic option covers everything we need. Signed-off-by: Dan McGee <dpmcgee@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 January 2010, 19:50:50 UTC |
| 9f7a3c1 | Junio C Hamano | 31 January 2010, 19:11:16 UTC | RPM packaging: use %global inside %{!?...} According to https://www.redhat.com/archives/fedora-devel-list/2010-January/msg00093.html scope of %define lasts until the end brace; earlier RPM up to Fedora 12 didn't necessarily honor the scope, but later versions corrected the bug. Problem and solution both pointed out by Todd Zullinger. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 January 2010, 19:33:44 UTC |
| 6ddf75a | Jeff King | 31 January 2010, 09:14:46 UTC | mention new shell execution behavior in release notes This is already in the "bells and whistles" section, but it also has a slight chance of breakage, so let's also mention it in the "changed behaviors" section. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 January 2010, 18:27:56 UTC |
| de7a796 | Jens Lehmann | 31 January 2010, 16:43:49 UTC | Fix memory leak in submodule.c The strbuf used in add_submodule_odb() was never released. So for every submodule - populated or not - we leaked its object directory name when using "git diff*" with the --submodule option. Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 January 2010, 18:25:23 UTC |
| 6a5d0b0 | Ralf Wildenhues | 31 January 2010, 13:24:39 UTC | Fix typos in technical documentation. Signed-off-by: Ralf Wildenhues <Ralf.Wildenhues@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 January 2010, 18:24:53 UTC |
| aa14013 | John 'Warthog9' Hawley | 30 January 2010, 22:30:44 UTC | gitweb: Add optional extra parameter to die_error, for extended explanation Add a 3rd, optional, parameter to die_error to allow for extended error information to be output along with what the error was. Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 23:53:55 UTC |
| 1ee4b4e | John 'Warthog9' Hawley | 30 January 2010, 22:30:43 UTC | gitweb: add a "string" variant of print_sort_th Add a function (named format_sort_th) that returns the string that print_sort_th would print. Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 23:53:54 UTC |
| 0cf207f | John 'Warthog9' Hawley | 30 January 2010, 22:30:42 UTC | gitweb: add a "string" variant of print_local_time Add a function (named format_local_time) that returns the string that print_local_time would print. Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 23:53:54 UTC |
| 24d4afc | John 'Warthog9' Hawley | 30 January 2010, 22:30:41 UTC | gitweb: Check that $site_header etc. are defined before using them If one of $site_header, $site_footer or $home_text is not defined, you get extraneous errors in the web logs, for example (line wrapped for better readibility): [Wed Jan 13 16:55:42 2010] [error] [client ::1] [Wed Jan 13 16:55:42 2010] gitweb.cgi: Use of uninitialized value $site_header in -f at /var/www/gitweb/gitweb.cgi line 3287., referer: http://git/gitweb.cgi This ensures that those variables are defined before trying to use it. Note that such error can happen only because of an error in gitweb config file; building gitweb.cgi can make mentioned variables holding empty string (it is even the default), but they are still defined. Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 23:53:53 UTC |
| 62331ef | John 'Warthog9' Hawley | 30 January 2010, 22:30:40 UTC | gitweb: Makefile improvements Adjust the main Makefile so you can simply run make gitweb which in turn calls gitweb/Makefile. This means that in order to generate gitweb, you can simply run 'make' from gitweb subdirectory: cd gitweb make Targets gitweb/gitweb.cgi and (dependent on JSMIN being defined) gitweb/gitweb.min.js in main Makefile are preserved for backward compatibility. Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 23:53:52 UTC |
| b62a1a9 | John 'Warthog9' Hawley | 30 January 2010, 22:30:39 UTC | gitweb: Load checking This changes slightly the behavior of gitweb, so that it verifies that the box isn't inundated with before attempting to serve gitweb. If the box is overloaded, it basically returns a 503 Server Unavailable until the load falls below the defined threshold. This helps dramatically if you have a box that's I/O bound, reaches a certain load and you don't want gitweb, the I/O hog that it is, increasing the pain the server is already undergoing. This behavior is controlled by $maxload configuration variable. Default is a load of 300, which for most cases should never be hit. Unset it (set it to undefined value, i.e. undef) to turn off checking. Currently it requires that '/proc/loadavg' file exists, otherwise the load check is bypassed (load is taken to be 0). So platforms that do not implement '/proc/loadavg' currently cannot use this feature (provisions are included for additional checks to be added by others). There is simple test in t/t9501-gitweb-standalone-http-status.sh to check that it correctly returns "503 Service Unavailable" if load is too high, and also if there are any Perl warnings or errors. Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 23:53:50 UTC |
| 745a2db | Jakub Narebski | 30 January 2010, 22:30:38 UTC | gitweb: Make running t9501 test with '--debug' reliable and usable Remove test_debug lines after 'snapshots: tgz only default format enabled' and 'snapshots: all enabled in default, use default disabled value' tests. Those tests constitute of multiple gitweb_run invocation, therefore outputting gitweb.output for the last gitweb_run wouldn't help much in debugging test failure, and can only confuse. For snapshot tests which check for "200 OK" status, change test_debug 'cat gitweb.output' to test_debug 'cat gitweb.headers' Otherwise when running this test with '--debug' option, t/t9501-gitweb-standalone-http-status.sh would dump *binary data* (the snapshot itself) to standard output, which can mess up state of terminal due to term control characters which can be embedded in output. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 23:33:06 UTC |
| b0883aa | Junio C Hamano | 30 January 2010, 20:08:26 UTC | is_submodule_modified(): fix breakage with external GIT_INDEX_FILE Even when the environment was given for the top-level process, checking in the submodule work tree should use the index file associated with the work tree of the submodule. Do not export it to the environment. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 21:56:56 UTC |
| a9c7c43 | Junio C Hamano | 30 January 2010, 17:45:11 UTC | RPM packaging: don't include foreign-scm-helper bits yet The files in /usr/lib/python* are only the support infrastructure for foreign scm interface yet to be written and/or shipped with git. Don't include them in the binary package (this will also free us from Python dependency). When we ship with foreign scm interface, we will need to package these files with it in a separate subpackage, but we are not there yet. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 21:56:50 UTC |
| bfac23d | Dan McGee | 30 January 2010, 15:42:58 UTC | grep: Fix two memory leaks We duplicate the grep_opt structure when using grep threads, but didn't later free either the patterns attached to this new structure or the structure itself. Signed-off-by: Dan McGee <dpmcgee@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 17:11:00 UTC |
| 31d8738 | Markus Heidelberg | 30 January 2010, 16:23:37 UTC | rebase: don't invoke the pager for each commit summary This regression was introduced by commit 0aa958d (rebase: replace antiquated sed invocation, 2010-01-24), which changed the invocation of "git rev-list | sed" to "git log". It can be reproduced by something like this: $ git rebase -s recursive origin/master Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 16:42:42 UTC |
| 3a985c2 | Junio C Hamano | 30 January 2010, 07:38:31 UTC | Update draft release notes to 1.7.0 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 07:38:31 UTC |
| b10b918 | Junio C Hamano | 30 January 2010, 07:36:17 UTC | Merge branch 'maint' * maint: fix memcpy of overlapping area | 30 January 2010, 07:36:17 UTC |
| 3325cea | Junio C Hamano | 30 January 2010, 07:36:13 UTC | Merge branch 'maint-1.6.5' into maint * maint-1.6.5: fix memcpy of overlapping area | 30 January 2010, 07:36:13 UTC |
| 947c346 | Johannes Sixt | 29 January 2010, 23:54:05 UTC | Implement pthread_cond_broadcast on Windows See http://www.cse.wustl.edu/~schmidt/win32-cv-1.html, section "The SignalObjectAndWait solution". But note that this implementation does not use SignalObjectAndWait (which is needed to achieve fairness, but we do not need fairness). Note that our implementations of pthread_cond_broadcast and pthread_cond_signal require that they are invoked with the mutex held that is used in the pthread_cond_wait calls. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 03:42:40 UTC |
| a004fb9 | Sebastian Schuberth | 23 January 2010, 14:20:28 UTC | If deriving SVN_SSH from GIT_SSH on msys, also add quotes In contrast to GIT_SSH, SVN_SSH requires quotes for paths that contain spaces. As GIT_SSH will not work if it contains quotes, it is safe to assume it never contains quotes. Also, adding quotes to SVN_SSH for paths that do not contain spaces does no harm. So we always add quotes when deriving SVN_SSH from GIT_SSH on msys. This fixes msysGit issue 385, see http://code.google.com/p/msysgit/issues/detail?id=385 Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 30 January 2010, 03:37:54 UTC |
| fc4b10c | Junio C Hamano | 29 January 2010, 20:57:44 UTC | Merge git://git.kernel.org/pub/scm/gitk/gitk * git://git.kernel.org/pub/scm/gitk/gitk: gitk: Update German translation gitk: Add French translation gitk: update Italian translation gitk: Update Swedish translation gitk: Adjust two equal strings which differed in whitespace gitk: Display submodule diffs with appropriate encoding gitk: Fix display of newly-created tags gitk: Enable gitk to create tags with messages gitk: Update Hungarian translation gitk: Add Hungarian translation gitk: Add "--no-replace-objects" option | 29 January 2010, 20:57:44 UTC |
| 02e5124 | Jeff King | 29 January 2010, 10:37:23 UTC | add shebang line to git-mergetool--lib.sh Even though this script is expected to be sourced instead of executed on its own, the #!/bin/sh line provides simple documentation about what format the file is in. In particular, the lack of such a line was confusing the valgrind support of our test scripts, which assumed that any executable without a #!-line should be intercepted and run through valgrind. So during valgrind-enabled tests, any script sourcing this file actually sourced the valgrind interception script instead. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 29 January 2010, 17:56:51 UTC |
| 7b48c17 | Jeff King | 29 January 2010, 10:31:30 UTC | fix off-by-one allocation error Caught by valgrind in t5516. Reading the code shows we malloc enough for our string, but not trailing NUL. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 29 January 2010, 17:56:12 UTC |
| 65d41d4 | Jeff King | 29 January 2010, 10:28:44 UTC | fix memcpy of overlapping area Caught by valgrind in t5500, but it is pretty obvious from reading the code that this is shifting elements of an array to the left, which needs memmove. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 29 January 2010, 17:52:21 UTC |
| e1a3f28 | Shawn O. Pearce | 29 January 2010, 15:58:56 UTC | Merge branch 'maint' * maint: git-gui: fix shortcut for menu "Commit/Revert Changes" | 29 January 2010, 15:58:56 UTC |
| d6db1bb | Heiko Voigt | 29 January 2010, 15:57:48 UTC | git-gui: fix shortcut for menu "Commit/Revert Changes" The shortcut was not properly recognized previously. Signed-off-by: Heiko Voigt <heiko.voigt@mahr.de> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 29 January 2010, 15:58:52 UTC |
| d70bb62 | Christian Stimming | 29 January 2010, 11:55:14 UTC | gitk: Update German translation Signed-off-by: Christian Stimming <stimming@tuhh.de> Signed-off-by: Paul Mackerras <paulus@samba.org> | 29 January 2010, 11:55:14 UTC |
| 5cc0f82 | Emmanuel Trillaud | 12 January 2010, 13:02:50 UTC | gitk: Add French translation Signed-off-by: Emmanuel Trillaud <etrillaud@gmail.com> Signed-off-by: Thomas Moulard <thomas.moulard@gmail.com> Signed-off-by: Guy Brand <gb@unistra.fr> Signed-off-by: Nicolas Sebrecht <nicolas.s.dev@gmx.fr> Signed-off-by: Paul Mackerras <paulus@samba.org> | 29 January 2010, 11:53:44 UTC |
| 9f05312 | Michele Ballabio | 29 January 2010, 11:51:28 UTC | gitk: update Italian translation Signed-off-by: Michele Ballabio <barra_cuda@katamail.com> Signed-off-by: Paul Mackerras <paulus@samba.org> | 29 January 2010, 11:51:28 UTC |
| b495f0b | Peter Krefting | 29 January 2010, 11:50:29 UTC | gitk: Update Swedish translation Signed-off-by: Peter Krefting <peter@softwolves.pp.se> Signed-off-by: Paul Mackerras <paulus@samba.org> | 29 January 2010, 11:50:29 UTC |
| 831cc7e | Jens Lehmann | 28 January 2010, 21:20:39 UTC | git-gui: Quote git path when starting another gui in a submodule In do_git_gui the path of the git executable has to be put into a list, otherwise calling it will fail when when spaces are present in its path. Reported-by: Heiko Voigt <hvoigt@hvoigt.net> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 28 January 2010, 23:44:41 UTC |
| dace5dd | Junio C Hamano | 28 January 2010, 22:33:33 UTC | Merge branch 'maint' * maint: bash: don't offer remote transport helpers as subcommands | 28 January 2010, 22:33:33 UTC |
| 00f09d0 | SZEDER Gábor | 28 January 2010, 01:05:55 UTC | bash: support 'git notes' and its subcommands ... and it will offer refs unless after -m or -F, because these two options require a non-ref argument. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> Acked-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 22:22:37 UTC |
| 1f7d57f | Michal Sojka | 28 January 2010, 09:08:47 UTC | filter-branch: Add tests for submodules in tree-filter Add tests to make sure that: 1) a submodule can be removed and its content replaced with regular files ('rewrite submodule with another content'). This test passes only with the previous patch applied. 2) it is possible to replace submodule revision by direct index manipulation ('replace submodule revision'). Although it would be better to run such a filter in --index-filter, this test shows that this functionality is not broken by the previous patch. This succeeds both with and without the previous patch. Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 21:58:24 UTC |
| 03ca839 | Michal Sojka | 28 January 2010, 09:08:46 UTC | filter-branch: Fix to allow replacing submodules with another content When git filter-branch is used to replace a submodule with another content, it always fails on the first commit. Consider a repository with submod directory containing a submodule. The following command to remove the submodule and replace it with a file fails: git filter-branch --tree-filter 'rm -rf submod && git rm -q submod && mkdir submod && touch submod/file' with an error: error: submod: is a directory - add files inside instead The reason is that git diff-index, which generates the first part of the list of files updated by the tree filter, emits also the removed submodule even if it was replaced by a real directory. Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 21:49:53 UTC |
| 63d04a7 | SZEDER Gábor | 22 January 2010, 10:54:51 UTC | bash: don't offer remote transport helpers as subcommands Since commits a2d725b7 (Use an external program to implement fetching with curl, 2009-08-05) and c9e388bb (Make the "traditionally-supported" URLs a special case, 2009-09-03) remote transport helpers like 'remote-ftp' and 'remote-curl' are offered by the completion script as available subcommands. Not good, since they are helpers, therefore should not be offered, so filter them out. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> Acked-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 20:36:12 UTC |
| 4ff61c2 | Junio C Hamano | 28 January 2010, 20:33:42 UTC | grep --quiet: finishing touches Name the option "--quiet" not "--quick", document it, and add tests. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 20:33:42 UTC |
| 12a258c | Jeff King | 28 January 2010, 09:56:43 UTC | reject @{-1} not at beginning of object name Something like foo@{-1} is nonsensical, as the @{-N} syntax is reserved for "the Nth last branch", and is not an actual reflog selector. We should not feed such nonsense to approxidate at all. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 20:12:50 UTC |
| d46a830 | Jeff King | 28 January 2010, 09:52:22 UTC | fix parsing of @{-1}@{u} combination Previously interpret_branch_name would see @{-1} and stop parsing, leaving the @{u} as cruft that provoked an error. Instead, we should recurse if there is more to parse. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 20:12:42 UTC |
| 42cab60 | Jeff King | 28 January 2010, 09:50:20 UTC | test combinations of @{} syntax Now that we have several different types of @{} syntax, it is a good idea to test them together, which reveals some failures. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 20:12:36 UTC |
| af86deb | Jeff King | 28 January 2010, 14:52:16 UTC | rerere: fix too-short initialization This was caused by a typo in the sizeof parameter, and meant we looked at uninitialized memory. Caught by valgrind in t2030. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 17:30:14 UTC |
| cbdaf56 | Michele Ballabio | 07 September 2009, 16:45:16 UTC | git-gui: update Italian translation Signed-off-by: Michele Ballabio <barra_cuda@katamail.com> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 28 January 2010, 15:18:29 UTC |
| fe9c06b | Peter Krefting | 28 January 2010, 12:57:34 UTC | git-gui: Update Swedish translation (520t0f0u) Signed-off-by: Peter Krefting <peter@softwolves.pp.se> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 28 January 2010, 15:17:47 UTC |
| 8e52dc3 | Jeff King | 28 January 2010, 08:52:18 UTC | t0101: use absolute date The original version used relative approxidates, which don't reproduce as reliably as absolute ones. Commit 6c647a fixed this for one case, but missed the "silly" case. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 08:58:17 UTC |
| b62cb17 | Junio C Hamano | 28 January 2010, 08:46:45 UTC | Merge branch 'fk/threaded-grep' * fk/threaded-grep: Threaded grep grep: expose "status-only" feature via -q | 28 January 2010, 08:46:45 UTC |
| 811428e | Junio C Hamano | 28 January 2010, 08:46:33 UTC | Merge branch 'gp/maint-cvsserver' * gp/maint-cvsserver: git-cvsserver: allow regex metacharacters in CVSROOT | 28 January 2010, 08:46:33 UTC |
| df3dac3 | Junio C Hamano | 28 January 2010, 08:41:52 UTC | tests: update tests that used to fail "diff --cc" output t4038 tests was fixed by b810cbb (diff --cc: a lost line at the beginning of the file is shown incorrectly, 2009-07-22), which was actually the commit that introduced this test.. An error in "git merge -s resolve" t6035 tests was fixed by 730f728 (unpack-trees.c: look ahead in the index, 2009-09-20). Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 January 2010, 08:41:52 UTC |
| c80d7be | Pat Thoyts | 26 January 2010, 00:05:31 UTC | git-gui: use themed tk widgets with Tk 8.5 This patch enables the use of themed Tk widgets with Tk 8.5 and above. These make a significant difference on Windows in making the application appear native. On Windows and MacOSX ttk defaults to the native look as much as possible. On X11 the user may select a theme using the TkTheme XRDB resource class by adding an line to the .Xresources file. The set of installed theme names is available using the Tk command 'ttk::themes'. The default on X11 is similar to the current un-themed style - a kind of thin bordered motif look. A new git config variable 'gui.usettk' may be set to disable this if the user prefers the classic Tk look. Using Tk 8.4 will also avoid the use of themed widgets as these are only available since 8.5. Some support is included for Tk 8.6 features (themed spinbox and native font chooser for MacOSX and Windows). Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 28 January 2010, 01:13:52 UTC |
| ab2d3b0 | Christian Stimming | 26 January 2010, 21:26:45 UTC | git-gui: Update German translation (12 new or changed strings). Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 28 January 2010, 01:13:47 UTC |
| 7c39323 | Junio C Hamano | 27 January 2010, 22:58:21 UTC | Merge branch 'jc/upstream-reflog' * jc/upstream-reflog: Fix log -g this@{upstream} | 27 January 2010, 22:58:21 UTC |
| 103209c | Junio C Hamano | 27 January 2010, 22:57:37 UTC | Merge branch 'jc/maint-reflog-bad-timestamp' * jc/maint-reflog-bad-timestamp: t0101: use a fixed timestamp when searching in the reflog Update @{bogus.timestamp} fix not to die() approxidate_careful() reports errorneous date string | 27 January 2010, 22:57:37 UTC |
| 6818685 | Junio C Hamano | 27 January 2010, 22:56:42 UTC | Merge branch 'il/maint-colon-address' * il/maint-colon-address: Allow use of []-wrapped addresses in git:// Support addresses with ':' in git-daemon | 27 January 2010, 22:56:42 UTC |
| a0075d9 | Junio C Hamano | 27 January 2010, 22:56:38 UTC | Merge branch 'il/maint-xmallocz' * il/maint-xmallocz: Fix integer overflow in unpack_compressed_entry() Fix integer overflow in unpack_sha1_rest() Fix integer overflow in patch_delta() Add xmallocz() | 27 January 2010, 22:56:38 UTC |
| f1694b6 | Junio C Hamano | 27 January 2010, 22:56:25 UTC | Merge branch 'jh/maint-config-file-prefix' * jh/maint-config-file-prefix: builtin-config: Fix crash when using "-f <relative path>" from non-root dir | 27 January 2010, 22:56:25 UTC |
| cb21d8f | Junio C Hamano | 27 January 2010, 20:22:37 UTC | transport_get(): drop unnecessary check for !remote At the beginning of the function we make sure remote is not NULL, and the remainder of the funciton already depends on it. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 January 2010, 20:22:37 UTC |
| 4da5046 | Ilari Liusvaara | 27 January 2010, 17:53:17 UTC | Fix remote.<remote>.vcs remote.<remote>.vcs causes remote->foreign_vcs to be set on entry to transport_get(). Unfortunately, the code assumed that any such entry is stale from previous round. Fix this by making VCS set by URL to be volatile w.r.t. transport_get() instead. Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi> Acked-by: Daniel Barkalow <barkalow@iabervon.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 January 2010, 20:05:04 UTC |
| 6c647af | Junio C Hamano | 27 January 2010, 18:54:22 UTC | t0101: use a fixed timestamp when searching in the reflog That will give us a better reproducibility during tests. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 January 2010, 18:54:30 UTC |
| a5e10ac | Junio C Hamano | 27 January 2010, 18:53:09 UTC | Update @{bogus.timestamp} fix not to die() The caller will say "It is not a valid object name" if it wants to, and some callers may even try to see if it names an object and otherwise try to see if it is a path. Pointed out by Jeff King. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 January 2010, 18:53:09 UTC |
