| 1145c57 | wpedrak | 29 April 2021, 10:08:52 UTC | server: replace mlockall with `Mlock` in `--experimental-memory-mlock` Implementation of `--experimental-memory-mlock` backed by `mlockall` syscall is replaced by `Mlock` flag (backed by mlock syscall) of bboltDB. | 29 April 2021, 10:08:52 UTC |
| 927b3a3 | wpedrak | 28 April 2021, 14:00:04 UTC | server: replace mlockall with `Mlock` in `--experimental-memory-mlock` Implementation of `--experimental-memory-mlock` backed by `mlockall` syscall is replaced by `Mlock` flag (backed by mlock syscall) of bboltDB. | 29 April 2021, 10:08:20 UTC |
| cc52d99 | Piotr Tabor | 21 April 2021, 10:29:01 UTC | Merge pull request #12883 from ptabor/20210421-backend-refactor-testing mvcc/backend tests: Refactor: Do not mix testing&prod code. | 21 April 2021, 10:29:01 UTC |
| d7d110b | Piotr Tabor | 09 April 2021, 13:49:50 UTC | mvcc/backend tests: Refactor: Do not mix testing&prod code. | 21 April 2021, 07:43:13 UTC |
| ea287dd | Piotr Tabor | 21 April 2021, 07:31:38 UTC | Merge pull request #12854 from ptabor/20210410-shouldApplyV3 (no)StoreV2 (Part 3): Applying consistency fix: ClusterVersionSet (and co) might get not applied on v2store | 21 April 2021, 07:31:38 UTC |
| ce3dae6 | Piotr Tabor | 21 April 2021, 07:30:02 UTC | Merge pull request #12873 from ptabor/20210417-test-docker-gcloud Makefile: Use `gcloud auth configure-docker` instead of `gcloud docker ...` for test-images | 21 April 2021, 07:30:02 UTC |
| 0f2c940 | Sam Batschelet | 21 April 2021, 01:18:15 UTC | Merge pull request #12880 from chaochn47/exclude_alarms_from_health_check etcdhttp/metrics.go: exclude alarms from health check conditionally with `?exclude=NOSPACE` | 21 April 2021, 01:18:15 UTC |
| b321c48 | Chao Chen | 20 April 2021, 20:17:26 UTC | Update CHANGELOG-3.5.md | 20 April 2021, 20:17:26 UTC |
| 140ea4f | Chao Chen | 20 April 2021, 20:17:09 UTC | etcdhttp/metrics.go: exclude alarms from health check conditionally with ?exclude=NOSPACE | 20 April 2021, 20:17:09 UTC |
| 8162d9c | Piotr Tabor | 19 April 2021, 21:08:42 UTC | Merge pull request #12876 from qsyqian/branch_management_link doc: fix branch management link | 19 April 2021, 21:08:42 UTC |
| 334e696 | Gyuho Lee | 19 April 2021, 17:12:42 UTC | Merge pull request #12878 from lilic/fix-docker-release Makefile, build.sh: Fix build process | 19 April 2021, 17:12:42 UTC |
| 51c28fc | Lili Cosic | 19 April 2021, 15:48:23 UTC | build.sh: Adjust building etcdctl to be same as etcd binary This fixes so that the ENV vars are taken in the same way as for etcd binary. | 19 April 2021, 15:51:46 UTC |
| 81652d1 | Lili Cosic | 19 April 2021, 15:46:36 UTC | Makefile: Fix build-docker-release-master Since the Dockerfile files are now per arch, this adjusts to detect ARCH and builds docker release from the Dockerfile.<ARCH> file. | 19 April 2021, 15:47:03 UTC |
| 11249fd | Piotr Tabor | 19 April 2021, 14:51:49 UTC | Merge pull request #12874 from ptabor/20210417-go1.16.3 Update go for 3.5: 1.15.x -> 1.16.3 | 19 April 2021, 14:51:49 UTC |
| 3423a94 | Piotr Tabor | 17 April 2021, 10:21:14 UTC | Update go for 3.5: 1.15 -> 1.16.(3). https://github.com/etcd-io/etcd/issues/12732 | 19 April 2021, 14:50:54 UTC |
| 2cbd86b | qsyqian | 19 April 2021, 07:25:19 UTC | doc: fix branch management link Fixes #12875 | 19 April 2021, 07:25:19 UTC |
| 2f77a1a | Piotr Tabor | 18 April 2021, 15:44:07 UTC | Merge pull request #12864 from ssbostan/master client: fix check datascale command for https endpoints | 18 April 2021, 15:44:07 UTC |
| 06ba0fc | Piotr Tabor | 17 April 2021, 10:58:46 UTC | Merge pull request #12846 from pyiyun/fix-snaptmpfile-bug etcdserver: remove temp files in snap dir when etcdserver starting | 17 April 2021, 10:58:46 UTC |
| 5ad8880 | Piotr Tabor | 17 April 2021, 10:11:09 UTC | Makefile: Use gcloud auth configure-docker instead of gcloud docker. | 17 April 2021, 10:11:09 UTC |
| 97a8aff | Saeid Bostandoust | 17 April 2021, 09:54:56 UTC | fix util.go file | 17 April 2021, 09:54:56 UTC |
| 80586c5 | chao | 16 April 2021, 23:39:34 UTC | etcdserver/util.go: reduce memory when logging range requests (#12871) * etcdserver/util.go: reduce memory when logging range requests Fixes #12835 * Update CHANGELOG-3.5.md | 16 April 2021, 23:39:34 UTC |
| 5744cdf | Piotr Tabor | 16 April 2021, 19:49:46 UTC | Merge pull request #12870 from ptabor/20210416-fix-flake-TestSnapshotV3RestoreMultiMemberAdd-master Fix TestSnapshotV3RestoreMultiMemberAdd flakes (leaks) | 16 April 2021, 19:49:46 UTC |
| 17b9823 | Piotr Tabor | 16 April 2021, 16:55:56 UTC | Fix TestSnapshotV3RestoreMultiMemberAdd flakes (leaks) - most important: unix's socket transport should not keep idle connections. For top-level Transport we close them using: https://github.com/etcd-io/etcd/blob/f3c518025e284d3d070a63d5969c69176f247b33/server/etcdserver/api/rafthttp/transport.go#L226 but currently we don't have access to close them witing the nest (unix) transport. Short idle deadline is good enough. - Use dialContext (instead of dial) to make sure context is passed down the stack - Make sure Context is cancelled as soon as the operation is done in pipeline - nit: use dedicated method to yeld goroutines. Tested with: ``` d=$(date +"%Y%m%d_%H%M") (cd tests && go test --timeout=60m ./integration/snapshot -run TestSnapshotV3RestoreMultiMemberAdd -v --count=180 2>&1 | tee log_${d}.log) ``` There were transports & cmux leaked: ``` leak.go:118: Test appears to have leaked a Transport: internal/poll.runtime_pollWait(0x7f6c5c3784c8, 0x72, 0xffffffffffffffff) /usr/lib/google-golang/src/runtime/netpoll.go:222 +0x55 internal/poll.(*pollDesc).wait(0xc003296298, 0x72, 0x0, 0x18, 0xffffffffffffffff) /usr/lib/google-golang/src/internal/poll/fd_poll_runtime.go:87 +0x45 internal/poll.(*pollDesc).waitRead(...) /usr/lib/google-golang/src/internal/poll/fd_poll_runtime.go:92 internal/poll.(*FD).Read(0xc003296280, 0xc0031f60a8, 0x18, 0x18, 0x0, 0x0, 0x0) /usr/lib/google-golang/src/internal/poll/fd_unix.go:166 +0x1d5 net.(*netFD).Read(0xc003296280, 0xc0031f60a8, 0x18, 0x18, 0x18, 0xc0009056e2, 0x203000) /usr/lib/google-golang/src/net/fd_posix.go:55 +0x4f net.(*conn).Read(0xc000010258, 0xc0031f60a8, 0x18, 0x18, 0x0, 0x0, 0x0) /usr/lib/google-golang/src/net/net.go:183 +0x91 github.com/soheilhy/cmux.(*bufferedReader).Read(0xc0003d24e0, 0xc0031f60a8, 0x18, 0x18, 0xc0003d24d0, 0xc0009056e2, 0xc000278400) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/buffer.go:53 +0x12d github.com/soheilhy/cmux.hasHTTP2Preface(0x1367e20, 0xc0003d24e0, 0x7f6c5c699f40) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/matchers.go:195 +0x8a github.com/soheilhy/cmux.matchersToMatchWriters.func1(0x7f6c5c699f40, 0xc000010258, 0x1367e20, 0xc0003d24e0, 0xc000010258) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:128 +0x39 github.com/soheilhy/cmux.(*cMux).serve(0xc003228690, 0x138c410, 0xc000010258, 0xc00327f740, 0xc0059ba860) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:192 +0x1e7 created by github.com/soheilhy/cmux.(*cMux).Serve /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:179 +0x191 internal/poll.runtime_pollWait(0x7f6c5c60f3f0, 0x72, 0xffffffffffffffff) /usr/lib/google-golang/src/runtime/netpoll.go:222 +0x55 internal/poll.(*pollDesc).wait(0xc000d53018, 0x72, 0x1000, 0x1000, 0xffffffffffffffff) /usr/lib/google-golang/src/internal/poll/fd_poll_runtime.go:87 +0x45 internal/poll.(*pollDesc).waitRead(...) /usr/lib/google-golang/src/internal/poll/fd_poll_runtime.go:92 internal/poll.(*FD).Read(0xc000d53000, 0xc000cfd000, 0x1000, 0x1000, 0x0, 0x0, 0x0) /usr/lib/google-golang/src/internal/poll/fd_unix.go:166 +0x1d5 net.(*netFD).Read(0xc000d53000, 0xc000cfd000, 0x1000, 0x1000, 0x3, 0x3, 0x1000000000001) /usr/lib/google-golang/src/net/fd_posix.go:55 +0x4f net.(*conn).Read(0xc00031a570, 0xc000cfd000, 0x1000, 0x1000, 0x0, 0x0, 0x0) /usr/lib/google-golang/src/net/net.go:183 +0x91 net/http.(*persistConn).Read(0xc00093b320, 0xc000cfd000, 0x1000, 0x1000, 0x577750, 0x60, 0x0) /usr/lib/google-golang/src/net/http/transport.go:1933 +0x77 bufio.(*Reader).fill(0xc005702fc0) /usr/lib/google-golang/src/bufio/bufio.go:101 +0x108 bufio.(*Reader).Peek(0xc005702fc0, 0x1, 0xc00077c660, 0xc003b082a0, 0xc000d08de0, 0x5ae586, 0x11dd6c0) /usr/lib/google-golang/src/bufio/bufio.go:139 +0x4f net/http.(*persistConn).readLoop(0xc00093b320) /usr/lib/google-golang/src/net/http/transport.go:2094 +0x1a8 created by net/http.(*Transport).dialConn /usr/lib/google-golang/src/net/http/transport.go:1754 +0xdaa net/http.(*persistConn).writeLoop(0xc00093b320) /usr/lib/google-golang/src/net/http/transport.go:2393 +0xf7 created by net/http.(*Transport).dialConn /usr/lib/google-golang/src/net/http/transport.go:1755 +0xdcf sync.runtime_Semacquire(0xc0059ba868) /usr/lib/google-golang/src/runtime/sema.go:56 +0x45 sync.(*WaitGroup).Wait(0xc0059ba860) /usr/lib/google-golang/src/sync/waitgroup.go:130 +0x65 github.com/soheilhy/cmux.(*cMux).Serve.func1(0xc003228690, 0xc0059ba860) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:158 +0x56 github.com/soheilhy/cmux.(*cMux).Serve(0xc003228690, 0x13698c0, 0xc00377a0f0) /home/ptab/private/golang/pkg/mod/github.com/soheilhy/cmux@v0.1.5/cmux.go:173 +0x115 go.etcd.io/etcd/server/v3/embed.(*Etcd).servePeers.func1(0xc0007cc360, 0x122b75f) /home/ptab/corp/etcd/server/embed/etcd.go:518 +0x2b9 go.etcd.io/etcd/server/v3/embed.(*Etcd).servePeers.func3(0xc00036d080, 0xc0059330a0) /home/ptab/corp/etcd/server/embed/etcd.go:549 +0x182 created by go.etcd.io/etcd/server/v3/embed.(*Etcd).servePeers /home/ptab/corp/etcd/server/embed/etcd.go:543 +0x73a --- FAIL: TestSnapshotV3RestoreMultiMemberAdd (17.74s) ``` | 16 April 2021, 18:17:28 UTC |
| 28a490b | pyiyun | 09 April 2021, 01:58:56 UTC | etcdserver: remove temp files in snap dir when etcdServer starting When etcd exits abnormally, tmp files will remain in snap dir, so clean up tmp files in snap dir when etcdserver starting. Fixes #12837 | 16 April 2021, 12:30:04 UTC |
| a9c4301 | Saeid Bostandoust | 15 April 2021, 23:21:04 UTC | fix check datascale command for https endpoints | 15 April 2021, 23:21:04 UTC |
| f3c5180 | Piotr Tabor | 15 April 2021, 22:07:35 UTC | Merge pull request #12861 from ptabor/20210413-test-logging-fixes Embedded server should not mess global loggers (by default) | 15 April 2021, 22:07:35 UTC |
| b47c5fc | Piotr Tabor | 15 April 2021, 15:54:37 UTC | Address review comments a.d. logging. | 15 April 2021, 15:54:37 UTC |
| c73da74 | Piotr Tabor | 15 April 2021, 15:37:03 UTC | Merge pull request #12862 from lilic/enable-race .travis.yaml: Enables race in the tests | 15 April 2021, 15:37:03 UTC |
| 2843fde | Lili Cosic | 15 April 2021, 12:06:45 UTC | .travis.yaml: Enables race in the tests As the TestV3WatchRestoreSnapshotUnsync flakiness was fixed, this removes the TODO and enables the race again. | 15 April 2021, 12:32:52 UTC |
| fad6391 | Piotr Tabor | 14 April 2021, 10:31:37 UTC | Configure proper logging for grpc integration tests. | 14 April 2021, 10:47:38 UTC |
| d72f7ef | Piotr Tabor | 14 April 2021, 10:16:11 UTC | Give control to Embedded servers whether they override global loggers So far each instance of embed server was overriding the grpc loggers and zap.global loggers. It's counter intutitive that last created Embedded server was 'wining' and more-over it was breaking grpc expectation to change it "only" before the grpc stack is being used. This PR introduces explicit call: `embed.Config::SetupGlobalLoggers()`, that changes the loggers where requested. The call is used by etcd main binary. The immediate benefit from this change is reduction of test flakiness, as there were flakes due to not a proper logger being used across tests. | 14 April 2021, 10:47:38 UTC |
| eafbc8c | Piotr Tabor | 14 April 2021, 07:16:11 UTC | Update zap logging dependency. In particular bring up zapgrpc V2 code: https://github.com/uber-go/zap/commit/89e382035d3a984a01e6c9c8be5462f11efac844 https://pkg.go.dev/google.golang.org/grpc/grpclog#LoggerV2 | 14 April 2021, 10:15:48 UTC |
| 57a092b | Piotr Tabor | 13 April 2021, 21:05:52 UTC | Merge pull request #12859 from tomwilkie/fix-mixin Fix the mixin. | 13 April 2021, 21:05:52 UTC |
| d69e46e | Piotr Tabor | 13 April 2021, 21:01:03 UTC | Make ShouldApplyV3 an enum - not bool | 13 April 2021, 21:01:03 UTC |
| 562d645 | Tom Wilkie | 13 April 2021, 18:38:55 UTC | Fix the mixin. Signed-off-by: Tom Wilkie <tom@grafana.com> | 13 April 2021, 18:38:55 UTC |
| 4388bfc | Piotr Tabor | 13 April 2021, 15:33:43 UTC | Merge pull request #12858 from hnlq715/patch-1 client: fix doc typo | 13 April 2021, 15:33:43 UTC |
| 5db0070 | 大可 | 13 April 2021, 14:22:42 UTC | Update doc.go | 13 April 2021, 14:22:42 UTC |
| d7e971e | 大可 | 13 April 2021, 08:33:24 UTC | client: fix doc typo | 13 April 2021, 08:33:24 UTC |
| b1c04ce | Piotr Tabor | 10 April 2021, 09:42:15 UTC | Applying consistency fix: ClusterVersionSet (and co) might get no applied on v2store ClusterVersionSet, ClusterMemberAttrSet, DowngradeInfoSet functions are writing both to V2store and backend. Prior this CL there were in a branch not executed if shouldApplyV3 was false, e.g. during restore when Backend is up-to-date (has high consistency-index) while v2store requires replay from WAL log. The most serious consequence of this bug was that v2store after restore could have different index (revision) than the same exact store before restore, so potentially different content between replicas. Also this change is supressing double-applying of Membership (ClusterConfig) changes on Backend (store v3) - that lackilly are not part of MVCC/KeyValue store, so they didn't caused Revisions to be bumped. Inspired by jingyih@ comment: https://github.com/etcd-io/etcd/pull/12820#issuecomment-815299406 | 12 April 2021, 07:43:48 UTC |
| 7f97dfd | Piotr Tabor | 09 April 2021, 14:41:54 UTC | Merge pull request #12795 from wpedrak/resend-read-index-on-first-commit-in-term etcdserver: resend ReadIndex request on empty apply request | 09 April 2021, 14:41:54 UTC |
| 08ea9cb | wpedrak | 31 March 2021, 09:04:19 UTC | etcdserver: integration test covering first commit in current term notification | 09 April 2021, 14:05:02 UTC |
| 3991a8c | wpedrak | 29 March 2021, 10:31:44 UTC | etcdserver: replace `forceVersionC` with `FirstCommitInTermNotify` | 09 April 2021, 09:30:42 UTC |
| 3d485fa | wpedrak | 23 March 2021, 15:39:05 UTC | etcdserver: resend ReadIndex request on empty apply request Empty apply indicates first commit in current term. It is first time when follower is sure, that it's ReadIndex request can be processed. | 09 April 2021, 09:30:42 UTC |
| bad0b4d | Piotr Tabor | 08 April 2021, 13:14:53 UTC | Merge pull request #12823 from mtulio/chore/dash-var-refresh chore/dash-var-refresh: change default refresh to 2(time range) | 08 April 2021, 13:14:53 UTC |
| aeeecc0 | Marco Tulio R Braga | 08 April 2021, 13:09:01 UTC | fix/dash-var-refresh: add const and description | 08 April 2021, 13:12:41 UTC |
| 63c25bf | Piotr Tabor | 08 April 2021, 07:22:22 UTC | Merge pull request #12804 from ptabor/20210326-v3-publish server: v2store deprecation: Prepare to use publishV3 instead of publish V2. | 08 April 2021, 07:22:22 UTC |
| e776efb | Piotr Tabor | 07 April 2021, 23:20:07 UTC | Merge pull request #12828 from ptabor/20210404-embed-etcd embed: etcd.Close() is closing Errc() channel as well. | 07 April 2021, 23:20:07 UTC |
| 5da9cac | Piotr Tabor | 04 April 2021, 13:25:10 UTC | embed: etcd.Close() is closing Errc() channel as well. Inspired by https://github.com/etcd-io/etcd/pull/9612 by purpleidea@. | 07 April 2021, 23:19:13 UTC |
| cc0f812 | Piotr Tabor | 07 April 2021, 18:38:16 UTC | server_test.go: Use context.Background() instead of TODO in tests. Suggected in: https://golang.org/pkg/context/#Background | 07 April 2021, 23:15:16 UTC |
| d4a8093 | Piotr Tabor | 28 March 2021, 10:58:30 UTC | Switch release-test (upgrade test) to use etcd 3.4 (instead of 3.3) as upgrade-base. | 07 April 2021, 23:15:16 UTC |
| 931af49 | Piotr Tabor | 07 April 2021, 22:48:41 UTC | Merge pull request #12830 from ptabor/20210405-split-pkg Split client/pkg as dedicated low-dependencies module for client | 07 April 2021, 23:12:17 UTC |
| 816d332 | Piotr Tabor | 07 April 2021, 22:48:41 UTC | Merge pull request #12830 from ptabor/20210405-split-pkg Split client/pkg as dedicated low-dependencies module for client | 07 April 2021, 22:48:41 UTC |
| 24d2a9d | Piotr Tabor | 07 April 2021, 18:26:10 UTC | test.sh: Turn off enforcement for minimal go.sum. It seems that generated go.sum differs between different go versions. This was introducing noise in the tests. | 07 April 2021, 18:26:10 UTC |
| e24e72c | Piotr Tabor | 07 April 2021, 18:23:08 UTC | Merge pull request #12836 from chalin/chalin-contrib-lock-2021-04-06 Contrib lock example | 07 April 2021, 18:23:08 UTC |
| 3bb7acc | Piotr Tabor | 05 April 2021, 20:31:07 UTC | Migrate dependencies pkg/foo -> client/pkg/foo | 06 April 2021, 22:38:47 UTC |
| 7168409 | Piotr Tabor | 06 April 2021, 21:46:20 UTC | Merge pull request #12829 from garenchan/dev/etcdctl-lock etcdctl: lock return exit code of exec-command | 06 April 2021, 21:46:20 UTC |
| 2ba69de | Patrice Chalin | 06 April 2021, 19:21:01 UTC | Contrib lock example | 06 April 2021, 19:21:01 UTC |
| c047ed5 | garenchan | 05 April 2021, 03:55:55 UTC | etcdctl: lock return exit code of exec-command Sometimes we expect to get the exit code of the command being executed. | 06 April 2021, 06:34:31 UTC |
| 0b81fdf | Piotr Tabor | 05 April 2021, 18:36:38 UTC | Move pkg/* used by client to client/pkg. | 05 April 2021, 21:47:27 UTC |
| dfb03ab | Piotr Tabor | 02 April 2021, 09:04:38 UTC | Merge pull request #12826 from allenporter/reporting-bugs Fix "reporting bugs" link in documentation, which currently 404s | 02 April 2021, 09:04:38 UTC |
| 1906cfd | Allen Porter | 02 April 2021, 02:22:02 UTC | etcdserver: Fix "reporting bugs" link in documentation, which currently 404s Update the "reporting bugs" link to be the current correct url from the documentation, replacing a dash with an underscore in the URL. | 02 April 2021, 02:24:15 UTC |
| d2bc534 | Marco Braga | 01 April 2021, 03:03:31 UTC | chore/dash-var-refresh: change default refresh to 2(time range) | 01 April 2021, 03:06:57 UTC |
| d18ac20 | Piotr Tabor | 30 March 2021, 10:59:41 UTC | Merge pull request #12766 from mrajashree/master Update cert generation Makefile to include configurable cert file names | 30 March 2021, 10:59:41 UTC |
| a49c7ec | Piotr Tabor | 30 March 2021, 10:53:02 UTC | Merge pull request #12817 from cwedgwood/3.4-changelog CHANGELOG-3.4 updates | 30 March 2021, 10:53:02 UTC |
| 5d05be3 | Chris Wedgwood | 29 March 2021, 18:38:25 UTC | CHANGELOG-3.4 updates | 29 March 2021, 18:38:25 UTC |
| 7899f76 | Sam Batschelet | 29 March 2021, 18:30:21 UTC | Merge pull request #12812 from hexfusion/bump-cl-3.2 CHANGELOG: release 3.2 | 29 March 2021, 18:30:21 UTC |
| b04477a | Sam Batschelet | 28 March 2021, 22:58:22 UTC | CHANGELOG: release 3.2 Signed-off-by: Sam Batschelet <sbatsche@redhat.com> | 29 March 2021, 02:19:47 UTC |
| a40a6e9 | Sam Batschelet | 28 March 2021, 23:14:13 UTC | Merge pull request #12805 from ptabor/20210326-minor-test-fixes tests: logging & temp-dir fixes | 28 March 2021, 23:14:13 UTC |
| 52b81bb | Sam Batschelet | 28 March 2021, 23:12:43 UTC | Merge pull request #12807 from ptabor/20210327-update-cmux-stable Update dependencies -> in particular cmux to stable 1.15.0 | 28 March 2021, 23:12:43 UTC |
| 578ffd5 | Piotr Tabor | 27 March 2021, 20:08:50 UTC | Merge pull request #12790 from nvanbenschoten/reduce-raft-proto-size raft: disable XXX_NoUnkeyedLiteral, XXX_unrecognized, and XXX_sizecache fields in protos | 27 March 2021, 20:08:50 UTC |
| f290ab2 | Piotr Tabor | 27 March 2021, 19:48:33 UTC | Update dependecies: github.com/grpc-ecosystem/grpc-gateway v1.14.6 -> grpc-gateway v1.16.0 golang.org/x/time v0.0.0-20200630173020-3af7569d3a1e->v0.0.0-20210220033141-f8bda1e9f3ba | 27 March 2021, 19:48:33 UTC |
| c49807f | Piotr Tabor | 27 March 2021, 10:18:13 UTC | Update cmux to 1.5.0. Executed using: ``` ./scripts/update_dep.sh github.com/soheilhy/cmux v0.1.5 ``` | 27 March 2021, 10:18:13 UTC |
| 7665bd7 | Piotr Tabor | 27 March 2021, 10:16:29 UTC | scripts/update_dep.sh: Script to update selected versions of dependencies. | 27 March 2021, 10:17:56 UTC |
| 55ccbe6 | Piotr Tabor | 26 March 2021, 12:47:04 UTC | membership/cluster_test: Use zaptest logger. | 26 March 2021, 12:54:59 UTC |
| 03f55ee | Piotr Tabor | 26 March 2021, 12:19:49 UTC | Make NewTmpBackend use testing tmp location (so cleanup). | 26 March 2021, 12:54:55 UTC |
| 8ee1dd9 | Piotr Tabor | 25 March 2021, 07:23:00 UTC | Merge pull request #12735 from ptabor/20210227-reduce-store-v2-clean no-store_v2: Store ConfState as part of WAL log snapshot | 25 March 2021, 07:23:00 UTC |
| 4d4c84e | Piotr Tabor | 28 February 2021, 13:40:01 UTC | server: Written Snapshot's to WAL contains populated ConfState. This will (among others) allow etcd-3.6 to not depend on store_v2 .snap files at all, as WAL + db file will be self-sufficient. | 24 March 2021, 23:31:44 UTC |
| fce0c19 | Piotr Tabor | 28 February 2021, 13:39:41 UTC | Regenerate protos. | 24 March 2021, 23:31:44 UTC |
| 9180e8e | Piotr Tabor | 28 February 2021, 13:38:24 UTC | wal: Update WAL Snapshot format to contain ConfState. | 24 March 2021, 23:31:44 UTC |
| 65d6a1f | Piotr Tabor | 24 March 2021, 22:57:56 UTC | Merge pull request #12801 from ptabor/20210323-try-upgrade-proto Update dep: github.com/golang/protobuf v1.3.5 -> v1.5.1, grpc: 1.32->1.36 | 24 March 2021, 22:57:56 UTC |
| d0962f1 | Piotr Tabor | 24 March 2021, 21:06:06 UTC | Adopt grpc_testing to grpc-1.36. | 24 March 2021, 22:31:03 UTC |
| a606766 | Piotr Tabor | 24 March 2021, 20:23:14 UTC | Update dep: grpc: 1.32.0 -> 1.36.0. | 24 March 2021, 21:27:55 UTC |
| 45fb7b4 | Piotr Tabor | 24 March 2021, 19:40:56 UTC | Update dep: github.com/golang/protobuf v1.3.5 -> v1.5.1 Thanks to https://go-review.googlesource.com/c/protobuf/+/300869/ its feasible now. | 24 March 2021, 21:27:12 UTC |
| 7d7a9c6 | Piotr Tabor | 24 March 2021, 20:51:47 UTC | codec.go: should use google runtime golang-proto runtime can deal with both: gogo & golang generated protobufs. It does not work vice-versa with protobuf-1.5.1. | 24 March 2021, 21:06:47 UTC |
| 62d3ede | Piotr Tabor | 24 March 2021, 19:34:19 UTC | test.sh: Temporarilly disable the "eeshew you" fmt check. | 24 March 2021, 19:40:13 UTC |
| 1b300cd | Piotr Tabor | 24 March 2021, 09:46:39 UTC | Merge pull request #12796 from joelsmith/master *: Update gogo/protobuf to v1.3.2, rerun ./scripts/genproto.sh | 24 March 2021, 09:46:39 UTC |
| 21188b5 | Gyuho Lee | 23 March 2021, 18:34:50 UTC | Merge pull request #12798 from gyuho/security security: add private distributor list, and its application template | 23 March 2021, 18:34:50 UTC |
| f18f609 | Gyuho Lee | 23 March 2021, 18:16:38 UTC | security: add private distributor list, and its application template Signed-off-by: Gyuho Lee <leegyuho@amazon.com> | 23 March 2021, 18:34:15 UTC |
| 19f7c6e | Joel Smith | 23 March 2021, 17:42:57 UTC | *: Update gogo/protobuf to v1.3.2, rerun ./scripts/genproto.sh While it appears that etcd is not vulnerable to CVE-2021-3121, it is a good idea to update to the new generator so that new vulnerable code isn't generated in any future APIs. Also, this lays the issue to rest of whether there is any issue with etcd and CVE-2021-3121. | 23 March 2021, 17:48:06 UTC |
| 4f34f14 | Piotr Tabor | 23 March 2021, 14:57:31 UTC | Merge pull request #12762 from wpedrak/postpone-read-index raft: postpone MsgReadIndex until first commit in the term | 23 March 2021, 14:57:31 UTC |
| 30ce606 | Piotr Tabor | 23 March 2021, 12:47:41 UTC | Merge pull request #12780 from wpedrak/read_index_retry Read index retry | 23 March 2021, 12:47:41 UTC |
| 758ff01 | wpedrak | 11 March 2021, 14:39:41 UTC | raft: postpone MsgReadIndex until first commit in the term Fixes #12680 | 23 March 2021, 11:28:42 UTC |
| 456e129 | Piotr Tabor | 23 March 2021, 08:19:26 UTC | Merge pull request #12793 from gliptak/patch-1 Correct ineffassign | 23 March 2021, 08:19:26 UTC |
| 49d19ef | Gábor Lipták | 22 March 2021, 18:11:30 UTC | Correct ineffassign | 22 March 2021, 18:11:30 UTC |
| e51c697 | Nathan VanBenschoten | 20 March 2021, 06:33:40 UTC | raft: disable XXX_NoUnkeyedLiteral, XXX_unrecognized, and XXX_sizecache fields in protos This commit removes the `XXX_NoUnkeyedLiteral`, `XXX_unrecognized`, and `XXX_sizecache` auto-generated fields from generated protobuf structs in the raft package. This was done for all of the same reasons CockroachDB removed the generation of these fields in https://github.com/cockroachdb/cockroach/pull/38404. They come with very limited advantages but moderate disadvantages. `XXX_NoUnkeyedLiteral` and `XXX_sizecache` were only enabled recently in cc7b4fa, and this appears to have been unintentional. Meanwhile, `XXX_unrecognized` has been around for longer and has arguably more reason to stay because it can assist with forwards compatibility. However, any real mixed-version upgrade story for this package is mostly untold at this point, and keeping this field seems just as likely to cause unexpected bugs (e.g. a field was propagated but not updated correctly when passed through an old version) as it seems to fix real issues, so it also doesn't warrant its cost. This reduces the in-memory representation size of all Raft protos. Notably, it reduces the memory size of an `Entry` proto from *80 bytes* to *48 bytes* and the memory size of a `Message` proto from *392 bytes* to *264 bytes*. Both of these structs are used frequently, and often in slices, where this wasted space really starts to add up. This was motivated by a regression in microbenchmarks in CockroachDB due to cc7b4fa, which was caught in https://github.com/cockroachdb/cockroach/issues/62212. | 20 March 2021, 07:24:18 UTC |
| ebc0174 | Nathan VanBenschoten | 20 March 2021, 06:13:05 UTC | raft: Add TestProtoMemorySizes test This test checks the in-memory size of each proto struct to detect unexpected changes to their memory representation. | 20 March 2021, 07:23:57 UTC |
| 8469108 | Piotr Tabor | 19 March 2021, 19:10:11 UTC | Merge pull request #12782 from ptabor/20210316-fixes Integration: Test flakiness fixes | 19 March 2021, 19:10:11 UTC |
| 18321a0 | Piotr Tabor | 18 March 2021, 20:55:51 UTC | Merge pull request #12786 from ptabor/20210318-debug-env client: Bring back ETCD_CLIENT_DEBUG variable interpretation. | 18 March 2021, 20:55:51 UTC |
| e2b5835 | Piotr Tabor | 18 March 2021, 18:44:28 UTC | Fix go-tip: (1.17) fmt error: ``` gofmt' started at Thu Mar 18 18:06:00 UTC 2021 transport/sockopt_unix.go diff -u transport/sockopt_unix.go.orig transport/sockopt_unix.go --- transport/sockopt_unix.go.orig 2021-03-18 18:06:01.667483834 +0000 +++ transport/sockopt_unix.go 2021-03-18 18:06:01.667483834 +0000 @@ -1,3 +1,4 @@ +//go:build !windows // +build !windows package transport transport/sockopt_windows.go diff -u transport/sockopt_windows.go.orig transport/sockopt_windows.go --- transport/sockopt_windows.go.orig 2021-03-18 18:06:01.667483834 +0000 +++ transport/sockopt_windows.go 2021-03-18 18:06:01.667483834 +0000 @@ -1,3 +1,4 @@ +//go:build windows // +build windows ``` | 18 March 2021, 18:44:28 UTC |
| 9312d1b | Piotr Tabor | 18 March 2021, 10:00:36 UTC | clientv3: Bring back ETCD_CLIENT_DEBUG variable interpretation. env ETCD_CLIENT_DEBUG supports log levels (debug, info, warn, error, dpanic, panic, fatal). Only when set, overrides application-wide grpc logging settings. | 18 March 2021, 17:43:07 UTC |
