| d82c309 | Vincenzo Eduardo Padulano | 10 April 2024, 12:55:55 UTC | [tmva] Warn when using RBDT and xgboost Representing the current situation at https://github.com/root-project/root/issues/15197 | 11 April 2024, 09:53:51 UTC |
| 0d56835 | Jonas Rembser | 09 April 2024, 22:18:45 UTC | [TMVA] Disable `rbdt_xgboost` test Disabled because RBDT doesn't support the imbalanced tree structure of XGBoost models. We need to disable this test right now, because we have now installed XGBoost on the GitHub action runners, and this test will be red. This test never worked, we just never noticed because XGBoost was not installed on any CI platform. Backport of a commit from #15183. | 09 April 2024, 23:37:56 UTC |
| c2cacce | moneta | 03 April 2024, 08:12:23 UTC | [tmva][tutorials] Fix dependency of tutorials Fix the dependency of Python and C++ tutorials using the Higgs_trained_model.h5 file | 03 April 2024, 21:58:51 UTC |
| f7c6065 | moneta | 03 April 2024, 17:36:36 UTC | [tutorials][tmva] Use different name for header and weights in some SOFIE tutorials | 03 April 2024, 21:58:51 UTC |
| 734ccf3 | Danilo Piparo | 03 April 2024, 10:03:45 UTC | [skip-ci][ci] Skip matrix overrides in case of workflow_dispatch events, which is what is triggered when releasing. | 03 April 2024, 10:04:30 UTC |
| 406832b | moneta | 02 April 2024, 16:59:22 UTC | [tmva] Fix TMVA_SOFIE tutorial dependency | 02 April 2024, 20:34:13 UTC |
| a7bd218 | moneta | 02 April 2024, 13:22:35 UTC | [tmva] Backport for master new versions of tutorial The new versions of tutorial should fix some sporadic failures observed when creating the data file | 02 April 2024, 20:34:13 UTC |
| 82d205e | moneta | 02 April 2024, 09:04:50 UTC | [tmva][pymva] Improve handling of input files in keras and pytorch tutorials | 02 April 2024, 20:34:13 UTC |
| 220d77d | Vassil Vassilev | 25 March 2024, 08:06:36 UTC | [runtime_cxxmodules] Allow for changing the modulemap name to match the overlay. Fixes #14964 | 27 March 2024, 22:12:39 UTC |
| d47192f | Vassil Vassilev | 14 March 2024, 16:40:18 UTC | [runtime_cxxmodules] Do not overlay on top of the unix modulemaps. We should have separate cases for unix and apple, otherwise the modulemaps go on top of each other. | 27 March 2024, 22:12:39 UTC |
| ff1b7a6 | Danilo Piparo | 13 March 2024, 16:13:00 UTC | [graphics] Save memory when obtaining TImageDump instance by using TClass instead of the interpreter. As a side effect, the whole process is much faster. fixes an incarnation of #14156, mitigating the overall effect of the highlighted behaviour | 25 March 2024, 13:46:21 UTC |
| 461f44c | Vincenzo Eduardo Padulano | 19 March 2024, 09:14:16 UTC | [PyROOT] Avoid the interpreter to query info for array pythonizations Substitute the C++ functions GetSizeOfType and GetDataPointer in our CPython extension library for the equivalent cppyy functions. | 20 March 2024, 18:36:33 UTC |
| eae7f0f | moneta | 27 November 2023, 13:55:40 UTC | [tmva][pymva] Avoid creating output file tmva.root These tutorials don't need to create an output root file of the training. This avois potential problem of running the tutorials in parallel and writing on the same file | 18 March 2024, 10:15:26 UTC |
| b3899e6 | Danilo Piparo | 16 March 2024, 09:22:12 UTC | [ci] Remove GFAL option for mac-beta | 16 March 2024, 16:57:56 UTC |
| 6c749b0 | Richard Smith | 01 April 2022, 01:40:40 UTC | An expression should only contain an unexpanded parameter pack if it lexically contains a mention of the pack. Systematically distinguish between syntactic and semantic references to packs, especially when propagating dependence from a type into an expression. We should consult the type-as-written when computing syntactic dependence and should consult the semantic type when computing semantic dependence. Fixes #54402. | 16 March 2024, 16:57:56 UTC |
| 1c71250 | Pavlo Svirin | 09 January 2024, 12:42:56 UTC | Added patch for #7128 bugfix | 16 March 2024, 16:57:56 UTC |
| 1443779 | Pavlo Svirin | 09 January 2024, 21:28:16 UTC | CLing cleanup for #7128 bugfix | 16 March 2024, 16:57:56 UTC |
| 582d313 | Vassil Vassilev | 08 March 2024, 20:40:23 UTC | [runtime_cxxmodules] Fix libcxx on osx15.3 | 16 March 2024, 16:57:56 UTC |
| de0b5f5 | Vassil Vassilev | 11 March 2024, 15:56:18 UTC | Update core/clingutils/CMakeLists.txt Co-authored-by: Giulio Eulisse <10544+ktf@users.noreply.github.com> | 16 March 2024, 16:57:56 UTC |
| 5e1ec2c | Danilo Piparo | 12 March 2024, 11:36:56 UTC | [ci] Add mac-beta builds | 16 March 2024, 16:57:56 UTC |
| 4b6659d | moneta | 15 March 2024, 16:20:39 UTC | [pymva] Remove import of deprecated torch function | 15 March 2024, 16:33:58 UTC |
| 2cb5559 | moneta | 15 March 2024, 11:15:36 UTC | [tmva][pymva] Remove depreacted function in SOFIE torch parser The torch funciton _set_onnx_shape_inference is now deprecated in torch >=1.14 versions. It is now removed | 15 March 2024, 13:21:11 UTC |
| 010f559 | moneta | 15 March 2024, 09:43:18 UTC | [tmva][pymva] Changes for new version (1.4) of scikit-learn With new version of scikit-learn the bool parameters must be passed as bool and not anymore as integers. In addition in AdaBoost base_estimator was renamed to estimator | 15 March 2024, 13:21:11 UTC |
| b321dc7 | Bertrand Bellenot | 01 September 2023, 06:32:08 UTC | [TMVA] Don't use the same file name (`TMVA.root`) everywhere (#13576) * [TMVA] Don't use the same file name (`TMVA.root`) everywhere Use different file names (instead of `TMVA.root` everywhere), to prevent potential conflicts when running the test concurrently. Trying to solve the following kind of error on Windows: ``` SysError in <TFile::TFile>: could not delete C:\ROOT-CI\build\runtutorials\TMVA.root (errno: 13) Permission denied ``` * [skip-ci] fix a typo in the documentation | 12 March 2024, 10:38:01 UTC |
| 73cfc12 | Bertrand Bellenot | 12 March 2024, 08:34:04 UTC | [roofit] Disable failing tests on Windows Disable tutorials failing on Windows with VS 2022 v17.8 | 12 March 2024, 10:29:57 UTC |
| 595d1aa | Bertrand Bellenot | 12 March 2024, 08:45:38 UTC | [skip-ci][windows] disable mtbb201_parallelHistoFill.C (#14936) * [windows] disable mtbb201_parallelHistoFill.C mtbb201_parallelHistoFill.C fails on Windows x86 and VS v17.9 with the following error: IncrementalExecutor::executeFunction: symbol '_Thrd_sleep_for@4' unresolved while linking [cling interface function]! Due to this line: std::this_thread::sleep_for(std::chrono::duration<double, std::nano>(500)); * Update tutorials/CMakeLists.txt | 12 March 2024, 08:45:38 UTC |
| 8d037d0 | Lorenzo Moneta | 11 March 2024, 17:18:01 UTC | Backport change to use .h5 files instead of .keras in 6.28 branch (#14926) * disable tmva-sofie for mac nodes * [tmva][pymva] Use .h5 file instead of .keras Go back to use .h5 files instead of .keras due to a problem in Keras loading .keras files on MacOS ARM (see https://github.com/keras-team/keras/issues/18278 ) * Revert "disable tmva-sofie for mac nodes" This reverts commit ad3d343cb994de5d2613f7b04acb26d6a04e3664. * chage from .keras .h5 also in macro test file | 11 March 2024, 17:18:01 UTC |
| f1ce32d | Danilo Piparo | 08 March 2024, 14:48:15 UTC | [skip ci][ci] Set gfal to OFF for mac builds | 08 March 2024, 14:48:15 UTC |
| 0a34159 | Danilo Piparo | 08 March 2024, 08:01:55 UTC | [skip ci][ci] Add CXX17 to all builds by default | 08 March 2024, 08:01:55 UTC |
| 2166914 | Danilo Piparo | 07 March 2024, 13:37:56 UTC | [skip ci][ci] Remove gfal and root7 for Windows builds | 07 March 2024, 13:37:56 UTC |
| f0a5285 | Danilo Piparo | 07 March 2024, 13:25:23 UTC | [skip ci][ci] Require CXX17 for Macos and Linux builds | 07 March 2024, 13:25:23 UTC |
| cd45661 | Danilo Piparo | 07 March 2024, 08:35:40 UTC | [skip ci][ci] Instruct Checkout action to fetch the correct branch of the root repository. | 07 March 2024, 08:35:40 UTC |
| 33a5d42 | Danilo Piparo | 05 March 2024, 20:30:05 UTC | [skip ci][ci] Remove oracle from default options for the new CI | 05 March 2024, 20:30:05 UTC |
| 19b7fe4 | Danilo Piparo | 05 March 2024, 16:11:24 UTC | [skip ci][ci] Configure 628 builds on the new CI | 05 March 2024, 16:16:34 UTC |
| ed0df17 | Vincenzo Eduardo Padulano | 15 February 2024, 12:25:01 UTC | [tmva] Completely relax float comparison in TestSofieModels | 22 February 2024, 10:58:14 UTC |
| f6be9dc | Vincenzo Eduardo Padulano | 04 February 2024, 14:26:12 UTC | [tmva] Relax float comparison in test | 15 February 2024, 10:15:58 UTC |
| a8d678e | Jonas Hahnfeld | 02 February 2024, 12:37:22 UTC | [core/zip] Add test for compression buffer sizes This would have found any of the previous three commits. (cherry picked from commit 73d8c3d616bd9dd5b8288b879c6dd3f4dbfc3d26) | 08 February 2024, 10:56:51 UTC |
| e2c444a | Jonas Hahnfeld | 02 February 2024, 08:59:27 UTC | [core/zip] Validate target size before compression In practice, the target size is greater or equal the source size in most cases for ROOT, but add this additional correct check to fuzz the inputs in the next commit. (cherry picked from commit 23261a631c9e53a2ca7981a61d174c6465873a0e) | 08 February 2024, 10:56:51 UTC |
| 06f1297 | Jonas Hahnfeld | 02 February 2024, 08:47:05 UTC | [core/lzma] Properly account for kHeaderSize lzma_code must only see the buffers without the header, so the sizes have to be adjusted accordingly. Fixes https://github.com/root-project/root/issues/14508 (cherry picked from commit 17e35619159c236302b526caa35d1b5f707587b2) | 08 February 2024, 10:56:51 UTC |
| e4d6646 | Jonas Hahnfeld | 02 February 2024, 12:39:23 UTC | [core/zip] Properly account for HDRSIZE in R__zipZLIB R__unzipZLIB is already properly subtracting it from srcsize. (cherry picked from commit 44d1c2355cd5ae53b811de53061ecd6cabcd0a14) | 08 February 2024, 10:56:51 UTC |
| 2f00d6d | moneta | 26 January 2024, 16:13:04 UTC | [math][fitter] Fix crash when doing a weighted likelihood fit A bug was introduced in #10439 affecting the weighted likelihood fits Add missing test for Weighted likelihood fits in stressHistoFit | 01 February 2024, 13:12:05 UTC |
| 38b33bb | Danilo Piparo | 30 January 2024, 15:23:38 UTC | [relnotes] Fix links rendering of webpage | 30 January 2024, 15:23:38 UTC |
| 643785c | Danilo Piparo | 30 January 2024, 15:22:14 UTC | [relnotes] Fix rendering of webpage | 30 January 2024, 15:22:14 UTC |
| 8f23966 | Danilo Piparo | 30 January 2024, 10:18:02 UTC | "Update ROOT version files to v6.28/13." | 30 January 2024, 10:18:02 UTC |
| a25ba7c | Danilo Piparo | 30 January 2024, 08:13:32 UTC | "Update ROOT version files to v6.28/12." | 30 January 2024, 08:13:32 UTC |
| 2c56d61 | Danilo Piparo | 30 January 2024, 08:07:30 UTC | [relnotes] Update for 6.28/12. | 30 January 2024, 08:07:30 UTC |
| d1fb58e | Danilo Piparo | 30 January 2024, 07:33:55 UTC | [NFC] Spelling | 30 January 2024, 07:33:55 UTC |
| 1233eb0 | Sergey Linev | 19 January 2024, 08:27:39 UTC | [tbrowser] check web canvas creation Allow to create web-based canvas only if web display is enabled. It only can happen programmatically | 29 January 2024, 20:05:00 UTC |
| 7a7abc6 | Sergey Linev | 30 November 2023, 10:18:58 UTC | [http] disable default webgui page There was simple lists of windows. Even now it is not possible connect them - just forbid this | 29 January 2024, 20:05:00 UTC |
| 939f603 | Sergey Linev | 13 December 2023, 09:02:04 UTC | [webgui] secure arguments for http server creation Prevent possibility to provide extra (potentially dangerous) arguments to creation of engines in http server | 29 January 2024, 20:05:00 UTC |
| 9cc8c39 | Sergey Linev | 07 December 2023, 08:51:21 UTC | [rbrowser] do not allow reconnect | 29 January 2024, 20:05:00 UTC |
| a7ad984 | Sergey Linev | 06 December 2023, 07:28:32 UTC | [http] do not expose current dir for webgui webgui uses THttpServer with limited functionality. Normally files from current directory can be read via THttpServer, but not in case of webgui where it opens potential security problem | 29 January 2024, 20:05:00 UTC |
| bf51a3b | Sergey Linev | 06 December 2023, 16:48:58 UTC | [webgui] RWebWindowsManager::SetLoopbackMode() Introduce such method to let switch it off - for very special cases. | 29 January 2024, 20:05:00 UTC |
| 9694b7e | Sergey Linev | 07 December 2023, 12:52:24 UTC | Provide initializer for TROOT web display flags | 29 January 2024, 19:54:54 UTC |
| 99cb5b3 | Sergey Linev | 07 December 2023, 12:47:52 UTC | Disable rc parameter for web based tree viewer If in rootrc file web-based tree viewer stored and web mode is not active, it will be disabled with warning message | 29 January 2024, 19:54:54 UTC |
| 59721fd | Sergey Linev | 06 December 2023, 16:31:12 UTC | Let start web browser only in web mode | 29 January 2024, 19:54:54 UTC |
| 2f55c4e | Sergey Linev | 06 December 2023, 16:30:36 UTC | Do not create web canvas and browser from rootrc Handling in normal TRootGuiFactory, where normal classes are created as well | 29 January 2024, 19:54:54 UTC |
| 4a62f69 | Sergey Linev | 06 December 2023, 16:30:02 UTC | Do not create web browser from rootrc without web | 29 January 2024, 19:54:54 UTC |
| 150c1bd | Sergey Linev | 06 December 2023, 16:29:11 UTC | Disable WebGui.Display rootrc parameter | 29 January 2024, 19:54:54 UTC |
| 68c03c1 | Sergey Linev | 06 December 2023, 16:28:41 UTC | Disable --web args for TApplication | 29 January 2024, 19:54:54 UTC |
| 3a028d5 | Danilo Piparo | 26 January 2024, 07:34:36 UTC | [Core] Change logo date from 2023 to 2024 | 26 January 2024, 07:45:42 UTC |
| ebb702f | Bertrand Bellenot | 25 January 2024, 08:01:20 UTC | [v6-28][core][backport] Fix random crashes on Windows Fix random crashes of the `imt101_parTreeProcessing` tutorial on Windows | 25 January 2024, 11:20:30 UTC |
| 4fe40a6 | Olivier Couet | 25 January 2024, 09:17:17 UTC | Remove matomo code (#14431) | 25 January 2024, 09:17:17 UTC |
| 19eff09 | Vincenzo Eduardo Padulano | 16 January 2024, 20:49:44 UTC | [core] Fix statements at global scope in TCling test `TInterpreter::Declare` does not support issuing statements on the global scope, while `TInterpreter::ProcessLine` does. This test was first introduced in a development version of ROOT (6.31), where the upgrade to LLVM16 was already in place. In that scenario, clang supports global scope statements (thanks to changes made for clang-repl). Applying the test to ROOT 6.30 uncovered the problem, since the clang of LLVM13 does not support global scope statements. Fix the test by using `ProcessLine` instead of `Declare` which does the intended thing independently from the ROOT version. Co-authored-by: Vassil Vassilev <vasil.georgiev.vasilev@cern.ch> | 24 January 2024, 20:09:02 UTC |
| 943e821 | Vincenzo Eduardo Padulano | 08 January 2024, 10:53:20 UTC | [core] Make some constants constexpr This allows us to avoid generating symbols in libCore for these constants keeping the same amount of open calls at ROOT startup time. | 24 January 2024, 20:09:02 UTC |
| 4afc72e | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Prefer variable initializer over symbol search Symbol lookup is a quite expensive operation and might result in JIT compilation and library loading. Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 24 January 2024, 20:09:02 UTC |
| 9d068f9 | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Evaluate initializer of constant variables Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 24 January 2024, 20:09:02 UTC |
| 71bf80e | Vassil Vassilev | 08 January 2024, 10:21:54 UTC | [core] Reduce symbol search only to when autoloading is enabled. The llvm9 JIT issued callbacks when a symbol was missing and we reacted on it by loading the relevant library. In root-project/root@9b2041e3 we have kept the logic but now the JIT started querying more often even for symbols which are okay to be missing. In turn that leads to scanning all libraries causing performance issues. This patch tries to limit this functionality only in contexts where automatic loading is allowed. | 24 January 2024, 20:09:02 UTC |
| 9b126d2 | moneta | 06 October 2023, 11:22:30 UTC | [tmva] Fix dependency and speed-up TMVA_CNN and TMVA_RNN tutorials | 22 January 2024, 09:35:10 UTC |
| c99b924 | Philippe Canal | 11 December 2023, 10:05:06 UTC | Core: Add missing typeid name demangling | 19 January 2024, 22:53:38 UTC |
| 3d12501 | Philippe Canal | 08 December 2023, 20:55:20 UTC | Core: Avoid (indirect) memory hoarding in TPluginManager. This was reported at https://github.com/art-framework-suite/art/issues/142 and is due to the combination of (a) We do not generate dictionary for std::tuple instances (b) When TClass::GetClass is called it tries to load the dictonary until there is a full TClass object is in memory (c) The emulated std::tuple TClass are marked as 'not loaded' (d) Searching for the TClass for a templated class will cost memory (during the lookup of the instantiation). (e) TPluginManager::ExecPluginImpl was looking up the TClass for the typle `std::type< list of arguments>` The lookup induced in (e) in the user's case (root built with runtime cxx module on) lead to some memory allocation in Clang while trying to find out if there was now a library or dictionary to load. | 19 January 2024, 22:53:38 UTC |
| 72e02d1 | Vincenzo Eduardo Padulano | 19 December 2023, 17:14:16 UTC | [core] Materialize symbols for TError variables The variables present in TError.h are used throughout the ROOT libraries. Anytime one of these variables is requested, e.g. with a simple test such as `python -c "import ROOT; ROOT.kError"`, the interpreter will lookup the corresponding symbol. Previously, the variables were declared and defined in the header directly but were not generating any symbol since the linkage was internal. With this commit, provide external linkage to these variables so that the corresponding symbols are materialized in libCore.so. As a consequence, a huge number of extra lookups by cling is avoided. | 20 December 2023, 08:49:55 UTC |
| a42cc81 | Vincenzo Eduardo Padulano | 18 December 2023, 07:50:06 UTC | [core] Properly define TString::kNPOS data member according to standard C++ A declaration of a static data member *is not* also a definition, even if the data member is default-initialized in the class body. The definition must be explicitly written in one TU, which also ensures proper ODR use. See https://en.cppreference.com/w/cpp/language/definition. Co-authored-by: Jonas Hahnfeld <jonas.hahnfeld@cern.ch> | 19 December 2023, 13:13:10 UTC |
| 6587bb1 | Bertrand Bellenot | 14 December 2023, 08:10:32 UTC | Add a safety check on `std::multimap::empty()` Prevent a potential crash on Windows in Debug mode when the multimap is empty | 15 December 2023, 09:36:47 UTC |
| 6c58f17 | Bertrand Bellenot | 11 December 2023, 14:40:44 UTC | Use the correct parameter types for `NetLocalGroupEnum` and `NetLocalGroupGetMembers` | 13 December 2023, 16:31:47 UTC |
| 1766f21 | Jonas Hahnfeld | 24 November 2023, 13:39:34 UTC | [cling] DeclUnloader: Remove extra check isInstantiatedInPCH This effectively reverts commit 74472caaa9 ("[cling] Fixes issue in DeclUnloader: do not unload templates intantiated in the PCH"), it's not needed anymore, all tests pass and the snippet in the summary of https://github.com/root-project/root/pull/4447 works, but it filters too many declarations from the unloader. (cherry picked from commit 1c3ea0a068bc22eacf0dee087d8e3e2801b8018d) | 13 December 2023, 09:06:01 UTC |
| f12ae12 | Javier Lopez-Gomez | 29 August 2023, 14:43:05 UTC | [cling] DeclUnloader: do not delete instantiated member functions The body of member functions of a templated class only gets instantiated when the function is used. These `CXXMethodDecl` should not be deleted from the AST; instead return them to the 'instantiation pending' state. (cherry picked from commit afba1d737aeafd554ac4763fcc2d542de961be2a) | 13 December 2023, 09:06:01 UTC |
| 4571e1b | Javier Lopez-Gomez | 29 August 2023, 14:43:05 UTC | [cling] DeclUnloader: remove StaticVarCollector StaticVarCollector recursively visited descendants of a `FunctionDecl` node to collect static local variables. However, these always appear in the enclosing DeclContext. (cherry picked from commit bd28a5b793947c1b777edb376c35062da409281b) | 13 December 2023, 09:06:01 UTC |
| 95c304c | Javier Lopez-Gomez | 24 August 2023, 13:39:44 UTC | [cling] Fix unmatched `#pragma clang diagnostic push` Cherry-picked from 94c5c9e3d134fa69cfe14f6d731eeaf6a540b39c. | 13 December 2023, 09:06:01 UTC |
| 481fab3 | Javier Lopez-Gomez | 24 August 2023, 13:39:44 UTC | [cling][NFC] Move helper functions to anonymous namespace at the beginning Cherry-picked from fa2cacb4413fc43e8ea58c561e2d62bd43e22f5d. | 13 December 2023, 09:06:01 UTC |
| 5df8b8f | Sergey Linev | 30 November 2023, 13:07:47 UTC | [webgui] do not build without http | 01 December 2023, 07:14:29 UTC |
| ad63cee | Danilo Piparo | 27 November 2023, 20:46:05 UTC | "Update ROOT version files to v6.28/11." | 27 November 2023, 20:46:05 UTC |
| f7ba9bf | Danilo Piparo | 27 November 2023, 20:22:19 UTC | "Update ROOT version files to v6.28/10." | 27 November 2023, 20:42:22 UTC |
| c55f24b | Danilo Piparo | 27 November 2023, 19:21:20 UTC | [relnotes] Update for 6.28/10. | 27 November 2023, 19:21:20 UTC |
| 492215d | Sergey Linev | 27 November 2023, 15:55:36 UTC | [webgui] use classical browser by default | 27 November 2023, 18:21:55 UTC |
| 5434c69 | Sergey Linev | 27 November 2023, 12:12:47 UTC | [webgui] always use loopback Disregard of rootrc parameters always assign loopback. The only valid alternative - unix socket. FastCGI is also disabled for the moment; it is alternative to civetweb | 27 November 2023, 17:00:34 UTC |
| ba65f3b | Sergey Linev | 27 November 2023, 11:59:03 UTC | [webgui] change RBrowser warning | 27 November 2023, 17:00:34 UTC |
| 5bd09b7 | Sergey Linev | 23 November 2023, 10:16:40 UTC | [jsroot] 7.3.x 23/11/2023 Fix - draw histogram with only negative bins jsroot:#276 Fix - reading TLeaf with fixed-size array Fix - correctly set pave name jsroot:#278 | 23 November 2023, 16:51:41 UTC |
| 2735cc8 | Sergey Linev | 21 November 2023, 07:32:09 UTC | [webgui] use loopback by default Default value is on in C++ code, but was remained off in system.rootrc and over-rulling C++ | 21 November 2023, 17:02:07 UTC |
| 60f680f | Olivier Couet | 21 November 2023, 09:26:55 UTC | [v6-28] Backport Cocoa (#14020) * Fix Cocoa GUI for MacOS14 and clang5 * Fix the text editor (Thanks Timur !) | 21 November 2023, 09:26:55 UTC |
| 79424c0 | Sergey Linev | 31 October 2023, 08:49:28 UTC | [jsroot] 7.3.x 31/10/2023 1. Fix - correctly set visibility level for geo drawing 2. Fix - use more factor for number of nodes in geo drawing 3. Fix - add missing Chebyshev0 function 4. Fix - provide Gaus with normalization 5. Fix - call 3D rendering after adding TPolyLine3D 6. Fix - properly add interactive resize elements 7. Fix - drop handling on tabs layout 8. Fix - member-wise streaming of std::map #262 9. Fix - typo in expandItem 10. Fix - add missing import in RPavePainter 11. Fix - prevent drawing of empty TGraph 12. Fix - use semicolon in RH3 13. Fix - prevent zero division when drawing TGraph exclusion 14. Fix - draw th2 col bins with configured y bar 15. Fix - let handle derived classes from TH1/TH2 #269 16. Fix - add support of #mp symbol 17. Fix - support TMath::Sq() function 18. Fix - prevent drawing of empty TGraph | 31 October 2023, 11:53:52 UTC |
| 55a4c23 | Jonas Rembser | 28 October 2023, 13:02:10 UTC | [PyROOT] Fix typo in recent PyROOT commit `Metho_` -> `Method_` | 28 October 2023, 14:43:52 UTC |
| b3f6230 | Jonas Rembser | 23 October 2023, 19:40:30 UTC | [PyROOT] Add patch for commit that avoids failing CPython 3.12 assert | 28 October 2023, 14:43:52 UTC |
| 6a2341d | Jonas Rembser | 20 October 2023, 16:56:32 UTC | [PyROOT] Prevent functions from crashing due to Python 3.12 assert Since Python 3.12, in the implementation of 'classobject.h' the function PyMethod_GET_SELF performs an assert to check that the passed function argument is a method: ``` \#define _PyMethod_CAST(meth) \ (assert(PyMethod_Check(meth)), _Py_CAST(PyMethodObject*, meth)) [...] static inline PyObject* PyMethod_GET_SELF(PyObject *meth) { return _PyMethod_CAST(meth)->im_self; } ``` It's fair that the assert fails, because the Python type of `meth` in this context is not a `PyMethod_Type`, but the `CustomInstanceMethod_Type` from cppyy. However, as can be seen in the implementation of `CustomInstanceMethod_New`, the actual C++ type that implements this custom cppy type is just the regular `PyMethodObject`. Hence, this commit suggests new assert-free `CustomInstanceMethod_GET_*` macros that replace the `PyMethod_GET_*` macros in the context of the `CustomInstanceMethod` implementation. | 28 October 2023, 14:43:52 UTC |
| 0f8b06b | Pere Mato | 26 October 2023, 09:11:27 UTC | Make FindMySQL.cmake more tolerant | 27 October 2023, 14:32:03 UTC |
| a1297c3 | Sergey Linev | 26 October 2023, 07:19:53 UTC | [tbrowser] ensure that TCanvas created when web mode is not active In "classical" TBrowser one want to use normal TCanvas - even if rootrc configured differently. Therefore change gEnv values for the time when canvas is created | 26 October 2023, 13:36:23 UTC |
| bf3e7b5 | Vincenzo Eduardo Padulano | 24 October 2023, 14:30:01 UTC | [PyROOT] Fix distributed RDataFrame tests due to error serialization This commit enables serialization of the Python proxy defined within cppyy to the C++ std::runtime_error class. By doing so, we avoid errors that happen in certain configurations of Dask tasks where a std::runtime_error may be thrown within the event loop itself. Recent CI failures report the following: ``` RDataFrame::Run: event loop was interrupted Warning in <TBufferFile::WriteObjectAny>: since runtime_error has no public constructor which can be called without argument, objects of this class can not be read with the current library. You will need to add a default constructor before attempting to read it. Warning in <TStreamerInfo::Build>: runtime_error: base class exception has no streamer or dictionary it will not be saved Warning in <TStreamerInfo::Build>: runtime_error: __cow_string has no streamer or dictionary, data member "_M_msg" will not be saved Error in <TClass::New>: cannot create object of class runtime_error Error in <TBufferFile::ReadObject>: could not create object of class runtime_error *** Break *** segmentation violation ``` This is due to the fact that for some reason the std::runtime_error object is serialized at the end of the function scope within the Dask task. The culprit is the [tblib](https://github.com/ionelmc/python-tblib) Python package, a dependency of Dask. Its most recent version (3.0.0) released on October 22th changes the pickling behaviour of exception objects, which is now evidently more enforced than before. Downgrading to previous versions of tblib make the errors above disappear in the distributed RDataFrame tests. | 25 October 2023, 07:24:55 UTC |
| 919f224 | Danilo Piparo | 04 October 2023, 09:17:39 UTC | [PyROOT] Speedup inclusion of ROOT module by removing invocations to the root-config executable. This executable was invoked twice to check if RDataFrame was available. Such a behaviour causes a severe slowdown, especially on cvmfs. This has been replaced by a simple string comparison. Backport of 4c863d | 22 October 2023, 05:33:30 UTC |
| 08b1d43 | Jonas Hahnfeld | 13 October 2023, 14:36:42 UTC | [clang] Fix crash with constexpr destructor Fixes https://github.com/root-project/root/issues/13851 See also https://github.com/llvm/llvm-project/issues/68702 (cherry picked from commit 0919a5359eefda0fc9e56a3198da21596114d62f) | 18 October 2023, 09:32:54 UTC |
| ebb1810 | Bertrand Bellenot | 03 October 2023, 10:56:43 UTC | Add the `TWebFile::Close(Option_t *option)` method This is needed to properly close and delete the socket when closing the file in `TROOT::CloseFiles()`, preventing a potential issue when trying to close the socket afterwards | 17 October 2023, 07:01:38 UTC |
