| 40b4fb7 | Axel Naumann | 28 August 2023, 11:26:43 UTC | "Update ROOT version files to v6.28/06." | 28 August 2023, 11:26:43 UTC |
| f6765fc | Axel Naumann | 28 August 2023, 11:08:57 UTC | [relnotes] Update for 6.28/06. | 28 August 2023, 11:08:57 UTC |
| 1913ab5 | Jonas Hahnfeld | 23 August 2023, 12:10:30 UTC | std.modulemap: Make bits/invoke.h optional It only appears in GCC 7, but C++14 is already supported since GCC 6 and users want to build ROOT 6.28 using that compiler. | 23 August 2023, 14:14:00 UTC |
| 16a8fbd | Bertrand Bellenot | 18 August 2023, 07:30:22 UTC | [windows] Make `OpenDirectory` and `GetDirEntry` thread safe (#13472) * [windows] Make `OpenDirectory` and `GetDirEntry` thread safe Create a struct holding the flag, `HANDLE`, and `WIN32_FIND_DATA` used by `OpenDirectory`, `GetDirEntry`, and `FreeDirectory`, so each thread creates its own instance of it. This fixes randome failures in mutithreaded applications on Windows, like for example in the `R__USE_IMT` part of the `datasource-root` test: ``` [ RUN ] TRootTDS.DefineSlotMT Error in <TFile::TFile>: file C:/root-dev/build/x64/debug/tree/dataframe/test/G__NTupleStruct.vcx does not exist [ OK ] TRootTDS.DefineSlotMT (191 ms) [ RUN ] TRootTDS.FromARDFMT Error in <TFile::Init>: C:/root-dev/build/x64/debug/tree/dataframe/test/INSTALL.vcxproj not a ROOT file C:\root-dev\git\master\tree\dataframe\test\datasource_root.cxx(175): error: Expected equality of these values: 29. Which is: 29 *max Which is: 23 [ FAILED ] TRootTDS.FromARDFMT (6 ms) ``` * Adress the comments from Axel * Pass the correct pointer to the helper * Cosmetics * Update core/winnt/src/TWinNTSystem.cxx Prevent possible memory leak Co-authored-by: Philippe Canal <pcanal@fnal.gov> * Update core/winnt/src/TWinNTSystem.cxx --------- Co-authored-by: Philippe Canal <pcanal@fnal.gov> | 22 August 2023, 09:31:47 UTC |
| 063dbfc | Philippe Canal | 14 August 2023, 19:36:30 UTC | io: Do not turn on automatically MustClean for TDirectory | 21 August 2023, 16:52:04 UTC |
| 2328350 | moneta | 09 August 2023, 08:09:07 UTC | Fix stressHistoFit for some sporadic failures observed on some platform: - fix random initialization. Now histograms are always generated with same seeds - fix 2D poly fitting by increase histogram statistics - increase tolerance for GSLSimAn fit (cherry picked from commit 6ec300319f1eb4afe5e7b19965405fd7532d17c1) | 21 August 2023, 06:26:26 UTC |
| 078bd82 | Jonas Hahnfeld | 08 May 2023, 09:10:32 UTC | [stressVector] Tolerate even higher deviation of TLorentzVector::DeltaR The test currently fails on mac13arm. (cherry picked from commit f237213f79718d083fe2ad0ef17de0b114a20e19) | 21 August 2023, 06:26:26 UTC |
| 4db7d19 | Philippe Canal | 16 August 2023, 00:39:58 UTC | Delete the object held by gROOT after we reset the globals. For example this allows unique_ptr to be deleted first and thus inform TROOT if need be. Fix #13462 | 16 August 2023, 22:46:33 UTC |
| cbd020d | Sergey Linev | 15 August 2023, 08:08:40 UTC | [webgui] add firefox/chrome browser locations from Gentoo | 16 August 2023, 07:37:58 UTC |
| 7ad9196 | Sergey Linev | 15 August 2023, 08:03:40 UTC | [cmake] add firefox/chrome browsers names from Gentoo | 16 August 2023, 07:37:58 UTC |
| a8f4be7 | Sergey Linev | 15 August 2023, 08:43:32 UTC | [cmake] remove chrome workaround for Ubuntu Was introduced by https://github.com/root-project/root/commit/e7d80140e6847bbffa0765c4610c4e7d0266a0c6 Seems to be bug was resolved: https://bugs.launchpad.net/chromium-browser/+bug/1893020 https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1894216 | 16 August 2023, 07:37:58 UTC |
| 281a162 | Jonas Hahnfeld | 14 August 2023, 11:56:21 UTC | [interpreter] Fix check-cling with builtin_llvm Forward TARGET_TRIPLE which is used by Cling's lit.site.cfg.in. (cherry picked from commit 09b61b4750efdc0e2148c013326550411c077cad) | 15 August 2023, 08:35:20 UTC |
| 38e05a2 | Stephan Lachnit | 08 August 2023, 20:17:43 UTC | [cmake] Improve interface for external LLVM (cherry picked from commit 92807f3591c25266ad9145045ef062527eea732a) | 15 August 2023, 08:35:20 UTC |
| 6e2f24f | Stephan Lachnit | 06 August 2023, 19:48:35 UTC | [cmake] Explicitly disable linking against shared LLVM (cherry picked from commit 96ad64a9089ec6bb893a2ee59c0e057220572d7e) | 15 August 2023, 08:35:20 UTC |
| ab4dd5e | Stephan Lachnit | 29 January 2023, 00:08:29 UTC | CMake: use CLING_BINARY_DIR instead of LLVM_BINARY_DIR to configure ClingConfig.cmake This fixes #12151. Signed-off-by: Stephan Lachnit <stephanlachnit@debian.org> (cherry picked from commit 8a45c096f16a38d3990a7b2efc894145c178b992) | 15 August 2023, 08:35:20 UTC |
| 940f151 | Sergey Linev | 09 August 2023, 12:59:54 UTC | Fix rounding problem in circle drawing in latex parser Used only for #odot processing Fixes: https://root-forum.cern.ch/t/55967 | 14 August 2023, 10:32:11 UTC |
| 9d89f1c | Enrico Guiraud | 03 August 2023, 17:15:47 UTC | [core] Do not provide our own strlcpy if glibc >= 2.38 Since version 2.38, glibc provides strlcpy and strlcat. No need to provide our own. In fact ROOT's definitions clash with glibc's: the latter are marked `noexcept`. | 06 August 2023, 18:07:13 UTC |
| 6fc4f0f | Jonas Hahnfeld | 25 July 2023, 13:59:32 UTC | [TCling] Fix suppression of enum forward declarations There can be multiple attributes in the forward declaration, see the added test in roottest/cling/dict/enum (reduced from a case reported by CMS in https://github.com/cms-sw/cmssw/issues/42234), so we have to look for the last closing parentheses. (cherry picked from commit 9d2f7612a6e88d3a7148b19e131402349bac509b) | 27 July 2023, 11:10:02 UTC |
| 556ddda | Jonas Hahnfeld | 20 July 2023, 10:11:45 UTC | [cling] Inject symbols from libc_nonshared.a These symbols may not be found automatically. See also upstream issue https://github.com/llvm/llvm-project/issues/61289. This fixes the test DynamicLibraryManager/cached_realpath.C, approach by Lang Hames. (cherry picked from commit 4b6075b8dca5c652ce04734da2afd7e440acbbd2) | 26 July 2023, 07:35:55 UTC |
| 60bab1a | Jonas Hahnfeld | 19 July 2023, 13:37:44 UTC | Automatically adjust C++ version of PCH in Cling's test This fixes test/CodeUnloading/PCH/VTables.C with C++17 and later. (cherry picked from commit e3047a05df79e189f859e5a23bcab9f3c6b8f434) | 26 July 2023, 07:35:55 UTC |
| 9734dcf | Jonas Hahnfeld | 08 March 2023, 14:37:32 UTC | [cling] Use compiled Module for stored states Since the upgrade to LLVM 13, the JIT infrastructure takes ownership of the Module. After JIT compilation, we get back a (const) pointer to the compiled module. This fixes the Cling test ErrorRecovery/StoredState.C. (cherry picked from commit 6af3b28a6555187f7d3f411b1a2b8d60f56c87c7) | 26 July 2023, 07:35:55 UTC |
| 8c52333 | Bertrand Bellenot | 20 July 2023, 06:09:17 UTC | Don't filter out methods returning the caller class | 26 July 2023, 06:38:28 UTC |
| b19970f | Bertrand Bellenot | 19 July 2023, 13:59:30 UTC | Re-enable browsing of `TMethodBrowsable` Prevent potential infinite recursion and simplify some of the code. This fixes the Github issue #13233 and doesn't affect the already closed Jira issue [#9260](https://sft.its.cern.ch/jira/browse/ROOT-9260) | 26 July 2023, 06:38:28 UTC |
| 8c19761 | Yash Solanki | 07 July 2023, 12:26:08 UTC | [Refactor]: Add RooWorkspace variable creation logic to C++ backend - Add variable creation logic to C++ files in roofit/hs3 - Add JSONTree creation logic to JSONIOUtils - Add importJSONElement to RooJSONFactoryWSTool - Rename importVarfromString to importVariableElement | 22 July 2023, 09:36:49 UTC |
| 4eb761c | Bertrand Bellenot | 17 July 2023, 11:15:53 UTC | Sort the lists before merging According to the [documentation](https://en.cppreference.com/w/cpp/container/list/merge), the lists need to be sorted before merging them. This fixes a `Debug Assertion Failed! Expression sequence not ordered` error on Windows. | 22 July 2023, 09:36:49 UTC |
| e921830 | Jonas Rembser | 17 July 2023, 10:49:49 UTC | [RF] Use `EXPECT_DOUBLE_EQ` for failing tests in testLikelihoodJob As explained in #12832 by @egpbos, the tests in `testLikelihoodJob` can fail on some platforms because of the different event splitting strategies that make the results not exactly comparable with `EXPECT_EQ`. The two replacements suggested in this PR should fix the current unit test failures on `mac13arm/cxx17`. | 22 July 2023, 09:36:49 UTC |
| abc73db | Jonas Rembser | 17 July 2023, 10:45:37 UTC | [RF] Change precision of RooAbsL EventSections tests As requested in #12832. | 22 July 2023, 09:36:49 UTC |
| c5a9fa4 | Vincenzo Eduardo Padulano | 17 July 2023, 07:23:06 UTC | [xroofit] Use std::string to format vector::size This avoids compiler warnings on 32bit platforms such as ``` warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘std::vector<std::tuple<int, double, double> >::size_type’ {aka ‘unsigned int’} [-Wformat=] ``` | 22 July 2023, 09:36:49 UTC |
| 2f6a8ab | Jonas Rembser | 16 July 2023, 11:29:40 UTC | [RF] Make RooSimultaneous::compileForNormSet agnostic of binnedL mode To support the binned likelihood optimiazation also outside a RooSimultaneous with BatchMode, the logic to enable the binned likelihood is moved out of `RooSimultaneous::compileForNormSet()` and inside the `compileForNormSet()` functions of RooProdPdf and RooRealSumPdf, which are the classes that are actually relevant for the binned likelihood. | 22 July 2023, 09:36:49 UTC |
| 689a7c3 | Jonas Rembser | 16 July 2023, 11:28:58 UTC | [RF] Fix memory leak in RooAbsTestStatistic from `getParameters()` | 22 July 2023, 09:36:49 UTC |
| 4e37976 | Carsten Burgard | 10 July 2023, 15:57:12 UTC | [RF][HS3] Export formula expressions with actual variable names Export formula expressions from `RooFormulaVar` and `RooGenericPdf` with actual variable names to make them readable. A unit test for this is also implemented now. | 22 July 2023, 09:36:49 UTC |
| fbb5583 | Carsten Burgard | 10 July 2023, 15:56:51 UTC | [RF] Add getter functions to RooFormulaVar and RooGenericPdf * `getParameter()` was only there in the RooFormulaVar, and is not also added to the RooGenericPdf to be consistent * new `nParameters()` method to get the number of parameters in a way that is obviously connected to `getParameter(i)` | 22 July 2023, 09:36:49 UTC |
| eb2057c | Jonas Rembser | 16 July 2023, 13:35:37 UTC | [RF][HS3] Make no difference between pdf and function import keys This simplifies the code a bit and we don't need to hardcode the assumption that pdf types end with `_dist`. | 22 July 2023, 09:36:49 UTC |
| f8024b2 | Jonas Rembser | 16 July 2023, 13:23:13 UTC | [RF][HS3] Generalize JSONIO importer interface It didn't really make sense to have different interfaces for pdfs and functions. | 22 July 2023, 09:36:49 UTC |
| 51acbc1 | Jonas Rembser | 04 July 2023, 11:01:47 UTC | [RF][HS3] Use `RooDataHist::set()` directly when importing histograms This is more direct and doesn't require changing the values of the input variables. | 22 July 2023, 09:36:49 UTC |
| cc131a7 | Jonas Rembser | 04 July 2023, 10:58:52 UTC | [RF][HF] Don't use large tolerance in HistFactory HS3 comparison Now that the difference in the piecewise interpolation was fixed in the last commit, there is no need for a large tolerance anymore in the HistFactory HS3 fit comparisons. Also, use `TH1D` for the template histograms to avoid precision loss. Furthermore, change the pre-fit parameters away from the minimum to avoid fit convergence problems. | 22 July 2023, 09:36:49 UTC |
| d5307c9 | Jonas Rembser | 04 July 2023, 08:32:26 UTC | [RF][HS3][HF] Use `setPositiveDefinite()` for RooPiecewiseInterpolation This is done to be consistent with the old HistFactory implementation. | 22 July 2023, 09:36:49 UTC |
| ab6e1e8 | Jonas Rembser | 06 July 2023, 11:49:12 UTC | [RF] Modernize RooNormSetCache to fix invalid iterator dereferencing Re-implement the RooNormSetCache with the appropriate STL containers. In particular, it now uses `std::set` and `std::deque` instead of `std::map` and `std::vector`, which was not efficient for the round-robin replacement. This change was motivated because it could happen in the past that the round-robin replacement was dereferencing invalid iterators. | 22 July 2023, 09:36:49 UTC |
| 0ad2028 | Yash Solanki | 01 July 2023, 16:00:01 UTC | [RF] Chore: remove manual loading of expressions and keys in test - Remove manual loading of JSON factory expressions and export keys from RooFit tests as these are loaded automatically | 22 July 2023, 09:36:49 UTC |
| 12f4f45 | Yash Solanki | 01 July 2023, 14:13:06 UTC | [RF] Refactor: Load factory expression & export keys automatically - Load factory expressions & export keys automatically when pdfImportExpressions, functionImportExpressions or exportKey is called to avoid unnecessary imports | 22 July 2023, 09:36:49 UTC |
| f02c802 | Jonas Rembser | 29 June 2023, 13:03:47 UTC | [RF] Avoid `override` warnings in RooClassFactory | 22 July 2023, 09:36:49 UTC |
| 8fe688e | Jonas Rembser | 01 July 2023, 14:42:22 UTC | [RF][HS3] Refactor HS3 HistFactory implementation to reduce code | 22 July 2023, 09:36:49 UTC |
| b05267e | Carsten Burgard | 30 June 2023, 15:05:02 UTC | [RF][HS3][HF] Added bugfix for NaNs being wrongfully propagated | 22 July 2023, 09:36:49 UTC |
| 64a2f48 | Carsten Burgard | 30 June 2023, 15:03:19 UTC | [RF][HS3][HF] Allow custom modifiers referencing functions Allow custom modifiers referencing functions from the body - needed for PreprocessFunctions. | 22 July 2023, 09:36:49 UTC |
| 9950903 | Yash Solanki | 28 June 2023, 11:45:50 UTC | Feat: Change roofit/HS3 for Pythonic dictionary-based object creation - Allow creation of p.d.f.s, functions and variables in RooWorkspace in PyROOT using a dictionary. - Add JSONIOUtils for comparing string suffix with an input string - Implement the C++ side this Pythnoization | 22 July 2023, 09:36:49 UTC |
| c1b4974 | Jonas Rembser | 27 June 2023, 23:46:48 UTC | [RF][HS3] Write literal const vars as literals also when in collections | 22 July 2023, 09:36:49 UTC |
| 577998a | Jonas Rembser | 27 June 2023, 18:01:49 UTC | [RF][HS3] Also enable using lists instead of dicts in `Domains` | 22 July 2023, 09:36:49 UTC |
| b30b33d | Carsten Burgard | 26 June 2023, 13:03:39 UTC | [RF][HS3] Improved error reporting for HS3 HistFactory implementation | 22 July 2023, 09:36:49 UTC |
| 71ef8b4 | Jonas Rembser | 26 June 2023, 22:23:29 UTC | [RF][HS3][HF] Fix exporting constant parameters in HistFactoryJSONTool When flagging constant parameters in the `HistFactoryJSONTool`, some default values are filled for these parameters if they are not defined already. The default values were so far only appropriate for the `alpha_*` parameters. If the name starts with `gamma_`, other defaults should be used. | 22 July 2023, 09:36:49 UTC |
| 37983f9 | Jonas Rembser | 26 June 2023, 22:22:40 UTC | [RF][HS3][HF] Export all parameters of HistFactory models to JSON We want to avoid implicit parameters in the JSON: all floating parameters that are used in the models should have domain definitions. | 22 July 2023, 09:36:49 UTC |
| 4ab2c38 | Jonas Rembser | 26 June 2023, 22:22:06 UTC | [RF][HF] Don't exclude the global observables for constant parameters In HistFactory, if you defined constant parameters in the `Measurement`, the corresponding global observables got removed from the list of global observables. That's not a good idea, because if one sets the parameter non-constant again, the global observable is not specified and you get wrong results because the normalization of the constraint is wrong. It is safer to include the global observables of all parameters, and it comes only at a very little price anyway. Now, the constraints for constant parameters are evaluated, while before they were not. | 22 July 2023, 09:36:49 UTC |
| 7c459a9 | Jonas Rembser | 26 June 2023, 22:20:43 UTC | [RF][HS3] Improve global observables detection in RooFit HS3 This commits implements the canonical way on detecting global observables in the RooJSONFactoryWSTool such that the ModelConfig can be filled correctly. Global observables are the constant `RooRealVars` that are not part of any pdf over the observables. The last important part was not checked so far. Follows up on #13051. Closes #13053. | 22 July 2023, 09:36:49 UTC |
| 04de627 | Jonas Rembser | 26 June 2023, 16:15:25 UTC | [RF][HS3][HF] Merge `testHSHistFactory` with `testHistFactory` All HistFactory unit tests are merged in one file, such that the nice test matrix in `testHistFactory` can also be used for the HS3 HistFactory tests. In particular, the combined test is also covering the support for non-uniform binning in HistFactory HS3. | 22 July 2023, 09:36:49 UTC |
| ff02ecf | Carsten Burgard | 22 June 2023, 17:58:20 UTC | [RF][HS3] Added code to HS3 to allow for non-uniform binnings Adds support for non-uniform binnings to HS3. Adds an if/then/else everywhere RooRealVars are read or written to handle non-uniform binnings as well. | 22 July 2023, 09:36:49 UTC |
| 262400d | will-cern | 21 June 2023, 13:46:59 UTC | [RF] Use `printValue()` in RooFitResult for non-RooRealVars In some user cases there are things in the constPar list that aren't a RooRealVar, so make this printout more flexible by using the printValue method. | 22 July 2023, 09:36:49 UTC |
| 8c2f568 | Jonas Rembser | 31 May 2023, 19:34:01 UTC | [RF] Disable manual memory management via constructor flags In the `ROOFIT_MEMORY_SAFE_INTERFACES`, all the constructors that have a `takeOwnership` flag should remove this flag from their signature. Passing flags to denote ovnership transfer is manual memory management, and manual memory management should not be necessary in the memory-safe mode. | 22 July 2023, 09:36:49 UTC |
| 8b82dbe | Jonas Rembser | 24 June 2023, 09:16:21 UTC | [RF] Add `JSONTree::create()` overload that directly takes a `string` This is especially useful from Python, where first instantiating a `std::istream` does not look "pythonic". | 22 July 2023, 09:36:49 UTC |
| aae7b1d | Jonas Rembser | 01 February 2023, 21:14:22 UTC | [RF] Make it possible to switch to `ryml` backend after building ROOT ROOT introduced a build flag in 6.26.00 that allowed you to build it using the `ryml` library instead of nlohmann-json as the backend for the JSON IO. But that was not particularly great. The `ryml` backend code is at risk of rotting, because to try and test it one needs a special ROOT build. It would be much better to just build both backends if `ryml` is installed on the system, and have a mechanism for developers to try this other backend. This is implemented in this commit. | 22 July 2023, 09:36:49 UTC |
| 326dbb6 | Carsten Burgard | 20 June 2023, 15:10:55 UTC | [RF][HS3] Fill the NPs and Globs lists in ModelConfigs on JSON import The solution for now is a bit makeshift, as it relies on the const/non-const properties to be set correctly at the time of creation. However, it's better than not doing anything, as this now allows the `ModelConfig::createNLL` to do its job correctly on imported workspaces. | 22 July 2023, 09:36:49 UTC |
| 84d11ae | Jonas Rembser | 21 July 2023, 10:39:50 UTC | [RF] Code-format `testHistFactory.cxx` | 22 July 2023, 09:36:49 UTC |
| 93394c3 | Paul Gessinger | 05 April 2023, 21:11:40 UTC | C++20: add missing include, fix span c'tor Partial application of commit edc0039c809a76f594ac21658402935eaeae9d36, some changes have already been applied in other backports. | 17 July 2023, 06:26:07 UTC |
| e63424b | Jonas Hahnfeld | 19 January 2023, 13:39:37 UTC | [clang] Fix up application of D41416 The LLVM 13 port of the patch missed to adapt findSpecialization of ClassTemplateDecl and VarTemplateDecl. During the upgrade, we only noticed and fixed FunctionTemplateDecl::findSpecialization. (cherry picked from commit 41840bfaccb50898664b6396cc3a907932a1b8f4) | 13 July 2023, 11:01:11 UTC |
| f8409a9 | Vassil Vassilev | 03 July 2023, 09:46:22 UTC | ParseTypeName might trigger deserialization. (cherry picked from commit ecdf0354b0eb07cdded27c81bb2f34f859e7a383) | 13 July 2023, 11:01:11 UTC |
| 713149a | Jonas Hahnfeld | 03 July 2023, 06:05:14 UTC | [clang] Relax assertion on lazily loading template specs Due to hash collisions, it can happen that we load another template specialization with the same hash. This is fine, as long as the next call to findSpecializationImpl does not find a matching Decl for the template arguments. (cherry picked from commit 13abc9f0145614965be62fd985855a84541a9fe3) | 13 July 2023, 11:01:11 UTC |
| 1e12b44 | Jonas Hahnfeld | 30 June 2023, 14:39:18 UTC | [clang] Add API to iterate already loaded specializations This avoids deserialization if necessary, for example in DeclUnloader. See also https://reviews.llvm.org/D154328 (cherry picked from commit 73a9a58c9260ed8337ff7046d95aadf093b89b7a) | 13 July 2023, 11:01:11 UTC |
| 9ad672e | Jonas Hahnfeld | 14 June 2023, 18:33:08 UTC | [clang] Fix ODR hashing of template template parameters For hashing, we should not differentiate between templates and qualified templates and only look at the underlying name. See also https://reviews.llvm.org/D153003 (cherry picked from commit 56dcdbb57cd70d5647632e3886b815379fa2b479) | 13 July 2023, 11:01:11 UTC |
| 9afee25 | Sergey Linev | 28 June 2023, 12:11:49 UTC | [webcanvas] fix update optimization When gPad->Modified() called without real change in the content, produced TWebCnavas JSON will be equivalent with previous one. Therefore one can assume that newer version already was send to the client and do not need to be updated again | 28 June 2023, 14:14:33 UTC |
| 1699904 | Sergey Linev | 27 June 2023, 07:04:53 UTC | [rbrowser] use TWebCanvas in async mode In special engines like qt5web or cefweb synchronous update of the canvas may block normal event loop of such engines. | 28 June 2023, 11:23:17 UTC |
| cf10ced | Bertrand Bellenot | 27 June 2023, 08:09:40 UTC | [skip-ci][windows] Use the correct syntax for the `START` command Use the correct syntax for the `START` command, which is: ``` START "title" [/D path] [options] "command" [parameters] ``` This prevent the following error with the `.forum bug` command: ``` root [0] .forum bug The system cannot accept the START command parameter "https://root-forum.cern.ch/new-topic?category=ROOT&tags=bug&body=___%0A_Please read [tips for efficient and successful posting](https:%2F%2Froot-forum.cern.ch%2Ft%2Ftips-for-efficient-and-successful-posting%2F28292) and [posting code](https:%2F%2Froot-forum.cern.ch%2Ft%2Fposting-code-read-this-first%2F28293)_%0A%0A%23%23%23 Describe the bug%0A<!--%0AA clear and concise description of what the wrong behavior is.%0A-->%0A%23%23%23 Expected behavior%0A<!--%0AA clear and concise description of what you expected to happen.%0A-->%0A%0A%23%23%23 To Reproduce%0A<!--%0ASteps to reproduce the behavior:%0A1. Your code that triggers the issue: at least a part%3B ideally something we can run ourselves.%0A2. Don't forget to attach the required input files!%0A3. How to run your code and %2F or build it, e.g. %60root myMacro.C%60, ...%0A-->%0A%0A%23%23%23 Setup%0A%60%60%60%0AROOT v6.29%2F01%0ABuilt for win32 on Jun 26 2023, 07:55:07%0AFrom heads%2Fmaster@v6-29-01-1740-ga5471d735c%0AWith MSVC 19.29.30146.0%0ABinary directory: C:\Users\bellenot\build\x86\release\bin%0A%60%60%60%0A%0A<!--%0APlease specify also how you obtained ROOT, such as %60dnf install%60 %2F binary download %2F you built it yourself.%0A-->%0A%0A%23%23%23 Additional context%0A<!--%0AAdd any other context about the problem here.%0A-->&". root [1] ``` | 27 June 2023, 14:04:09 UTC |
| 0cff9bf | moneta | 16 June 2023, 09:20:39 UTC | fixes for merge conflicts | 22 June 2023, 10:46:31 UTC |
| 9febed2 | moneta | 16 June 2023, 09:17:28 UTC | fix color settings in stressHistoFit | 22 June 2023, 10:46:31 UTC |
| bb04b30 | moneta | 14 June 2023, 12:26:37 UTC | [math] Further improvement and fixes for stressHistoFit - do not disable now fitting tests based on GSL Minimizers (if MathMore is available) - suppress in GSL Minimizer log messages (e.f. when fit failed) when printLevel i szeo (quite mode) | 22 June 2023, 10:46:31 UTC |
| 59213ab | moneta | 25 May 2023, 08:18:17 UTC | [math] Improve stressHistoFit Add several new tests (e.g. Fumili) and fix many of the failures. Improve also the test debugging (e.g. adding possibility to write output file with histograms) | 22 June 2023, 10:46:31 UTC |
| feb67bf | moneta | 25 May 2023, 08:11:37 UTC | [minuit2] Use both Fumili and Fumili2 as algorithm name for Minuit2 | 22 June 2023, 10:46:31 UTC |
| 48604ba | moneta | 25 May 2023, 08:17:16 UTC | [math] Fix linear fits with option "WIDTH" Fix the linear fit when normalizing by the bin volume (width). This is for fitting variable bins histograms. | 22 June 2023, 10:46:31 UTC |
| e6b7913 | moneta | 25 May 2023, 08:14:44 UTC | [math] Fix fitting when using bin integral and normalized by bin volume (e.g. for fitting variable bins histograms with option I) Also fix chi2 fitting for THnsparse histograms | 22 June 2023, 10:46:31 UTC |
| 9ce807d | Jonas Hahnfeld | 19 June 2023, 21:08:28 UTC | [cxxmodules] Avoid loading more modules while instantiating templates When instantiating templates, all Decls are present in the AST (with possibly deserialization pending). At that point, we should not load more modules which could find an implicit template instantiation that is lazily loaded. Fixes #12003 (cherry picked from commit ffdc579bbcd858e966db879c4258d0623eb520f1) | 21 June 2023, 06:30:21 UTC |
| e1c68d0 | Jonas Rembser | 16 June 2023, 14:52:22 UTC | [RF] Use `RooFit::OwningPtr<T>` in RooFit data generation functions | 20 June 2023, 10:29:01 UTC |
| 80af560 | Jonas Rembser | 20 June 2023, 08:36:00 UTC | [RF] Avoid RooSpan creation from iterators that causes CI build errors | 20 June 2023, 10:29:01 UTC |
| 6d24486 | Jonas Rembser | 07 June 2023, 21:15:48 UTC | [CMake] Add warning for the `minuit2_omp` or `minuit2_mpi` build options The options `minuit2_omp` and `minuit2_mpi` are dangerous because it means you can only minimize thread-safe functions with Minuit2. If you want Minuit2 with OpenMP or MPI support, it is better to build Minuit2 standalone. | 20 June 2023, 10:29:01 UTC |
| b84c036 | Jonas Rembser | 12 June 2023, 09:51:31 UTC | [math] Avoid warnings from `Vc.h` in Fedora nightlies The `array-bounds` warning should be ignored when including `Vc.h`. This fixes the last remaining warnings in the fedora nightlies: https://lcgapp-services.cern.ch/root-jenkins/view/ROOT%20Nightly/job/root-nightly-master/LABEL=ROOT-fedora36,SPEC=default,V=master/lastBuild/parsed_console/ | 20 June 2023, 10:29:01 UTC |
| 47f797c | will-cern | 17 June 2023, 11:59:32 UTC | [RF] Update RooAbsCollection.cxx - fix invalid read bug in remove If the hashAssistedFind feature is active, the old code gave an invalid read because of the delete further up. This change ensures the deletion happens last. | 20 June 2023, 10:29:01 UTC |
| 3190664 | Jonas Rembser | 14 June 2023, 23:27:23 UTC | [RF] Avoid RooBinWidthFunction in final likelihood computation graphs Since ROOT 6.26, the HistFactory models include the RooBinWidthFunction to multiply the yields in the RooHistFuncs with the inverse bin widths, in order to get the correct probability density. That's great and fixes HistFactory for non-uniform binnings, but it is not optimal for the `BinnedLikelihood` code path. Here, the bin widths need to multiplied back again to get the event yields in each bin. This commit suggests to improve the situation for the new BatchMode by propagating the information that we are building a binned likelihood down to the RooBinWidthFunctions, such that they can remove themselves. Then, if such RooBinWidthFunctions were encountered and disabled, the NLL knows that it can skip the multiplication with the bin widths. What is proposed here looks like a small performance optimization only, but actually the main motivation is not performance but RooFit AD support. By removing the RooBinWidthFunctions from the computation graphs of HistFactory likelihoods, we don't need to implement code generation support for this class, which would be not trivial in the general n-dimensional case. With the suggestion in this PR, all that work is avoided. | 20 June 2023, 10:29:01 UTC |
| 3a8ba0c | Jonas Rembser | 15 June 2023, 02:18:01 UTC | [RF] Don't consider extended pdf in RooProdPdf as constraint term If one of the pdfs in a RooProdPdf is extended, it should not be considered to be extracted as a constraint term. Also, fix `RooProdPdf::getConnectedParameters()` which should not consider the extended pdf as disconnected, as the expected events of this RooProdPdf depend on it. A unit test that covers this is also implemented. Closes this old Jira ticket: https://sft.its.cern.ch/jira/browse/ROOT-7604 | 20 June 2023, 10:29:01 UTC |
| 7ea4669 | Jonas Rembser | 15 June 2023, 02:16:25 UTC | [RF] Implement `createExpectedEventsFunc()` in RooExtendedTerm | 20 June 2023, 10:29:01 UTC |
| aa7afa2 | Jonas Rembser | 14 June 2023, 18:49:57 UTC | [RF] Speed up `getParameters()` for BatchMode NLL In the `getParameters()` implementation of the RooFitDriver wrapper, there was a call to `RooAbsArg::getParameters()`, which is expensive. It's better to let the Driver figure out what the parameters are, given that it already stores all the information to figure this out very quickly. This speeds up the likelihood creation for ATLAS Higgs combination models by about 20 % when using the BatchMode. | 20 June 2023, 10:29:01 UTC |
| 19a6cb1 | Jonas Rembser | 14 June 2023, 18:49:16 UTC | [RF] Fix some intentional leaks that are not needed anymore | 20 June 2023, 10:29:01 UTC |
| 52cdf01 | Jonas Rembser | 12 June 2023, 20:09:13 UTC | [RF] Introduce `RooAbsPdf::createExpectedEventsFunc()` method Introduce the new `RooAbsPdf::createExpectedEventsFunc()` method to explicitly create an object that represents the expected number of events. Like this, the expected number of events is fully exposed in the computation graph, just like the integrals. This makes adding support of RooFit codegen+AD for extended fits trivial, and also optimizes the BatchMode because the RooFitDriver can de-duplicate integrals that appear both in the regular evaluation path and `RooAbsPdf::expectedEvents()`. | 20 June 2023, 10:29:01 UTC |
| 9c74192 | Jonas Rembser | 13 June 2023, 14:49:53 UTC | [RF] More member functions in RooFitDriver This is to reduce the amount of inlined code to have a better resolution for performance profiles. | 20 June 2023, 10:29:01 UTC |
| 308d9a1 | Jonas Rembser | 13 June 2023, 13:24:12 UTC | [RF] Implement `FlexibleInterpVar::computeBatch()` | 20 June 2023, 10:29:01 UTC |
| 9bf3f95 | Jonas Rembser | 02 June 2023, 10:47:31 UTC | [RF] Make `RooMinimizer::save()` return a RooFit::OwningPtr<> | 20 June 2023, 10:29:01 UTC |
| 8a31892 | Jonas Rembser | 02 June 2023, 00:14:11 UTC | [RF] Remove `rf507_debugtools` tutorials The `rf507_debugtools` tutorial shows a functionality that is not active in the ROOT releases, so it should be removed. The only way to get something useful out of this tutorial is to recompile ROOT, changing the preprocessor macros `TRACRE_CREATE` and `TRACE_DESTROY` to be defined in `RooTrace.h`. That's way to advanced for the audience of the tutorials. The usage example from the tutorial is moved to the reference guide. | 20 June 2023, 10:29:01 UTC |
| 6c92c89 | Jonas Rembser | 07 June 2023, 10:56:44 UTC | [RF] RooAddPdf::compileForNormSet: apply conditional projection factor This fixes conditional RooAddPdfs like `p(x | y)` when compiling a pdf for a fixed normalization set. | 20 June 2023, 10:29:01 UTC |
| 8f9d4e0 | Jonas Rembser | 07 June 2023, 10:55:55 UTC | [RF] Use correct norm. set in `RooRealIntegral::compileForNormSet()` | 20 June 2023, 10:29:01 UTC |
| 8cd1414 | Olivier Couet | 16 June 2023, 13:49:30 UTC | back-port stressgraphics gif fix. (#12947) * [skip-ci] back-port stressgraphics gif fix. * adjust ref file | 16 June 2023, 13:49:30 UTC |
| 180dd8c | Bertrand Bellenot | 14 June 2023, 10:57:47 UTC | [cmake][windows] Use standard ${PYTHON_LIBRARIES} on Windows Use `${PYTHON_LIBRARIES}` to automatically select the correct (debug/release) Python library when both are installed. For example, with both debug and release versions of Python, `PYTHON_LIBRARIES` is set as: ``` PYTHON_LIBRARIES:INTERNAL=optimized;C:/Python310/libs/python310.lib;debug;C:/Python310/libs/python310_d.lib ``` And with only the release version: ``` PYTHON_LIBRARIES:INTERNAL=C:/Python310/libs/python310.lib ``` So the correct one will be used. This fixes the following error when both versions are installed: ``` CMake Error at bindings/pyroot/cppyy/CPyCppyy/CMakeLists.txt:61 (target_link_libraries): The "optimized" argument must be followed by a library. ``` | 15 June 2023, 12:15:43 UTC |
| 9248a09 | Sergey Linev | 12 June 2023, 12:28:58 UTC | [jsroot] 7.3.3 release | 12 June 2023, 12:30:20 UTC |
| 1d17dae | Bertrand Bellenot | 09 June 2023, 13:47:51 UTC | [skip-ci][windows] Install also cfitsio.dll This should fix the error [reported on the forum](https://root-forum.cern.ch/t/windows-visual-studio-binary-root-v6-28-04-win64-vc17-exe-fitio-fails/55244) | 12 June 2023, 10:31:07 UTC |
| b7de1ef | Enrico Guiraud | 09 June 2023, 17:00:32 UTC | [DF] Actually push back values, do not write to uninitialized memory This fixes a bug in the creation of Snapshot actions. We were writing and then reading back booleans from uninitialized memory (just reserve'd). It happens to work, but of course it is incorrect. | 09 June 2023, 20:51:48 UTC |
| d1090b6 | Enrico Guiraud | 08 June 2023, 01:55:38 UTC | [DF] Test filling histogram with scalar value, collection of weights | 08 June 2023, 18:44:57 UTC |
