| 48e34ed | Axel Naumann | 21 March 2023, 10:09:10 UTC | "Update ROOT version files to v6.28/02." | 21 March 2023, 10:09:10 UTC |
| fcbd205 | Axel Naumann | 21 March 2023, 10:04:32 UTC | [relnotes] Add 6.28/02 fixed bugs. | 21 March 2023, 10:04:32 UTC |
| 4bba27b | Bertrand Bellenot | 15 March 2023, 07:35:45 UTC | Fix an issue with the canvas editor when the canvas is embedded (#12477) * Fix an issue with the canvas editor when the canvas is embedded Fix a problem with the editor not appearing when the TCanvas is embedded, [as reported on the Forum](https://root-forum.cern.ch/t/editor-not-appearing-in-gui-canvas/53968) Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> * Cosmetics (thanks Axel!) --------- Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> (cherry picked from commit 77d0a99502b722743b6872bb8fd73076d352361e) | 20 March 2023, 19:19:04 UTC |
| 5f98b46 | Bertrand Bellenot | 10 March 2023, 14:34:40 UTC | Fix compilation errors with -std:c++20 on Windows (cherry picked from commit dc1fc29ec7ac633c1c397a88b4f91338da02bf80) | 20 March 2023, 19:19:04 UTC |
| 0296383 | Olivier Couet | 09 March 2023, 10:03:50 UTC | Fix multiple hist drawing in log scale. (#12448) (cherry picked from commit c675f8a16dec99372b2318c2f826329465db52cc) | 20 March 2023, 19:19:04 UTC |
| c918f10 | Olivier Couet | 07 March 2023, 11:29:19 UTC | [skip-ci] Fix TTree::Draw doc (#12446) * [skip-ci] Fix TTree::Draw doc * Wrong quotes (cherry picked from commit 6fa068ef6e8263c677db136252a164703cbcdc0e) | 20 March 2023, 19:19:04 UTC |
| 0822c18 | Jonas Rembser | 05 March 2023, 12:16:49 UTC | [core] Use explicit type in TList iteration example The example for range-based iteration in `TList.cxx` uses a pattern that can yield compiler warnings for some GCC versions: ``` warning: loop variable 'obj' is always a copy because the range of type 'TList' does not return a reference [-Wrange-loop-analysis] ``` To avoid spreading this pattern, this commit suggests to change the example to explicitly use the `TObject *` type, which also makes the example clearer. (cherry picked from commit 0a0d79ea4c3975f7deb4ac62f3247c5a16a34815) | 20 March 2023, 19:19:04 UTC |
| b36ccc6 | Olivier Couet | 07 March 2023, 10:00:03 UTC | [skip-ci] Improve TGraph2DPainter help (#12436) (cherry picked from commit 8f2f1b531c2254440fa715402d73a69d7a47d9e6) | 20 March 2023, 19:19:04 UTC |
| fa3fa7d | Bertrand Bellenot | 06 March 2023, 12:24:16 UTC | Make sure non-builtin xrootd is not using builtin_openssl. Should fix #12231 (cherry picked from commit 2f419f582230b71f053e6a788511d30ea27ad09b) | 20 March 2023, 19:19:04 UTC |
| 1c718bd | Olivier Couet | 06 March 2023, 09:12:25 UTC | Undesired behaviour with SetRangeUser & Draw->(“same”) & Log Scale (#12415) * Undesired behaviour with SetRangeUser & Draw->(“same”) & Log Scale * The coordinates might be defined by something else than a TH1 (cherry picked from commit 180c8099bfb6ad753b8a698445351662f8c5ef1f) | 20 March 2023, 19:19:04 UTC |
| 28430c2 | Jakob Blomer | 01 March 2023, 22:56:20 UTC | remove unused parameter from ParseTreeFilename (cherry picked from commit 248163e25dc708f4b094963381257c86c069bdfa) | 20 March 2023, 19:19:04 UTC |
| 5d9d5a7 | moneta | 28 February 2023, 16:20:10 UTC | [math] Add virtual destructor to Fitter and fix an issue for PyROOT When constructing in Python a derived class from Fitter an error occurred caused probably of a not understanding a typedef. See issue #12391 Include also suggestion received from PR review from Jonas and Xavier (cherry picked from commit 7e0ff8491f3fcf49a3cff72880dbd305dba365f8) | 20 March 2023, 19:19:04 UTC |
| 1bc1469 | Mattias Ellert | 01 March 2023, 17:30:35 UTC | Don't install roofit files when roofit is disabled (cherry picked from commit 2ec59b82fdd70164439b38e22c2ea56db4aec5ea) | 20 March 2023, 19:19:04 UTC |
| 292fee8 | Mattias Ellert | 01 March 2023, 17:32:45 UTC | Veto tests using clad when clad is disabled (cherry picked from commit f2be527990fc71d890c64ad290f55b9a74b41b89) | 20 March 2023, 19:19:04 UTC |
| 7f62707 | Vassil Vassilev | 16 February 2023, 07:04:17 UTC | Remove the problematic uses_allocator_args.h It is not present on some versions of libstdc++ which makes the compilation of Core.pcm fail. (cherry picked from commit ac30be310508ee8f3b944f2b23d8d975014b0d3e) | 20 March 2023, 19:19:04 UTC |
| 1a14408 | Vassil Vassilev | 09 February 2023, 17:47:16 UTC | [cxxmodules] Add a module for experimental/string_view Recent gcc updates somehow make experimental/string_view available through module string_view. Then it wrongly decides it needs to include "bits/ranges_base.h" which is a c++14 header and breaks the compilation in case of c++11. This patch adds a proper experimental/string_view to disallow such shadowing. (cherry picked from commit 2ce11e2cb54da2f35f65e295448ac1fb4c56db37) | 20 March 2023, 19:19:04 UTC |
| 438cfd8 | Axel Naumann | 21 December 2022, 08:37:56 UTC | [cling] Revert "Disable GlobalISel on AArch64": This reverts fcab0add4a79379b5087fe786261f4ab0cc9776a which is not needed anymore since llvm13 / ORCv2 / JITLink. (cherry picked from commit 3ffadcaa2fbe4a0c3c2e6553bb6e44747a3c3324) | 20 March 2023, 19:19:04 UTC |
| 0052ec3 | Axel Naumann | 15 February 2023, 16:29:27 UTC | [cmake] macOS: export DYLD_LIBRARY_PATH, not LD_LIBRARY_PATH. Co-authored-by: sa35 (cherry picked from commit 74b8f234a364793fb48f3aeb0f19052e3d9435e3) | 20 March 2023, 19:19:04 UTC |
| 9791804 | Philippe Canal | 10 February 2023, 18:59:30 UTC | Add missing dictionary (cherry picked from commit b922be660ecc3d5bf7d3f379c099268a32a500bf) | 20 March 2023, 19:19:04 UTC |
| 0e9156c | Philippe Canal | 30 January 2023, 20:54:15 UTC | Warn about compiled compiled proxy containing emulated objects (cherry picked from commit 9433a897a874b56a2d45437818ee539ef49badaf) | 20 March 2023, 19:19:04 UTC |
| e176e97 | YuryYury | 13 February 2023, 14:53:25 UTC | Fixing a typo in the documentation: `SetOptStats --> SetOptStat` (cherry picked from commit 9588a87bec13d19b27a73def78961ed958060328) | 20 March 2023, 19:19:04 UTC |
| 4da4e5b | ACA4DFA4 | 14 February 2023, 06:27:39 UTC | fix a line in PyMethodBase.cxx which make it fail to build (cherry picked from commit 14c51d169d3890c8f5a2a80e0b11fb3756d0720e) | 20 March 2023, 19:19:04 UTC |
| bbba8c4 | Bertrand Bellenot | 08 February 2023, 11:43:17 UTC | Don't cast a TDirectory pointer argument to a Long_t (even if its value is 0) (#12243) * Don't cast a TDirectory pointer argument to a Long_t (even if its value is 0) Should fix the failure of tutorial/tree/run_h1analysis.C on Win64 * Update tree/tree/src/TSelectorList.cxx Co-authored-by: Philippe Canal <pcanal@fnal.gov> --------- Co-authored-by: Philippe Canal <pcanal@fnal.gov> (cherry picked from commit 2948660f80f32326e2264130928737ef93892817) | 20 March 2023, 19:19:04 UTC |
| 03fc22f | Guilherme Amadio | 07 February 2023, 16:11:44 UTC | [CMake] Update XRootD builtin to version 5.5.2 (cherry picked from commit 3be9c92b29cd1e97e716ee7b6c4e24d0794688e5) | 20 March 2023, 19:19:04 UTC |
| 8a112f5 | Axel Naumann | 03 February 2023, 08:38:26 UTC | [TCling] tell clang when to use modules, even with C++20: with C++20, clang turns on modules unconditionally. That interfers with our expectation to only have it on when -fmodules is passes. Instead, sync our expectation with clang. (cherry picked from commit 060a2bae3d41aaab1b924771246f34672c3952ba) | 20 March 2023, 19:19:04 UTC |
| 8957fe4 | Olivier Couet | 07 February 2023, 14:03:56 UTC | reformat help (#12241) (cherry picked from commit c2a7059dbf2d899a9c6e732064c002bf72e2c80a) | 20 March 2023, 19:19:04 UTC |
| 506817d | moneta | 03 February 2023, 15:02:23 UTC | [tmva][pymva] Fix finally the pymva test dependency (cherry picked from commit 3bb3ed19f9526b4fb097f7702c9c93e607cf298d) | 20 March 2023, 19:19:04 UTC |
| 64b7a6e | Jakob Blomer | 01 February 2023, 08:59:43 UTC | [NFC] fix doxygen syntax for RResult documentation (cherry picked from commit 8fc45a898c2d71eabb9724172dbef0eb81d94cc3) | 20 March 2023, 19:19:04 UTC |
| 0c32b50 | Jakob Blomer | 01 February 2023, 08:40:44 UTC | [NFC] Minor improvement to RResult documentation Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch> (cherry picked from commit e294799c4166b0e656c3d7c6f29eca28b214d67b) | 20 March 2023, 19:19:04 UTC |
| 266036d | Jakob Blomer | 27 January 2023, 12:22:54 UTC | [NFC] clarify use and intention of RResult<T>::Unwrap() (cherry picked from commit 2ccaa6be33bd65ebcd5bc6d128fcafc645baceb1) | 20 March 2023, 19:19:04 UTC |
| 1fd7e27 | Enrico Guiraud | 02 February 2023, 19:32:15 UTC | [VecOps] Avoid -ffast-math The performance gains are unclear and the option can harm users linking against the library with gcc<13, see also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 . (cherry picked from commit 3cfb0da6078ca9ebdb4d006c56102eaff1a1b45f) | 20 March 2023, 19:19:04 UTC |
| 310a3c8 | Sergey Linev | 03 February 2023, 07:33:10 UTC | Add missing include to metacling test Detected with -Ddev=ON cmake flags (cherry picked from commit de19eb1ddb9d1b2edcb5d2187078b2d67bb7b784) | 20 March 2023, 19:19:04 UTC |
| 1569ede | Enrico Guiraud | 02 February 2023, 21:40:48 UTC | [tree] Fix typo in error message (cherry picked from commit ee112dfe1da04590a0fd8ed9656eb4a83a948596) | 20 March 2023, 19:19:04 UTC |
| ce4f8a9 | Vassil Vassilev | 31 January 2023, 20:28:44 UTC | Add variant to the modulemap to address a cmssw-related issue. (cherry picked from commit 78078590dd8c61f90cd0fafe7a1c0b18e65af40b) | 20 March 2023, 19:19:04 UTC |
| baaada1 | Axel Naumann | 01 February 2023, 16:28:11 UTC | [rmkdepend] Work around GCC format truncation warning: Co-authored-by: Philippe Canal <pcanal@fnal.gov> ``` build/rmkdepend/include.c:306:37: warning: ‘%s’ directive output may be truncated writing up to 8190 bytes into a region of size between 1 and 8191 [-Wformat-truncation=] 306 | snprintf(path, BUFSIZ, "%s/%s", *pp, include); ``` (cherry picked from commit c931a7af5f7b0912bbd3e2de4ea368154e58e474) | 20 March 2023, 19:19:04 UTC |
| 6487b62 | Javier Lopez-Gomez | 17 January 2023, 18:09:52 UTC | [io] Fix C++20 `[-Wdeprecated-enum-enum-conversion]` warnings Fix a long list of C++20 warnings related to operands of different enumeration types, such as ``` io/io/src/TEmulatedMapProxy.cxx:144:25: warning: bitwise operation between different enumeration types ‘EProperty’ and ‘TGenCollectionProxy::<unnamed enum>’ is deprecated [-Wdeprecated-enum-enum-conversion] io/io/src/TStreamerInfo.cxx:4397:21: warning: arithmetic between different enumeration types ‘TStreamerInfo::EReadWrite’ and ‘EDataType’ is deprecated [-Wdeprecated-enum-enum-conversion] ``` (cherry picked from commit 91f25d0d133644c159f36656829ebe4b3fa4d4ff) | 20 March 2023, 19:19:04 UTC |
| bcc0355 | Javier Lopez-Gomez | 17 January 2023, 18:09:52 UTC | [core] Fix C++20 warning in `TSystem::SetBuildDir()` ``` core/base/src/TSystem.cxx:4040:42: warning: bitwise operation between different enumeration types ‘TSystem::EAclicProperties’ and ‘TObject::<unnamed enum>’ is deprecated [-Wdeprecated-enum-enum-conversion] core/base/src/TSystem.cxx:4042:43: warning: bitwise operation between different enumeration types ‘TSystem::EAclicProperties’ and ‘TObject::<unnamed enum>’ is deprecated [-Wdeprecated-enum-enum-conversion] ``` The `& kBitMask` part has been removed as it seems totally bogus. (cherry picked from commit 2c45ab3781598971b45ef19932300b285a808405) | 20 March 2023, 19:19:04 UTC |
| e92b38c | Javier Lopez-Gomez | 17 January 2023, 18:09:52 UTC | [net] Fix warning in rpdutils.cxx when built using `-std=c++20` ``` net/rpdutils/src/rpdutils.cxx:422:54: warning: using value of simple assignment with ‘volatile’-qualified left operand is deprecated [-Wvolatile] ``` (cherry picked from commit 25e5f51e90bf2237fbda9b442723e778a1321e37) | 20 March 2023, 19:19:04 UTC |
| 55af925 | Javier Lopez-Gomez | 17 January 2023, 18:09:52 UTC | [ntuple,daos] Allow aggregate initialization of `ROidDkeyPair` in C++20 (cherry picked from commit 704e5c786211c30057d99c472348ff6137b60585) | 20 March 2023, 19:19:04 UTC |
| f920952 | Javier Lopez-Gomez | 17 January 2023, 18:09:52 UTC | [cling] Add missing `const` in `operator==` and `operator!=` Add missing `const` in `{DelayCall,MacroDirective}Info::operator==` and `operator!=`. This fixes the following warnings in C++20 ``` interpreter/cling/lib/Interpreter/Transaction.cpp:173:23: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'cling::Transaction::DelayCallInfo' and 'cling::Transaction::DelayCallInfo') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator] interpreter/cling/lib/Interpreter/Transaction.cpp:218:21: warning: ISO C++20 considers use of overloaded operator '==' (with operand types 'cling::Transaction::MacroDirectiveInfo' and 'cling::Transaction::MacroDirectiveInfo') to be ambiguous despite there being a unique best viable function [-Wambiguous-reversed-operator] ``` (cherry picked from commit 1c7bf2abc972b66913a49768276982875b73ddae) | 20 March 2023, 19:19:04 UTC |
| e37e8fb | Vassil Vassilev | 02 January 2023, 11:21:25 UTC | [cxxmodules] Adjust the modulemap for c++20 (cherry picked from commit 3ea654bdeeef0868d52963c9995d24ac6e776cf9) | 20 March 2023, 19:19:04 UTC |
| aa881eb | Axel Naumann | 09 December 2022, 08:31:38 UTC | [clang] Add "cplusplus20" as module requirement: This needs to be upstreamed. (cherry picked from commit 4225f7e8b87252bda26aef9915ffe9544268a677) | 20 March 2023, 19:19:04 UTC |
| a6c19f4 | Axel Naumann | 09 December 2022, 16:52:29 UTC | [roofitcore] Missing header for `std::runtime_error` etc. (cherry picked from commit 5cb964402bc12919b0419b692f5b62d1236ddbf9) | 20 March 2023, 19:19:04 UTC |
| 59496a2 | Axel Naumann | 09 December 2022, 16:44:09 UTC | [foundation,roofitbc] span::index_type is called size_type. (cherry picked from commit c18603fec58d20a9750d83f68a281c047c2ef12f) | 20 March 2023, 19:19:04 UTC |
| 3f141e6 | Axel Naumann | 09 December 2022, 16:38:51 UTC | [foundation] Add support for C++20 std::span: By moving the preamble "can we use <span>" into ROOT/span.hxx we can have a module built of span.hxx. Otherwise, a module for span.hxx would make the backported std::(ROOT::)span available even for the case where std::span exists. (cherry picked from commit bd3e827a100fdeb77f03180bbaeeabb2afcb5704) | 20 March 2023, 19:19:04 UTC |
| feb5658 | Axel Naumann | 09 December 2022, 16:35:57 UTC | [roofitbc] Missing include. (cherry picked from commit 8ada2e9ecfca8e5bc1c7515ebe8d3b4241f49cd8) | 20 March 2023, 19:19:04 UTC |
| 637cacc | Axel Naumann | 09 December 2022, 16:06:40 UTC | [foundation] Make span backport available if not __cpp_lib_span: There is no experimental::span anywhere; R__HAS_STD_SPAN was never set. This is needed for C++20 support. (cherry picked from commit 906d185243f519b3a1812a09651866bd5b3a6422) | 20 March 2023, 19:19:04 UTC |
| ead1dcb | Axel Naumann | 09 December 2022, 12:21:30 UTC | [roofitcore] Fix ambig op!= in RooAddPdf: With C++20 we get ``` roofit/roofitcore/src/RooAddPdf.cxx: In member function ‘std::pair<const RooArgSet*, AddCacheElem*> RooAddPdf::getNormAndCache(const RooArgSet*) const’: roofit/roofitcore/src/RooAddPdf.cxx:436:32: error: ambiguous overload for ‘operator!=’ (operand types are ‘const RooFit::UniqueId<RooArgSet>’ and ‘RooFit::UniqueId<RooArgSet>::Value_t’ {aka ‘long unsigned int’}) 436 | } else if(nset->uniqueId() != _idOfLastUsedNormSet) { | ~~~~~~~~~~~~~~~~ ^~ ~~~~~~~~~~~~~~~~~~~~ | | | | | RooFit::UniqueId<RooArgSet>::Value_t {aka long unsigned int} | const RooFit::UniqueId<RooArgSet> ``` (cherry picked from commit 91dd45bd1520b253863346ac27dca209afc76405) | 20 March 2023, 19:19:04 UTC |
| 9570372 | Axel Naumann | 09 December 2022, 12:19:04 UTC | [rootfitcore] Fix ambig op== in RooNormSetCache: With C++20 we get: include/RooNormSetCache.h:70:53: error: use of overloaded operator '==' is ambiguous (with operand types 'const RooNormSetCache::Pair::Value_t' (aka 'const unsigned long') and 'const UniqueId<RooArgSet>') if (_pairToIdx.end() != it && it->first.first() == RooFit::getUniqueId(set1)) ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/RooFit/UniqueId.h:61:9: note: candidate function (with reversed parameter order) bool operator==(UniqueId const &other) const { return _val == other._val; } ^ include/RooNormSetCache.h:70:53: note: built-in candidate operator==(unsigned long, unsigned long) if (_pairToIdx.end() != it && it->first.first() == RooFit::getUniqueId(set1)) ^ (cherry picked from commit 38fa29b767736f0fc1e7ffad160b489d0ab13b8f) | 20 March 2023, 19:19:04 UTC |
| 430469a | Axel Naumann | 09 December 2022, 12:14:56 UTC | [tree] No istream >> char*, and anywhy it was a bug: This was meant to read fLen values, see e.g. TLeafF. (cherry picked from commit 45ea529e5c56f37a8f034b7d1e23dd0155b59c85) | 20 March 2023, 19:19:04 UTC |
| f0845ad | Axel Naumann | 09 December 2022, 12:13:48 UTC | [io] Disentagle fwd decl and use of TIDNode, fixes C++20. (cherry picked from commit 655704255436b53e6f51e298aa42889cf9d99d8c) | 20 March 2023, 19:19:04 UTC |
| 7c6375d | Axel Naumann | 09 December 2022, 07:46:09 UTC | [base] Fix C++20 warning volatile compount assignment: ``` core/base/inc/TStorage.h:135:12: warning: compound assignment with ‘volatile’-qualified left operand is deprecated [-Wvolatile] 135 | bits &= ~kIsOnHeap; | ~~~~~^~~~~~~~~~~~~ ``` (cherry picked from commit 0853635a7c975669e03343987a83db3b70f722b8) | 20 March 2023, 19:19:04 UTC |
| 063344c | Marcelo Juchem | 01 October 2021, 07:42:23 UTC | [llvm] Fix ambiguous overload build failure LLVM (llvmorg-14-init) under Debian sid using latest gcc (Debian 10.3.0-9) 10.3.0 fails due to ambiguous overload on operators == and !=: /root/src/llvm/src/llvm/tools/obj2yaml/elf2yaml.cpp:212:22: error: ambiguous overload for 'operator!=' (operand types are 'llvm::ELFYAML::ELF_SHF' and 'int') /root/src/llvm/src/llvm/tools/obj2yaml/elf2yaml.cpp:204:32: error: ambiguous overload for 'operator!=' (operand types are 'const llvm::yaml::Hex64' and 'int') /root/src/llvm/src/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:629:35: error: ambiguous overload for 'operator==' (operand types are 'const uint64_t' {aka 'const long unsigned int'} and 'llvm::Register') Reviewed by: StephenTozer, jmorse, Higuoxing Differential Revision: https://reviews.llvm.org/D109534 (cherry picked from commit bea08da739b771f91c1cf800469a6bef4d5fee6b) | 20 March 2023, 19:19:04 UTC |
| ae0b8ed | Evgeny Mandrikov | 06 January 2022, 16:01:05 UTC | [llvm] Fix build failure with GCC 11 in C++20 mode See https://wg21.link/cwg2237 Reviewed By: shafik, dexonsmith Differential Revision: https://reviews.llvm.org/D115355 (cherry picked from commit 9450b0cbf44cdb478418d68a6da8742d13d39742) | 20 March 2023, 19:19:04 UTC |
| 9fed429 | Sergey Linev | 20 January 2023, 16:19:25 UTC | Fix gcc13 warning in RDF::Union initialization Cannot automatically convert array of const char* to vector of std::string (cherry picked from commit a4458629624574e7967427522925032c74009e7b) | 20 March 2023, 19:19:04 UTC |
| 619b2cb | Olivier Couet | 23 January 2023, 16:21:17 UTC | Improve TROOT doc (#11976) * Improve TROOT doc * better wording * Better wording (cherry picked from commit 4f88cdc6581541b1b918dae2e511f2de23b6b7b1) | 20 March 2023, 19:19:04 UTC |
| 4b86e67 | Sergey Linev | 20 January 2023, 16:15:42 UTC | Fix gcc13 warning in TPaveText (cherry picked from commit 9da833337430eb6c1e9da59d9eb3a8d335089bd7) | 20 March 2023, 19:19:04 UTC |
| dd61f06 | Sergey Linev | 23 January 2023, 07:32:47 UTC | Fix gcc13 warning in TMVA Sofie includes Properly initialize std::vector<std::string>, gcc13 do not like to automatically convert array of const char* to it. (cherry picked from commit d4ce2e65b4ecf8ca3ec07c04fb0d7453219fda4e) | 20 March 2023, 19:19:04 UTC |
| 45ee019 | Vassil Vassilev | 20 January 2023, 15:46:13 UTC | Do not register LLVMSupport as a library when it should be a component (#11703) Do not register LLVMSupport as a library when it should be a component LLVM component must be registered as LLVM_LINK_COMPONENTS to be compatible with LLVM Dylib. Otherwise they are loaded twice in the final binary, once through LLVM Dylmib and once through individual component, and this results in some options being registered twice. Fix root-project/cling#440 (cherry picked from commit 286d96b12aad8688b9d8e4b3b5df843dcfb716a8) | 20 March 2023, 19:19:04 UTC |
| 70a229f | Mattias Ellert | 20 January 2023, 05:34:11 UTC | Add missing #include <cstdint> Fixes compilation error with gcc 13 (cherry picked from commit 87d302b9192538e18645f4c3efadc70e9a20a913) | 20 March 2023, 19:19:04 UTC |
| 75cd810 | Jonas Hahnfeld | 18 January 2023, 12:57:38 UTC | Revert "[llvm] Fix win32 mangling in OrcJIT v2:" Instead update DemangleNameForDlsym, the one function not using getGlobalPrefix(), to treat win32 the same as macOS. This reverts commit ed7ed9679ab4f51b1fe608716f740e6716e9cec4. (cherry picked from commit 8a998b5fda80ee60e7ae409ed5827645f81aa2ef) | 20 March 2023, 19:19:04 UTC |
| e76747e | Jonas Hahnfeld | 18 January 2023, 12:42:52 UTC | TCling: Unify demangling before calling dlsym (cherry picked from commit 74948ac8f0a633854e43b729150906aef53b1db6) | 20 March 2023, 19:19:04 UTC |
| c9cad5b | Jonas Hahnfeld | 19 January 2023, 16:41:36 UTC | [cling] Fix in-process lookup of symbols without GlobalPrefix On Windows, C++ symbols are prefixed not with the "global" prefix, but with a question mark. (cherry picked from commit 217206823aef3c5e60990153d83597fa73e556ac) | 20 March 2023, 19:19:04 UTC |
| ea41f6d | Jonas Hahnfeld | 19 January 2023, 07:55:59 UTC | [cling] Remove explicit setting of COFF binary format on Windows This is the default anyway. (cherry picked from commit 8968ccd0611857c0a0c1c28de4d2a87696c8495c) | 20 March 2023, 19:19:04 UTC |
| 988aea0 | Bertrand Bellenot | 11 January 2023, 08:48:23 UTC | Disable tests depending on xml when xml is not found Disable several tests who are using hist2workspace, which requires xml, when `ROOT_xml_FOUND` is not set (cherry picked from commit ef776fd7c277cad27e5669d66fec6cd04da25885) | 20 March 2023, 19:19:04 UTC |
| 5800ddc | Philippe Canal | 16 March 2023, 23:33:27 UTC | Allow splitting of TTime objects | 20 March 2023, 08:13:57 UTC |
| 17d9bfd | Bertrand Bellenot | 09 March 2023, 12:12:38 UTC | [skip-ci][windows] Fix TDatime on Windows Fix a wrong value of `TDatime::GetDateFromGlobalDay()` as reported [on the Forum](https://root-forum.cern.ch/t/correct-global-day-conversion-functions-for-root-tdatime/53938) | 09 March 2023, 16:13:04 UTC |
| 3b9132c | Axel Naumann | 03 March 2023, 11:37:00 UTC | [clang] survive -Inon-accessible-directory: If part of the -I search path cannot be accessed (permissions), clang will throw an error, even if the header can be found in subsequent search path elements. This is counter productive as the compilation will seem to have failed due to that error, even though everyone is happy. This is not the sys first error that needs to be suppressed, and it might not be the last... (cherry picked from commit b02e870f8d9e5d01732914d9b7bbc0a3313a3135) | 09 March 2023, 09:46:45 UTC |
| 32e5a8d | Axel Naumann | 03 March 2023, 11:20:47 UTC | [cling] Do not try to find runtime headers in ./: These headers are part of cling, not user code, so starting with the current directory is pointless and can actually be counterproductive. This helps with https://github.com/root-project/root/issues/12409 but not enough; any dictionary header will still try to access "./". (cherry picked from commit e660b0b9a69c981e086de455978f400046ca5c59) | 09 March 2023, 09:46:45 UTC |
| 0effb10 | Sergey Linev | 09 March 2023, 08:00:22 UTC | [rbrowser] in any case provide lastcycle argument for browser request | 09 March 2023, 08:10:38 UTC |
| 120d987 | Sergey Linev | 08 March 2023, 08:45:05 UTC | [rbrowser] fix expand of sub-sub elements | 09 March 2023, 08:10:38 UTC |
| 529b2e9 | Sergey Linev | 08 March 2023, 07:48:59 UTC | [rbrowser] do not remove TTree from file when browse it Keep TTree ownership with TDirectory, let correctly cleanup it | 09 March 2023, 08:10:38 UTC |
| 30019da | Jonas Rembser | 23 January 2023, 17:06:21 UTC | Change `clang-format` style to have line breaks in c'tor initializer We use the `clang-format` style of ROOT for all the new source files in RooFit, but some code looks pretty ugly. For example, here in the constructor of `RooNLLVarNer`: ```C++ RooNLLVarNew::RooNLLVarNew(const char *name, const char *title, RooAbsPdf &pdf, RooArgSet const &observables, bool isExtended, RooFit::OffsetMode offsetMode, bool binnedL) : RooAbsReal(name, title), _pdf{"pdf", "pdf", this, pdf}, _observables{getObs(pdf, observables)}, _isExtended{isExtended}, _binnedL{binnedL}, _weightVar{"weightVar", "weightVar", this, *dummyVar(weightVarName), true, false, true}, ... ``` Really not great to have all the elements in the constructor initializer list in one line. It's hard to read, there are weird line breaks, and if you only change one member it looks like you have changed everything. This commit suggests to have line breaks in the style instead, so from now on, it will look better. | 07 March 2023, 13:37:24 UTC |
| bebbcf4 | Vincenzo Eduardo Padulano | 22 February 2023, 23:05:51 UTC | [DF] Allow optional metadata for a sample | 07 March 2023, 12:09:39 UTC |
| dae9d48 | Vincenzo Eduardo Padulano | 22 February 2023, 23:04:15 UTC | [DF] Require lists of trees and files in specification | 07 March 2023, 12:09:39 UTC |
| 9eccccd | Vincenzo Eduardo Padulano | 21 February 2023, 15:49:51 UTC | [DF] Use dictionary for samples instead of list According to the current status of the discussion at https://github.com/root-project/root/issues/11624 Enforce this in the `FromSpec` function by throwing an error if the JSON spec does not conform. | 07 March 2023, 12:09:39 UTC |
| 48cc33e | Vincenzo Eduardo Padulano | 21 February 2023, 14:26:30 UTC | [DF][NFC] Change 'group' to 'sample' in dataset specification | 07 March 2023, 12:09:39 UTC |
| ccc8df1 | Mattias Ellert | 02 March 2023, 07:31:29 UTC | Missing experimental add-on module ROOT.RDF.Experimental.Distributed (DistRDF) should not fail the loading of the rest of the ROOT.RDF namespace. | 03 March 2023, 09:48:15 UTC |
| 73e74a4 | Mattias Ellert | 02 March 2023, 07:25:36 UTC | Use consistent minimum Python version for DistRDF The minimum version was changed in bindings/CMakeLists.txt but not in the check in the code. | 03 March 2023, 09:48:15 UTC |
| a99193b | Jonas Hahnfeld | 20 February 2023, 09:08:00 UTC | [cling] Disable outline-atomics on AArch64 The routines __aarch64_* are defined in the static library libgcc.a and not necessarily included in libCling or otherwise present in the process, so the interpreter has a hard time finding them. Fixes #12294 (cherry picked from commit ddf9a8c3d113e3a3d48dbe13b6b4a6bf2338fb7a) | 02 March 2023, 19:41:34 UTC |
| c87908d | Enrico Guiraud | 01 March 2023, 15:52:54 UTC | [VecOps] Avoid unnecessarily large allocations when masking We only need to allocate storage for the elements that pass the mask, not for as many elements as the original array had. | 02 March 2023, 15:37:33 UTC |
| efd3cea | Enrico Guiraud | 01 March 2023, 15:49:56 UTC | [VecOps] Make sure lifetime of elements is started when masking Before this commit the implementation of RVecN::operator[](const RVecN<V, M> &conds) implicitly assumed that the value type be trivially-constructible: it was using reserve + copy-assignment + manual resizing to fill the returned vector, which never properly initializes the new elements. This commits changes that to a reserve + push_back, which properly constructs the new elements in place. This fixes #12398. | 02 March 2023, 15:37:33 UTC |
| 0d5bd35 | Sergey Linev | 01 March 2023, 22:20:15 UTC | [rbrowser] when expand path force update of model to refresh widgets | 01 March 2023, 22:28:41 UTC |
| 7b09b3b | Sergey Linev | 01 March 2023, 22:19:44 UTC | [webgeom] fix display of expand path Once expanded, one have to force model refresh to get visible changes | 01 March 2023, 22:28:41 UTC |
| 699f8b4 | Sergey Linev | 01 March 2023, 22:14:13 UTC | [webgeom] fix error when sending found elements If nodes limit not set - ignore it | 01 March 2023, 22:28:41 UTC |
| 7beeca4 | Jonas Rembser | 14 January 2023, 11:25:20 UTC | [PyROOT] Only build RooFit and TMVA pythonizations if needed Like this, we are polluting the build and install directories less with unneeded files and it also speeds up the build process a bit if RooFit and/or TMVA are disabled. Their pythonization files don't need to be compiled to `.pyc` files. | 27 February 2023, 16:12:25 UTC |
| 4ab2a16 | Javier Lopez-Gomez | 13 February 2023, 14:05:39 UTC | [ntuple] RPageSinkBuf: add missing call to ReleasePage() | 27 February 2023, 12:12:34 UTC |
| 4ed48c7 | Olivier Couet | 24 February 2023, 16:27:42 UTC | [skip-ci] fix ref guide build for non master branch (#12382) | 24 February 2023, 16:27:42 UTC |
| f209c1a | Sergey Linev | 23 February 2023, 13:20:11 UTC | Fix webgui/qt5web cmake file One should link now against web geometry viewer library | 23 February 2023, 13:37:58 UTC |
| c2c15c0 | Sergey Linev | 23 February 2023, 11:43:36 UTC | [jsroot] fixes from 23/02/2023 | 23 February 2023, 11:45:44 UTC |
| 6ab6fbd | Jonas Hahnfeld | 20 February 2023, 08:14:58 UTC | [tree] Avoid odr-using TTree::kMaxEntries (#12352) In C++14, this would require a definition. This should solve the linking errors about "undefined reference"s in the incrementals. | 22 February 2023, 15:32:53 UTC |
| 9c416bc | Enrico Guiraud | 09 February 2023, 13:52:16 UTC | [tree] Propagate TTreeIndex info through GetFriendInfo/MakeFriends This in turn fixes a problem with TTreeProcessorMT and multi-thread RDataFrame "forgetting" about the TTreeIndexes associated with input friend trees. Fixes https://github.com/root-project/root/issues/12260, "[DF] Bogus data read from indexed friend trees in multi-thread runs". | 20 February 2023, 08:56:19 UTC |
| 63d89c6 | Vincenzo Eduardo Padulano | 09 February 2023, 10:18:27 UTC | [tree] Always include number of entries in RFriendInfo creation Whether it is done via `Internal::TreeUtils::GetFriendInfo` or an `RFriendInfo::AddFriend` overload, the `fNEntriesPerTreePerFriend` data member will have the same cardinality as the `fFriendFileNames` data member. This makes the status of the created struct more easily usable, for example it simplifies the logic in `MakeFriends`. | 20 February 2023, 08:56:19 UTC |
| 11d26fa | Vincenzo Eduardo Padulano | 05 July 2022, 10:03:08 UTC | [tree] Simplify how TTreeProcessorMT retrieves friend information Use the new facilities in `ROOT::Internal::TreeUtils`: 1. Retrieve the number of entries of each friend tree at construction time. This removes the need to retrieve the information during the event loop from each task, bringing the amount of calls to this logic from NFILES*NENTRYRANGES to 1. 2. Remove the logic that creates the list of friends, now use `MakeFriends`. | 20 February 2023, 08:56:19 UTC |
| f4b759b | Vincenzo Eduardo Padulano | 05 July 2022, 09:31:37 UTC | [tree] Retrieve entries from friends and add utility function to make friends It is now possible to specify whether the number of entries from each tree should be retrieved when calling `GetFriendInfo`. This simplifies certain patterns that require also giving the number of entries when creating a TChain such as seen in `TTreeProcessorMT.cxx`. A new utility function called `MakeFriends` also streamlines the creation of a list of friends from the information held in the main tree. This can be useful in multiple places, such as TTreeProcessorMT and RDataFrame. | 20 February 2023, 08:56:19 UTC |
| 7e87965 | Vincenzo Eduardo Padulano | 08 February 2023, 14:56:29 UTC | [DF] Error out when TTreeIndex is used in distributed mode We do not support it at the moment, so better to raise an explicit error. | 20 February 2023, 08:56:19 UTC |
| b3430c4 | Enrico Guiraud | 08 February 2023, 18:52:38 UTC | [DF] Add test for indexed friends in MT mode | 20 February 2023, 08:56:19 UTC |
| aad8eb1 | Enrico Guiraud | 14 February 2023, 17:14:44 UTC | [tree] Fix ~TChainIndex in case of null fTree fTree can be null e.g. after a chainIndex->Clone(). Co-authored-by: Philippe Canal <pcanal@fnal.gov> | 20 February 2023, 08:56:19 UTC |
| 5ffe219 | Enrico Guiraud | 14 February 2023, 17:13:13 UTC | [tree] Actually set tree in TChainIndex::SetTree | 20 February 2023, 08:56:19 UTC |
| b0c2080 | Enrico Guiraud | 14 February 2023, 17:11:55 UTC | [tree] The argument to TVirtualIndex::SetTree cannot be const We need to assign the pointer to const to a pointer to non-const right inside the setter, and that currently requires a const_cast. This commit remove the const_cast by changing the signature of TVirtualIndex::SetTree to accept a pointer to _non-const_ TTree. | 20 February 2023, 08:56:19 UTC |
