| aaae600 | Nick Dyer | 29 October 2015, 16:39:53 UTC | Input: atmel_mxt_ts - initialise sysfs after object table probed Move the initialisation of sysfs attributes. Some of the sysfs functions have guards in case they are accessed early during probe, or during firmware flash. By ensuring the attributes are not present when they can be mis-used, these guards can be removed. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 30 October 2015, 16:43:48 UTC |
| 4215f8f | karl tsou | 02 July 2014, 05:14:08 UTC | Input: atmel_mxt_ts - rename config_csum attribute to config_crc Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 30 October 2015, 16:26:08 UTC |
| d8462ef | Nick Dyer | 27 October 2015, 11:53:50 UTC | Input: atmel_mxt_ts - avoid null regulator handle Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 30 October 2015, 16:26:07 UTC |
| 23f9e98 | Karl Tsou | 21 January 2015, 05:35:03 UTC | Input: atmel_mxt_ts - Add debug for T92 gesture and T93 touch seq msgs Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 30 October 2015, 16:26:06 UTC |
| 178ba36 | Nick Dyer | 27 October 2015, 11:07:20 UTC | Input: atmel_mxt_ts - split large reads into blocks On some platforms doing i2c reads of more than 255 bytes is problematic. For exampls, some chips with lots of objects have an info block larger than 255 bytes. Signed-off-by: Steven Swann <steven.swann@itdev.co.uk> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 30 October 2015, 16:26:05 UTC |
| 5aa3c7b | Nick Dyer | 22 October 2015, 09:03:58 UTC | Input: atmel_mxt_ts - reduce debug level for toggling MSG output Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 30 October 2015, 16:26:04 UTC |
| 292a138 | Nick Dyer | 15 September 2015, 14:19:22 UTC | Input: atmel_mxt_ts - check return values in mxt_start and mxt_stop Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 30 October 2015, 16:26:03 UTC |
| ab440de | Pan Xinhui | 04 August 2015, 23:53:04 UTC | Input: atmel_mxt_ts - suspend/resume causes panic if input_dev fails to init input_dev may be NULL if mxt_initialize_input_device fails. But pm ops is still available and suspend/resume assume input_dev is not NULL. To fix this issue, we add a check if (!input_dev). Signed-off-by: Pan Xinhui <xinhuix.pan@intel.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> | 25 August 2015, 15:35:51 UTC |
| 17b6341 | Nick Dyer | 06 August 2015, 09:38:41 UTC | Input: atmel_mxt_ts - refactor to add np variable in mxt_parse_dt Downgrade failure to read gpio-keymap to a warning (initialized to KEY_RESERVED by devm_kzalloc) Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:35:50 UTC |
| f1b1b7d | Nick Dyer | 22 June 2015, 08:47:58 UTC | Input: atmel_mxt_ts - tool type is ignored when slot is closed input_mt_report_slot_state() ignores the tool when the slot is closed. Remove the tool type from these function calls, which has caused a bit of confusion. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:45 UTC |
| bf9da7d | Nick Dyer | 17 June 2015, 10:49:17 UTC | Input: atmel_mxt_ts - don't report zero pressure from T9 If T9.CTRL DISAMP is set, then pressure is reported as zero. This means some app layers (eg tslib) will ignore the contact. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:44 UTC |
| 3fafaff | Nick Dyer | 04 June 2015, 15:04:07 UTC | Input: atmel_mxt_ts - remove debug about reset GPIO Downgrade to a comment since it appears on every probe when debug is enabled otherwise. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:42 UTC |
| 5ef9579 | Nick Dyer | 16 June 2015, 13:02:57 UTC | Input: atmel_mxt_ts - remove warning on zero T44 count Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:41 UTC |
| 8c96398 | Nick Dyer | 16 June 2015, 11:06:43 UTC | Input: atmel_mxt_ts - remove guards around inclusion of of_gpio.h Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:40 UTC |
| 2c426e1 | Nick Dyer | 16 June 2015, 12:37:37 UTC | Input: atmel_mxt_ts - improve formatting Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:39 UTC |
| d4f1244 | Nick Dyer | 16 June 2015, 11:07:21 UTC | Input: atmel_mxt_ts - tidy up flow in bootloader retries This fixes a warning from checkpatch. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:38 UTC |
| 938a1d7 | Nick Dyer | 16 June 2015, 10:54:41 UTC | Input: atmel_mxt_ts - fix minor checkpatch errors Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:37 UTC |
| 4a6d6cd | Nick Dyer | 04 June 2015, 15:07:02 UTC | Input: atmel_mxt_ts - reorder init completions to reduce upstream patch churn Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:36 UTC |
| 29336b4 | Nick Dyer | 04 June 2015, 15:06:08 UTC | Input: atmel_mxt_ts - rename TOUCH_CTRL to T9_CTRL Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:34 UTC |
| 1d51930 | Dmitry Torokhov | 07 April 2015, 23:30:01 UTC | Input: atmel_mxt_ts - add support for Google Pixel 2 This change allows atmel_mxt_ts to bind to ACPI-enumerated devices in Google Pixel 2 (2015). While newer version of ACPI standard allow use of device-tree-like properties in device descriptions, the version of ACPI implemented in Google BIOS does not support them, and we have to resort to DMI data to specify exact characteristics of the devices (touchpad vs. touchscreen, GPIO to button mapping, etc). Pixel 1 continues to use i2c devices and platform data created by chromeos-laptop driver, since ACPI does not enumerate them. Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> | 25 August 2015, 15:34:33 UTC |
| 75272ca | Sjoerd Simons | 06 April 2015, 20:10:30 UTC | Input: atmel_mxt_ts - split out touchpad initialisation logic If the "linux,gpio-keymap" DT property is defined, the T19 keys are configured and the device is setup as a touchpad rather than a touchscreen. The logic is part of the input device initialization routine but it can be factored out to its own function to simplify the former. Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> [Reinstate INPUT_MT_DIRECT] [put back variable i in mxt_initialize_input_device] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:32 UTC |
| 90c2778 | Javier Martinez Canillas | 06 April 2015, 18:25:13 UTC | Input: atmel_mxt_ts - factor out T9 and T100 init functions Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> [Merge in maxtouch-v3.14 branch] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:31 UTC |
| 9228e3f | Javier Martinez Canillas | 06 April 2015, 18:25:13 UTC | Input: atmel_mxt_ts - update hovering finger support The hovering finger support was based on Chung-Yih's work in the ChromiumOS downstream kernel: https://chromium-review.googlesource.com/#/c/219280/ In order to report hovering touch events to userspace applications, the patch uses the axis ABS_MT_DISTANCE to indicate if a finger is hovering or not. In other words, we could use the value of the axis ABS_MT_DISTANCE to tell if a finger is a touch or hovering finger: DISTANCE_ACTIVE_TOUCH: a finger touches on touchpad, ABS_MT_DISTANCE is zero DISTANCE_HOVERING: a hovering finger on top of touchpad [javier: rework hover support] Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> [nick: merge into maxtouch-v3.14 branch] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:30 UTC |
| 81a5c7a | Nick Dyer | 16 June 2015, 15:18:48 UTC | Input: atmel_mxt_ts - Improve reporting of stylus buttons The buttons should only be reported only on T107 messages, but they must be reported on every message since the buttons can be released as the stylus goes out of detect. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:29 UTC |
| bae1dc0 | Nick Dyer | 16 June 2015, 15:16:06 UTC | Input: atmel_mxt_ts - move #defines as per upstream Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:28 UTC |
| 861c673 | Nick Dyer | 16 June 2015, 15:15:24 UTC | Input: atmel_mxt_ts - use get_unaligned_le16 Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:26 UTC |
| b4a510f | Nick Dyer | 04 June 2015, 15:15:52 UTC | Input: atmel_mxt_ts - use BIT() macro everywhere Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:25 UTC |
| cb9669c | Dmitry Torokhov | 15 April 2015, 17:31:10 UTC | Input: atmel_mxt_ts - use BIT() macro when reporting button state This makes the intent a tad more clear. Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 25 August 2015, 15:34:24 UTC |
| c497cf8 | Nick Dyer | 30 April 2015, 15:08:03 UTC | Input: atmel_mxt_ts - delay enabling IRQ when not using regulators The path of enabling the IRQ in the probe function is not safe in level triggered operation, if it was already powered up and there is a message waiting on the device (eg finger down) because the object table has not yet been read. This forces the ISR into a hard loop. Delay enabling the interrupt until it is first needed. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 01 May 2015, 14:16:50 UTC |
| 17ef3ea | Nick Dyer | 19 March 2015, 16:36:45 UTC | Input: atmel_mxt_ts - make bootloader interrupt driven | 01 May 2015, 14:16:46 UTC |
| b046fa5 | Nick Dyer | 19 March 2015, 16:39:48 UTC | Input: atmel_mxt_ts - rename bl_completion to chg_completion | 01 May 2015, 13:58:46 UTC |
| 81dd63b | Nick Dyer | 06 January 2015, 14:11:31 UTC | Input: atmel_mxt_ts - check firmware format before putting device into bootloader mode | 01 May 2015, 13:58:00 UTC |
| 9c18b74 | Nick Dyer | 24 December 2014, 16:07:50 UTC | Input: atmel_mxt_ts - improve bootloader state machine handling Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 01 May 2015, 13:57:59 UTC |
| 31b266f | Nick Dyer | 24 December 2014, 14:38:16 UTC | Input: atmel_mxt_ts - combine bootloader version query with probe This removes some complexity from the bootloader state machine, and means that we always output some debug about the version as soon as we start talking to the bootloader. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 01 May 2015, 13:57:58 UTC |
| 7d38a7f | Nick Dyer | 23 December 2014, 16:27:29 UTC | Input: atmel_mxt_ts - refactor code to enter bootloader into separate func | 01 May 2015, 13:57:57 UTC |
| 3380b3f | Nick Dyer | 23 December 2014, 16:22:35 UTC | Input: atmel_mxt_ts - refactor firmware flash to extract context into struct | 01 May 2015, 13:57:56 UTC |
| c7f8291 | Nick Dyer | 16 December 2014, 16:47:55 UTC | Input: atmel_mxt_ts - guard debug interface when in bootloader mode Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 01 May 2015, 13:57:55 UTC |
| 2a5851d | Nick Dyer | 10 March 2015, 15:20:36 UTC | Input: atmel_mxt_ts - minor formatting fix Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 01 May 2015, 13:57:55 UTC |
| 8c3f7d9 | Nick Dyer | 10 March 2015, 15:19:49 UTC | Input: atmel_mxt_ts - add suspend modes | 01 May 2015, 13:57:54 UTC |
| d9a9f12 | Nick Dyer | 23 April 2015, 10:02:55 UTC | Input: atmel_mxt_ts - config CRC may start at T71 On devices with the T71 object, the config CRC will start there, rather than at T7. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 23 April 2015, 15:54:02 UTC |
| 7c09e13 | Nick Dyer | 10 March 2015, 15:25:06 UTC | Input: atmel_mxt_ts - Update device tree documentation | 23 April 2015, 15:53:56 UTC |
| 8ed3a0d | Nick Dyer | 09 December 2014, 12:54:29 UTC | Input: atmel_mxt_ts - fix bug in debug output for T100 | 16 December 2014, 15:48:45 UTC |
| 041ef5a | Nick Dyer | 09 December 2014, 12:54:07 UTC | Input: atmel_mxt_ts - remove unnecessary debug on ENOMEM | 16 December 2014, 15:48:45 UTC |
| 0e3b2f5 | Nick Dyer | 09 December 2014, 12:53:09 UTC | Input: atmel_mxt_ts - fix merge issue in T100 init code | 16 December 2014, 15:48:44 UTC |
| 0a2f039 | Nick Dyer | 09 December 2014, 11:49:57 UTC | Input: atmel_mxt_ts - remove unnecessary forward declarations | 16 December 2014, 15:48:44 UTC |
| 3a0b91a | Nick Dyer | 09 December 2014, 11:49:47 UTC | Input: atmel_mxt_ts - remove extra blank lines | 16 December 2014, 15:48:43 UTC |
| f017f02 | Nick Dyer | 05 December 2014, 11:23:07 UTC | Input: atmel_mxt_ts - disable interrupt for 50ms after reset The CHG/interrupt line is momentarily set (approximately 100 ms) as an input after power-up or reset for diagnostic purposes. This may cause spurious interrupts, so disable interrupt handler during this period. | 16 December 2014, 15:48:43 UTC |
| 9bc82bb | Nick Dyer | 05 December 2014, 11:22:03 UTC | Input: atmel_mxt_ts - change T100 debug output from status to tool type | 16 December 2014, 15:47:32 UTC |
| e646ac0 | Nick Dyer | 05 December 2014, 11:50:08 UTC | Input: atmel_mxt_ts - improve indentation by reworking if statements | 16 December 2014, 15:47:32 UTC |
| 2c74f03 | Nick Dyer | 28 November 2014, 16:53:15 UTC | Input: touchscreen - use __maybe_unused instead of ifdef around suspend/resume Use __maybe_unused instead of ifdef guards around suspend/resume functions, in order to increase build coverage and fix build warnings. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> | 16 December 2014, 15:47:32 UTC |
| 44df860 | Nick Dyer | 24 October 2014, 11:50:10 UTC | Input: atmel_mxt_ts - handle new T100 touch types Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 16 December 2014, 15:47:32 UTC |
| 2764354 | Nick Dyer | 26 November 2014, 16:20:00 UTC | Input: atmel_mxt_ts - improve handling of hover Pressure and touch major should be reported as non-zero if tool touching the device. | 16 December 2014, 15:47:32 UTC |
| 3f712e6 | Nick Dyer | 14 June 2013, 15:52:45 UTC | Input: atmel_mxt_ts - implement support for T107 active stylus Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 16 December 2014, 15:47:32 UTC |
| 15fd4c4 | Nick Dyer | 24 October 2014, 09:08:19 UTC | Adjust MXT_MAX_BLOCK_WRITE Some platforms appear to have an underlying I2C device which starts corrupting data if blocks exceed this length. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 24 October 2014, 09:20:07 UTC |
| 4f1ce8c | Stephen Warren | 09 September 2014, 15:15:24 UTC | Input: atmel_mxt_ts - fix double free of input device [reworked after comments by Dmitry Torokhov. Move free of input device into separate function. Only call in paths that require it. Move mxt_initialize after sysfs init, because otherwise an error in the sysfs init may interfere with the async return from the firmware loader. Add guards for sysfs functions. ] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:30:30 UTC |
| b96fee1 | Nick Dyer | 09 September 2014, 15:14:06 UTC | Input: atmel_mxt_ts - add guards when sysfs interface called with no object table Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:31 UTC |
| 29c8ab9 | Nick Dyer | 09 September 2014, 15:13:30 UTC | Input: atmel_mxt_ts - fix checkpatch warning with bare else Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:31 UTC |
| 64c2e0f | Nick Dyer | 09 September 2014, 15:12:04 UTC | Input: atmel_mxt_ts - remove unnecessary 'out of memory' message Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:31 UTC |
| 513bb8c | Nick Dyer | 02 September 2014, 15:37:46 UTC | Input: atmel_mxt_ts - don't spam dmesg with warning about empty interrupts In the case where the chip is not configured in the correct interrupt line mode, this warning output to dmesg output for each touch cycle. Downgrade the message to debug, since it is a benign condition. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:31 UTC |
| b99f70b | Dmitry Torokhov | 11 August 2014, 18:03:09 UTC | Input: atmel_mxt_ts - fix a few issues reported by Coverity This should fix the following issues reported by Coverity: *** CID 1230625: Logically dead code (DEADCODE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize() *** CID 1230627: Missing break in switch (MISSING_BREAK) /drivers/input/touchscreen/atmel_mxt_ts.c: 1436 in mxt_get_object_table() *** CID 1230629: Out-of-bounds write (OVERRUN) /drivers/input/touchscreen/atmel_mxt_ts.c: 1267 in mxt_update_cfg() *** CID 1230632: Unused pointer value (UNUSED_VALUE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1211 in mxt_update_cfg() Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:31 UTC |
| 88858db | Nick Dyer | 29 July 2014, 09:46:35 UTC | Input: atmel_mxt_ts - mXT224 DMA quirk was fixed in firmware v2.0.AA Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:30 UTC |
| e3e0ef5 | Nick Dyer | 29 July 2014, 09:45:53 UTC | Input: atmel_mxt_ts - reorder code due to upstream patch churn Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:30 UTC |
| 01b103d | Nick Dyer | 28 July 2014, 15:22:55 UTC | Input: atmel_mxt_ts - fix checkpatch issue WARNING: Missing a blank line after declarations Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:30 UTC |
| 1b4c1df | Nick Dyer | 28 July 2014, 10:42:55 UTC | Input: atmel-mxt_ts - use kstrtou8 in sysfs interface rather than scanf Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:30 UTC |
| c94606f | Nick Dyer | 28 July 2014, 09:13:55 UTC | Input: atmel_mxt_ts - call CRC completion after CRC update There is a possibility of a race here otherwise. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:30 UTC |
| 1a811c3 | Nick Dyer | 24 July 2014, 16:24:33 UTC | Input: atmel_mxt_ts - remove unnecessary blank line Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:30 UTC |
| 5d95437 | Nick Dyer | 24 July 2014, 16:24:02 UTC | Input: atmel_mxt_ts - minor tweak to capitalisation in comment Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:29 UTC |
| d59050a | Dmitry Torokhov | 23 July 2014, 23:29:55 UTC | Input: atmel_mxt_ts - split config update a bit Let's split config update code a bit so it is hopefully a bit easier to read. Also, the firmware update callback should be the entity releasing firmware blob, not lower layers. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> [release firmware when updating via update_cfg_store] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:29 UTC |
| 97396a0 | Nick Dyer | 24 July 2014, 16:22:25 UTC | Input: atmel_mxt_ts - add error check to request_firmware_nowait() Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:29 UTC |
| 8715dc2 | Nick Dyer | 24 July 2014, 16:21:48 UTC | Input: atmel_mxt_ts - rework platform data handling | 09 September 2014, 15:27:29 UTC |
| 49c0c24 | Dmitry Torokhov | 23 July 2014, 21:50:56 UTC | Input: atmel_mxt_ts - simplify mxt_initialize a bit I think having control flow with 2 goto/labels/flags is quite hard to read, this version is a bit more readable IMO. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:27:29 UTC |
| cf896ab | Janus Cheng | 20 July 2014, 10:36:14 UTC | Input: atmel_mxt_ts - check data->input_dev is not null in mxt_input_sync() * Symptom: if update_fw and update_cfg, kernel panic occurs. * Reproducibility: 10% * Root Cause: - If update_fw, the T6 will send a CFG_ERR message periodically. - After that, update_cfg process begin, the mxt_update_cfg_store() will invoke mxt_free_input_device() and nullify data->input_dev. - The CFG_ERR message will trigger mxt_interrupt(), and mxt_input_sync() will be invoked by mxt_process_messages_t44(). And mxt_input_sync() references a NULL data->input_dev and kernel panic occurs. TrackerRMS TKT-004235 | 12 August 2014, 16:05:29 UTC |
| 7e25850 | Nick Dyer | 23 July 2014, 14:53:33 UTC | Input: atmel_mxt_ts - fix interrupt documentation for tegra As advised by Stephen Warren, this was incorrect. Also slightly update wording. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 23 July 2014, 14:58:42 UTC |
| fb52903 | Nick Dyer | 04 July 2014, 11:35:57 UTC | Input: atmel_mxt_ts - fix bug in info CRC error output Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:34:27 UTC |
| 83040d9 | Nick Dyer | 03 July 2014, 10:11:20 UTC | Input: atmel_mxt_ts - leave platform to specify irqflags when using DT The function to check the interrupt configuration must use irq_get_trigger_type() to allow for this case. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:29:06 UTC |
| 55d857b | Nick Dyer | 20 June 2014, 09:30:13 UTC | Input: atmel_mxt_ts - fix bug with endianness conversion in T100 intialisation Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:36 UTC |
| 8d5ef3b | Nick Dyer | 18 June 2014, 23:46:06 UTC | Input: atmel_mxt_ts - use of_match_ptr rather than ifdefs Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:35 UTC |
| 04280ca | Nick Dyer | 18 June 2014, 23:45:33 UTC | Input: atmel_mxt_ts - allocate pdata using devm_kzalloc By using this function instead, there is no necessity to free on remove or probe failure, since it is handled for us. This also fixes an failure when kfree() is called on memory allocated using devm_kzalloc() in the DT parse function. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:34 UTC |
| 4e8a1ab | karl tsou | 18 June 2014, 23:42:34 UTC | Input: atmel_mxt_ts - support config checksum attribute in sysfs Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:33 UTC |
| c438f1c | Nick Dyer | 18 June 2014, 23:40:12 UTC | Input: atmel_mxt_ts - wrap long line Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:32 UTC |
| 18596d7 | Nick Dyer | 18 June 2014, 23:39:50 UTC | Input: atmel_mxt_ts - check gpio validity in mxt_probe_regulators Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:32 UTC |
| c70631b | Nick Dyer | 18 June 2014, 23:39:28 UTC | Input: atmel_mxt_ts - move functions in file to improve code layout Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:31 UTC |
| d0c1ce6 | Nick Dyer | 18 June 2014, 23:38:02 UTC | Input: atmel_mxt_ts - reorder mxt_free_object_table to improve robustness Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:30 UTC |
| fcfae57 | Nick Dyer | 18 June 2014, 23:30:46 UTC | Input: atmel_mxt_ts - add cfg name and input name to device tree Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:29 UTC |
| 347dff2 | Nick Dyer | 18 June 2014, 23:29:26 UTC | Input: atmel_mxt_ts - improve device tree parsing for earlier kernels of_property_read_u32_index() was only introduced in v3.10. Using the array operation is simpler anyway. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:28 UTC |
| aee662e | Nick Dyer | 18 June 2014, 23:41:40 UTC | Input: atmel_mxt_ts - improve error handling in initialise functions Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:27 UTC |
| 915c135 | Nick Dyer | 05 June 2014, 11:14:31 UTC | Input: atmel_mxt_ts - use async firmware loader interface for config Using request_firmware_nowait() allows the driver to be built into the kernel and use the firmware loader interface, without the probe failing with a 60s timeout due to the root filesystem not being available. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:27 UTC |
| 4eedb0f | Nick Dyer | 05 June 2014, 10:48:32 UTC | Input: atmel_mxt_ts - Initialise input slots with INPUT_MT_DIRECT This indicates the device coordinates should be directly mapped to screen. This is valid since scaling/flipping/rotation should be done by configuring the MXT device. It also flags to Android using INPUT_PROP_DIRECT that the device should be treated as a touch screen by default, and removes the necessity for a default IDC file. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:26 UTC |
| 5a4c198 | Nick Dyer | 05 June 2014, 09:06:04 UTC | Add documentation for device tree Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:25 UTC |
| 0dacc74 | Nick Dyer | 23 May 2014, 14:59:46 UTC | Input: atmel_mxt_ts - do not reset slots when input device is null Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:24 UTC |
| 8765349 | Nick Dyer | 23 May 2014, 14:58:42 UTC | Input: atmel_mxt_ts - change reset GPIO warning to debug message Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:24 UTC |
| 70d553b | Nick Dyer | 23 May 2014, 14:57:31 UTC | Input: atmel_mxt_ts - rename mxt_check_reg_init to mxt_update_cfg Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:23 UTC |
| 1f6a0fc | Nick Dyer | 23 May 2014, 14:27:51 UTC | Input: atmel_mxt_ts - Set pointer emulation on touchpads Touchpads are pointers, so make sure to pass the correct values to input_mt_report_pointer_emulation(). Without this, tap-to-click doesn't work. Signed-off-by: Benson Leung <bleung@chromium.org> Signed-off-by: Stephen Warren <swarren@nvidia.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:22 UTC |
| 0158865 | Nick Dyer | 23 May 2014, 14:24:23 UTC | Input: atmel_mxt_ts - fix invalid return from mxt_get_bootloader_version The patch e57a66aa8534: "Input: atmel_mxt_ts - read and report bootloader version" from May 18, 2014, leads to the following static checker warning: drivers/input/touchscreen/atmel_mxt_ts.c:437 mxt_get_bootloader_version( warn: signedness bug returning '(-5)' drivers/input/touchscreen/atmel_mxt_ts.c 429 static u8 mxt_get_bootloader_version(struct mxt_data *data, u8 val) 430 { 431 struct device *dev = &data->client->dev; 432 u8 buf[3]; 433 434 if (val & MXT_BOOT_EXTENDED_ID) { 435 if (mxt_bootloader_read(data, &buf[0], 3) != 0) { 436 dev_err(dev, "%s: i2c failure\n", __func__); 437 return -EIO; ^^^^ This gets truncated into a number from 0-255 and anyway the caller doesn't check for errors. (reported by Dan Carpenter) Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:21 UTC |
| cff90bf | Nick Dyer | 23 May 2014, 14:11:00 UTC | Input: atmel_mxt_ts - implement device tree support Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:20 UTC |
| f24ab04 | Nick Dyer | 20 May 2014, 12:46:40 UTC | Input: atmel_mxt_ts - address code indentation issues Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:20 UTC |
| e4a37de | Nick Dyer | 20 May 2014, 09:54:57 UTC | Input: atmel_mxt_ts - fix build error in mxt_read_t9_resolution Stephen Rothwell reported this build error: drivers/input/touchscreen/atmel_mxt_ts.c: In function 'mxt_read_t9_resolution': drivers/input/touchscreen/atmel_mxt_ts.c:1043:2: warning: passing argument 1 of '__swab16s' makes pointer from integer without a cast [enabled by default] le16_to_cpus(range.x); ^ Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:19 UTC |
| 139b6e3 | Prajosh Premdas | 30 April 2014, 17:41:43 UTC | Input: atmel_mxt_ts - fixed vdd being checked instead of avdd Fixed the wrong check where vdd was being checked instead of avdd after regulator_get function for avdd Signed-off-by: Prajosh Premdas <premdas.prajosh@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:18 UTC |
| 7720ba6 | Nick Dyer | 31 May 2013, 10:22:58 UTC | Input: atmel_mxt_ts - implement improved debug message interface Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 13:26:17 UTC |
| 2b33db0 | Nick Dyer | 23 August 2011, 15:37:50 UTC | Input: atmel_mxt_ts - add memory access interface via sysfs Atmel maXTouch chips can be addressed via an "Object Based Protocol" which defines how i2c registers are mapped to different functions within the chips. This interface exposes the register map and allows user-space utilities to inspect and alter object configuration, and to view diagnostic data, while the device is running. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> Acked-by: Benson Leung <bleung@chromium.org> | 04 July 2014, 13:26:17 UTC |
