72c0333 | Nick Dyer | 25 April 2016, 13:45:23 UTC | Merge pull request #13 from ndyer/maxtouch-v3.14 Maxtouch v3.14 updates | 25 April 2016, 13:45:23 UTC |
4c72090 | Nick Dyer | 22 April 2016, 16:10:16 UTC | Input: atmel_mxt_ts - zero terminate config firmware file We use sscanf to parse the configuration file, so it's necessary to zero terminate the configuration otherwise a truncated file can cause the parser to run off into uninitialised memory. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 22 April 2016, 16:15:20 UTC |
f83c9bb | Nick Dyer | 22 April 2016, 16:12:51 UTC | Input: atmel_mxt_ts - refactor config update code to add context struct Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 22 April 2016, 16:12:51 UTC |
90ddd8b | Nick Dyer | 15 March 2016, 17:30:44 UTC | Input: atmel_mxt_ts - create fw attr before mxt_initialize | 22 April 2016, 14:42:51 UTC |
71b2796 | Dmitry Torokhov | 20 November 2015, 18:58:07 UTC | Input: atmel_mxt_ts - add generic platform data for Chromebooks Apparently people are installing generic Linux distributions not only on Pixels but also on other Chromebooks. Unfortunately on all of them Atmel parts assigned names ATML0000 and ATML0001, and do not carry any other configuration data. So let's create generic instance of platform data that should cover most of them (we assume that they will not be using T100 objects, since with those Google mapped BTN_LEFT onto a different GPIO, so slightly different keymap would be needed, but I think we used parts with T100 on ARM devices where we thankfully have DTS and can describe the devices better). Tested-by: Rich K <rgkirch@gmail.com> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 22 April 2016, 14:42:48 UTC |
fa6d353 | Javier Martinez Canillas | 11 December 2015, 21:22:39 UTC | Input: atmel_mxt_ts - add maxtouch to I2C table for module autoload The Atmel maxtouch DT binding documents that the compatible string for the device is "atmel,maxtouch" and the I2C core always reports a module alias of the form i2c:alias where alias is the compatible string model: $ grep MODALIAS /sys/devices/platform/12e00000.i2c/i2c-8/8-004b/uevent MODALIAS=i2c:maxtouch But there isn't maxtouch entry in the I2C device ID table so when the i2c:maxtouch MODALIAS uevent is reported, kmod is not able to match the alias with a module to load: $ modinfo atmel_mxt_ts | grep alias alias: of:N*T*Catmel,maxtouch alias: i2c:mXT224 alias: i2c:atmel_mxt_tp alias: i2c:atmel_mxt_ts alias: i2c:qt602240_ts So add the maxtouch entry to the I2C device ID table to allow the module to be autoloaded when the device is registered via OF. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 22 April 2016, 14:42:46 UTC |
11a72ee | Nick Dyer | 15 March 2016, 17:28:30 UTC | Input: atmel_mxt_ts - remove some blank lines | 22 April 2016, 14:42:39 UTC |
f1804f1 | Nick Dyer | 15 March 2016, 17:28:13 UTC | Input: atmel_mxt_ts - remove debug msg in correct places | 22 April 2016, 14:42:34 UTC |
f371bc4 | Nick Dyer | 15 March 2016, 17:27:27 UTC | Input: atmel_mxt_ts - use min() macro | 22 April 2016, 14:42:29 UTC |
c03ddbc | Nick Dyer | 11 January 2016, 02:29:34 UTC | Input: atmel_mxt_ts - improve touchscreen size/orientation handling Both T100 and T9 handle range and orientation in a similar fashion. Reduce duplication between the two implementations. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> | 22 April 2016, 14:42:26 UTC |
49bba71 | Nick Dyer | 10 March 2016, 15:35:26 UTC | Input: atmel_mxt_ts - fix warning in mxt_set_up_active_stylus Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 22 April 2016, 14:39:12 UTC |
7d452f7 | Nick Dyer | 17 December 2015, 10:11:58 UTC | Merge pull request #12 from ndyer/maxtouch-v3.14 Updates to maxtouch-v3.14 driver | 17 December 2015, 10:11:58 UTC |
ecfe5ef | Nick Dyer | 15 December 2015, 17:29:00 UTC | Input: atmel_mxt_ts - don't register T107 stylus reports unless enabled Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 17 December 2015, 10:04:32 UTC |
9541c60 | Nick Dyer | 15 December 2015, 17:29:00 UTC | Input: atmel_mxt_ts - remove support for old T63 active stylus Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 16 December 2015, 11:44:54 UTC |
586fec6 | Nick Dyer | 15 December 2015, 17:54:13 UTC | Input: atmel_mxt_ts - remove duplicated code in mxt_initialize_input_device() Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 15 December 2015, 17:54:13 UTC |
b63e03a | Nick Dyer | 15 December 2015, 12:48:50 UTC | Input: atmel_mxt_ts - fix bug with entering bootloader Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 15 December 2015, 12:48:50 UTC |
37ce0c5 | Nick Dyer | 30 October 2015, 15:10:54 UTC | Merge pull request #10 from ndyer/maxtouch-v3.14 TKT-010987 Release Oct 2015 driver changes to github | 30 October 2015, 15:10:54 UTC |
02086c9 | Nick Dyer | 29 October 2015, 16:39:53 UTC | Input: atmel_mxt_ts - initialise sysfs after object table probed Move the initialisation of sysfs attributes. Some of the sysfs functions have guards in case they are accessed early during probe, or during firmware flash. By ensuring the attributes are not present when they can be mis-used, these guards can be removed. | 30 October 2015, 12:37:27 UTC |
57af0f6 | karl tsou | 02 July 2014, 05:14:08 UTC | Input: atmel_mxt_ts - rename config_csum attribute to config_crc Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 October 2015, 13:13:59 UTC |
03bd7e7 | Nick Dyer | 27 October 2015, 11:53:50 UTC | Input: atmel_mxt_ts - avoid null regulator handle Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 October 2015, 13:13:59 UTC |
35b9ed6 | Karl Tsou | 21 January 2015, 05:35:03 UTC | Input: atmel_mxt_ts - Add debug for T92 gesture and T93 touch seq msgs Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 October 2015, 13:13:58 UTC |
46e4fb7 | Nick Dyer | 27 October 2015, 11:07:20 UTC | Input: atmel_mxt_ts - split large reads into blocks On some platforms doing i2c reads of more than 255 bytes is problematic. For exampls, some chips with lots of objects have an info block larger than 255 bytes. Signed-off-by: Steven Swann <steven.swann@itdev.co.uk> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 October 2015, 12:33:08 UTC |
4e86e6b | Nick Dyer | 22 October 2015, 09:03:58 UTC | Input: atmel_mxt_ts - reduce debug level for toggling MSG output Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 October 2015, 12:33:06 UTC |
43a586e | Nick Dyer | 15 September 2015, 14:19:22 UTC | Input: atmel_mxt_ts - check return values in mxt_start and mxt_stop Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 October 2015, 12:32:59 UTC |
13f22bf | Nick Dyer | 06 August 2015, 12:47:17 UTC | Merge pull request #9 from ndyer/maxtouch-v3.14 Merge upstream changes into maxtouch-v3.14 | 06 August 2015, 12:47:17 UTC |
85a9ade | Pan Xinhui | 04 August 2015, 23:53:04 UTC | Input: atmel_mxt_ts - suspend/resume causes panic if input_dev fails to init input_dev may be NULL if mxt_initialize_input_device fails. But pm ops is still available and suspend/resume assume input_dev is not NULL. To fix this issue, we add a check if (!input_dev). Signed-off-by: Pan Xinhui <xinhuix.pan@intel.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> | 06 August 2015, 12:44:24 UTC |
35058d9 | Nick Dyer | 06 August 2015, 09:38:41 UTC | Input: atmel_mxt_ts - refactor to add np variable in mxt_parse_dt Downgrade failure to read gpio-keymap to a warning (initialized to KEY_RESERVED by devm_kzalloc) Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 06 August 2015, 12:44:20 UTC |
7137626 | Nick Dyer | 30 July 2015, 14:38:19 UTC | Merge pull request #8 from ndyer/maxtouch-v3.14 Merge upstream changes into maxtouch-v3.14 | 30 July 2015, 14:38:19 UTC |
12936a0 | Nick Dyer | 22 June 2015, 08:47:58 UTC | Input: atmel_mxt_ts - tool type is ignored when slot is closed input_mt_report_slot_state() ignores the tool when the slot is closed. Remove the tool type from these function calls, which has caused a bit of confusion. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:17 UTC |
23cff25 | Nick Dyer | 17 June 2015, 10:49:17 UTC | Input: atmel_mxt_ts - don't report zero pressure from T9 If T9.CTRL DISAMP is set, then pressure is reported as zero. This means some app layers (eg tslib) will ignore the contact. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:16 UTC |
463e6ab | Nick Dyer | 04 June 2015, 15:04:07 UTC | Input: atmel_mxt_ts - remove debug about reset GPIO Downgrade to a comment since it appears on every probe when debug is enabled otherwise. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:16 UTC |
2ef7380 | Nick Dyer | 16 June 2015, 13:02:57 UTC | Input: atmel_mxt_ts - remove warning on zero T44 count Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:15 UTC |
f140cbd | Nick Dyer | 16 June 2015, 11:06:43 UTC | Input: atmel_mxt_ts - remove guards around inclusion of of_gpio.h Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:14 UTC |
702785a | Nick Dyer | 16 June 2015, 12:37:37 UTC | Input: atmel_mxt_ts - improve formatting Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:14 UTC |
0b1af86 | Nick Dyer | 16 June 2015, 11:07:21 UTC | Input: atmel_mxt_ts - tidy up flow in bootloader retries This fixes a warning from checkpatch. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:13 UTC |
c6d2762 | Nick Dyer | 16 June 2015, 10:54:41 UTC | Input: atmel_mxt_ts - fix minor checkpatch errors Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:13 UTC |
93918df | Nick Dyer | 04 June 2015, 15:07:02 UTC | Input: atmel_mxt_ts - reorder init completions to reduce upstream patch churn Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:12 UTC |
cfe3f58 | Nick Dyer | 04 June 2015, 15:06:08 UTC | Input: atmel_mxt_ts - rename TOUCH_CTRL to T9_CTRL Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:11 UTC |
9028f42 | Dmitry Torokhov | 07 April 2015, 23:30:01 UTC | Input: atmel_mxt_ts - add support for Google Pixel 2 This change allows atmel_mxt_ts to bind to ACPI-enumerated devices in Google Pixel 2 (2015). While newer version of ACPI standard allow use of device-tree-like properties in device descriptions, the version of ACPI implemented in Google BIOS does not support them, and we have to resort to DMI data to specify exact characteristics of the devices (touchpad vs. touchscreen, GPIO to button mapping, etc). Pixel 1 continues to use i2c devices and platform data created by chromeos-laptop driver, since ACPI does not enumerate them. Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> | 29 July 2015, 20:17:11 UTC |
61d588d | Sjoerd Simons | 06 April 2015, 20:10:30 UTC | Input: atmel_mxt_ts - split out touchpad initialisation logic If the "linux,gpio-keymap" DT property is defined, the T19 keys are configured and the device is setup as a touchpad rather than a touchscreen. The logic is part of the input device initialization routine but it can be factored out to its own function to simplify the former. Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> [Reinstate INPUT_MT_DIRECT] [put back variable i in mxt_initialize_input_device] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:10 UTC |
6b8953d | Javier Martinez Canillas | 06 April 2015, 18:25:13 UTC | Input: atmel_mxt_ts - factor out T9 and T100 init functions Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> [Merge in maxtouch-v3.14 branch] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:10 UTC |
2407b22 | Javier Martinez Canillas | 06 April 2015, 18:25:13 UTC | Input: atmel_mxt_ts - update hovering finger support The hovering finger support was based on Chung-Yih's work in the ChromiumOS downstream kernel: https://chromium-review.googlesource.com/#/c/219280/ In order to report hovering touch events to userspace applications, the patch uses the axis ABS_MT_DISTANCE to indicate if a finger is hovering or not. In other words, we could use the value of the axis ABS_MT_DISTANCE to tell if a finger is a touch or hovering finger: DISTANCE_ACTIVE_TOUCH: a finger touches on touchpad, ABS_MT_DISTANCE is zero DISTANCE_HOVERING: a hovering finger on top of touchpad [javier: rework hover support] Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> [nick: merge into maxtouch-v3.14 branch] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 20:17:09 UTC |
122e6d6 | Nick Dyer | 16 June 2015, 15:18:48 UTC | Input: atmel_mxt_ts - Improve reporting of stylus buttons The buttons should only be reported only on T107 messages, but they must be reported on every message since the buttons can be released as the stylus goes out of detect. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 18:15:05 UTC |
cfd7094 | Nick Dyer | 16 June 2015, 15:16:06 UTC | Input: atmel_mxt_ts - move #defines as per upstream Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 18:15:01 UTC |
d7aaa05 | Nick Dyer | 16 June 2015, 15:15:24 UTC | Input: atmel_mxt_ts - use get_unaligned_le16 Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2015, 18:14:33 UTC |
1593c9a | Nick Dyer | 04 June 2015, 15:15:52 UTC | Input: atmel_mxt_ts - use BIT() macro everywhere Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 16 June 2015, 12:10:08 UTC |
43c3b3e | Dmitry Torokhov | 15 April 2015, 17:31:10 UTC | Input: atmel_mxt_ts - use BIT() macro when reporting button state This makes the intent a tad more clear. Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 June 2015, 14:57:48 UTC |
d263fc3 | Nick Dyer | 30 April 2015, 15:08:03 UTC | Input: atmel_mxt_ts - delay enabling IRQ when not using regulators The path of enabling the IRQ in the probe function is not safe in level triggered operation, if it was already powered up and there is a message waiting on the device (eg finger down) because the object table has not yet been read. This forces the ISR into a hard loop. Delay enabling the interrupt until it is first needed. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 30 April 2015, 15:21:42 UTC |
c3eb7c2 | Nick Dyer | 19 March 2015, 16:36:45 UTC | Input: atmel_mxt_ts - make bootloader interrupt driven | 27 April 2015, 16:31:02 UTC |
84917e0 | Nick Dyer | 19 March 2015, 16:39:48 UTC | Input: atmel_mxt_ts - rename bl_completion to chg_completion | 27 April 2015, 16:31:02 UTC |
eb8fdee | Nick Dyer | 06 January 2015, 14:11:31 UTC | Input: atmel_mxt_ts - check firmware format before putting device into bootloader mode | 27 April 2015, 16:31:01 UTC |
801f83a | Nick Dyer | 24 December 2014, 16:07:50 UTC | Input: atmel_mxt_ts - improve bootloader state machine handling Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 27 April 2015, 16:31:00 UTC |
e8c0b10 | Nick Dyer | 24 December 2014, 14:38:16 UTC | Input: atmel_mxt_ts - combine bootloader version query with probe This removes some complexity from the bootloader state machine, and means that we always output some debug about the version as soon as we start talking to the bootloader. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 27 April 2015, 16:31:00 UTC |
632589b | Nick Dyer | 23 December 2014, 16:27:29 UTC | Input: atmel_mxt_ts - refactor code to enter bootloader into separate func | 27 April 2015, 16:30:59 UTC |
8aac17c | Nick Dyer | 23 December 2014, 16:22:35 UTC | Input: atmel_mxt_ts - refactor firmware flash to extract context into struct | 27 April 2015, 16:30:59 UTC |
e4c68ee | Nick Dyer | 16 December 2014, 16:47:55 UTC | Input: atmel_mxt_ts - guard debug interface when in bootloader mode Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 27 April 2015, 16:30:58 UTC |
e464784 | Nick Dyer | 10 March 2015, 15:20:36 UTC | Input: atmel_mxt_ts - minor formatting fix Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 27 April 2015, 16:30:58 UTC |
5ba62ef | Nick Dyer | 10 March 2015, 15:19:49 UTC | Input: atmel_mxt_ts - add suspend modes | 27 April 2015, 16:30:57 UTC |
96e59cd | Nick Dyer | 23 April 2015, 10:02:55 UTC | Input: atmel_mxt_ts - config CRC may start at T71 On devices with the T71 object, the config CRC will start there, rather than at T7. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 23 April 2015, 15:42:48 UTC |
fca9f31 | Nick Dyer | 10 March 2015, 15:25:06 UTC | Input: atmel_mxt_ts - Update device tree documentation | 17 March 2015, 12:19:21 UTC |
3907be9 | Nick Dyer | 09 December 2014, 12:54:29 UTC | Input: atmel_mxt_ts - fix bug in debug output for T100 | 16 December 2014, 11:05:27 UTC |
a201886 | Nick Dyer | 09 December 2014, 12:54:07 UTC | Input: atmel_mxt_ts - remove unnecessary debug on ENOMEM | 12 December 2014, 17:09:11 UTC |
c5b2fd9 | Nick Dyer | 09 December 2014, 12:53:09 UTC | Input: atmel_mxt_ts - fix merge issue in T100 init code | 12 December 2014, 17:09:11 UTC |
870e547 | Nick Dyer | 09 December 2014, 11:49:57 UTC | Input: atmel_mxt_ts - remove unnecessary forward declarations | 12 December 2014, 17:09:10 UTC |
f49d15d | Nick Dyer | 09 December 2014, 11:49:47 UTC | Input: atmel_mxt_ts - remove extra blank lines | 12 December 2014, 17:09:10 UTC |
3d6afc7 | Nick Dyer | 05 December 2014, 11:23:07 UTC | Input: atmel_mxt_ts - disable interrupt for 50ms after reset The CHG/interrupt line is momentarily set (approximately 100 ms) as an input after power-up or reset for diagnostic purposes. This may cause spurious interrupts, so disable interrupt handler during this period. | 12 December 2014, 17:09:09 UTC |
d60a46c | Nick Dyer | 05 December 2014, 11:22:03 UTC | Input: atmel_mxt_ts - change T100 debug output from status to tool type | 12 December 2014, 17:09:08 UTC |
e129ca5 | Nick Dyer | 05 December 2014, 11:50:08 UTC | Input: atmel_mxt_ts - improve indentation by reworking if statements | 12 December 2014, 17:09:08 UTC |
febb33d | Nick Dyer | 28 November 2014, 16:53:15 UTC | Input: touchscreen - use __maybe_unused instead of ifdef around suspend/resume Use __maybe_unused instead of ifdef guards around suspend/resume functions, in order to increase build coverage and fix build warnings. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> | 12 December 2014, 17:09:07 UTC |
b6d4b6e | Nick Dyer | 24 October 2014, 11:50:10 UTC | Input: atmel_mxt_ts - handle new T100 touch types Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 12 December 2014, 17:09:07 UTC |
8a317bd | Nick Dyer | 26 November 2014, 16:20:00 UTC | Input: atmel_mxt_ts - improve handling of hover Pressure and touch major should be reported as non-zero if tool touching the device. | 12 December 2014, 17:09:03 UTC |
128c825 | Nick Dyer | 14 June 2013, 15:52:45 UTC | Input: atmel_mxt_ts - implement support for T107 active stylus Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 12 December 2014, 17:05:03 UTC |
7ba066a | Nick Dyer | 24 October 2014, 09:08:19 UTC | Input: atmel_mxt_ts - adjust MXT_MAX_BLOCK_WRITE Some platforms appear to have an underlying I2C device which starts corrupting data if blocks exceed this length. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 24 October 2014, 10:43:03 UTC |
5ebb68c | Stephen Warren | 09 September 2014, 15:15:24 UTC | Input: atmel_mxt_ts - fix double free of input device [reworked after comments by Dmitry Torokhov. Move free of input device into separate function. Only call in paths that require it. Move mxt_initialize after sysfs init, because otherwise an error in the sysfs init may interfere with the async return from the firmware loader. Add guards for sysfs functions. ] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:16:01 UTC |
f56cf2a | Nick Dyer | 09 September 2014, 15:14:06 UTC | Input: atmel_mxt_ts - add guards when sysfs interface called with no object table Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:16:00 UTC |
861eaec | Nick Dyer | 09 September 2014, 15:13:30 UTC | Input: atmel_mxt_ts - fix checkpatch warning with bare else Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:16:00 UTC |
1da3bd7 | Nick Dyer | 09 September 2014, 15:12:04 UTC | Input: atmel_mxt_ts - remove unnecessary 'out of memory' message Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:15:59 UTC |
8a565da | Nick Dyer | 02 September 2014, 15:37:46 UTC | Input: atmel_mxt_ts - don't spam dmesg with warning about empty interrupts In the case where the chip is not configured in the correct interrupt line mode, this warning output to dmesg output for each touch cycle. Downgrade the message to debug, since it is a benign condition. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 09 September 2014, 15:15:59 UTC |
dae0a25 | Janus Cheng | 20 July 2014, 10:36:14 UTC | Input: atmel_mxt_ts - check data->input_dev is not null in mxt_input_sync() * Symptom: if update_fw and update_cfg, kernel panic occurs. * Reproducibility: 10% * Root Cause: - If update_fw, the T6 will send a CFG_ERR message periodically. - After that, update_cfg process begin, the mxt_update_cfg_store() will invoke mxt_free_input_device() and nullify data->input_dev. - The CFG_ERR message will trigger mxt_interrupt(), and mxt_input_sync() will be invoked by mxt_process_messages_t44(). And mxt_input_sync() references a NULL data->input_dev and kernel panic occurs. TrackerRMS TKT-004235 | 12 August 2014, 16:06:16 UTC |
0834d5f | Dmitry Torokhov | 11 August 2014, 18:03:09 UTC | Input: atmel_mxt_ts - fix a few issues reported by Coverity This should fix the following issues reported by Coverity: *** CID 1230625: Logically dead code (DEADCODE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize() *** CID 1230627: Missing break in switch (MISSING_BREAK) /drivers/input/touchscreen/atmel_mxt_ts.c: 1436 in mxt_get_object_table() *** CID 1230629: Out-of-bounds write (OVERRUN) /drivers/input/touchscreen/atmel_mxt_ts.c: 1267 in mxt_update_cfg() *** CID 1230632: Unused pointer value (UNUSED_VALUE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1211 in mxt_update_cfg() Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 12 August 2014, 15:27:21 UTC |
13a28fc | Nick Dyer | 29 July 2014, 09:46:35 UTC | Input: atmel_mxt_ts - mXT224 DMA quirk was fixed in firmware v2.0.AA Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 12 August 2014, 15:20:11 UTC |
9c6cefd | Nick Dyer | 29 July 2014, 09:45:53 UTC | Input: atmel_mxt_ts - reorder code due to upstream patch churn Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2014, 09:47:18 UTC |
1668937 | Nick Dyer | 28 July 2014, 15:22:55 UTC | Input: atmel_mxt_ts - fix checkpatch issue WARNING: Missing a blank line after declarations Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2014, 09:47:18 UTC |
645b11d | Nick Dyer | 28 July 2014, 10:42:55 UTC | Input: atmel-mxt_ts - use kstrtou8 in sysfs interface rather than scanf Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2014, 09:47:17 UTC |
a5a39ec | Nick Dyer | 28 July 2014, 09:13:55 UTC | Input: atmel_mxt_ts - call CRC completion after CRC update There is a possibility of a race here otherwise. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 29 July 2014, 09:47:14 UTC |
cfb9008 | Nick Dyer | 24 July 2014, 16:24:33 UTC | Input: atmel_mxt_ts - remove unnecessary blank line Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 24 July 2014, 16:29:00 UTC |
b3501d6 | Nick Dyer | 24 July 2014, 16:24:02 UTC | Input: atmel_mxt_ts - minor tweak to capitalisation in comment Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 24 July 2014, 16:28:59 UTC |
9048a68 | Dmitry Torokhov | 23 July 2014, 23:29:55 UTC | Input: atmel_mxt_ts - split config update a bit Let's split config update code a bit so it is hopefully a bit easier to read. Also, the firmware update callback should be the entity releasing firmware blob, not lower layers. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> [release firmware when updating via update_cfg_store] Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 24 July 2014, 16:28:50 UTC |
c680da9 | Nick Dyer | 24 July 2014, 16:22:25 UTC | Input: atmel_mxt_ts - add error check to request_firmware_nowait() Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 24 July 2014, 16:22:25 UTC |
a3aa258 | Nick Dyer | 24 July 2014, 16:21:48 UTC | Input: atmel_mxt_ts - rework platform data handling | 24 July 2014, 16:21:48 UTC |
75fcc1c | Dmitry Torokhov | 23 July 2014, 21:50:56 UTC | Input: atmel_mxt_ts - simplify mxt_initialize a bit I think having control flow with 2 goto/labels/flags is quite hard to read, this version is a bit more readable IMO. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 24 July 2014, 16:20:07 UTC |
e41f091 | Nick Dyer | 23 July 2014, 14:53:33 UTC | Input: atmel_mxt_ts - fix interrupt documentation for tegra As advised by Stephen Warren, this was incorrect. Also slightly update wording. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 23 July 2014, 14:57:12 UTC |
9dbb941 | Nick Dyer | 04 July 2014, 11:35:57 UTC | Input: atmel_mxt_ts - fix bug in info CRC error output Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 04 July 2014, 11:35:57 UTC |
e6bc3d7 | Nick Dyer | 03 July 2014, 10:11:20 UTC | Input: atmel_mxt_ts - leave platform to specify irqflags when using DT The function to check the interrupt configuration must use irq_get_trigger_type() to allow for this case. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 03 July 2014, 14:41:29 UTC |
a350ed5 | Nick Dyer | 20 June 2014, 09:30:13 UTC | Input: atmel_mxt_ts - fix bug with endianness conversion in T100 intialisation Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 03 July 2014, 09:24:44 UTC |
d62312d | Nick Dyer | 18 June 2014, 23:46:06 UTC | Input: atmel_mxt_ts - use of_match_ptr rather than ifdefs Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 19 June 2014, 00:05:45 UTC |
c7643a5 | Nick Dyer | 18 June 2014, 23:45:33 UTC | Input: atmel_mxt_ts - allocate pdata using devm_kzalloc By using this function instead, there is no necessity to free on remove or probe failure, since it is handled for us. This also fixes an failure when kfree() is called on memory allocated using devm_kzalloc() in the DT parse function. Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 19 June 2014, 00:05:45 UTC |
3fecd27 | karl tsou | 18 June 2014, 23:42:34 UTC | Input: atmel_mxt_ts - support config checksum attribute in sysfs Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 19 June 2014, 00:05:44 UTC |
8466580 | Nick Dyer | 18 June 2014, 23:40:12 UTC | Input: atmel_mxt_ts - wrap long line Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 19 June 2014, 00:05:43 UTC |
254de6f | Nick Dyer | 18 June 2014, 23:39:50 UTC | Input: atmel_mxt_ts - check gpio validity in mxt_probe_regulators Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk> | 19 June 2014, 00:05:43 UTC |