Revision 2413a06c7bf2a1f3e86680ceb041e75c729f44f1 authored by Igor Canadi on 24 April 2014, 13:22:58 UTC, committed by Igor Canadi on 24 April 2014, 13:22:58 UTC
Summary:
Currently, whenever DB Verification fails we bail out by calling `exit(1)`. This is kind of bad since it causes unclean shutdown and spew of error log messages like:
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
05:03:27 pthread lock: Invalid argument
This diff adds a new parameter that is set to true when verification fails. It can then use the parameter to bail out safely.
Test Plan: Casued artificail failure. Verified that exit was clean.
Reviewers: dhruba, haobo, ljin
Reviewed By: haobo
CC: leveldb
Differential Revision: https://reviews.facebook.net/D18243
1 parent d8fe006
| File | Mode | Size |
|---|---|---|
| build_tools | ||
| coverage | ||
| db | ||
| doc | ||
| hdfs | ||
| helpers | ||
| include | ||
| java | ||
| linters | ||
| port | ||
| table | ||
| tools | ||
| util | ||
| utilities | ||
| .arcconfig | -rw-r--r-- | 246 bytes |
| .clang-format | -rw-r--r-- | 138 bytes |
| .gitignore | -rw-r--r-- | 317 bytes |
| CONTRIBUTING.md | -rw-r--r-- | 759 bytes |
| HISTORY.md | -rw-r--r-- | 5.0 KB |
| INSTALL.md | -rw-r--r-- | 3.3 KB |
| LICENSE | -rw-r--r-- | 1.6 KB |
| Makefile | -rw-r--r-- | 20.2 KB |
| PATENTS | -rw-r--r-- | 1.4 KB |
| README | -rw-r--r-- | 2.9 KB |
| README.fb | -rw-r--r-- | 96 bytes |
| ROCKSDB_LITE.md | -rw-r--r-- | 1020 bytes |
Computing file changes ...
